[GTK3] Make CSD window decorations 18px instead of 16px

Authored by cblack on Aug 29 2019, 12:16 PM.

Description

[GTK3] Make CSD window decorations 18px instead of 16px

Summary: As mentioned by @ndavis in D23547, window buttons should be 18px instead of 16px. This revision changes the size of the window buttons accordingly.

Test Plan:
Before:

After:

Reviewers: Breeze, ngraham, ndavis

Reviewed By: Breeze, ngraham, ndavis

Subscribers: bcooksley, ndavis, plasma-devel

Tags: Plasma

Differential Revision: https://phabricator.kde.org/D23560

Details

freeno added a subscriber: freeno.EditedAug 31 2019, 4:30 AM

The script no longer installs my themes into /.local/share/themes after the latest commit. I get this error and the older version works fine. "cp: cannot create directory '': No such file or directory". The theme is there but my gtk's are missing the title buttons. I finally got it to make the theme by adding -t with the name but it made it in the same folder as script and it did not color the new assets.

ndavis added a comment.EditedAug 31 2019, 8:53 AM

The script no longer installs my themes into /.local/share/themes after the latest commit. I get this error and the older version works fine. "cp: cannot create directory '': No such file or directory". The theme is there but my gtk's are missing the title buttons. I finally got it to make the theme by adding -t with the name but it made it in the same folder as script and it did not color the new assets.

Are you sure it was this commit? This commit barely affects anything. The last commit to affect the build script was R98:fa8e67c617f32d9da5f7cf0b55f61a7e47f03ee5.

freeno added a comment.EditedAug 31 2019, 9:10 PM

It was the commit that supposed fixed title bars. I have used this script for a long time and I keep it updated so I can catch the latest changes and I just download this about 4 to 5 days and it worked fine but whatever was done to the title buttons has done something. If I go about my business in the normal fashion then my gtk3 themes that actually use gtk title bars will not have a close button and I get the error I showed you up top. No problems ever before but now the script has errors. The script has a line added at the very bottom and that is causing errors. Only two cp in the script that I can see so it has to be the last line I believe that is doing it. I am 100% percent positive it was the latest commit from 2 days ago. The cp command in last line. I can track it down but I don't know how to fix it. You should be able to use script just like:. "/build_theme.sh". That should install current color scheme gtk theme with name breeze into /.local/share/themes and it does with errors and your themes will have no close buttons. cp commands on line 44 and the last line and the one from 44 has been there all along so it the latest changes. If I build with -t and the theme name it builds in the folder that i am currently in and the new assets do not get colored. The new assets and the new line at the bottom are the problem. The new breeze assets do not get colored like this.

freeno added a comment.EditedSep 1 2019, 2:15 AM

One more thing here. Aren't the new assets supposed to be colored also???Breeze-check-checked-symbolic , breeze-check-indeterminate-symbolic, breeze-check-unchecked. These assets remain stock breeze colors. Maybe this is the way you want it but I don't think so. The script runs with no errors now by the way but these assets which I believe are the new ones are not being colored.

cblack added a comment.Sep 1 2019, 2:15 AM

@cblack thoughts?

Fixed with R98:cb05242e4d32d32fe12cf22ea9e84d3753d422db.

One more thing here. Aren't the new assets supposed to be colored also???Breeze-check-checked-symbolic.svg , breeze-check-indeterminate-symbolic, breeze-check-unchecked. These assets remain stock breeze colors. maybe this is the way you want it but I don't think so. The script runs with no errors now by the way but these assets which I believe are the new ones are not being colored.

They are recolored at runtime rather than at buildtime now.

freeno added a comment.Sep 1 2019, 2:19 AM

Ok thanks for all your hard work. I wish I could do more to help the community and I would if I could for sure. I am trying to get better so maybe one day. Thanks again.

freeno added a comment.EditedSep 11 2019, 4:44 PM

I have some buttons that are half white and full white sometimes when they should not be. This is the latest version.

ndavis added a comment.EditedSep 11 2019, 5:00 PM

I have some buttons that are half white and full white sometimes when they should not be. This is the latest version.

R98:7b3d0777ea6c10dd430ed686434d3a4e2d072632 would be the last commit to affect that.

If you're not sure which commit a bug appeared in, it's better to write a bug report on bugs.kde.org. Our bugzilla is really the proper place to put any kind of bug report, but if you already know which commit caused the bug and you have all the necessary information ready, including the way to reproduce the bug, then it's OK to comment on a commit or differential revision.

freeno added a comment.EditedSep 12 2019, 2:08 AM

Sorry. Was just trying to help. Ok here is all the proof I can show. On my stock Breeze Dark theme in Arch Linux the buttons in the same preferences menu in pacmac-aur are not doing that and when that window becomes inactive the buttons turn grey. Now if I go to color schemes and select breeze dark and build a new theme and name it something other than breeze dark and use that theme it should be the same as breeze dark theme but it is not. The buttons either turn all the white just like in my photos above or white with black outline or blue with white outline and every single time the buttons turn white for inactive and not grey. They should be blue with dark outline in that style. So whatever is different from the stock Arch stable KDE desktop Breeze dark and the newest breeze here is doing it. I can show screenshots if need be.

I'll look into these issues when I get through my backlog of things to do.

freeno added a comment.EditedThu, Oct 3, 10:24 PM

Sorry to leave this here but just so you know the buttons are still the same way.