[GTK3] Have checkboxes and radiobuttons respect the user's color scheme.
ClosedPublic

Authored by cblack on Wed, Aug 28, 9:22 PM.

Details

Summary

Checkboxes and radiobuttons are now recolored according to the user's colour tastes.

Test Plan

Old:

New:

Diff Detail

Repository
R98 Breeze for Gtk
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
cblack created this revision.Wed, Aug 28, 9:22 PM
Restricted Application added a project: Plasma. · View Herald TranscriptWed, Aug 28, 9:22 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
cblack requested review of this revision.Wed, Aug 28, 9:22 PM
cblack updated this revision to Diff 64894.Wed, Aug 28, 9:26 PM

Change from hover color to focus color

cblack edited the test plan for this revision. (Show Details)Wed, Aug 28, 9:28 PM
ngraham added inline comments.
src/gtk3/widgets/_checkboxes.scss
9

Commented-out code should be deleted entirely

ndavis added a subscriber: ndavis.Wed, Aug 28, 9:57 PM
ndavis requested changes to this revision.EditedWed, Aug 28, 10:00 PM

I've already said this to you in the VDG chat, but just to prevent confusion for other people, I'll repeat it here.

These buttons are 18x18, but they are 16x16 with the Qt theme. Also make sure the rounded corners have a radius of 2.5. Please fix this if you can.

This revision now requires changes to proceed.Wed, Aug 28, 10:00 PM
cblack updated this revision to Diff 64900.Wed, Aug 28, 10:14 PM

Update based off of feedback

cblack edited the test plan for this revision. (Show Details)Wed, Aug 28, 10:15 PM

These SVGs don't quite line up with the grid, which causes the inner part to have slightly blurry edges.

ndavis added a comment.EditedWed, Aug 28, 10:45 PM

Here, this is a pixel perfect version.

edited again

cblack updated this revision to Diff 64906.Thu, Aug 29, 1:15 AM

Use provided SVGs

ndavis added a comment.EditedThu, Aug 29, 2:51 AM

I should have been more clear, but I meant all of the checkbox and radio button SVGs. The SVGs I provided just did the most difficult changes and could be reused to create the other versions.

I should have been more clear, but I meant all of the checkbox and radio button SVGs. The SVGs I provided just did the most difficult changes and could be reused to create the other versions. The Window buttons should go back to being 18px.

Ok, I'll make the other SVGs as well.

I'll change the window buttons in a seperate revision.

I should have been more clear, but I meant all of the checkbox and radio button SVGs. The SVGs I provided just did the most difficult changes and could be reused to create the other versions. The Window buttons should go back to being 18px.

Ok, I'll make the other SVGs as well.

I'll change the window buttons in a seperate revision.

Yeah, I just realized those weren't added in this revision.

cblack updated this revision to Diff 64909.Thu, Aug 29, 3:09 AM

Fix the rest of those SVGs

ndavis accepted this revision.Thu, Aug 29, 4:47 AM

LGTM

This revision is now accepted and ready to land.Thu, Aug 29, 4:47 AM
ndavis edited the test plan for this revision. (Show Details)Thu, Aug 29, 6:58 AM
This revision was automatically updated to reflect the committed changes.