Improve "user-trash" icon
ClosedPublic
Actions

Authored by GB_2 on Sep 3 2019, 7:07 PM.

Details

Reviewers

ngraham
ndavis

Group Reviewers

VDG

Commits

R266:c3a9be4d311a: Improve "user-trash" icon

Summary

Make some gradients and details look better.
Old:

New:

Test Plan

Search for "user-trash" in Cuttlefish.

Diff Detail

Repository

R266 Breeze Icons

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

GB_2 created this revision.Sep 3 2019, 7:07 PM

Restricted Application added a project: Frameworks. · View Herald TranscriptSep 3 2019, 7:07 PM

Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript

GB_2 requested review of this revision.Sep 3 2019, 7:07 PM

Harbormaster completed remote builds in B16071: Diff 65353.Sep 3 2019, 7:07 PM

I like it! The old one was a bit stumpy IMO.

We're supposed to use 6px margins on the top and bottom, making the visible part of the icon 52px tall. Bottom line shadows are normally supposed to be 1px tall. Other than that, it looks pretty good.

This revision now requires changes to proceed.Sep 4 2019, 7:13 AM

Fix margins and hard shadows

Harbormaster completed remote builds in B16083: Diff 65373.Sep 4 2019, 4:08 PM

GB_2 edited the summary of this revision. (Show Details)Sep 4 2019, 4:09 PM

ndavis accepted this revision.Sep 4 2019, 4:13 PM

This revision is now accepted and ready to land.Sep 4 2019, 4:13 PM

Fix more 64px hard shadows

Harbormaster completed remote builds in B16086: Diff 65376.Sep 4 2019, 4:26 PM

GB_2 edited the summary of this revision. (Show Details)Sep 4 2019, 4:26 PM

Closed by commit R266:c3a9be4d311a: Improve "user-trash" icon (authored by GB_2). · Explain WhySep 4 2019, 4:27 PM

This revision was automatically updated to reflect the committed changes.

Maybe it's because I am thirsty rigt now, but the new user-full-trash on a quick look also resembles a full fresh beer glass waiting to be emptied :) Not sure this association improves my life :P

Revision Contents
Changeset List

			Path	Packages
M			icons-dark/places/32/user-trash-full.svg (99 lines)
M			icons-dark/places/32/user-trash.svg (55 lines)
M			icons-dark/places/64/user-trash-full.svg (457 lines)
M			icons-dark/places/64/user-trash.svg (322 lines)
M			icons/places/32/user-trash-full.svg (99 lines)
M			icons/places/32/user-trash.svg (55 lines)
M			icons/places/64/user-trash-full.svg (457 lines)
M			icons/places/64/user-trash.svg (322 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	65353	34fe985		Sep 3 2019, 7:07 PM	★	★
Diff 2	65373	34fe985	Fix margins and hard shadows	Sep 4 2019, 4:08 PM	★	★
Diff 3	65376	34fe985	Fix more 64px hard shadows	Sep 4 2019, 4:26 PM	★	★
Diff 4	65377	34fe985	R266:c3a9be4d311abd69a6e73798afba4f3ccc4d8061	Sep 4 2019, 4:26 PM	★	★