Tweak size and color of handles for the seek/volume sliders
ClosedPublic

Authored by januz on May 13 2018, 1:36 AM.

Details

Summary

Make the handles a bit smaller and tweak the border color. This isn't breeze's proper style, but I think it fits better with the design of the player/header bar.

Also this patch makes the volume slider look disabled when muted. (see screenshot)

Diff Detail

Repository
R255 Elisa
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
januz requested review of this revision.May 13 2018, 1:36 AM
januz created this revision.
januz edited the summary of this revision. (Show Details)May 13 2018, 1:37 AM
januz added a reviewer: Elisa.
januz added a project: Elisa.

I don't like the changes to the slider to be honest. Let's wait for others to chime in.
For easier comparison, it would be nice to have before and after pictures.
The disabled volume bar is great, that annoyed me before.

The disabled volume slider is much better. I am unsure about the reduction of size for the handle given that is makes it harder to touch it.
The ability to use Elisa with a touch screen is really important. That was one of the stated goals for this project.

src/qml/MediaPlayerControl.qml
308

Please remove the extra blank line.

317–321

I have a laptop with a touch screen. This kind of changes make it harder to use the sliders. Are you sure it is really worth it ?

468–471

idem

mgallien requested changes to this revision.May 22 2018, 8:48 PM
This revision now requires changes to proceed.May 22 2018, 8:48 PM

+1 for keeping the controls touchable.

Heh I thought this was only affecting desktops so it didn't need to be touchable, I completely forgot PCs have touchscreens too these days.
Good points, I'll revert that later

januz updated this revision to Diff 34840.May 25 2018, 1:00 AM
  • Revert size changes
  • Remove blank line
  • Tweak border colors (size change)
mgallien accepted this revision.May 29 2018, 8:10 PM

Thanks and sorry for the delays from my side

This revision is now accepted and ready to land.May 29 2018, 8:10 PM
This revision was automatically updated to reflect the committed changes.

No problem :)