fix several issues caused by the use of loaders for the music views
fix navigation when browsing artists
remove useless code to clear the views that are unloaded
Details
Details
- Reviewers
astippich - Commits
- R255:f69a290cd3b9: mainly fix navigation between the different views
R255:d8a4039ae3d5: when no views is shown, ensure we unload them all
R255:99bf5c211439: fix several issued caused by the use of loaders for the music views
R255:54cb18ca78af: ViewManager is reponsible of pushing views and poping views
R255:c5125bcf08e7: fix several issues caused by the use of loaders for the music views
brings back navigation in artists view
Diff Detail
Diff Detail
- Repository
- R255 Elisa
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
Fixes the described issue, but navigation from an album to the corresponding artist still does not work
Comment Actions
- ViewManager is reponsible of pushing views and poping views
- when no views is shown, ensure we unload them all
should be working as before but with the loaders and more future proof
I have been fixing the bug this way to provide a way to navigate to any views
to allow implementing the ideas around navigation from the context view (i.e.
the view shown when the playlist is expanded)
Comment Actions
the button in the album view accessed via the artist view is still not working properly.
For the future, I think the right way to do would be to only use one stackview for all views, this would remove the need for loaders. it would also allow true back and forward navigation between the views.
Comment Actions
- mainly fix navigation between the different views
- ViewManager is reponsible of pushing views and poping views
- when no views is shown, ensure we unload them all
- fix warnings when switching to an artist from one album