Differential D12290

Don't draw list dividers
ClosedPublic
Actions

Authored by nicolasfella on Apr 17 2018, 5:01 PM.

Details

Reviewers
albertvaka
Group Reviewers
KDE Connect
VDG
Commits
R225:f81cf3bf363c: Don't draw list dividers
Summary

Depends on D12289

IMHO it looks sleeker without, especially the dividers on top and bottom and before the section headers are disturbing. Since the content of each list item is just one line of text its also not really needed to separate things

Test Plan

Before:

After:

Diff Detail

Repository
R225 KDE Connect - Android application
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
nicolasfella created this revision.Apr 17 2018, 5:01 PM
Restricted Application added a project: KDE Connect. · View Herald TranscriptApr 17 2018, 5:01 PM
nicolasfella requested review of this revision.Apr 17 2018, 5:01 PM
nicolasfella edited the test plan for this revision. (Show Details)Apr 17 2018, 5:01 PM
broulik added a reviewer: VDG.Apr 18 2018, 8:03 PM
Restricted Application added a subscriber: kdeconnect. · View Herald TranscriptJul 26 2018, 5:42 PM
ngraham edited the summary of this revision. (Show Details)Jul 26 2018, 8:38 PM
ngraham added a dependency: D12289: Rename list layout.
januz awarded a token.Jul 26 2018, 9:32 PM
albertvaka accepted this revision.Jul 27 2018, 5:12 PM
This revision is now accepted and ready to land.Jul 27 2018, 5:12 PM
Closed by commit R225:f81cf3bf363c: Don't draw list dividers (authored by nicolasfella). · Explain WhyJul 27 2018, 9:41 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mres/layout/devices_list.xml (2 lines)

Diff 38627

View Options

res/layout/devices_list.xml

Loading...