Before

After

It is heavily inspired by https://diegogangl.github.io/

I might be biased but I absolutely love this :D

Some notes:

• The track number isn't aligned to the right side of the cover, and the title isn't aligned to the album title. The artist name seems to be more to the left than the title too.
• I'd consider adding a very small padding on the right side (pushing the track time to the left). Like 2-5px, so it's a bit more balanced
• I'd also try adding some marginTop to the album title rows. So albums can be separated better and have some more breathing room.
• Also: should the title rows follow the odd/even coloring of the rows, or always be white? (or other color)

New version:

New version with reversed layout:

+1 for @januz's idea about not following the alternating background color for header rows (i.e. make them always be white or gray). I think that would help to make albums more distinct from one another in the list.

In D13639#281448, @ngraham wrote:

+1 for @januz's idea about not following the alternating background color for header rows (i.e. make them always be white or gray). I think that would help to make albums more distinct from one another in the list.

@ngraham @januz What do you have in mind ? I could do album header in white and alternating colors for the tracks including the first one. I am affraid it would look odd if the previous album finished with a white track. Anyway, I will try that.

In D13639#281449, @mgallien wrote:

In D13639#281448, @ngraham wrote:

+1 for @januz's idea about not following the alternating background color for header rows (i.e. make them always be white or gray). I think that would help to make albums more distinct from one another in the list.

@ngraham @januz What do you have in mind ? I could do album header in white and alternating colors for the tracks including the first one. I am affraid it would look odd if the previous album finished with a white track. Anyway, I will try that.

with the album header always of a given color:

I can see what you mean, the alternating colors would look weird if they go across albums. The other option could be making the alternating colors "local" to albums, but I'm not sure how we could do that since we can't rely on track numbers.

Another issue: songs without an album look a bit weird. This was an problem before too though. Maybe set the title to something like "(No Album)" for these?

In D13639#281508, @januz wrote:

I can see what you mean, the alternating colors would look weird if they go across albums. The other option could be making the alternating colors "local" to albums, but I'm not sure how we could do that since we can't rely on track numbers.

Did you had a look at the last screenshot where all album headers have a third color distinct from the rows ? The difference may be too small but at the same time, I am a bit lost on which solution apply.

Another issue: songs without an album look a bit weird. This was an problem before too though. Maybe set the title to something like "(No Album)" for these?

I would prefer to fix this issue in another review to keep this one to the initial scope in the hope to finish it for the next release.

In D13639#282787, @mgallien wrote:

In D13639#281508, @januz wrote:

I can see what you mean, the alternating colors would look weird if they go across albums. The other option could be making the alternating colors "local" to albums, but I'm not sure how we could do that since we can't rely on track numbers.

Did you had a look at the last screenshot where all album headers have a third color distinct from the rows ? The difference may be too small but at the same time, I am a bit lost on which solution apply.

I see, I saw the third color screenshot but I thought you were talking about the alternating row colors going on across albums. I don't think it looks bad, could you push it here so we can see how it looks in elisa?

Another issue: songs without an album look a bit weird. This was an problem before too though. Maybe set the title to something like "(No Album)" for these?

I would prefer to fix this issue in another review to keep this one to the initial scope in the hope to finish it for the next release.

Sounds good

overall quite nice, I like the changes! I think some margin on the right side for the track length would be great though

I think it looks really good right now! Two more things:

• Every track has the multi-disc format now (1/2, 1/3, etc.) even when they are not multi disc. Some individual tracks show " / 1".
• The screen you shared earlier had the track numbers and artist names in a lighter grey, did you decide against it?

In D13639#283452, @astippich wrote:

overall quite nice, I like the changes! I think some margin on the right side for the track length would be great though

Thanks for your feedback. I have added some margins around the track duration. You are right.

In D13639#283542, @januz wrote:

I think it looks really good right now! Two more things:

• Every track has the multi-disc format now (1/2, 1/3, etc.) even when they are not multi disc. Some individual tracks show " / 1".

I am investigating.

• The screen you shared earlier had the track numbers and artist names in a lighter grey, did you decide against it?

Unfortunately, I have not yet found a reliable way to get light text with all fonts. Some work, some does not work.

In D13639#284146, @mgallien wrote:

Unfortunately, I have not yet found a reliable way to get light text with all fonts. Some work, some does not work.

That's weird, changing the color should always work. Unless you are changing the weight, that would only work with fonts that have a light variant.

In D13639#284496, @januz wrote:

In D13639#284146, @mgallien wrote:

Unfortunately, I have not yet found a reliable way to get light text with all fonts. Some work, some does not work.

That's weird, changing the color should always work. Unless you are changing the weight, that would only work with fonts that have a light variant.

Yes, this is the solution. I will try to see if using a different color would make the visual effect reliable no matter the chosen font. I had always used the light variant of fonts.

In D13639#284496, @januz wrote:

In D13639#284146, @mgallien wrote:

Unfortunately, I have not yet found a reliable way to get light text with all fonts. Some work, some does not work.

That's weird, changing the color should always work. Unless you are changing the weight, that would only work with fonts that have a light variant.

I tried modifying the color but I did not manage to do it. I had difficulties to select a color that would work (including dark themes). I tried using dark color but with Breeze dark, the result is just bad.

In D13639#284146, @mgallien wrote:

In D13639#283542, @januz wrote:

I think it looks really good right now! Two more things:

• Every track has the multi-disc format now (1/2, 1/3, etc.) even when they are not multi disc. Some individual tracks show " / 1".

I am investigating.

I found a couple of issues related to management of single/multiple discs albums. Still, I do not yet understand the exact problem you are getting.

I also need to fix the layout in case an album has 2 digits disc numbers.

• The screen you shared earlier had the track numbers and artist names in a lighter grey, did you decide against it?

Unfortunately, I have not yet found a reliable way to get light text with all fonts. Some work, some does not work.