use more appropriate icon names for the tracks and play list views
ClosedPublic
Actions

Authored by mgallien on May 16 2018, 5:27 AM.

Details

Reviewers

astippich
januz

Commits

Summary

use more appropriate icon names for the tracks and play list views

Test Plan

works

Repository

R255 Elisa

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

mgallien requested review of this revision.May 16 2018, 5:27 AM

mgallien created this revision.

LGTM. The tracks icon is much better now

This revision is now accepted and ready to land.May 16 2018, 12:39 PM

please also adjust the windows theme

src/qml/Theme.qml
32–33	I think we can also use a more standard name here

This revision now requires changes to proceed.May 16 2018, 6:44 PM

mgallien marked an inline comment as done.May 16 2018, 8:17 PM

This revision is now accepted and ready to land.May 16 2018, 8:46 PM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			src/qml/Theme.qml (6 lines)
M			src/windows/WindowsTheme.qml (6 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	34255	4289fca		May 16 2018, 5:27 AM	★	★
Diff 2	34327	4f6142b	- fiw windows specific support and add one more icon name change	May 16 2018, 8:17 PM	★	★
Diff 3	34331	985e203	R255:b4fa37e72be08e683deb1c9df58b036f57ea6f37	May 16 2018, 8:58 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
c57c97be807b	015ee69b31dd	2cbff0f20828	Matthieu Gallien	fiw windows specific support and add one more icon name change	May 16 2018, 8:16 PM
2cbff0f20828	3f3887dd2e55	4f6142b7cb97	Matthieu Gallien	use more appropriate icon names for the tracks and play list views (Show More…)	May 16 2018, 5:25 AM