well.. I couldn't get it running as a toolchain and kept running into errors.
- Queries
- All Stories
- Search
- Advanced Search
Advanced Search
Apr 17 2019
In D20558#451898, @sh-zam wrote:In my case if I do this: include (Android.cmake), then it won't be able to find the ECMAndroidDeployQt.cmake because I am using android-ndk's toolchain.
What does it mean that "it expects to run as a toolchain"?
In D20558#450229, @sh-zam wrote:Why are you using it without Android.cmake?
I am building Krita and to add create-apk target I am using include (ECMAndroidDeployQt.cmake), I can't use Android.cmake because of some variables as it expects to run as a toolchain.
Apr 15 2019
- disallow whitespaces in path
Why are you using it without Android.cmake?
- disallow whitespaces in path
In D20558#450198, @sh-zam wrote:Can we add a cmake_minimum_required to 3.7? Regex fails to compile on older versions, when run outside of Android.cmake.
Apr 14 2019
Looks good to me, can you land it?
Can we add a cmake_minimum_required to 3.7? Regex fails to compile on older versions, when run outside of Android.cmake.
improved name and code flow
Apr 13 2019
minor typo fixed
Apr 7 2019
All the modules that use this cmake file, already build fine in debug mode with strict iterators.
This enables the same setting in release mode, for code that already builds fine in debug mode. So unless people have bad code in #ifndef NDEBUG, I don't expect this to break anything at all.
Are we sure we don't break code by introducing this? Or we're just going to play Whac-A-Mole with compile errors until all it's compiling again?
Apr 2 2019
Mar 29 2019
Hmm it looks like we're using ancient code option.
FWIW, I have meanwhile used this patch to build all kube dependencies on linux and osx as well, and it seems like it doesn't break anything.
for generating server files too
Mar 26 2019
LGTM, looks like clang-cl will be missing a few arguments though.
There was already an earlier (abandoned) attempt at this: https://git.reviewboard.kde.org/r/128779
Mar 24 2019
fixing a typo.
make parallel network requests.
complete diff.
now with glob matching and another round of renaming blacklist files.
Mar 23 2019
remove BLACKLSIT for httpcheck
add httpupdate and split out blacklist file
In D19996#436824, @winterz wrote:this would be a nice addition to Krazy. on my todo list.
this would be a nice addition to Krazy. on my todo list.
search for http://\S
add more excludes.
update http regex
update python script.
Mar 5 2019
Makes sense --> https://phabricator.kde.org/D19538
Mar 4 2019
FWIW, this still results in inproper pc files, from what I heard recently. The prefix variable can be overriden from outside when calling pkg-config (cmp. pkg-config --help) to allow for relocatable installations. Same like CMake Config files also allow relocation by having the install prefix not hardcoded into directory var values.
Thanks.
Update unittests, passes now
In D19506#424301, @cgiboudeaux wrote:The autotest has to be fixed as well
The autotest has to be fixed as well
Works for me !
In D18943#424041, @kossebau wrote:In D18943#424029, @vkrause wrote:What I don't understand though is which FindFontconfig this used to find, there is non in plasma-desktop...
kdelibs4support provides one.
Mar 3 2019
In D18943#424029, @vkrause wrote:What I don't understand though is which FindFontconfig this used to find, there is non in plasma-desktop...
D19499 fixes that here
In D18943#423969, @matthieugras wrote:This commit breaks plasma-desktop compilation for me (on ubuntu && arch => undefined refrence in plasma-desktop/kcms/kfontinst).
This commit breaks plasma-desktop compilation for me (on ubuntu && arch => undefined refrence in plasma-desktop/kcms/kfontinst).
Add backward compatibility variables.
In D19486#423728, @cgiboudeaux wrote:We probably need to set uppercase variables for the moment. plasma-desktop and powerdevil include the ECM modules dir before their local copy, so any older release would fail to build with ECM >= 5.57
We probably need to set uppercase variables for the moment. plasma-desktop and powerdevil include the ECM modules dir before their local copy, so any older release would fail to build with ECM >= 5.57
The warning needs to be removed then. We can't really warn at the time of using a variable.
Mar 2 2019
LGTM
ping?
Feb 26 2019
In D19016#420246, @apol wrote:Applications can still override it, note it's a default.
Also note this: https://developer.android.com/distribute/best-practices/develop/target-sdk
Applications can still override it, note it's a default.
Also note this: https://developer.android.com/distribute/best-practices/develop/target-sdk
Feb 25 2019
Feb 22 2019
If anyone hits a cmake error about "/usr/include/EGL/EGL/egl.h" after updating ECM (e.g. in kwayland or plasma-framework), remove the cache in the builddir and rerun cmake. This commit is actually correct, it's just incompatible with existing caches.
Feb 20 2019
Has this been fixed? I haven't seen these warnings
Yep, I'd say let's get it in kstars and if other applications start needing it, we move it to ECM to share.
Feb 19 2019
explicitly set FOUND_VAR so it is camelcase too
Thanks! just a little thing to fix before pushing
Feb 18 2019
In D19005#414313, @apol wrote:In D19005#412258, @vkrause wrote:Actually having tested this, "deprecated_value" looks wrong there, shouldn't this be "default_value"?
no, the value is coming from the cache, so that's the one we're setting. What this patch tries to make sure is that we don't forward an empty value (resetting a proper variable to "").
fix bad copy paste in compat setup