tcberner (Tobias C. Berner)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
Mar 22 2016, 8:57 PM (200 w, 20 h)
Availability
Available

Recent Activity

Sat, Jan 18

tcberner accepted D26750: CMake: Bump min TpQt version to 0.9.8 and use its targets.

Looks good to me. FreeBSD CI already has telepathy-qt5-0.9.8 installed.

Sat, Jan 18, 2:48 PM · KDE Telepathy
tcberner requested review of D26748: Fix liboath detection and use include directory..
Sat, Jan 18, 7:59 AM

Dec 14 2019

tcberner added a comment to D26008: Include the gmock prefix in the search path.

See [1]

05:46:54  -- Found libgmock: /usr/local/include/gmock, /usr/local/lib/libgmock.so;/usr/local/lib/libgtest.so;/usr/lib/libpthread.so
[...]
05:47:24  In file included from /usr/home/jenkins/workspace/Extragear/amarok/kf5-qt5 FreeBSDQt5.13/tests/core/logger/TestLogger.cpp:21:
05:47:24  /usr/home/jenkins/workspace/Extragear/amarok/kf5-qt5 FreeBSDQt5.13/tests/mocks/MockLogger.h:20:10: fatal error: 'gmock/gmock.h' file not found
05:47:24  #include <gmock/gmock.h>
05:47:24           ^~~~~~~~~~~~~~~
05:47:24  1 error generated.
Dec 14 2019, 9:56 PM
tcberner requested review of D26008: Include the gmock prefix in the search path.
Dec 14 2019, 9:55 PM
tcberner closed D26007: Add Intl_LIBRARIES and Intl_INCLUDE_DIRS to FalkonPrivate.
Dec 14 2019, 9:46 PM · Falkon
tcberner committed R875:3efda1bda45d: Add Intl_LIBRARIES and Intl_INCLUDE_DIRS to FalkonPrivate (authored by tcberner).
Add Intl_LIBRARIES and Intl_INCLUDE_DIRS to FalkonPrivate
Dec 14 2019, 9:46 PM
tcberner requested review of D26007: Add Intl_LIBRARIES and Intl_INCLUDE_DIRS to FalkonPrivate.
Dec 14 2019, 9:24 PM · Falkon

Dec 8 2019

tcberner closed D25808: Add FreeBSD to supported platforms.
Dec 8 2019, 1:58 PM
tcberner updated the diff for D25808: Add FreeBSD to supported platforms.
  • Add .arcconfig
Dec 8 2019, 12:23 PM
tcberner requested review of D25808: Add FreeBSD to supported platforms.
Dec 8 2019, 12:22 PM

Nov 24 2019

tcberner committed R321:100777109dde: FreeBSD: lld does not support -Wl,-z,nodump (authored by tcberner).
FreeBSD: lld does not support -Wl,-z,nodump
Nov 24 2019, 8:31 AM
tcberner closed D25501: FreeBSD: lld does not support -Wl,-z,nodump.
Nov 24 2019, 8:31 AM · KDE Edu
tcberner updated the summary of D25501: FreeBSD: lld does not support -Wl,-z,nodump.
Nov 24 2019, 8:04 AM · KDE Edu
tcberner requested review of D25501: FreeBSD: lld does not support -Wl,-z,nodump.
Nov 24 2019, 8:03 AM · KDE Edu
tcberner abandoned D17863: Add ecm_check_linker_flags function.
Nov 24 2019, 8:03 AM · Build System, Frameworks

Nov 21 2019

tcberner added a comment to T12069: Request for a FreeBSD Qt5 build job on build.kde.org.

I think it would be preferable if the cmake were fixed to properly respect the values read via the find package call. It's an easy fix after all.

Nov 21 2019, 4:35 PM · Digikam
tcberner added a comment to T12069: Request for a FreeBSD Qt5 build job on build.kde.org.

Yes, all the patch-* in the files direcotry in the above link get applied before building.

Nov 21 2019, 11:03 AM · Digikam
tcberner added a comment to T12069: Request for a FreeBSD Qt5 build job on build.kde.org.

We have it fixed like so in the tree:
https://github.com/freebsd/freebsd-ports-kde/blob/master/graphics/digikam/files/patch-core_CMakeLists.txt

Nov 21 2019, 5:11 AM · Digikam

Nov 20 2019

tcberner added a comment to T12069: Request for a FreeBSD Qt5 build job on build.kde.org.

@cgilles https://build.kde.org/job/Extragear/job/digikam/job/kf5-qt5%20FreeBSDQt5.13/8/console opencv has been installed -- failures are now the missing link directories (basically -L/usr/local/lib)

Nov 20 2019, 7:40 PM · Digikam
tcberner added a comment to T12069: Request for a FreeBSD Qt5 build job on build.kde.org.

Sure, I'll do that later today.

Nov 20 2019, 11:11 AM · Digikam

Oct 25 2019

tcberner updated the diff for D24810: Ensure defintion of XDG_DATA_DIRS.

Update commit message in diff.

Oct 25 2019, 6:02 AM · Plasma
tcberner updated the diff for D24810: Ensure defintion of XDG_DATA_DIRS.

Fix comment and commit message.

Oct 25 2019, 6:01 AM · Plasma

Oct 20 2019

tcberner requested review of D24810: Ensure defintion of XDG_DATA_DIRS.
Oct 20 2019, 5:28 PM · Plasma

Oct 17 2019

tcberner committed R244:b1d27cabc2a9: KProcessInfoList -- add proclist backend for FreeBSD (authored by tcberner).
KProcessInfoList -- add proclist backend for FreeBSD
Oct 17 2019, 2:38 PM
tcberner closed D21146: KProcessInfoList -- add proclist backend for FreeBSD.
Oct 17 2019, 2:38 PM · Frameworks
tcberner added a comment to D21146: KProcessInfoList -- add proclist backend for FreeBSD.

@adridg I've addressed your comments [finally].

Oct 17 2019, 1:51 PM · Frameworks
tcberner updated the diff for D21146: KProcessInfoList -- add proclist backend for FreeBSD.
  • procstat: add FindProcstat.cmake
  • procstat: add procstat backend
  • procstat: add procstat option
  • procstat: add linkage for procstat backend
Oct 17 2019, 1:50 PM · Frameworks

Jul 10 2019

tcberner committed R94:940f4af994a0: Use QTWEBENGINEWIDGETS_VERSION (authored by mlaurent).
Use QTWEBENGINEWIDGETS_VERSION
Jul 10 2019, 5:37 AM
tcberner committed R94:eefff09e2f3f: Use QTWEBENGINE_VERSION not QT_VERSION for WebEngine feature detection (authored by tcberner).
Use QTWEBENGINE_VERSION not QT_VERSION for WebEngine feature detection
Jul 10 2019, 5:37 AM
tcberner committed R94:9f4aea073dc1: Add missing include files (authored by mlaurent).
Add missing include files
Jul 10 2019, 5:37 AM

Jul 6 2019

tcberner committed R94:b3d4de670ad6: Use QTWEBENGINE_VERSION not QT_VERSION for WebEngine feature detection (authored by tcberner).
Use QTWEBENGINE_VERSION not QT_VERSION for WebEngine feature detection
Jul 6 2019, 7:11 PM
tcberner closed D22300: Use QTWEBENGINE_VERSION not QT_VERSION for WebEngine feature detection.
Jul 6 2019, 7:11 PM · KDE PIM
tcberner requested review of D22300: Use QTWEBENGINE_VERSION not QT_VERSION for WebEngine feature detection.
Jul 6 2019, 3:06 PM · KDE PIM

Jul 5 2019

tcberner added a comment to T11177: ASan backtrace with FreeBSD CI builds does not show source line numbers.

See build 160

00:26:54  ==654==ERROR: AddressSanitizer: heap-use-after-free on address 0x60700075d3c8 at pc 0x00080264d0fb bp 0x7fffdddec670 sp 0x7fffdddec668
00:26:54  READ of size 4 at 0x60700075d3c8 thread T18
00:26:54      #0 0x80264d0fa in std::__1::__atomic_base<int, false>::load(std::__1::memory_order) const /usr/include/c++/v1/atomic:926:17
00:26:54      #1 0x80264d0fa in int QAtomicOps<int>::loadAcquire<int>(std::__1::atomic<QAtomicOps<int>::loadAcquire<int>> const&) /usr/local/include/qt5/QtCore/qatomic_cxx11.h:239
00:26:54      #2 0x80264c504 in QBasicAtomicInteger<int>::loadAcquire(void) const /usr/local/include/qt5/QtCore/qbasicatomic.h:106:51
00:26:54      #3 0x8026f3b44 in QBasicAtomicInteger<int>::operator(cast)(int, void) const /usr/local/include/qt5/QtCore/qbasicatomic.h:108:48
00:26:54      #4 0x8026f24dc in KDevelop::FileManagerListJob::startNextJob(void)::$_0::operator()(KDevelop::Path const&) const /usr/home/jenkins/workspace/KDevelop/kdevelop/kf5-qt5 FreeBSDQt5.12/kdevplatform/project/filemanagerlistjob.cpp:122:17
00:26:54      #5 0x8026f1daa in QtConcurrent::StoredFunctorCall1<void, KDevelop::FileManagerListJob::startNextJob(void)::$_0, KDevelop::Path>::runFunctor(void) /usr/local/include/qt5/QtConcurrent/qtconcurrentstoredfunctioncall.h:432:34
00:26:54      #6 0x80269c364 in QtConcurrent::RunFunctionTask<void>::run(void) /usr/local/include/qt5/QtConcurrent/qtconcurrentrunbase.h:136:19
00:26:54      #7 0x80269c528 in virtual function non-virtual override offset : -16 QtConcurrent::RunFunctionTask<void>::run(void) /usr/local/include/qt5/QtConcurrent/qtconcurrentrunbase.h
00:26:54      #8 0x807716d6f in QThreadPoolThread::run(void) /wrkdirs/usr/ports/devel/qt5-core/work/qtbase-everywhere-src-5.12.2/src/corelib/thread/qthreadpool.cpp:99:24
00:26:54      #9 0x80770d8d4 in QThreadPrivate::start(void*) /wrkdirs/usr/ports/devel/qt5-core/work/qtbase-everywhere-src-5.12.2/src/corelib/thread/qthread_unix.cpp:361:14
00:26:54      #10 0x807379775  (/lib/libthr.so.3+0xd775)
Jul 5 2019, 10:28 PM · build.kde.org
tcberner added a comment to T11177: ASan backtrace with FreeBSD CI builds does not show source line numbers.

I think the issue was that there was no llvm-symbolizer binary found on the system, as in FreeBSD 12.0 it seems none is provided by the base system, so we only had the versioned ones llvm-symbolizer50 and llvm-symbolizer60 available in $PATH.

Jul 5 2019, 10:09 PM · build.kde.org

May 12 2019

tcberner added a member for FreeBSD: arrowd.
May 12 2019, 9:34 AM
tcberner added a comment to D21146: KProcessInfoList -- add proclist backend for FreeBSD.

Gargh, the code kdelibs code formatter changed a lot more in kprocesslist_unix_proc.cpp than wanted :/

May 12 2019, 9:33 AM · Frameworks
tcberner updated the diff for D21146: KProcessInfoList -- add proclist backend for FreeBSD.
  • Switch to 2-Clause
  • Move procstat backend into its own file
  • Remove now unnecessary config-kprocesslist.cmake
May 12 2019, 9:28 AM · Frameworks

May 11 2019

tcberner updated the diff for D21146: KProcessInfoList -- add proclist backend for FreeBSD.

Remove commented line.

May 11 2019, 9:19 PM · Frameworks
tcberner added inline comments to D21146: KProcessInfoList -- add proclist backend for FreeBSD.
May 11 2019, 9:16 PM · Frameworks
tcberner requested review of D21146: KProcessInfoList -- add proclist backend for FreeBSD.
May 11 2019, 9:15 PM · Frameworks

May 4 2019

tcberner added a comment to T10874: Make pulseaudio-qt available in KDE Connect CI.

The FreeBSD builders now have the package pulseaudio-qt installed (also libfakekey).

May 4 2019, 7:42 AM · build.kde.org

May 2 2019

tcberner added a comment to T10874: Make pulseaudio-qt available in KDE Connect CI.

I'll add it later.

May 2 2019, 11:37 AM · build.kde.org

Feb 19 2019

tcberner committed R240:7c64db956829: Fix FindEGL (authored by tcberner).
Fix FindEGL
Feb 19 2019, 12:15 PM
tcberner closed D19075: Fix FindEGL.
Feb 19 2019, 12:15 PM · Build System, Frameworks

Feb 16 2019

tcberner updated the diff for D19075: Fix FindEGL.

Simply set NAMES EGL/egl.h and fixup the header version check.

Feb 16 2019, 10:51 AM · Build System, Frameworks
tcberner added a comment to D19075: Fix FindEGL.

I think that it should be NAMES EGL/egl.h

Feb 16 2019, 10:47 AM · Build System, Frameworks
tcberner updated the diff for D19075: Fix FindEGL.

Store the path gathered via pkgconfig in COMPLETE_EGL_INCLUDE_DIR and
use its parent directory for EGL_INCLUDE_DIR.

Feb 16 2019, 9:57 AM · Build System, Frameworks
tcberner added a comment to D19075: Fix FindEGL.

Possibly the returend EGL_INCLUDE_DIR should possibly be stripped of the suffix too, as most will proably include 'EGL/egl.h', and not 'egl.h', I guess?

Feb 16 2019, 7:23 AM · Build System, Frameworks
tcberner added a reviewer for D19075: Fix FindEGL: FreeBSD.
Feb 16 2019, 7:19 AM · Build System, Frameworks
tcberner added a dependency for D19075: Fix FindEGL: D18960: Add compile check to FindEGL.
Feb 16 2019, 7:19 AM · Build System, Frameworks
tcberner added a dependent revision for D18960: Add compile check to FindEGL: D19075: Fix FindEGL.
Feb 16 2019, 7:19 AM · Build System, Frameworks
tcberner requested review of D19075: Fix FindEGL.
Feb 16 2019, 7:18 AM · Build System, Frameworks

Feb 13 2019

tcberner added a comment to D18960: Add compile check to FindEGL.

Seems this is sadly breaking something for FreeBSD though, see
https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20FreeBSDQt5.12/21/console

Feb 13 2019, 5:24 PM · Build System, Frameworks

Feb 12 2019

tcberner committed R487:b46c224553f6: Define QT.phonon4qt5.module = phonon4qt5 for Qt5-5.12.1 (authored by tcberner).
Define QT.phonon4qt5.module = phonon4qt5 for Qt5-5.12.1
Feb 12 2019, 11:32 AM
tcberner closed D18919: Define QT.phonon4qt5.module = phonon4qt5 for Qt5-5.12.1.
Feb 12 2019, 11:32 AM

Feb 11 2019

tcberner added a comment to D18919: Define QT.phonon4qt5.module = phonon4qt5 for Qt5-5.12.1.

Probably should set module like in https://phabricator.kde.org/D18243

Feb 11 2019, 4:19 PM
tcberner requested review of D18919: Define QT.phonon4qt5.module = phonon4qt5 for Qt5-5.12.1.
Feb 11 2019, 6:20 AM

Jan 26 2019

tcberner added a comment to T10400: Dependency change for Krita.

quazip-0.7.3 is now installed.

Jan 26 2019, 9:26 AM · build.kde.org
tcberner added a comment to T10397: Qt 5.12 for plasma master.

FreeBSD already has 5.12 on CI

Jan 26 2019, 9:05 AM · build.kde.org

Jan 6 2019

tcberner added a reviewer for D18009: Add Findepoll.cmake to find epoll/epoll-shim and add initial FreeBSD support: FreeBSD.
Jan 6 2019, 12:04 PM · KWin
tcberner updated the diff for D18009: Add Findepoll.cmake to find epoll/epoll-shim and add initial FreeBSD support.
  • add include directory
  • fix HAVE_epoll -> epoll_FOUND
Jan 6 2019, 11:55 AM · KWin
tcberner requested review of D18009: Add Findepoll.cmake to find epoll/epoll-shim and add initial FreeBSD support.
Jan 6 2019, 11:24 AM · KWin

Jan 5 2019

tcberner abandoned D17606: [WIP] Use <optional> if available..

Thanks :)

Jan 5 2019, 12:01 AM · KDE PIM

Dec 31 2018

tcberner added a comment to D17863: Add ecm_check_linker_flags function.

Why not fixing kstars instead?

Dec 31 2018, 6:48 AM · Build System, Frameworks

Dec 29 2018

tcberner added a comment to D17863: Add ecm_check_linker_flags function.

See: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=230603

Dec 29 2018, 10:58 PM · Build System, Frameworks
tcberner updated the summary of D17863: Add ecm_check_linker_flags function.
Dec 29 2018, 10:57 PM · Build System, Frameworks
tcberner requested review of D17863: Add ecm_check_linker_flags function.
Dec 29 2018, 10:56 PM · Build System, Frameworks

Dec 26 2018

tcberner added a comment to D17606: [WIP] Use <optional> if available..

I've recently run into the same problem on Akonadi on Windows, ended up allowing C++17 on Windows only and shipping a C++14-compatible implementation of C++17 optional in 3rdparty for everyone else.

Maybe we could just get rid of the `optional` in this agent until we can switch to C++17 proper. I hate not having it, but it's just one or two occurrences here and probably not worth the magic to satisfy all compilers.
Dec 26 2018, 5:43 PM · KDE PIM

Dec 15 2018

tcberner requested review of D17606: [WIP] Use <optional> if available..
Dec 15 2018, 4:47 PM · KDE PIM

Dec 6 2018

tcberner added inline comments to D17015: Fix the Qt doc creation with Qt 5.12..
Dec 6 2018, 7:40 PM · Build System, Frameworks

Nov 2 2018

tcberner committed R482:40ce07bcee92: Fix FreeBSD kvm backend. (authored by Heath Nielson <heathn@gmail.com>).
Fix FreeBSD kvm backend.
Nov 2 2018, 12:39 PM
tcberner closed D16608: Fix FreeBSD kvm backend..
Nov 2 2018, 12:39 PM
tcberner requested review of D16610: Don't redefine nulltpr on FreeBSD.
Nov 2 2018, 12:36 PM
tcberner added a comment to D16608: Fix FreeBSD kvm backend..

No problem to patch git/master

Gilles Caulier

Nov 2 2018, 12:24 PM
tcberner requested review of D16608: Fix FreeBSD kvm backend..
Nov 2 2018, 12:01 PM

Oct 24 2018

tcberner added a comment to D16398: Check QtWebEngine version instead of Qt's.

Cool, this should also benefit FreeBSD, where we have
Qt 5.11.2/QtWebengine 5.9.4

Oct 24 2018, 12:07 PM · KDE PIM

Oct 21 2018

tcberner committed R123:1c1f654b0010: sddm-kcm: don't hardcode session file location. (authored by Róbert Bagdán <kikadf.01@gmail.com>).
sddm-kcm: don't hardcode session file location.
Oct 21 2018, 8:06 AM
tcberner closed D16339: sddm-kcm: don't hardcode session file location..
Oct 21 2018, 8:06 AM · Plasma

Oct 20 2018

tcberner added a reviewer for D16339: sddm-kcm: don't hardcode session file location.: Plasma.
Oct 20 2018, 5:15 PM · Plasma
tcberner requested review of D16339: sddm-kcm: don't hardcode session file location..
Oct 20 2018, 5:14 PM · Plasma

Aug 30 2018

tcberner committed R878:156accc34f44: Fix build on FreeBSD by including <array>. (authored by tcberner).
Fix build on FreeBSD by including <array>.
Aug 30 2018, 4:15 PM
tcberner closed D14534: Fix build on FreeBSD by including <array>..
Aug 30 2018, 4:15 PM · Plasma

Aug 1 2018

tcberner requested review of D14534: Fix build on FreeBSD by including <array>..
Aug 1 2018, 11:44 AM · Plasma

Jul 29 2018

tcberner added a comment to T9249: KDevelop's GDB pretty printer units tests fail due to non-UTF-8 default codec.

Hm, python is on:

Jul 29 2018, 10:10 AM · FreeBSD, KDevelop, build.kde.org
tcberner added a comment to T9249: KDevelop's GDB pretty printer units tests fail due to non-UTF-8 default codec.

@arrowd, the pkgs are upgraded, and gdb is at 8.1_5.

Jul 29 2018, 9:27 AM · FreeBSD, KDevelop, build.kde.org
tcberner added a comment to T9249: KDevelop's GDB pretty printer units tests fail due to non-UTF-8 default codec.

Let me build new packages then :)

Jul 29 2018, 5:58 AM · FreeBSD, KDevelop, build.kde.org

Jul 15 2018

tcberner added a comment to D14066: Find KF5I18n in the top-level CMakeLists.txt.

+1 otherwise kde-dev-utils fails to package on FreeBSD too with 5.48.

Jul 15 2018, 10:03 AM
tcberner added a comment to T9091: Merge PulseAudio and Phonon KCM.

I would say not really.

Jul 15 2018, 9:39 AM · Plasma
tcberner added a comment to T9091: Merge PulseAudio and Phonon KCM.
  • There is PA FreeBSD -- but many prefer to not use it.
  • The Phonon Audio Video config dialog in systemsettings is "useful" in that it let's you test the sound output and check the installed backends.
Jul 15 2018, 7:52 AM · Plasma

May 23 2018

tcberner committed R181:d2d922409855: Fix build/test on FreeBSD (authored by tcberner).
Fix build/test on FreeBSD
May 23 2018, 8:52 PM
tcberner closed D13044: Fix build/test on FreeBSD.
May 23 2018, 8:52 PM
tcberner committed R410:08c096c43600: Fix linking on FreeBSD (authored by tcberner).
Fix linking on FreeBSD
May 23 2018, 8:49 PM
tcberner closed D13057: Fix linking on FreeBSD.
May 23 2018, 8:49 PM
tcberner requested review of D13057: Fix linking on FreeBSD.
May 23 2018, 10:33 AM
tcberner added a comment to T8802: New dependency for kpat (required for CI).

kpat still needs to add the required library paths or use the pkgconfig target:

12:25:27 /usr/bin/ld: error: unable to find library -lfreecell-solver
May 23 2018, 10:26 AM · build.kde.org
tcberner added a comment to T8802: New dependency for kpat (required for CI).

Sure, I'll add it later

May 23 2018, 10:10 AM · build.kde.org

May 22 2018

tcberner edited reviewers for D13044: Fix build/test on FreeBSD, added: FreeBSD; removed: Automotive.
May 22 2018, 4:48 PM
tcberner requested review of D13044: Fix build/test on FreeBSD.
May 22 2018, 4:47 PM

May 19 2018

tcberner committed R875:37a79e3ad4b4: Use IMPORTED_TARGET for GnomeKeyring. (authored by tcberner).
Use IMPORTED_TARGET for GnomeKeyring.
May 19 2018, 12:28 PM