Differential D19486

Add UDev find module
ClosedPublic
Actions

Authored by vkrause on Mar 3 2019, 9:26 AM.

Details

Reviewers

Commits

Summary

This one is originally coming from Solid, but there are several more copies
in our repositories (plasma-desktop, kwin, powerdevil, etc).

Diff Detail

Repository

R240 Extra CMake Modules

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

vkrause created this revision.Mar 3 2019, 9:26 AM

Restricted Application added projects: Frameworks, Build System. · View Herald TranscriptMar 3 2019, 9:26 AM

Restricted Application added subscribers: kde-buildsystem, kde-frameworks-devel. · View Herald Transcript

vkrause requested review of this revision.Mar 3 2019, 9:26 AM

Harbormaster completed remote builds in B9113: Diff 53047.Mar 3 2019, 9:26 AM

We probably need to set uppercase variables for the moment. plasma-desktop and powerdevil include the ECM modules dir before their local copy, so any older release would fail to build with ECM >= 5.57

find-modules/FindUDev.cmake
25	Since 5.57

In D19486#423728, @cgiboudeaux wrote:

We probably need to set uppercase variables for the moment. plasma-desktop and powerdevil include the ECM modules dir before their local copy, so any older release would fail to build with ECM >= 5.57

Just tested. powerdevil fails to link and HAVE_UDEV is #undef'ed in config-keyboard.h from plasma-desktop. We need compat variables until KF6.

Add backward compatibility variables.

Harbormaster completed remote builds in B9118: Diff 53055.Mar 3 2019, 10:38 AM

krop accepted this revision.Mar 3 2019, 10:53 AM

krop added inline comments.

find-modules/FindUDev.cmake
87	mark_as_advanced(UDEV_FOUND UDEV_LIBS UDEV_INCLUDE_DIR)

This revision is now accepted and ready to land.Mar 3 2019, 10:53 AM

Closed by commit R240:8999b7bd6f6d: Add UDev find module (authored by vkrause). · Explain WhyMar 4 2019, 8:05 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

		Path
D	M	attic/modules/FindUDev.cmake (19 lines)
A	M	docs/find-module/FindUDev.rst (1 line)
A	M	find-modules/FindUDev.cmake (92 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	53047	e3b6c87		Mar 3 2019, 9:26 AM	★	★
Diff 2	53055	e3b6c87	Add backward compatibility variables.	Mar 3 2019, 10:38 AM	★	★
Diff 3	53160	4c78221	R240:8999b7bd6f6d1505c1b59b48432a3cfa4a90a2f8	Mar 4 2019, 8:04 PM	★	★