android: don't default to gcc anymore
AcceptedPublic

Authored by apol on Feb 14 2019, 2:36 PM.

Details

Reviewers
vkrause
Group Reviewers
Frameworks
Summary

It's deprecated

Diff Detail

Repository
R240 Extra CMake Modules
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 8293
Build 8311: arc lint + arc unit
apol created this revision.Feb 14 2019, 2:36 PM
Restricted Application added projects: Frameworks, Build System. · View Herald TranscriptFeb 14 2019, 2:36 PM
Restricted Application added subscribers: kde-buildsystem, kde-frameworks-devel. · View Herald Transcript
apol requested review of this revision.Feb 14 2019, 2:36 PM
vkrause accepted this revision.Feb 14 2019, 3:35 PM
This revision is now accepted and ready to land.Feb 14 2019, 3:35 PM

Actually having tested this, "deprecated_value" looks wrong there, shouldn't this be "default_value"?

In fact none of those seem to work here. D19016 works here though, and I suspect that the 14 -> 21 in there should fix ECM on the CI.

apol added a comment.Feb 18 2019, 1:01 AM

Actually having tested this, "deprecated_value" looks wrong there, shouldn't this be "default_value"?

no, the value is coming from the cache, so that's the one we're setting. What this patch tries to make sure is that we don't forward an empty value (resetting a proper variable to "").

In D19005#414313, @apol wrote:

Actually having tested this, "deprecated_value" looks wrong there, shouldn't this be "default_value"?

no, the value is coming from the cache, so that's the one we're setting. What this patch tries to make sure is that we don't forward an empty value (resetting a proper variable to "").

ah, that makes more sense, no idea why that seemed to break things here then though