Feed Advanced Search

Yesterday

aacid closed D19005: android: don't default to gcc anymore.

Talked with Aleix, we're deciding to drop this for the moment

Sun, Jul 21, 5:37 PM · Build System, Frameworks
cgiboudeaux added a comment to D22580: Notify users when not using KDE_INSTALL_USE_QT_SYS_PATHS about prefix.sh.

Thinking again: KDE_INSTALL_USE_QT_SYS_PATHS has no effect on XDG_CONFIG_DIRS and XDG_DATA_DIRS. Running prefix.sh is useful even if KDE_INSTALL_USE_QT_SYS_PATHS is true.

Sun, Jul 21, 9:28 AM · Build System, Frameworks
cgiboudeaux accepted D22580: Notify users when not using KDE_INSTALL_USE_QT_SYS_PATHS about prefix.sh.
Sun, Jul 21, 9:12 AM · Build System, Frameworks
apol updated the diff for D22580: Notify users when not using KDE_INSTALL_USE_QT_SYS_PATHS about prefix.sh.

Support older cmakes

Sun, Jul 21, 9:04 AM · Build System, Frameworks

Sat, Jul 20

cgiboudeaux added inline comments to D22580: Notify users when not using KDE_INSTALL_USE_QT_SYS_PATHS about prefix.sh.
Sat, Jul 20, 3:26 PM · Build System, Frameworks
albertvaka accepted D22580: Notify users when not using KDE_INSTALL_USE_QT_SYS_PATHS about prefix.sh.
Sat, Jul 20, 12:53 PM · Build System, Frameworks
apol updated the diff for D22580: Notify users when not using KDE_INSTALL_USE_QT_SYS_PATHS about prefix.sh.

Improve wording

Sat, Jul 20, 12:49 PM · Build System, Frameworks
albertvaka added inline comments to D22580: Notify users when not using KDE_INSTALL_USE_QT_SYS_PATHS about prefix.sh.
Sat, Jul 20, 12:47 PM · Build System, Frameworks
apol requested review of D22580: Notify users when not using KDE_INSTALL_USE_QT_SYS_PATHS about prefix.sh.
Sat, Jul 20, 12:14 PM · Build System, Frameworks

Tue, Jul 9

apol added a comment to D22317: Fix type names casing.

Just out of curiosity, why don't you use the cmake toolchain from Android NDK ? is located in ndk-bundle/build/cmake/android.toolchain.cmake

Tue, Jul 9, 3:07 PM · Build System, Frameworks
vatra added a comment to D22317: Fix type names casing.

Just out of curiosity, why don't you use the cmake toolchain from Android NDK ? is located in ndk-bundle/build/cmake/android.toolchain.cmake

Tue, Jul 9, 5:48 AM · Build System, Frameworks

Mon, Jul 8

apol closed D22317: Fix type names casing.
Mon, Jul 8, 11:50 AM · Build System, Frameworks
vkrause accepted D22317: Fix type names casing.
Mon, Jul 8, 6:50 AM · Build System, Frameworks
apol requested review of D22317: Fix type names casing.
Mon, Jul 8, 12:28 AM · Build System, Frameworks

Sat, Jun 29

zzag abandoned D22156: RFC: Add wayland-protocols find module.

how many users are there?

Sat, Jun 29, 6:46 PM · Build System, Frameworks
cgiboudeaux added a comment to D22156: RFC: Add wayland-protocols find module.

how many users are there?

Sat, Jun 29, 6:34 PM · Build System, Frameworks
apol added a comment to D22156: RFC: Add wayland-protocols find module.

LGTM +1

Sat, Jun 29, 5:36 PM · Build System, Frameworks
zzag retitled D22156: RFC: Add wayland-protocols find module from Add wayland-protocols find module to RFC: Add wayland-protocols find module.
Sat, Jun 29, 2:09 PM · Build System, Frameworks
zzag requested review of D22156: RFC: Add wayland-protocols find module.
Sat, Jun 29, 2:06 PM · Build System, Frameworks

Jun 17 2019

vkrause added a comment to D19996: WIP Add a global test for insecure http: URLs used in code or documentation.

Any chance this could not be done by abusing KDECMakeSettings.cmake as injection vector?

Jun 17 2019, 6:07 PM · Build System, Frameworks

Jun 16 2019

kossebau added a comment to D19996: WIP Add a global test for insecure http: URLs used in code or documentation.

Any chance this could not be done by abusing KDECMakeSettings.cmake as injection vector? I know you are just following the example of what was done for appstreamcli, but IMHO this has already been a bad hack, screwing over the fine granular design of all the ECM modules trying to keep aspects separate. And yes, by the price of the overhead with more explicit module includes, but it's like that. Or we should just screw it and put everything in one big "KDEECMEverythingEvenKitchenSink.cmake" ;) And yes, one possible would like to have such a generic wrapper module in any case, for quick prototyping. But the individual modules should stay focussed.

Jun 16 2019, 1:33 PM · Build System, Frameworks
bcooksley added a comment to D21313: Create specific directory for Qt logging categories file.

The Binary Factory uses the tooling shipped as part of the KDE SDK (which always builds everything from scratch, and I don't know if part of that includes ECM, hence why the issue doesn't show up there).

Jun 16 2019, 8:43 AM · Build System, Frameworks
vkrause added a comment to D21313: Create specific directory for Qt logging categories file.

@apol @vkrause Perhaps something to check wit the CI or in general with the ECM Android toolchain to make sure the ECM of the host and the target are not accidentally mixed or both visible at the same time.

Jun 16 2019, 7:51 AM · Build System, Frameworks
kossebau updated subscribers of D21313: Create specific directory for Qt logging categories file.

This change appears to be responsible for all Android builds being broken.
See https://build.kde.org/view/Failing/

Could someone take a look please?

Jun 16 2019, 12:37 AM · Build System, Frameworks

Jun 15 2019

bcooksley added a comment to D21313: Create specific directory for Qt logging categories file.

This change appears to be responsible for all Android builds being broken.
See https://build.kde.org/view/Failing/

Jun 15 2019, 9:25 PM · Build System, Frameworks

Jun 13 2019

apol accepted D20984: Add ECMAddQmlModule.
Jun 13 2019, 12:33 AM · Build System, Frameworks
kossebau updated the diff for D20984: Add ECMAddQmlModule.
  • add options to take identifiers/type names from file base names
  • add option to specify version suffix to install path
Jun 13 2019, 12:21 AM · Build System, Frameworks

Jun 10 2019

elvisangelaccio added a comment to D21695: Add FindTaglib.cmake.

I'm not entirely sure about taglib-config on Windows

Jun 10 2019, 7:55 PM · Build System, Frameworks
elvisangelaccio added a comment to D21695: Add FindTaglib.cmake.

Where does this FindTaglib.cmake come from?

Jun 10 2019, 7:53 PM · Build System, Frameworks
cgiboudeaux added a comment to D21695: Add FindTaglib.cmake.

attic/modules/FindTaglib.cmake shall be deleted.

Jun 10 2019, 11:44 AM · Build System, Frameworks
cgiboudeaux added inline comments to D21695: Add FindTaglib.cmake.
Jun 10 2019, 11:41 AM · Build System, Frameworks
dfaure requested changes to D21695: Add FindTaglib.cmake.

Certainly a good idea to have this in ECM, so that this mess can be sorted out once and for all...

Jun 10 2019, 11:04 AM · Build System, Frameworks

Jun 9 2019

heikobecker added a comment to D21695: Add FindTaglib.cmake.

I'm not entirely sure about taglib-config on Windows and Android (can't test there), but similar to pkg-config I omitted the special casing. Tried to test this by moving taglib-config out of the way on Linux and a taglib install in default locations, which worked fine.

Jun 9 2019, 3:40 PM · Build System, Frameworks
heikobecker requested review of D21695: Add FindTaglib.cmake.
Jun 9 2019, 3:34 PM · Build System, Frameworks

May 31 2019

mlaurent closed D21313: Create specific directory for Qt logging categories file.
May 31 2019, 2:56 PM · Build System, Frameworks
mlaurent retitled D21313: Create specific directory for Qt logging categories file from Create specific directory for kdebugsettings categories file to Create specific directory for Qt logging categories file.
May 31 2019, 2:55 PM · Build System, Frameworks
mlaurent updated the diff for D21313: Create specific directory for Qt logging categories file.

Fix typo

May 31 2019, 2:54 PM · Build System, Frameworks
cgiboudeaux added a comment to D21313: Create specific directory for Qt logging categories file.

Maybe also update the commit message to 'Create specific directory for Qt logging categories file'

May 31 2019, 8:45 AM · Build System, Frameworks
cgiboudeaux accepted D21313: Create specific directory for Qt logging categories file.
May 31 2019, 8:43 AM · Build System, Frameworks

May 30 2019

mlaurent added a comment to D21313: Create specific directory for Qt logging categories file.

So ? :)

May 30 2019, 1:07 PM · Build System, Frameworks

May 28 2019

mlaurent updated the diff for D21313: Create specific directory for Qt logging categories file.

Change as qlogging-categories5

May 28 2019, 6:55 AM · Build System, Frameworks
mlaurent added a comment to D21313: Create specific directory for Qt logging categories file.

Thanks david.
Indeed qlogging-categories5 seems a good name :)

May 28 2019, 6:52 AM · Build System, Frameworks

May 27 2019

dfaure added a comment to D21313: Create specific directory for Qt logging categories file.

My suggestion is to call this qlogging-categories5.

May 27 2019, 8:48 PM · Build System, Frameworks

May 25 2019

mgallien added a comment to D21381: use org.freedesktop.appstream-glib package to validate appstream data.
In D21381#469617, @apol wrote:

How about we test against both?

May 25 2019, 9:44 AM · Build System, Frameworks
mgallien updated the diff for D21381: use org.freedesktop.appstream-glib package to validate appstream data.
  • use appstream-util and appstreamcli to validate appdata file
May 25 2019, 9:40 AM · Build System, Frameworks
mlaurent added a comment to D21313: Create specific directory for Qt logging categories file.

LOGGINGCATEGORIESDIR indeed it's more specific +1 for me
debug-categories5 => indeed it's just using by kdebugsettings at the moment. => kdebugsettings-categories5 ?
no idea if it's better.

May 25 2019, 8:08 AM · Build System, Frameworks

May 24 2019

bcooksley added a comment to D21381: use org.freedesktop.appstream-glib package to validate appstream data.

Aleix is correct, Flatpak commands are not possible within the CI environment (as Docker is heavily locked down, and the containerisation and other isolation measures that Flatpak tries to take are locked out as a consequence)
Not to mention that Flatpak is Linux only as well, while Appstream data isn't applicable to multiple platforms.

May 24 2019, 7:30 PM · Build System, Frameworks
apol requested changes to D21381: use org.freedesktop.appstream-glib package to validate appstream data.

How about we test against both?

May 24 2019, 7:26 PM · Build System, Frameworks
ngraham added a reviewer for D21381: use org.freedesktop.appstream-glib package to validate appstream data: apol.
May 24 2019, 2:52 PM · Build System, Frameworks
kossebau added inline comments to D21313: Create specific directory for Qt logging categories file.
May 24 2019, 2:44 PM · Build System, Frameworks
mlaurent updated the diff for D21313: Create specific directory for Qt logging categories file.

Oops indeed I forgot to readd KXMLGUI_INSTALL_DIR

May 24 2019, 2:35 PM · Build System, Frameworks
mgallien requested review of D21381: use org.freedesktop.appstream-glib package to validate appstream data.
May 24 2019, 1:22 PM · Build System, Frameworks
cgiboudeaux added a comment to D21313: Create specific directory for Qt logging categories file.

Ping ?

May 24 2019, 7:45 AM · Build System, Frameworks
mlaurent added a comment to D21313: Create specific directory for Qt logging categories file.

Ping ?

May 24 2019, 5:02 AM · Build System, Frameworks

May 22 2019

kossebau updated the summary of D20984: Add ECMAddQmlModule.
May 22 2019, 6:05 PM · Build System, Frameworks
kossebau updated the diff for D20984: Add ECMAddQmlModule.

Renamed to ECMAddQmlModule, with more helper macros for non-C++ parts

May 22 2019, 5:51 PM · Build System, Frameworks
dfaure closed D21314: Don't enable QT_STRICT_ITERATORS on Windows..
May 22 2019, 7:49 AM · Build System, Frameworks
mlaurent updated the diff for D21313: Create specific directory for Qt logging categories file.

Use DEBUGCATEGORIESDIR and debug-categories5

May 22 2019, 4:55 AM · Build System, Frameworks

May 21 2019

dvratil accepted D21314: Don't enable QT_STRICT_ITERATORS on Windows..
May 21 2019, 2:09 PM · Build System, Frameworks
mlaurent added a comment to D21313: Create specific directory for Qt logging categories file.

DEBUGCATEGORIESDIR is fine for me too

May 21 2019, 10:58 AM · Build System, Frameworks
apol added a comment to D21314: Don't enable QT_STRICT_ITERATORS on Windows..

+1

May 21 2019, 10:53 AM · Build System, Frameworks
cgiboudeaux added a comment to D21313: Create specific directory for Qt logging categories file.

Looks mostly fine safe for the directory name that needs the major version to avoid conflicts when libfoo.categories built using KF5 will have to coexist with KF6.
It needs a '5' in its name.

May 21 2019, 7:52 AM · Build System, Frameworks
dfaure updated the diff for D21314: Don't enable QT_STRICT_ITERATORS on Windows..

Remove unrelated change

May 21 2019, 7:32 AM · Build System, Frameworks
dfaure requested review of D21314: Don't enable QT_STRICT_ITERATORS on Windows..
May 21 2019, 7:32 AM · Build System, Frameworks
cgiboudeaux added inline comments to D21313: Create specific directory for Qt logging categories file.
May 21 2019, 7:16 AM · Build System, Frameworks
mlaurent updated the diff for D21313: Create specific directory for Qt logging categories file.

Fix comment reported by Christophe Giboudeaux

May 21 2019, 7:08 AM · Build System, Frameworks
cgiboudeaux added inline comments to D21313: Create specific directory for Qt logging categories file.
May 21 2019, 6:51 AM · Build System, Frameworks
mlaurent updated the diff for D21313: Create specific directory for Qt logging categories file.

Forgot to commit before creating diff

May 21 2019, 6:14 AM · Build System, Frameworks
lbeltrame added a reviewer for D21313: Create specific directory for Qt logging categories file: cgiboudeaux.
May 21 2019, 5:51 AM · Build System, Frameworks
lbeltrame updated subscribers of D21313: Create specific directory for Qt logging categories file.
May 21 2019, 5:50 AM · Build System, Frameworks
mlaurent added a reviewer for D21313: Create specific directory for Qt logging categories file: dfaure.
May 21 2019, 5:48 AM · Build System, Frameworks
mlaurent requested review of D21313: Create specific directory for Qt logging categories file.
May 21 2019, 5:48 AM · Build System, Frameworks

May 3 2019

kossebau updated the diff for D20984: Add ECMAddQmlModule.

Add also support for TYPEINFO, merging main logic of ecm_generate_qmltypes

May 3 2019, 4:14 PM · Build System, Frameworks
kossebau updated the diff for D20984: Add ECMAddQmlModule.

get rid of newer list(TRANSFORM)

May 3 2019, 1:05 PM · Build System, Frameworks
kossebau updated the diff for D20984: Add ECMAddQmlModule.

Use file(WRITE/APPEND) over file(GENERATE), for less intermediate vars

May 3 2019, 12:58 PM · Build System, Frameworks
kossebau added a comment to D20984: Add ECMAddQmlModule.
In D20984#460128, @apol wrote:

wouldn't it be almost as complex to file(WRITE ... qmldir)? Most of the code is to construct the file.

May 3 2019, 11:51 AM · Build System, Frameworks
apol added a comment to D20984: Add ECMAddQmlModule.

wouldn't it be almost as complex to file(WRITE ... qmldir)? Most of the code is to construct the file.

May 3 2019, 11:21 AM · Build System, Frameworks
kossebau updated the summary of D20984: Add ECMAddQmlModule.
May 3 2019, 9:33 AM · Build System, Frameworks
kossebau updated the diff for D20984: Add ECMAddQmlModule.

Add DEPENDS & DESIGNERSUPPORTED, nothing complicated there (besides going
for asking string with pair of identifier & version, to avoid any arg clash
& make parsing easier)

May 3 2019, 9:33 AM · Build System, Frameworks
kossebau added a comment to D20984: Add ECMAddQmlModule.

Possibly the ECMGenerateQmlTypes could be also merged somehow, but I have no experience with that, so leaving to someone else to improve here.

May 3 2019, 8:45 AM · Build System, Frameworks
kossebau requested review of D20984: Add ECMAddQmlModule.
May 3 2019, 8:43 AM · Build System, Frameworks

Apr 17 2019

sh-zam added a comment to D20558: Bug fix: find c++ stl using regex.

well.. I couldn't get it running as a toolchain and kept running into errors.

Apr 17 2019, 4:23 PM · Build System, Frameworks
apol added a comment to D20558: Bug fix: find c++ stl using regex.

In my case if I do this: include (Android.cmake), then it won't be able to find the ECMAndroidDeployQt.cmake because I am using android-ndk's toolchain.

Apr 17 2019, 4:08 PM · Build System, Frameworks
sh-zam closed D20558: Bug fix: find c++ stl using regex.
Apr 17 2019, 3:57 PM · Build System, Frameworks
sh-zam added a comment to D20558: Bug fix: find c++ stl using regex.

What does it mean that "it expects to run as a toolchain"?

Apr 17 2019, 3:55 PM · Build System, Frameworks
apol accepted D20558: Bug fix: find c++ stl using regex.
Apr 17 2019, 3:16 PM · Build System, Frameworks
sh-zam added inline comments to D20558: Bug fix: find c++ stl using regex.
Apr 17 2019, 2:51 PM · Build System, Frameworks
apol added a comment to D20558: Bug fix: find c++ stl using regex.

Why are you using it without Android.cmake?

I am building Krita and to add create-apk target I am using include (ECMAndroidDeployQt.cmake), I can't use Android.cmake because of some variables as it expects to run as a toolchain.

Apr 17 2019, 2:36 PM · Build System, Frameworks

Apr 15 2019

sh-zam updated the diff for D20558: Bug fix: find c++ stl using regex.
  • disallow whitespaces in path
Apr 15 2019, 4:53 PM · Build System, Frameworks
sh-zam added a comment to D20558: Bug fix: find c++ stl using regex.

Why are you using it without Android.cmake?

Apr 15 2019, 12:28 AM · Build System, Frameworks
sh-zam updated the diff for D20558: Bug fix: find c++ stl using regex.
  • disallow whitespaces in path
Apr 15 2019, 12:28 AM · Build System, Frameworks
sh-zam closed D20509: Detect duplicate ANDROID_EXTRA_LIBS and minor bug fix.
Apr 15 2019, 12:13 AM · Build System, Frameworks
apol added a comment to D20558: Bug fix: find c++ stl using regex.

Can we add a cmake_minimum_required to 3.7? Regex fails to compile on older versions, when run outside of Android.cmake.

Apr 15 2019, 12:08 AM · Build System, Frameworks

Apr 14 2019

apol accepted D20509: Detect duplicate ANDROID_EXTRA_LIBS and minor bug fix.

Looks good to me, can you land it?

Apr 14 2019, 11:59 PM · Build System, Frameworks
sh-zam added a comment to D20558: Bug fix: find c++ stl using regex.

Can we add a cmake_minimum_required to 3.7? Regex fails to compile on older versions, when run outside of Android.cmake.

Apr 14 2019, 10:29 PM · Build System, Frameworks
sh-zam updated the diff for D20509: Detect duplicate ANDROID_EXTRA_LIBS and minor bug fix.

improved name and code flow

Apr 14 2019, 8:59 PM · Build System, Frameworks
sh-zam requested review of D20558: Bug fix: find c++ stl using regex.
Apr 14 2019, 8:55 PM · Build System, Frameworks
apol requested changes to D20509: Detect duplicate ANDROID_EXTRA_LIBS and minor bug fix.
Apr 14 2019, 5:47 PM · Build System, Frameworks

Apr 13 2019

lbeltrame added reviewers for D20509: Detect duplicate ANDROID_EXTRA_LIBS and minor bug fix: apol, vkrause.
Apr 13 2019, 10:47 PM · Build System, Frameworks
sh-zam updated the diff for D20509: Detect duplicate ANDROID_EXTRA_LIBS and minor bug fix.

minor typo fixed

Apr 13 2019, 5:01 PM · Build System, Frameworks