Feed Advanced Search

Fri, May 3

kossebau updated the diff for D20984: Add ECMInstallQmlModules, with ecm_install_qmlplugin as start.

Add also support for TYPEINFO, merging main logic of ecm_generate_qmltypes

Fri, May 3, 4:14 PM · Build System, Frameworks
kossebau updated the diff for D20984: Add ECMInstallQmlModules, with ecm_install_qmlplugin as start.

get rid of newer list(TRANSFORM)

Fri, May 3, 1:05 PM · Build System, Frameworks
kossebau updated the diff for D20984: Add ECMInstallQmlModules, with ecm_install_qmlplugin as start.

Use file(WRITE/APPEND) over file(GENERATE), for less intermediate vars

Fri, May 3, 12:58 PM · Build System, Frameworks
kossebau added a comment to D20984: Add ECMInstallQmlModules, with ecm_install_qmlplugin as start.
In D20984#460128, @apol wrote:

wouldn't it be almost as complex to file(WRITE ... qmldir)? Most of the code is to construct the file.

Fri, May 3, 11:51 AM · Build System, Frameworks
apol added a comment to D20984: Add ECMInstallQmlModules, with ecm_install_qmlplugin as start.

wouldn't it be almost as complex to file(WRITE ... qmldir)? Most of the code is to construct the file.

Fri, May 3, 11:21 AM · Build System, Frameworks
kossebau updated the summary of D20984: Add ECMInstallQmlModules, with ecm_install_qmlplugin as start.
Fri, May 3, 9:33 AM · Build System, Frameworks
kossebau updated the diff for D20984: Add ECMInstallQmlModules, with ecm_install_qmlplugin as start.

Add DEPENDS & DESIGNERSUPPORTED, nothing complicated there (besides going
for asking string with pair of identifier & version, to avoid any arg clash
& make parsing easier)

Fri, May 3, 9:33 AM · Build System, Frameworks
kossebau added a comment to D20984: Add ECMInstallQmlModules, with ecm_install_qmlplugin as start.

Possibly the ECMGenerateQmlTypes could be also merged somehow, but I have no experience with that, so leaving to someone else to improve here.

Fri, May 3, 8:45 AM · Build System, Frameworks
kossebau requested review of D20984: Add ECMInstallQmlModules, with ecm_install_qmlplugin as start.
Fri, May 3, 8:43 AM · Build System, Frameworks

Apr 17 2019

sh-zam added a comment to D20558: Bug fix: find c++ stl using regex.

well.. I couldn't get it running as a toolchain and kept running into errors.

Apr 17 2019, 4:23 PM · Build System, Frameworks
apol added a comment to D20558: Bug fix: find c++ stl using regex.

In my case if I do this: include (Android.cmake), then it won't be able to find the ECMAndroidDeployQt.cmake because I am using android-ndk's toolchain.

Apr 17 2019, 4:08 PM · Build System, Frameworks
sh-zam closed D20558: Bug fix: find c++ stl using regex.
Apr 17 2019, 3:57 PM · Build System, Frameworks
sh-zam added a comment to D20558: Bug fix: find c++ stl using regex.

What does it mean that "it expects to run as a toolchain"?

Apr 17 2019, 3:55 PM · Build System, Frameworks
apol accepted D20558: Bug fix: find c++ stl using regex.
Apr 17 2019, 3:16 PM · Build System, Frameworks
sh-zam added inline comments to D20558: Bug fix: find c++ stl using regex.
Apr 17 2019, 2:51 PM · Build System, Frameworks
apol added a comment to D20558: Bug fix: find c++ stl using regex.

Why are you using it without Android.cmake?

I am building Krita and to add create-apk target I am using include (ECMAndroidDeployQt.cmake), I can't use Android.cmake because of some variables as it expects to run as a toolchain.

Apr 17 2019, 2:36 PM · Build System, Frameworks

Apr 15 2019

sh-zam updated the diff for D20558: Bug fix: find c++ stl using regex.
  • disallow whitespaces in path
Apr 15 2019, 4:53 PM · Build System, Frameworks
sh-zam added a comment to D20558: Bug fix: find c++ stl using regex.

Why are you using it without Android.cmake?

Apr 15 2019, 12:28 AM · Build System, Frameworks
sh-zam updated the diff for D20558: Bug fix: find c++ stl using regex.
  • disallow whitespaces in path
Apr 15 2019, 12:28 AM · Build System, Frameworks
sh-zam closed D20509: Detect duplicate ANDROID_EXTRA_LIBS and minor bug fix.
Apr 15 2019, 12:13 AM · Build System, Frameworks
apol added a comment to D20558: Bug fix: find c++ stl using regex.

Can we add a cmake_minimum_required to 3.7? Regex fails to compile on older versions, when run outside of Android.cmake.

Apr 15 2019, 12:08 AM · Build System, Frameworks

Apr 14 2019

apol accepted D20509: Detect duplicate ANDROID_EXTRA_LIBS and minor bug fix.

Looks good to me, can you land it?

Apr 14 2019, 11:59 PM · Build System, Frameworks
sh-zam added a comment to D20558: Bug fix: find c++ stl using regex.

Can we add a cmake_minimum_required to 3.7? Regex fails to compile on older versions, when run outside of Android.cmake.

Apr 14 2019, 10:29 PM · Build System, Frameworks
sh-zam updated the diff for D20509: Detect duplicate ANDROID_EXTRA_LIBS and minor bug fix.

improved name and code flow

Apr 14 2019, 8:59 PM · Build System, Frameworks
sh-zam requested review of D20558: Bug fix: find c++ stl using regex.
Apr 14 2019, 8:55 PM · Build System, Frameworks
apol requested changes to D20509: Detect duplicate ANDROID_EXTRA_LIBS and minor bug fix.
Apr 14 2019, 5:47 PM · Build System, Frameworks

Apr 13 2019

lbeltrame added reviewers for D20509: Detect duplicate ANDROID_EXTRA_LIBS and minor bug fix: apol, vkrause.
Apr 13 2019, 10:47 PM · Build System, Frameworks
sh-zam updated the diff for D20509: Detect duplicate ANDROID_EXTRA_LIBS and minor bug fix.

minor typo fixed

Apr 13 2019, 5:01 PM · Build System, Frameworks
sh-zam requested review of D20509: Detect duplicate ANDROID_EXTRA_LIBS and minor bug fix.
Apr 13 2019, 3:02 PM · Build System, Frameworks

Apr 7 2019

dfaure closed D20349: Unconditionally enable -DQT_STRICT_ITERATORS, not just in debug mode.
Apr 7 2019, 5:00 PM · Build System, Frameworks
aacid accepted D20349: Unconditionally enable -DQT_STRICT_ITERATORS, not just in debug mode.
Apr 7 2019, 4:56 PM · Build System, Frameworks
dfaure added a comment to D20349: Unconditionally enable -DQT_STRICT_ITERATORS, not just in debug mode.

All the modules that use this cmake file, already build fine in debug mode with strict iterators.
This enables the same setting in release mode, for code that already builds fine in debug mode. So unless people have bad code in #ifndef NDEBUG, I don't expect this to break anything at all.

Apr 7 2019, 4:23 PM · Build System, Frameworks
aacid added a comment to D20349: Unconditionally enable -DQT_STRICT_ITERATORS, not just in debug mode.

Are we sure we don't break code by introducing this? Or we're just going to play Whac-A-Mole with compile errors until all it's compiling again?

Apr 7 2019, 4:04 PM · Build System, Frameworks
dfaure requested review of D20349: Unconditionally enable -DQT_STRICT_ITERATORS, not just in debug mode.
Apr 7 2019, 1:23 PM · Build System, Frameworks

Apr 2 2019

bencreasy added a watcher for Build System: bencreasy.
Apr 2 2019, 1:07 AM

Mar 29 2019

apol closed D20105: ecm_add_wayland_client_protocol: Improve error messages.
Mar 29 2019, 1:10 PM · Build System, Frameworks
zzag added a comment to D20105: ecm_add_wayland_client_protocol: Improve error messages.

Hmm it looks like we're using ancient code option.

Mar 29 2019, 9:14 AM · Build System, Frameworks
zzag accepted D20105: ecm_add_wayland_client_protocol: Improve error messages.
Mar 29 2019, 9:06 AM · Build System, Frameworks
cmollekopf added a comment to D20059: Take clang-cl into account..

FWIW, I have meanwhile used this patch to build all kube dependencies on linux and osx as well, and it seems like it doesn't break anything.

Mar 29 2019, 7:23 AM · Build System, Frameworks
apol updated the diff for D20105: ecm_add_wayland_client_protocol: Improve error messages.

for generating server files too

Mar 29 2019, 3:20 AM · Build System, Frameworks
apol requested review of D20105: ecm_add_wayland_client_protocol: Improve error messages.
Mar 29 2019, 3:16 AM · Build System, Frameworks

Mar 26 2019

apol added a comment to D20059: Take clang-cl into account..

LGTM, looks like clang-cl will be missing a few arguments though.

Mar 26 2019, 2:31 PM · Build System, Frameworks
apol added a reviewer for D20059: Take clang-cl into account.: Windows.
Mar 26 2019, 2:29 PM · Build System, Frameworks
cmollekopf added a comment to D20059: Take clang-cl into account..

There was already an earlier (abandoned) attempt at this: https://git.reviewboard.kde.org/r/128779

Mar 26 2019, 9:11 AM · Build System, Frameworks
cmollekopf requested review of D20059: Take clang-cl into account..
Mar 26 2019, 9:09 AM · Build System, Frameworks

Mar 24 2019

knauss added a task to D19996: WIP Add a global test for insecure http: URLs used in code or documentation: T10716: Add check for accidental http: usage.
Mar 24 2019, 8:24 PM · Build System, Frameworks
knauss updated the diff for D19996: WIP Add a global test for insecure http: URLs used in code or documentation.

fixing a typo.

Mar 24 2019, 3:11 PM · Build System, Frameworks
knauss updated the diff for D19996: WIP Add a global test for insecure http: URLs used in code or documentation.

make parallel network requests.

Mar 24 2019, 2:29 PM · Build System, Frameworks
knauss updated the diff for D19996: WIP Add a global test for insecure http: URLs used in code or documentation.

complete diff.

Mar 24 2019, 12:31 PM · Build System, Frameworks
knauss updated the diff for D19996: WIP Add a global test for insecure http: URLs used in code or documentation.

now with glob matching and another round of renaming blacklist files.

Mar 24 2019, 12:19 PM · Build System, Frameworks

Mar 23 2019

knauss updated the diff for D19996: WIP Add a global test for insecure http: URLs used in code or documentation.

remove BLACKLSIT for httpcheck

Mar 23 2019, 10:17 PM · Build System, Frameworks
knauss updated the diff for D19996: WIP Add a global test for insecure http: URLs used in code or documentation.

add httpupdate and split out blacklist file

Mar 23 2019, 10:14 PM · Build System, Frameworks
knauss added a comment to D19996: WIP Add a global test for insecure http: URLs used in code or documentation.

this would be a nice addition to Krazy. on my todo list.

Mar 23 2019, 9:43 PM · Build System, Frameworks
winterz added a comment to D19996: WIP Add a global test for insecure http: URLs used in code or documentation.

this would be a nice addition to Krazy. on my todo list.

Mar 23 2019, 3:57 PM · Build System, Frameworks
vkrause added inline comments to D19996: WIP Add a global test for insecure http: URLs used in code or documentation.
Mar 23 2019, 3:32 PM · Build System, Frameworks
knauss updated the diff for D19996: WIP Add a global test for insecure http: URLs used in code or documentation.

search for http://\S

Mar 23 2019, 2:07 PM · Build System, Frameworks
cgiboudeaux added inline comments to D19996: WIP Add a global test for insecure http: URLs used in code or documentation.
Mar 23 2019, 2:04 PM · Build System, Frameworks
vkrause added inline comments to D19996: WIP Add a global test for insecure http: URLs used in code or documentation.
Mar 23 2019, 1:58 PM · Build System, Frameworks
knauss updated the diff for D19996: WIP Add a global test for insecure http: URLs used in code or documentation.

add more excludes.

Mar 23 2019, 1:58 PM · Build System, Frameworks
knauss updated the diff for D19996: WIP Add a global test for insecure http: URLs used in code or documentation.

update http regex

Mar 23 2019, 1:51 PM · Build System, Frameworks
knauss updated the diff for D19996: WIP Add a global test for insecure http: URLs used in code or documentation.

update python script.

Mar 23 2019, 1:48 PM · Build System, Frameworks
cgiboudeaux added inline comments to D19996: WIP Add a global test for insecure http: URLs used in code or documentation.
Mar 23 2019, 1:46 PM · Build System, Frameworks
vkrause requested review of D19996: WIP Add a global test for insecure http: URLs used in code or documentation.
Mar 23 2019, 1:33 PM · Build System, Frameworks

Mar 5 2019

dfaure closed D19538: ECMGeneratePkgConfigFile: make all vars dependent on ${prefix}.
Mar 5 2019, 2:40 PM · Build System, Frameworks
apol accepted D19538: ECMGeneratePkgConfigFile: make all vars dependent on ${prefix}.
Mar 5 2019, 1:26 PM · Build System, Frameworks
dfaure added a comment to D19506: ECMGeneratePkgConfigFile: add variables used by pkg_check_modules.

Makes sense --> https://phabricator.kde.org/D19538

Mar 5 2019, 10:58 AM · Build System, Frameworks
dfaure requested review of D19538: ECMGeneratePkgConfigFile: make all vars dependent on ${prefix}.
Mar 5 2019, 10:49 AM · Build System, Frameworks

Mar 4 2019

vkrause closed D19486: Add UDev find module.
Mar 4 2019, 8:05 PM · Build System, Frameworks
kossebau added a comment to D19506: ECMGeneratePkgConfigFile: add variables used by pkg_check_modules.

FWIW, this still results in inproper pc files, from what I heard recently. The prefix variable can be overriden from outside when calling pkg-config (cmp. pkg-config --help) to allow for relocatable installations. Same like CMake Config files also allow relocation by having the install prefix not hardcoded into directory var values.

Mar 4 2019, 6:51 PM · Build System, Frameworks
dfaure closed D19506: ECMGeneratePkgConfigFile: add variables used by pkg_check_modules.
Mar 4 2019, 12:35 PM · Build System, Frameworks
cgiboudeaux accepted D19506: ECMGeneratePkgConfigFile: add variables used by pkg_check_modules.

Thanks.

Mar 4 2019, 12:23 PM · Build System, Frameworks
dfaure updated the diff for D19506: ECMGeneratePkgConfigFile: add variables used by pkg_check_modules.

Update unittests, passes now

Mar 4 2019, 11:52 AM · Build System, Frameworks
cgiboudeaux added a comment to D19506: ECMGeneratePkgConfigFile: add variables used by pkg_check_modules.

The autotest has to be fixed as well

Mar 4 2019, 11:35 AM · Build System, Frameworks
cgiboudeaux requested changes to D19506: ECMGeneratePkgConfigFile: add variables used by pkg_check_modules.
Mar 4 2019, 11:27 AM · Build System, Frameworks
cgiboudeaux added a comment to D19506: ECMGeneratePkgConfigFile: add variables used by pkg_check_modules.

The autotest has to be fixed as well

Mar 4 2019, 11:27 AM · Build System, Frameworks
fazevedo accepted D19506: ECMGeneratePkgConfigFile: add variables used by pkg_check_modules.

Works for me !

Mar 4 2019, 11:20 AM · Build System, Frameworks
dfaure requested review of D19506: ECMGeneratePkgConfigFile: add variables used by pkg_check_modules.
Mar 4 2019, 10:26 AM · Build System, Frameworks
vkrause added a comment to D18943: Add Fontconfig find modudle.

What I don't understand though is which FindFontconfig this used to find, there is non in plasma-desktop...

kdelibs4support provides one.

Mar 4 2019, 8:49 AM · Build System, Frameworks
vkrause closed D19499: Restore FindFontconfig backward compatibility for plasma-desktop.
Mar 4 2019, 7:37 AM · Build System, Frameworks

Mar 3 2019

cgiboudeaux accepted D19499: Restore FindFontconfig backward compatibility for plasma-desktop.
Mar 3 2019, 9:31 PM · Build System, Frameworks
kossebau added a comment to D18943: Add Fontconfig find modudle.

What I don't understand though is which FindFontconfig this used to find, there is non in plasma-desktop...

Mar 3 2019, 9:24 PM · Build System, Frameworks
vkrause added a comment to D18943: Add Fontconfig find modudle.

D19499 fixes that here

Mar 3 2019, 9:17 PM · Build System, Frameworks
vkrause requested review of D19499: Restore FindFontconfig backward compatibility for plasma-desktop.
Mar 3 2019, 9:17 PM · Build System, Frameworks
vkrause added a comment to D18943: Add Fontconfig find modudle.

This commit breaks plasma-desktop compilation for me (on ubuntu && arch => undefined refrence in plasma-desktop/kcms/kfontinst).

Mar 3 2019, 9:10 PM · Build System, Frameworks
matthieugras added a comment to D18943: Add Fontconfig find modudle.

This commit breaks plasma-desktop compilation for me (on ubuntu && arch => undefined refrence in plasma-desktop/kcms/kfontinst).

Mar 3 2019, 6:55 PM · Build System, Frameworks
cgiboudeaux accepted D19486: Add UDev find module.
Mar 3 2019, 10:53 AM · Build System, Frameworks
vkrause updated the diff for D19486: Add UDev find module.

Add backward compatibility variables.

Mar 3 2019, 10:38 AM · Build System, Frameworks
cgiboudeaux added a comment to D19486: Add UDev find module.

We probably need to set uppercase variables for the moment. plasma-desktop and powerdevil include the ECM modules dir before their local copy, so any older release would fail to build with ECM >= 5.57

Mar 3 2019, 10:27 AM · Build System, Frameworks
cgiboudeaux added a comment to D19486: Add UDev find module.

We probably need to set uppercase variables for the moment. plasma-desktop and powerdevil include the ECM modules dir before their local copy, so any older release would fail to build with ECM >= 5.57

Mar 3 2019, 10:18 AM · Build System, Frameworks
vkrause closed D18943: Add Fontconfig find modudle.
Mar 3 2019, 9:47 AM · Build System, Frameworks
vkrause requested review of D19486: Add UDev find module.
Mar 3 2019, 9:26 AM · Build System, Frameworks
dfaure requested changes to D15795: Fix warnings about deprecated install dirs.

The warning needs to be removed then. We can't really warn at the time of using a variable.

Mar 3 2019, 12:20 AM · Build System, Frameworks

Mar 2 2019

cgiboudeaux accepted D18943: Add Fontconfig find modudle.

LGTM

Mar 2 2019, 11:57 AM · Build System, Frameworks
vkrause added a comment to D18943: Add Fontconfig find modudle.

ping?

Mar 2 2019, 10:07 AM · Build System, Frameworks

Feb 26 2019

jjazeix added a comment to D19016: Update Android toolchain files to reality.
In D19016#420246, @apol wrote:

Applications can still override it, note it's a default.
Also note this: https://developer.android.com/distribute/best-practices/develop/target-sdk

Feb 26 2019, 3:57 PM · Build System, Frameworks
apol added a comment to D19016: Update Android toolchain files to reality.

Applications can still override it, note it's a default.
Also note this: https://developer.android.com/distribute/best-practices/develop/target-sdk

Feb 26 2019, 2:54 PM · Build System, Frameworks

Feb 25 2019

jjazeix added inline comments to D19016: Update Android toolchain files to reality.
Feb 25 2019, 9:29 PM · Build System, Frameworks

Feb 22 2019

dfaure added a comment to D19075: Fix FindEGL.

If anyone hits a cmake error about "/usr/include/EGL/EGL/egl.h" after updating ECM (e.g. in kwayland or plasma-framework), remove the cache in the builddir and rerun cmake. This commit is actually correct, it's just incompatible with existing caches.

Feb 22 2019, 3:20 PM · Build System, Frameworks
vkrause closed D19223: Fix releaseme checkout when this is included in a sub-directory.
Feb 22 2019, 1:47 PM · Build System, Frameworks
apol accepted D19223: Fix releaseme checkout when this is included in a sub-directory.
Feb 22 2019, 1:31 PM · Build System, Frameworks