sh-zam (Sharaf Zaman)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
Feb 25 2019, 12:12 AM (268 w, 4 d)
Availability
Available

Recent Activity

Mar 9 2023

sh-zam added a comment to T15245: Performance improvements plans for Resource Rewrite.

IIRC, it was KisResourceCacheDb::metaDataForId where lot of time was spent in prepare().

Mar 9 2023, 10:26 AM · Krita
sh-zam added a comment to T15245: Performance improvements plans for Resource Rewrite.

sure, I'll look into it then :)

Mar 9 2023, 10:01 AM · Krita
sh-zam added a comment to T15245: Performance improvements plans for Resource Rewrite.

A thing I found out when I was profiling the code for https://invent.kde.org/graphics/krita/-/merge_requests/1731, is the QSqlQuery::prepare being a bottleneck. I looked into a docs a bit and found out that prepared queries are "compiled" by sqlite into whatever its internal bytecode can understand, so this is something which doesn't need to happen over and over again, but something we can cache and only bind values whenever needed (I think Qt's QSqlQuery::exec takes care of resetting the bindings and re-executing the same prepared query).

Mar 9 2023, 9:57 AM · Krita

Oct 11 2022

sh-zam created T15892: Krita Featured Page architecture.
Oct 11 2022, 1:57 PM · Krita

Apr 14 2022

sh-zam updated the task description for T14359: Instructions for Uploading Krita to App Stores.
Apr 14 2022, 12:52 PM · Krita

Oct 28 2021

sh-zam added a watcher for Krita: sh-zam.
Oct 28 2021, 5:59 PM

Mar 23 2021

sh-zam added a comment to T13339: QML version of Krita.

Concerning the opengl depth test stuff, there's some mention of it in the qt6 docs: https://doc.qt.io/qt-6/qquickgraphicsconfiguration.html
That class doesn't exist in 5, the only mention I can find is that the depth buffers got to be reset: https://doc.qt.io/qt-5/qquickwindow.html#resetOpenGLState

I guess that means I could get rid of the blending mode stuff? I'll test on thursday.

Mar 23 2021, 5:10 PM · Krita
sh-zam added a comment to T13339: QML version of Krita.

I've ported the canvas (as suggested a week back in IRC) to use Kirigami's ApplicationWindow as a starter: https://invent.kde.org/szaman/krita/-/commits/krita-qml

Mar 23 2021, 1:19 PM · Krita

Mar 8 2021

sh-zam added a comment to T14170: Porting Krita's OpenGL canvas to Qt6.

So... if we would want to port, then the filters, settings, new image dialog, impex-dialogs and other things we keep in separate windows can be done first, but dockers will all need to be ported in one go?

Alright, then the next question. Halla is thinking about using KDDockWidget. If we'd use that here, will that lead to the same issue?

Mar 8 2021, 7:14 PM · Krita
sh-zam added a comment to T14170: Porting Krita's OpenGL canvas to Qt6.

This is also starting to sound like we should just get someone to just sit down and write a test program within a week (just basically a window with the aforementioned combos of qtquickwidgets, regular widget, opengl or qrhi widgets, etc) and just see what that uses on the different platforms? I think it might prove time saving?

There is an app above which uses QQuickWidget, QWindow (in a window container) and a normal QWidget. It worked fine on Linux. I can test it on Windows, MacOS may be for @rempt / amyspark.

Mar 8 2021, 6:25 PM · Krita

Mar 7 2021

sh-zam added a comment to T14170: Porting Krita's OpenGL canvas to Qt6.

This is also starting to sound like we should just get someone to just sit down and write a test program within a week (just basically a window with the aforementioned combos of qtquickwidgets, regular widget, opengl or qrhi widgets, etc) and just see what that uses on the different platforms? I think it might prove time saving?

Mar 7 2021, 5:24 PM · Krita
sh-zam added a comment to T14170: Porting Krita's OpenGL canvas to Qt6.

Window Container based approach

There will be one more problem of this approach. The outer window will still be rendered by Qt and will use opengl.dll.

Mar 7 2021, 5:02 PM · Krita

Mar 1 2021

sh-zam created T14170: Porting Krita's OpenGL canvas to Qt6.
Mar 1 2021, 8:05 PM · Krita

Oct 12 2020

sh-zam added a comment to T13751: Upload Krita 4.4.0 Final release.

I've built the x86 APK from release tarball: https://drive.google.com/file/d/1-DZipSmIdJSIfRvYVKAwMtK4ame8h4P9/view?usp=sharing

Oct 12 2020, 3:31 PM · Krita

Jun 28 2020

sh-zam committed R37:489fe5295bf5: Merge branch 'sh-zam/T13101-svg-mesh-gradients' into 'krita/4.3' (authored by sh-zam).
Merge branch 'sh-zam/T13101-svg-mesh-gradients' into 'krita/4.3'
Jun 28 2020, 11:45 PM

Jun 20 2020

sh-zam committed R37:8fa86a5df561: Merge branch 'sh-zam/T13101-svg-mesh-gradients' into 'krita/4.3' (authored by sh-zam).
Merge branch 'sh-zam/T13101-svg-mesh-gradients' into 'krita/4.3'
Jun 20 2020, 2:29 PM
sh-zam committed R37:5cde82f619ec: Merge branch 'sh-zam/T13101-svg-mesh-gradients' into 'krita/4.3' (authored by sh-zam).
Merge branch 'sh-zam/T13101-svg-mesh-gradients' into 'krita/4.3'
Jun 20 2020, 10:06 AM

Jun 19 2020

sh-zam committed R37:10d9f102fb53: Merge branch 'sh-zam/T13101-svg-mesh-gradients' into 'krita/4.3' (authored by sh-zam).
Merge branch 'sh-zam/T13101-svg-mesh-gradients' into 'krita/4.3'
Jun 19 2020, 4:20 PM
sh-zam committed R37:5d5e32d0df42: Merge branch 'sh-zam/T13101-svg-mesh-gradients' into 'krita/4.3' (authored by sh-zam).
Merge branch 'sh-zam/T13101-svg-mesh-gradients' into 'krita/4.3'
Jun 19 2020, 2:07 PM
sh-zam committed R37:a60008e42518: Send SvgMeshGradient from SvgParser to KoMeshGradientBackground (authored by sh-zam).
Send SvgMeshGradient from SvgParser to KoMeshGradientBackground
Jun 19 2020, 2:06 PM
sh-zam committed R37:542d7fbb08c0: Handle href, transform, gradientUnit attributes for meshgradients (authored by sh-zam).
Handle href, transform, gradientUnit attributes for meshgradients
Jun 19 2020, 2:06 PM
sh-zam committed R37:c72e842045fb: Add copy constructors to SvgMeshArray and SvgMeshGradient (authored by sh-zam).
Add copy constructors to SvgMeshArray and SvgMeshGradient
Jun 19 2020, 2:06 PM
sh-zam committed R37:e39c9a8a9cf7: Merge branch 'sh-zam/T13101-svg-mesh-gradients' into 'krita/4.3' (authored by sh-zam).
Merge branch 'sh-zam/T13101-svg-mesh-gradients' into 'krita/4.3'
Jun 19 2020, 1:40 PM
sh-zam committed R37:960cf803ca16: Merge branch 'sh-zam/T13101-svg-mesh-gradients' into 'krita/4.3' (authored by sh-zam).
Merge branch 'sh-zam/T13101-svg-mesh-gradients' into 'krita/4.3'
Jun 19 2020, 2:14 AM

Jun 18 2020

sh-zam committed R37:451edea1a7a3: Merge branch 'sh-zam/T13101-svg-mesh-gradients' into 'krita/4.3' (authored by sh-zam).
Merge branch 'sh-zam/T13101-svg-mesh-gradients' into 'krita/4.3'
Jun 18 2020, 10:57 AM
sh-zam committed R37:7c8c06bd5651: Merge branch 'sh-zam/T13101-svg-mesh-gradients' into 'krita/4.3' (authored by sh-zam).
Merge branch 'sh-zam/T13101-svg-mesh-gradients' into 'krita/4.3'
Jun 18 2020, 8:28 AM

Jun 17 2020

sh-zam committed R37:5fd85d10b96d: Merge branch 'sh-zam/T13101-svg-mesh-gradients' into 'krita/4.3' (authored by sh-zam).
Merge branch 'sh-zam/T13101-svg-mesh-gradients' into 'krita/4.3'
Jun 17 2020, 7:02 PM
sh-zam committed R37:cf3399d30032: Merge branch 'sh-zam/T13101-svg-mesh-gradients' into 'krita/4.3' (authored by sh-zam).
Merge branch 'sh-zam/T13101-svg-mesh-gradients' into 'krita/4.3'
Jun 17 2020, 7:13 AM
sh-zam committed R37:916858c36edc: Merge branch 'sh-zam/T13101-svg-mesh-gradients' into 'krita/4.3' (authored by sh-zam).
Merge branch 'sh-zam/T13101-svg-mesh-gradients' into 'krita/4.3'
Jun 17 2020, 4:40 AM

Jun 16 2020

sh-zam committed R37:3b2a231a17ae: Merge branch 'sh-zam/T13101-svg-mesh-gradients' into 'krita/4.3' (authored by sh-zam).
Merge branch 'sh-zam/T13101-svg-mesh-gradients' into 'krita/4.3'
Jun 16 2020, 1:34 PM
sh-zam committed R37:1a95d5c032f0: Merge branch 'sh-zam/T13101-svg-mesh-gradients' into 'krita/4.3' (authored by sh-zam).
Merge branch 'sh-zam/T13101-svg-mesh-gradients' into 'krita/4.3'
Jun 16 2020, 10:45 AM

Jun 15 2020

sh-zam committed R37:43a608cd9044: Merge branch 'sh-zam/T10784-android-port' into 'master' (authored by sh-zam).
Merge branch 'sh-zam/T10784-android-port' into 'master'
Jun 15 2020, 8:49 PM
sh-zam committed R37:1b7a05f0e8a6: Merge branch 'sh-zam/back_button_android' into 'master' (authored by sh-zam).
Merge branch 'sh-zam/back_button_android' into 'master'
Jun 15 2020, 8:48 PM
sh-zam committed R37:5abd71b33b73: Merge branch 'fdroid-changes' into 'master' (authored by sh-zam).
Merge branch 'fdroid-changes' into 'master'
Jun 15 2020, 8:45 PM
sh-zam committed R37:abb60e0617d3: Merge branch 'sh-zam/android-improvements' into 'master' (authored by sh-zam).
Merge branch 'sh-zam/android-improvements' into 'master'
Jun 15 2020, 8:45 PM
sh-zam committed R37:48dd60682d24: Merge branch 'master' of invent.kde.org:kde/krita into sh-zam/qt-patches (authored by sh-zam).
Merge branch 'master' of invent.kde.org:kde/krita into sh-zam/qt-patches
Jun 15 2020, 8:45 PM
sh-zam committed R37:ece9ce0b39a1: Remove redundant patches (authored by sh-zam).
Remove redundant patches
Jun 15 2020, 8:45 PM
sh-zam committed R37:e64de8348790: Android: Fix the offset bug when clicking items on modal dialog (authored by sh-zam).
Android: Fix the offset bug when clicking items on modal dialog
Jun 15 2020, 8:45 PM
sh-zam committed R37:44d13828c962: Android: Remove redundant Qt patch (authored by sh-zam).
Android: Remove redundant Qt patch
Jun 15 2020, 8:45 PM
sh-zam committed R37:3502a8d3a2e0: Android: Fix the offset bug when clicking items on modal dialog (authored by sh-zam).
Android: Fix the offset bug when clicking items on modal dialog
Jun 15 2020, 8:44 PM
sh-zam committed R37:3a68fc429e16: Remove redundant patches (authored by sh-zam).
Remove redundant patches
Jun 15 2020, 8:44 PM
sh-zam committed R37:4707a23f20e9: Android: Remove redundant Qt patch (authored by sh-zam).
Android: Remove redundant Qt patch
Jun 15 2020, 8:44 PM
sh-zam committed R37:0634ea89c29e: Merge branch 'sh-zam/qt-patches' into 'master' (authored by sh-zam).
Merge branch 'sh-zam/qt-patches' into 'master'
Jun 15 2020, 8:44 PM
sh-zam committed R37:a608535ed372: Android: Add renderer in combobox (authored by sh-zam).
Android: Add renderer in combobox
Jun 15 2020, 8:44 PM
sh-zam committed R37:8e24e4db59c2: Merge branch 'sh-zam/android-renderer-combobox' into 'master' (authored by sh-zam).
Merge branch 'sh-zam/android-renderer-combobox' into 'master'
Jun 15 2020, 8:44 PM
sh-zam committed R37:9a6e5613a734: Android: Backport a Qt patch to fix empty locales list bug (authored by sh-zam).
Android: Backport a Qt patch to fix empty locales list bug
Jun 15 2020, 8:43 PM
sh-zam committed R37:6c713d0c9a9d: Merge branch 'qt-patch' into 'master' (authored by sh-zam).
Merge branch 'qt-patch' into 'master'
Jun 15 2020, 8:43 PM
sh-zam committed R37:e6105c187497: Merge branch 'binary-factory-fix' into 'master' (authored by sh-zam).
Merge branch 'binary-factory-fix' into 'master'
Jun 15 2020, 8:42 PM
sh-zam committed R37:1481598e5c65: Add donation banner for Android (authored by sh-zam).
Add donation banner for Android
Jun 15 2020, 8:40 PM
sh-zam committed R37:b131db1ae347: Android: Remove a duplicate asset. (authored by sh-zam).
Android: Remove a duplicate asset.
Jun 15 2020, 8:40 PM
sh-zam committed R37:f1e55db26eb3: Add donation banner for Android (authored by sh-zam).
Add donation banner for Android
Jun 15 2020, 8:40 PM
sh-zam committed R37:e16d22f83e6a: Integrate Samsung's Air Actions (authored by amedonosova).
Integrate Samsung's Air Actions
Jun 15 2020, 8:38 PM
sh-zam committed R37:8f19a3c0bb34: Add donation banner for Android (authored by sh-zam).
Add donation banner for Android
Jun 15 2020, 8:38 PM
sh-zam committed R37:b4e29b495bed: Android: Remove a duplicate asset. (authored by sh-zam).
Android: Remove a duplicate asset.
Jun 15 2020, 8:38 PM
sh-zam committed R37:fe6379f11ebd: Android: remove libKF5Archive.so from CMakeLists.txt (authored by sh-zam).
Android: remove libKF5Archive.so from CMakeLists.txt
Jun 15 2020, 8:38 PM
sh-zam committed R37:01bc6ea193e7: Add missing openjpg to 3rdparty (authored by sh-zam).
Add missing openjpg to 3rdparty
Jun 15 2020, 8:38 PM
sh-zam committed R37:017d56c17e7d: Update kdesrc-buildrc to fix build (authored by sh-zam).
Update kdesrc-buildrc to fix build
Jun 15 2020, 8:38 PM
sh-zam committed R37:27fbb477ef76: Android: Add debug flag to kf5-frameworks build (authored by sh-zam).
Android: Add debug flag to kf5-frameworks build
Jun 15 2020, 8:38 PM
sh-zam committed R37:e3419761cf3f: Android: Remove redundant Qt patch (authored by sh-zam).
Android: Remove redundant Qt patch
Jun 15 2020, 8:38 PM
sh-zam committed R37:fbb1974c7702: Add placeholder build.gradle to complete the fdroid build (authored by sh-zam).
Add placeholder build.gradle to complete the fdroid build
Jun 15 2020, 8:38 PM
sh-zam committed R37:4109d5f66444: Update apk version in Manifest (authored by sh-zam).
Update apk version in Manifest
Jun 15 2020, 8:38 PM
sh-zam committed R37:5f80cec33802: Make fullscreenToggle available only for Android devices (authored by sh-zam).
Make fullscreenToggle available only for Android devices
Jun 15 2020, 8:38 PM
sh-zam committed R37:8e136e63b070: Add zoom button for quick access (authored by sh-zam).
Add zoom button for quick access
Jun 15 2020, 8:38 PM
sh-zam committed R37:8fa735d7737e: Bugfix: S-pen not drawing (authored by sh-zam).
Bugfix: S-pen not drawing
Jun 15 2020, 8:38 PM
sh-zam committed R37:65f1e2aa946f: Bugfix: When S-pen was not pointing canvas, it became unusable. (authored by sh-zam).
Bugfix: When S-pen was not pointing canvas, it became unusable.
Jun 15 2020, 8:38 PM
sh-zam committed R37:1ebd0f667149: Bugfix: S-pen not drawing (authored by sh-zam).
Bugfix: S-pen not drawing
Jun 15 2020, 8:38 PM
sh-zam committed R37:8fd6e2cd3946: Use back button (Android) to come out of full screen mode (authored by sh-zam).
Use back button (Android) to come out of full screen mode
Jun 15 2020, 8:38 PM
sh-zam committed R37:a0acb79f2a11: Add destructor to `KisAndroidFileManager` (authored by sh-zam).
Add destructor to `KisAndroidFileManager`
Jun 15 2020, 8:38 PM
sh-zam committed R37:3856c74cf348: Pass KisMainWindow* to KisAndroidFileManager's ctor (authored by sh-zam).
Pass KisMainWindow* to KisAndroidFileManager's ctor
Jun 15 2020, 8:38 PM
sh-zam committed R37:bb12cd997cf7: Use GLOBAL_PROFILE variable for common CMake variables in Android Build (authored by sh-zam).
Use GLOBAL_PROFILE variable for common CMake variables in Android Build
Jun 15 2020, 8:38 PM
sh-zam committed R37:28489ff5ce0e: Android: Hide news widget from the welcome screen (authored by sh-zam).
Android: Hide news widget from the welcome screen
Jun 15 2020, 8:38 PM
sh-zam committed R37:b43074081fd1: Remove redundant macro `QT_OPENGL_ES_3` (authored by sh-zam).
Remove redundant macro `QT_OPENGL_ES_3`
Jun 15 2020, 8:38 PM
sh-zam committed R37:e1d2e22d8b7b: Refactored autoSaveOnPause() (authored by sh-zam).
Refactored autoSaveOnPause()
Jun 15 2020, 8:38 PM
sh-zam committed R37:d6a57baaa962: Minor modifications to resetAngleButton on status bar (authored by sh-zam).
Minor modifications to resetAngleButton on status bar
Jun 15 2020, 8:38 PM
sh-zam committed R37:eb379efa7283: Add apidoc to a method (authored by sh-zam).
Add apidoc to a method
Jun 15 2020, 8:38 PM
sh-zam committed R37:70bf8b8b7511: Fix typo (authored by sh-zam).
Fix typo
Jun 15 2020, 8:38 PM
sh-zam committed R37:3ba449cb1bae: Set screen attribute to large and xLarge (authored by sh-zam).
Set screen attribute to large and xLarge
Jun 15 2020, 8:38 PM
sh-zam committed R37:3fc3c37ff832: Remove redundant include in cmake (authored by sh-zam).
Remove redundant include in cmake
Jun 15 2020, 8:38 PM
sh-zam committed R37:f9632de164b2: Change package to `org.krita` in manifest (authored by sh-zam).
Change package to `org.krita` in manifest
Jun 15 2020, 8:38 PM
sh-zam committed R37:75ec4fc228ae: Fix brush outline getting stuck (authored by sh-zam).
Fix brush outline getting stuck
Jun 15 2020, 8:38 PM
sh-zam committed R37:d91c617ec6a0: Add reset to rotation (authored by sh-zam).
Add reset to rotation
Jun 15 2020, 8:38 PM
sh-zam committed R37:a40f8a577ded: remove TODO (authored by sh-zam).
remove TODO
Jun 15 2020, 8:38 PM
sh-zam committed R37:065679e2a1f6: Add release arg, so we get an unsigned release APK (authored by sh-zam).
Add release arg, so we get an unsigned release APK
Jun 15 2020, 8:38 PM
sh-zam committed R37:035fb1d004c6: Add `kf5` target to `androidbuild.sh` (authored by sh-zam).
Add `kf5` target to `androidbuild.sh`
Jun 15 2020, 8:38 PM
sh-zam committed R37:551ae33afa79: Add license to java files (authored by sh-zam).
Add license to java files
Jun 15 2020, 8:38 PM
sh-zam committed R37:9eca89ba3d13: Use Android's Storage Access Framework to pick files (authored by sh-zam).
Use Android's Storage Access Framework to pick files
Jun 15 2020, 8:38 PM
sh-zam committed R37:7500fc7cf1b9: Add dedicated debug for android (authored by sh-zam).
Add dedicated debug for android
Jun 15 2020, 8:38 PM
sh-zam committed R37:0340e011c5bf: Fix cmake argument for old cmake versions (authored by sh-zam).
Fix cmake argument for old cmake versions
Jun 15 2020, 8:38 PM
sh-zam committed R37:c52fb91d7b72: update README.android (authored by sh-zam).
update README.android
Jun 15 2020, 8:38 PM
sh-zam committed R37:3cf25e37a4de: Android: add min opengles version 3.0 (authored by sh-zam).
Android: add min opengles version 3.0
Jun 15 2020, 8:38 PM
sh-zam committed R37:2915f048edfb: Fix opengl setting reset bug (authored by sh-zam).
Fix opengl setting reset bug
Jun 15 2020, 8:38 PM
sh-zam committed R37:939da32f43c0: [Android] Remove redundant python path (authored by sh-zam).
[Android] Remove redundant python path
Jun 15 2020, 8:38 PM
sh-zam committed R37:ce9d5a40eada: Fix crash during startup (authored by sh-zam).
Fix crash during startup
Jun 15 2020, 8:38 PM
sh-zam committed R37:3613f13c72bd: Fixes `libqtforandroid.so` crash (authored by sh-zam).
Fixes `libqtforandroid.so` crash
Jun 15 2020, 8:38 PM
sh-zam committed R37:56b56930791d: Android: Capitalize `k` in krita (authored by sh-zam).
Android: Capitalize `k` in krita
Jun 15 2020, 8:38 PM
sh-zam committed R37:411251cb8011: Update README.android.md (authored by sh-zam).
Update README.android.md
Jun 15 2020, 8:38 PM
sh-zam committed R37:c8e6194195e3: Android: Add icon (authored by sh-zam).
Android: Add icon
Jun 15 2020, 8:38 PM
sh-zam committed R37:304c68fef8ab: Build refactor (authored by sh-zam).
Build refactor
Jun 15 2020, 8:38 PM
sh-zam committed R37:8c70f515e35a: Minor build fix (authored by sh-zam).
Minor build fix
Jun 15 2020, 8:38 PM
sh-zam committed R37:591b52f09825: Minor bugfix: Save opengl setting on Android (authored by sh-zam).
Minor bugfix: Save opengl setting on Android
Jun 15 2020, 8:38 PM