Feed Advanced Search

May 6 2020

cblack updated the diff for D28154: Add users KCM.

Fix item alignment

May 6 2020, 2:42 AM · Plasma

May 5 2020

cblack requested review of D29465: [applets/appmenu] Improve menu feel.
May 5 2020, 11:51 PM · Plasma
cblack added a comment to D29464: [applets/appmenu] Hide old menu before showing new menu.

FWIW, I don't notice the flickering behaviour mentioned in the comment.

May 5 2020, 11:41 PM · Plasma
cblack requested review of D29464: [applets/appmenu] Hide old menu before showing new menu.
May 5 2020, 11:40 PM · Plasma
cblack requested review of D29456: Move KCM from accountdetails to personalisation.
May 5 2020, 8:36 PM
cblack updated the diff for D28154: Add users KCM.

Address feedback

May 5 2020, 8:16 PM · Plasma
cblack updated the diff for D28154: Add users KCM.

Fix permission denied bouncing

May 5 2020, 7:42 PM · Plasma
cblack updated the diff for D28154: Add users KCM.

Add Messages.sh

May 5 2020, 7:13 PM · Plasma
cblack updated the diff for D28154: Add users KCM.

Add Messages.sh

May 5 2020, 7:12 PM · Plasma
cblack updated the diff for D28154: Add users KCM.

Use section headers instead of font weights

May 5 2020, 6:39 PM · Plasma
cblack updated the diff for D28154: Add users KCM.

Improved dirty state handling

May 5 2020, 5:57 PM · Plasma
cblack updated the diff for D28154: Add users KCM.

Address the page oddities

May 5 2020, 5:30 PM · Plasma
cblack updated the diff for D28154: Add users KCM.

Take care of that feedback

May 5 2020, 4:51 PM · Plasma

May 4 2020

cblack added inline comments to D29434: Use small font for ExpandableListItem subtitle.
May 4 2020, 10:46 PM · Frameworks
cblack accepted D29432: Use small font for BasicListItem subtitle.
May 4 2020, 10:12 PM · Kirigami
cblack committed R242:68d5995c6352: Add smallFont to Kirigami plasma style (authored by cblack).
Add smallFont to Kirigami plasma style
May 4 2020, 2:35 PM
cblack closed D29412: Add smallFont to Kirigami plasma style.
May 4 2020, 2:35 PM · Frameworks
cblack requested review of D29412: Add smallFont to Kirigami plasma style.
May 4 2020, 2:28 PM · Frameworks
cblack added inline comments to D29409: Add documentation line on KCM translations.
May 4 2020, 2:21 PM · Frameworks
cblack committed R1014:f98e5d33f46b: Fix navigation regressions (authored by cblack).
Fix navigation regressions
May 4 2020, 1:58 PM
cblack closed D28888: Fix navigation regressions.
May 4 2020, 1:58 PM · Kirigami, Plasma
cblack committed R169:d2060bf4a12a: Introduce RouterWindow control (authored by cblack).
Introduce RouterWindow control
May 4 2020, 1:58 PM
cblack closed D29106: Introduce RouterWindow control.
May 4 2020, 1:58 PM · Kirigami
cblack committed R858:5b8868783c01: Implement smallFont in Kirigami plugin (authored by cblack).
Implement smallFont in Kirigami plugin
May 4 2020, 1:50 PM
cblack closed D29307: Implement smallFont in Kirigami plugin.
May 4 2020, 1:50 PM · Plasma
cblack added a comment to D29395: Refactor MediaController.

Now the inner image has a greater top margin than bottom margin. Also, could the artist and album be allowed to become two-line strings before eliding, maybe?

May 4 2020, 2:30 AM · Plasma

May 3 2020

cblack requested review of D29395: Refactor MediaController.
May 3 2020, 11:40 PM · Plasma

May 1 2020

cblack updated the diff for D28888: Fix navigation regressions.

Use normal list delegates

May 1 2020, 10:58 PM · Kirigami, Plasma
cblack added a comment to D29332: [xwl] Update to kwaylandserver changes.

Even after the rebase, it still FTBFS for me. (More conventional log, but without colours)

May 1 2020, 2:53 PM · KWin
cblack added a comment to D29332: [xwl] Update to kwaylandserver changes.

I may be missing something, but this patch fails to build for me.

May 1 2020, 2:22 PM · KWin
cblack added a comment to D28627: Adaptive panel opacity.

@davidedmundson can you take another look at the general direction of the code here? I'd like to know your thoughts on the direction this code is using before I start spending time sanding off the rough parts

May 1 2020, 12:55 PM · Plasma
cblack added a comment to D29307: Implement smallFont in Kirigami plugin.

How does this relate to D14562

May 1 2020, 12:48 PM · Plasma
cblack committed R120:0dcc58a10628: [applets/mediacontroller] Elide text (authored by cblack).
[applets/mediacontroller] Elide text
May 1 2020, 12:47 PM
cblack closed D29301: [applets/mediacontroller] Elide text.
May 1 2020, 12:47 PM · Plasma
cblack updated the diff for D29307: Implement smallFont in Kirigami plugin.

Add explanatory comment

May 1 2020, 2:23 AM · Plasma

Apr 30 2020

cblack requested review of D29307: Implement smallFont in Kirigami plugin.
Apr 30 2020, 5:15 PM · Plasma
cblack added inline comments to D29294: Add support for layers to PagePoolAction..
Apr 30 2020, 5:02 PM · Kirigami
cblack committed R169:9368dcc28f66: Introduce Theme::smallFont (authored by cblack).
Introduce Theme::smallFont
Apr 30 2020, 4:37 PM
cblack closed D29304: Introduce Theme::smallFont.
Apr 30 2020, 4:37 PM · Kirigami
cblack updated the diff for D29304: Introduce Theme::smallFont.

Drop Rust-ism

Apr 30 2020, 4:35 PM · Kirigami
cblack requested review of D29304: Introduce Theme::smallFont.
Apr 30 2020, 4:27 PM · Kirigami
cblack updated the diff for D29301: [applets/mediacontroller] Elide text.

Elide text

Apr 30 2020, 3:55 PM · Plasma
cblack requested review of D29301: [applets/mediacontroller] Elide text.
Apr 30 2020, 3:02 PM · Plasma
cblack added inline comments to D29074: Make BasicListItem more useful by giving it a subtitle property.
Apr 30 2020, 2:54 PM · Kirigami

Apr 29 2020

apol awarded T13060: Colour Picking on Wayland a Dat Boi token.
Apr 29 2020, 11:46 PM · Plasma on Wayland
cblack renamed T13060: Colour Picking on Wayland from Colour picking on Wayland to Colour Picking on Wayland.
Apr 29 2020, 11:39 PM · Plasma on Wayland
cblack added a comment to T13060: Colour Picking on Wayland.
In T13060#228606, @apol wrote:

Sure, but this is not what this ticket is about.

Apr 29 2020, 11:35 PM · Plasma on Wayland
cblack added a comment to T13060: Colour Picking on Wayland.
In T13060#228603, @apol wrote:

There's the org.kde.plasma.colorpicker that does this.

It's using dbus:

- snip -

Maybe it would be easier if you explained what you're trying to achieve?

Apr 29 2020, 11:29 PM · Plasma on Wayland
cblack added a comment to T10873: Make QML tooltips consistent.

I think the simple solution would be to just add something to the units in Kirigami and Plasma, and have coding convention to use those units.

Apr 29 2020, 9:46 PM · Plasma
cblack added inline comments to D29292: Port KKeySequenceItem to QQC2.
Apr 29 2020, 8:58 PM · Frameworks
cblack requested review of D29288: Improve PageRouter API.
Apr 29 2020, 8:20 PM · Kirigami
cblack added a comment to D29290: IGNORE THIS - TESTING A PHAB THING.

submit the revision as a draft (arc diff --draft) so you don't cause useless emails next time

Apr 29 2020, 8:19 PM · Plasma
cblack added a comment to D29279: Don't play volume feedback if max volume is reached.

To be clear: the 95%->100% transition still emits a sound, but 100%->100% does not any more

Apr 29 2020, 5:42 PM · Plasma
cblack added a comment to D29279: Don't play volume feedback if max volume is reached.

Not sure how I feel about this change. I often rely on auditory feedback rather than visual feedback to confirm that I'm at maximum volume.

Apr 29 2020, 5:34 PM · Plasma
cblack created T13060: Colour Picking on Wayland.
Apr 29 2020, 4:33 PM · Plasma on Wayland
cblack closed T12685: [kwin/kwayland] Add private protocol for obtaining application menu of the active client for a screen as Resolved.
Apr 29 2020, 4:18 PM · KWin, Plasma on Wayland
cblack accepted D29156: [kcms/fonts] When adjusting all fonts, keep Small font size smaller.

+1 from a design standpoint here.

Apr 29 2020, 3:07 PM · Plasma

Apr 28 2020

cblack committed R169:e0107f5854dc: Less segfaulty PageRouterAttached (authored by cblack).
Less segfaulty PageRouterAttached
Apr 28 2020, 7:35 PM
cblack closed D29262: Less segfaulty PageRouterAttached.
Apr 28 2020, 7:35 PM · Kirigami
cblack updated the diff for D29262: Less segfaulty PageRouterAttached.

Parent climbing

Apr 28 2020, 7:29 PM · Kirigami
cblack added inline comments to D29264: New tabs for Breeze.
Apr 28 2020, 6:48 PM · VDG, Plasma, Breeze
cblack edited reviewers for D29264: New tabs for Breeze, added: VDG, Breeze; removed: ngraham, niccolove.
Apr 28 2020, 6:45 PM · VDG, Plasma, Breeze
cblack requested review of D29262: Less segfaulty PageRouterAttached.
Apr 28 2020, 5:39 PM · Kirigami
cblack committed R169:515f999a8aa2: WIP: Improve PageRouter API, dysfunctional (authored by cblack).
WIP: Improve PageRouter API, dysfunctional
Apr 28 2020, 5:03 PM
cblack accepted D29203: kirigami.pri: Add missing includes.
Apr 28 2020, 4:37 PM · Kirigami
cblack committed R169:9b21a37d44e2: PageRouter: find parents of items better (authored by cblack).
PageRouter: find parents of items better
Apr 28 2020, 4:34 PM
cblack closed D29135: PageRouter: find parents of items better.
Apr 28 2020, 4:34 PM · Kirigami
cblack updated the diff for D29135: PageRouter: find parents of items better.

Coding style

Apr 28 2020, 4:33 PM · Kirigami
cblack accepted D29253: [wayland] Pass command line arguments to launched processes.
Apr 28 2020, 2:20 PM · KWin

Apr 27 2020

cblack added inline comments to D29232: Introduce the Header color set.
Apr 27 2020, 6:22 PM · Frameworks
cblack accepted D29232: Introduce the Header color set.

+1 to the approach here. I assume this would probably replace the WM set in kdeglobals for all practical usage?

Apr 27 2020, 3:35 PM · Frameworks
cblack added inline comments to D29119: Dolphin: Implement package kit for deb/rpm/pacman service packages.
Apr 27 2020, 3:31 PM · Dolphin

Apr 26 2020

cblack updated the diff for D28888: Fix navigation regressions.

Rebase

Apr 26 2020, 4:16 AM · Kirigami, Plasma

Apr 25 2020

cblack committed R1050:7a087599f527: Improved flatpak manifest (authored by cblack).
Improved flatpak manifest
Apr 25 2020, 10:44 PM
cblack added a comment to D29176: [GTK Subpage] Hide Breeze Dark for GTK3.

I'd probably like to introduce a custom "should show theme variant" attribute to theme indexes, but this will be fine for now.

Apr 25 2020, 2:48 PM · Plasma
cblack accepted D29176: [GTK Subpage] Hide Breeze Dark for GTK3.
Apr 25 2020, 2:48 PM · Plasma

Apr 24 2020

cblack updated the diff for D27669: [kstyle] Tools area.

Re-add empty drawing for menu bar

Apr 24 2020, 8:59 PM · Plasma
cblack updated the diff for D27669: [kstyle] Tools area.

Disconnect signals on destruction

Apr 24 2020, 8:03 PM · Plasma
cblack updated the diff for D28888: Fix navigation regressions.

Add left margin to image

Apr 24 2020, 7:51 PM · Kirigami, Plasma
cblack updated the diff for D28888: Fix navigation regressions.

Address feedback

Apr 24 2020, 7:05 PM · Kirigami, Plasma
cblack committed R98:d74cdcf1376f: Drop appmenu-gtk-module in settings.ini (authored by cblack).
Drop appmenu-gtk-module in settings.ini
Apr 24 2020, 6:52 PM
cblack updated the diff for D28888: Fix navigation regressions.

Swap collapsed header and image

Apr 24 2020, 6:38 PM · Kirigami, Plasma
cblack updated the diff for D28888: Fix navigation regressions.

Adjust listview

Apr 24 2020, 6:31 PM · Kirigami, Plasma
cblack updated the diff for D27669: [kstyle] Tools area.

Address tooling warnings

Apr 24 2020, 5:44 PM · Plasma
cblack requested changes to D29154: Use QWindow overload of QIcon::pixmap.

Icon handling looks somewhat funky with this patch applied when a window changes DPI.

Apr 24 2020, 3:22 PM · Plasma

Apr 23 2020

cblack accepted D29109: Port Clipboard and Notifications applets to Kirigami.PlaceholderMessage.
Apr 23 2020, 6:33 PM · Plasma
cblack updated the diff for D29135: PageRouter: find parents of items better.

Remove stray qDebug

Apr 23 2020, 4:32 PM · Kirigami
cblack requested review of D29135: PageRouter: find parents of items better.
Apr 23 2020, 4:25 PM · Kirigami

Apr 22 2020

cblack added inline comments to D28154: Add users KCM.
Apr 22 2020, 11:47 PM · Plasma
cblack updated the diff for D28154: Add users KCM.

Address feedback, needs fix for https://bugs.kde.org/show_bug.cgi?id=420439 in order to function

Apr 22 2020, 11:38 PM · Plasma
cblack requested review of D29106: Introduce RouterWindow control.
Apr 22 2020, 5:55 PM · Kirigami
cblack added a reverting change for R169:6a0535050b8c: Refactor for loops: R169:cb0535f1f52c: Revert "Refactor for loops".
Apr 22 2020, 4:37 PM
cblack committed R169:cb0535f1f52c: Revert "Refactor for loops" (authored by cblack).
Revert "Refactor for loops"
Apr 22 2020, 4:37 PM
cblack accepted D29080: [kcms/fonts] Guide users towards KScreen KCM for making things bigger on-screen.
Apr 22 2020, 3:04 AM · Plasma
cblack updated the diff for D28888: Fix navigation regressions.

Switch between ListView and CardsLayout

Apr 22 2020, 12:55 AM · Kirigami, Plasma

Apr 21 2020

cblack updated the diff for D27669: [kstyle] Tools area.

Remove stray qDebug

Apr 21 2020, 11:44 PM · Plasma
cblack committed R169:9f6e6e548024: Hotfix: fix bad typing in FormLayout array functions (authored by cblack).
Hotfix: fix bad typing in FormLayout array functions
Apr 21 2020, 9:56 PM
cblack committed R169:14a014ff78e6: Hotfix for SwipeListItem: use Array.prototype.*.call (authored by cblack).
Hotfix for SwipeListItem: use Array.prototype.*.call
Apr 21 2020, 9:31 PM
cblack committed R169:09680db5c9b0: Hotfix: use Array.prototype.some.call in ContextDrawer (authored by cblack).
Hotfix: use Array.prototype.some.call in ContextDrawer
Apr 21 2020, 9:06 PM
cblack added a comment to D28625: Use ShadowedRectangle for Card backgrounds.

This seems to be causing regressions to card behaviour for me.

Apr 21 2020, 8:29 PM · Kirigami