Differential D29307

Implement smallFont in Kirigami plugin
ClosedPublic
Actions

Authored by cblack on Apr 30 2020, 5:15 PM.

Details

Reviewers
mart
Group Reviewers
Kirigami
Commits
R858:5b8868783c01: Implement smallFont in Kirigami plugin
Test Plan

font.qml350 BDownload

Diff Detail

Repository
R858 Qt Quick Controls 2: Desktop Style
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
cblack created this revision.Apr 30 2020, 5:15 PM
Restricted Application added a project: Plasma. · View Herald TranscriptApr 30 2020, 5:15 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
cblack requested review of this revision.Apr 30 2020, 5:15 PM
ngraham added a comment.Apr 30 2020, 6:07 PM

It would be good to explain why we need to use DBus for this, when it wasn't already implemented for the normal font size.

cblack updated this revision to Diff 81642.May 1 2020, 2:23 AM

Add explanatory comment

filipf added a subscriber: filipf.May 1 2020, 7:52 AM

How does this relate to D14562

cblack added a comment.EditedMay 1 2020, 12:48 PM
In D29307#660851, @filipf wrote:

How does this relate to D14562

  1. This would have been a companion patch to it if it didn't get abandoned
  2. But they did, so this is implementing the new interface created in D29304
mart accepted this revision.May 4 2020, 9:59 AM
This revision is now accepted and ready to land.May 4 2020, 9:59 AM
Closed by commit R858:5b8868783c01: Implement smallFont in Kirigami plugin (authored by cblack). · Explain WhyMay 4 2020, 1:50 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 81884

View Options

CMakeLists.txt

Loading...
View Options

kirigami-plasmadesktop-integration/CMakeLists.txt

Loading...
View Options

kirigami-plasmadesktop-integration/plasmadesktoptheme.h

Loading...
View Options

kirigami-plasmadesktop-integration/plasmadesktoptheme.cpp

Loading...