| davidre | |
| ngraham |
| Plasma |
This implicitly fixes a bug where space is used in the shortcut item.
Previously as QQC1 button was made up of multiple objects the key
handling would be handled by an internal object before our filters.
In QQC2 it's all one item, so our Keys handler takes precendence.
Added a test file
Set the button to control+space, alt+4
Set the button to alt+space (this correctly showed a warning about a conflict)
Confirmed tooltip worked correctly
Used space to activate the button when we weren't recording. This someone still worked..
| Automatic diff as part of commit; lint not applicable. |
| Automatic diff as part of commit; unit tests not applicable. |
| src/qmlcontrols/kquickcontrols/KeySequenceItem.qml | ||
|---|---|---|
| 57 |
It's the worst!
It's come up before, this isn't ideal, but there's no other consistent alternative. It's the convention followed elsewhere. Let's follow that up on https://phabricator.kde.org/T10873 | |
| 58 | We need to specify the domain, but you're right i18nd would work just as well and save a QObject | |
| src/qmlcontrols/kquickcontrols/KeySequenceItem.qml | ||
|---|---|---|
| 57 | See task. | |