| cblack | |
| mart |
| Kirigami | |
| VDG |
This switches cards to use ShadowedRectangle for their background. It also refreshes their
design a bit, based on feedback from the VDG.
Still WIP because of potential design issues and I'm not entirely happy with the code for
the actual cards. Ideally I'd also move a bunch of this stuff to C++ but that'd involve a
reimplementing a bunch of Control behaviour.
BUG: 415526
New cards, normal colour scheme:
Breeze Dark:
| Automatic diff as part of commit; lint not applicable. |
| Automatic diff as part of commit; unit tests not applicable. |
Looks like a nice visual improvement.
Are the changes to the scenegraph stuff related? They don't look like a related change to making the Kirigami.Card use the ShadowedRectangle to me.
they should be, as far i know, a fix for the 1 pixel border that had some blurriness.
@ahiemstra can you confirm?
| src/controls/AbstractCard.qml | ||
|---|---|---|
| 30 | as we have a ColorUtils class now, since i've seen this super long thing just to make a color translucent many things, is maybe worth to have a ColorUtils.opacity(Kirigami.Theme.highlightColor, 0.3) instead? | |
They're both things I encountered while implementing this. One is a crash fix, the other is indeed a fix for pixel correctness.
| src/controls/AbstractCard.qml | ||
|---|---|---|
| 30 | This basically does the same thing as Kirigami.Separator. I think it'd be good to have this entire thing in ColorUtils yeah. | |
This seems to be causing regressions to card behaviour for me.
Cards are running together when they weren't previously:
The images are:
Additionally, this appears to be having a non-trivial performance regression to large amounts of cards, as Ikona will freeze for much longer with this patch in its Icon Browser than without cards.
Additionally, console output spams something like this when cards are involved:
/usr/lib64/qml/org/kde/kirigami.2/AbstractCard.qml:31: TypeError: Type error (file:////usr/lib64/qml/org/kde/kirigami.2/AbstractCard.qml:31, )