Differential D29434

Use small font for ExpandableListItem subtitle
ClosedPublic
Actions

Authored by ngraham on May 4 2020, 10:01 PM.

Details

Reviewers
broulik
ndavis
Group Reviewers
Plasma
VDG
Commits
R242:416f82f8f7f5: Use small font for ExpandableListItem subtitle
Summary

We're moving towards using the small font for subtitles in Kirigami BasicListItem (D29432)
so we should probably do the same here since it has the same title + subtitle layout.

Test Plan

Before:

After:

Diff Detail

Repository
R242 Plasma Framework (Library)
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ngraham created this revision.May 4 2020, 10:01 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptMay 4 2020, 10:01 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
ngraham requested review of this revision.May 4 2020, 10:01 PM
broulik added a comment.May 4 2020, 10:12 PM

Yes, please!

cblack added a subscriber: cblack.May 4 2020, 10:46 PM
cblack added inline comments.
src/declarativeimports/plasmaextracomponents/qml/ExpandableListItem.qml
434

font: theme.smallestFont

ngraham updated this revision to Diff 81956.May 4 2020, 11:14 PM
ngraham marked an inline comment as done.

Use the whole font, not just the point size

ndavis accepted this revision.May 6 2020, 3:23 AM
This revision is now accepted and ready to land.May 6 2020, 3:23 AM
Closed by commit R242:416f82f8f7f5: Use small font for ExpandableListItem subtitle (authored by ngraham). · Explain WhyMay 6 2020, 2:55 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 82110

View Options

src/declarativeimports/plasmaextracomponents/qml/ExpandableListItem.qml

Loading...