Feed Advanced Search

Tue, Dec 3

cblack updated the diff for D24275: [GTK3] Add module to reload colorscheme in GTK3 apps without restarting them.

Pull from master

Tue, Dec 3, 5:10 PM · Plasma
cblack added a comment to D24275: [GTK3] Add module to reload colorscheme in GTK3 apps without restarting them.
In D24275#571531, @GB_2 wrote:

Works now :-)

Tue, Dec 3, 4:12 PM · Plasma
cblack added a comment to D24275: [GTK3] Add module to reload colorscheme in GTK3 apps without restarting them.
In D24275#546111, @GB_2 wrote:

Does it work if you use an absolute path to the library? Go to $BUILDROOT/color-reload-module/libcolorreload-gtk-module.so and run gedit --gtk-module $PWD/libcolorreload-gtk-module.so

Nope, still shows the error.

Tue, Dec 3, 3:50 PM · Plasma

Sun, Dec 1

cblack added a comment to D25670: Synchronize decorations buttons order in GTK headerbars.

You would probably want to use icon instead of menu, as menu is only rendered as a fallback for a pattern that most GNOME applications don't use nowadays.

Sun, Dec 1, 11:28 PM · Plasma

Sat, Nov 30

cblack added a comment to T8871: Systematic KCM reorganisation.

I was doing some usability testing on the current settings organisation, and here are the results:

  • "Plasma" is being interpreted as a material rather than a brand name
  • Login screen settings are not in a place people will think to look for them
  • Emoticon configuration is associated as being with fonts, not with icons
  • Title buttons are associated with window management, not application style
  • Date & Time's location resulted in the only "no idea" reply
  • Launch feedback is associated with icons or window management rather than applications
  • Network shares went completely under the radar - they're under a generic tab labelled "Settings"
  • People associate KRunner with the shortcut, not the search
Sat, Nov 30, 10:19 PM · Plasma: KCM Redesign, VDG

Tue, Nov 26

cblack added a comment to D24660: [x11] Add support for _GTK_FRAME_EXTENTS.
In D24660#567598, @zzag wrote:
  • Snapping can be a bit odd as CSD windows can sometimes not realize that their size has changed until after you let go of the mouse

Is this something that needs to be fixed in the compositor itself? How can I reproduce the issue you've described?

Tue, Nov 26, 4:30 PM · KWin

Sun, Nov 24

cblack added a comment to D24660: [x11] Add support for _GTK_FRAME_EXTENTS.

I've been using this patch for a while, and here are some things I've noticed:

  • Thumbnails include window shadow; this appears fine in alt-tab switcher but on panel switcher thumbnails they're drawn with a solid background.
  • Snapping can be a bit odd as CSD windows can sometimes not realize that their size has changed until after you let go of the mouse
  • The shadows don't really fare well when you turn off compositing; toggling compositing while application is running does not seem to be an expected use case in GTK.
Sun, Nov 24, 7:13 PM · KWin

Sat, Nov 23

cblack committed R98:b7b622f9f216: Merge branch 'Plasma/5.17' - Treeview colour fix (authored by cblack).
Merge branch 'Plasma/5.17' - Treeview colour fix
Sat, Nov 23, 5:33 PM
cblack closed D25476: [GTK3] Fix invalid colour name in treeview.
Sat, Nov 23, 5:33 PM · Plasma
cblack committed R98:8c16c1961491: [GTK3] Fix invalid colour name in treeview (authored by cblack).
[GTK3] Fix invalid colour name in treeview
Sat, Nov 23, 5:33 PM

Fri, Nov 22

cblack requested review of D25476: [GTK3] Fix invalid colour name in treeview.
Fri, Nov 22, 9:15 PM · Plasma

Mon, Nov 18

cblack added a comment to T10611: Set options for GTK apps in the respective KCMs.
In T10611#208756, @zzag wrote:

Window decorations (fixes https://bugs.kde.org/show_bug.cgi?id=414113)

Not all decoration themes draw circles around decoration buttons, so that's probably CANTFIX. On the other hand, we could synchronize kwin's decoration button layout with the gtk-decoration-layout property.

Mon, Nov 18, 4:19 PM · Plasma: KCM Redesign

Sat, Nov 16

cblack added a reverting change for R98:b1649126c8c6: [GTK3] Revert checkbox recolouring: R98:980ceeb25b44: Revert "[GTK3] Revert checkbox recolouring".
Sat, Nov 16, 4:30 PM
cblack committed R98:980ceeb25b44: Revert "[GTK3] Revert checkbox recolouring" (authored by cblack).
Revert "[GTK3] Revert checkbox recolouring"
Sat, Nov 16, 4:30 PM
cblack closed D25336: Revert "[GTK3] Revert checkbox recolouring".
Sat, Nov 16, 4:30 PM · Plasma
cblack added a comment to D25336: Revert "[GTK3] Revert checkbox recolouring".

Thanks! Can you add a link to the bugfix in the description section so it's easy to reference? And has the upstream bugfix made it into a release yet such that we can count on it being present for users with rolling release distros, or users whose discrete-release distros eventually settle on Plasma 5.18?

Sat, Nov 16, 3:49 PM · Plasma
cblack updated the summary of D25336: Revert "[GTK3] Revert checkbox recolouring".
Sat, Nov 16, 3:49 PM · Plasma
cblack updated the summary of D25336: Revert "[GTK3] Revert checkbox recolouring".
Sat, Nov 16, 3:40 PM · Plasma
cblack added a reverting change for R98:b1649126c8c6: [GTK3] Revert checkbox recolouring: D25336: Revert "[GTK3] Revert checkbox recolouring".
Sat, Nov 16, 3:38 PM
cblack requested review of D25336: Revert "[GTK3] Revert checkbox recolouring".
Sat, Nov 16, 3:38 PM · Plasma
cblack added a comment to D24706: [RFC] Change button style.

I'm not a fan of dropping the diagonal movement- the transformation makes buttons feel much more button-y.

Sat, Nov 16, 12:50 AM · Breeze, VDG, Plasma

Wed, Nov 13

cblack added inline comments to D24743: Update GTK settings according to Plasma settings.
Wed, Nov 13, 8:21 PM · VDG, Plasma
cblack added inline comments to D24743: Update GTK settings according to Plasma settings.
Wed, Nov 13, 8:15 PM · VDG, Plasma

Tue, Nov 12

cblack added a comment to D24122: [GTK3] Generate Breeze Light assets.

Conceptually it seems like there are two ways to go:

  • Have a single Breeze theme that always follows the color scheme
  • Expose the ability to force the use of a particular color scheme via some UI (for example adding "Breeze Dark" and "Breeze Light" themes that always use the colors of the color schemes of the same names).

    But I think it will be terribly confusing if we add themes that *only* hardcode the colors of certain elements like checkboxes and windeco buttons. It should be all or nothing IMO.

    One alternative UI for this that I've been tinkering with in my mind is as follows: We have only a single "Breeze" GTK theme which follows the color scheme by default. Then there's a "Configure" button that lets you tell the theme which color scheme to use, with the list populated with all the installed color schemes, and defaulting to "Use system color scheme".
Tue, Nov 12, 11:10 PM · Plasma
cblack added a comment to D24122: [GTK3] Generate Breeze Light assets.

Could we repurpose the Breeze Light and Breeze Dark GTK themes to simply hardcode everything to be dark or light rather than following the color scheme? That mirrors what we do for the Plasma theme.

Tue, Nov 12, 10:46 PM · Plasma
cblack added a comment to D24122: [GTK3] Generate Breeze Light assets.

I thought this patch results in a "Breeze light" theme becoming visible in the KCM. If so, that would seem to fulfill the request, unless I'm misunderstanding how the Breeze Dark and proposed Breeze Light themes work. If these themes don't have hardcoded colors (as opposed to theme-respecting colors), what's the difference between them and the "Breeze" theme?

Tue, Nov 12, 10:39 PM · Plasma
cblack updated the test plan for D25281: [GTK3] Improve legibility of Firefox CSD colours.
Tue, Nov 12, 10:31 PM · Plasma
cblack added reviewers for D25281: [GTK3] Improve legibility of Firefox CSD colours: VDG, Breeze.
Tue, Nov 12, 10:28 PM · Plasma
cblack abandoned D23079: [GTK3] Fix Firefox's CSD colors, kinda.

See D25281.

Tue, Nov 12, 10:28 PM · Plasma
cblack requested review of D25281: [GTK3] Improve legibility of Firefox CSD colours.
Tue, Nov 12, 10:27 PM · Plasma
cblack added a comment to D24122: [GTK3] Generate Breeze Light assets.

We got another bug report illustrating another reason why this might be desirable from a user perspective, aside from the Chromium bug: https://bugs.kde.org/show_bug.cgi?id=413111

I'll rescind my objection so we can review and get it in. Can you rebase the patch?

Tue, Nov 12, 10:18 PM · Plasma

Mon, Nov 11

cblack added a comment to T12011: [promo] Posters/ Banners for KDE Conference India 2020.


My attempt at a poster

Mon, Nov 11, 11:01 PM · KDE Promo, VDG
cblack committed R98:4a472fd03d60: Merge branch 'Plasma/5.17' - Scrollbar states (authored by cblack).
Merge branch 'Plasma/5.17' - Scrollbar states
Mon, Nov 11, 12:16 AM
cblack committed R98:62ca13b84a2d: [GTK3] Modify scrollbar states to better resemble Breeze Qt (authored by cblack).
[GTK3] Modify scrollbar states to better resemble Breeze Qt
Mon, Nov 11, 12:15 AM
cblack closed D25246: [GTK3] Modify scrollbar states to better resemble Breeze Qt.
Mon, Nov 11, 12:15 AM · Plasma
cblack updated the summary of D25246: [GTK3] Modify scrollbar states to better resemble Breeze Qt.
Mon, Nov 11, 12:13 AM · Plasma

Sun, Nov 10

cblack updated the test plan for D25246: [GTK3] Modify scrollbar states to better resemble Breeze Qt.
Sun, Nov 10, 11:41 PM · Plasma
cblack requested review of D25246: [GTK3] Modify scrollbar states to better resemble Breeze Qt.
Sun, Nov 10, 11:39 PM · Plasma

Sat, Nov 9

cblack added a comment to D25015: Update breeze theme shadows.

One thing we might need to do in order to finally stop changing the shadows is come up with a math based system for deciding how shadows should look based on the elevation we want certain UI elements to have. We could copy Material Design shadows, but I don't think we should. MD's shadows get darker the larger they are, but that's not how real shadows work. Real shadows get darker the smaller they are because light bounces around.

Sat, Nov 9, 11:39 PM · Frameworks

Fri, Nov 8

cblack committed R98:37058bade9e3: Merge branch 'Plasma/5.17' - Firefox scrollbar fix (authored by cblack).
Merge branch 'Plasma/5.17' - Firefox scrollbar fix
Fri, Nov 8, 9:17 PM
cblack committed R98:be9775281fa9: [GTK3/Firefox] Fix scrollbar click region (authored by cblack).
[GTK3/Firefox] Fix scrollbar click region
Fri, Nov 8, 9:17 PM
cblack closed D25180: [GTK3/Firefox] Fix scrollbar click region.
Fri, Nov 8, 9:17 PM · Plasma
cblack updated the summary of D25180: [GTK3/Firefox] Fix scrollbar click region.
Fri, Nov 8, 9:13 PM · Plasma

Nov 7 2019

cblack added a comment to T11979: KDE neon's Welcome Screen.

This welcome dialogue are very popular, for openSUSE this looks like this:

. Note this is a distribution welcome dialogue and not a first run dialogue like in KDE 2 with configuration. So I wouldn't include configuration links.

Nov 7 2019, 1:06 AM · VDG

Nov 6 2019

cblack updated the test plan for D25180: [GTK3/Firefox] Fix scrollbar click region.
Nov 6 2019, 9:20 PM · Plasma
cblack requested review of D25180: [GTK3/Firefox] Fix scrollbar click region.
Nov 6 2019, 9:20 PM · Plasma

Nov 4 2019

cblack accepted D25147: Remove gtkrc-2.0 legacy settings.

This LGTM. Would probably check a variety of configs with a variety of applications just to be on the safe side and make sure there's no visual oddities, but it should be fine.

Nov 4 2019, 8:55 PM · Plasma

Oct 30 2019

cblack added a comment to D24126: [GTK3] CSD windows show handles on .solid-csd.

Doubtful; it relies on the scss rewrite which happened in 5.15 or 5.16 IIRC.

Indeed, 5.12 didn't use scss yet to generate gtk.css, but contains the gtk.css in the first place.

It should be possible to adjust that directly though, no?

Oct 30 2019, 1:57 PM · Plasma

Oct 29 2019

cblack committed R98:51968f9551aa: Merge branch 'Plasma/5.17' -> Reverse checkbox recoloring (authored by cblack).
Merge branch 'Plasma/5.17' -> Reverse checkbox recoloring
Oct 29 2019, 12:28 AM
cblack committed R98:b1649126c8c6: [GTK3] Revert checkbox recolouring (authored by cblack).
[GTK3] Revert checkbox recolouring
Oct 29 2019, 12:28 AM
cblack closed D24994: [GTK3] Revert checkbox recolouring.
Oct 29 2019, 12:28 AM · Plasma
cblack updated the summary of D24994: [GTK3] Revert checkbox recolouring.
Oct 29 2019, 12:05 AM · Plasma
cblack updated the diff for D24994: [GTK3] Revert checkbox recolouring.

Reverse checkboxes in menus as well

Oct 29 2019, 12:04 AM · Plasma

Oct 28 2019

cblack updated the test plan for D24994: [GTK3] Revert checkbox recolouring.
Oct 28 2019, 2:04 AM · Plasma
cblack requested review of D24994: [GTK3] Revert checkbox recolouring.
Oct 28 2019, 2:02 AM · Plasma
cblack committed R98:5c1a58b25519: [GTK3] Add styles for libhandy widgets (authored by cblack).
[GTK3] Add styles for libhandy widgets
Oct 28 2019, 1:52 AM
cblack closed D24786: [GTK3] Add styles for libhandy widgets.
Oct 28 2019, 1:52 AM · Plasma

Oct 24 2019

cblack added a comment to D24786: [GTK3] Add styles for libhandy widgets.

I think it might be a bit premature to copy the look of Plasma Mobile at this point. I don't know what is likely to change and what is likely to stay. I expect that it will mirror the look of desktop Plasma, which will mirror the look of the Breeze widget style.

Oct 24 2019, 8:50 PM · Plasma
cblack committed R120:7a7363289304: [sddm-theme] Add slot to configure a logo to be shown on the SDDM login screen (authored by cblack).
[sddm-theme] Add slot to configure a logo to be shown on the SDDM login screen
Oct 24 2019, 8:36 PM
cblack closed D22458: [sddm-theme] Add slot to configure a logo to be shown on the SDDM login screen.
Oct 24 2019, 8:36 PM · Plasma
cblack committed R120:5c8ce892e394: [sddm-theme] Start moving from QQC1 to QQC2 (authored by cblack).
[sddm-theme] Start moving from QQC1 to QQC2
Oct 24 2019, 8:36 PM
cblack closed D21815: [sddm-theme] Start moving from QQC1 to QQC2.
Oct 24 2019, 8:36 PM · Plasma

Oct 19 2019

cblack updated the test plan for D24786: [GTK3] Add styles for libhandy widgets.
Oct 19 2019, 4:25 PM · Plasma
cblack updated the test plan for D24786: [GTK3] Add styles for libhandy widgets.
Oct 19 2019, 4:22 PM · Plasma
cblack requested review of D24786: [GTK3] Add styles for libhandy widgets.
Oct 19 2019, 4:20 PM · Plasma

Oct 16 2019

cblack closed D24537: Icons for windy weather.
Oct 16 2019, 8:03 PM · Frameworks
cblack committed R266:ed5d288ae908: Icons for windy weather (authored by cblack).
Icons for windy weather
Oct 16 2019, 8:03 PM
cblack updated the diff for D24537: Icons for windy weather.

Run icons through SVG cleaner

Oct 16 2019, 7:50 PM · Frameworks
cblack updated the test plan for D24537: Icons for windy weather.
Oct 16 2019, 7:50 PM · Frameworks
cblack updated the diff for D24537: Icons for windy weather.

Remove excess icon

Oct 16 2019, 2:39 AM · Frameworks
cblack updated the diff for D24537: Icons for windy weather.

Colour changes

Oct 16 2019, 2:37 AM · Frameworks

Oct 15 2019

cblack committed R98:91c16f284c18: Fix compatibility of build_theme.sh with Dash (authored by gepardo).
Fix compatibility of build_theme.sh with Dash
Oct 15 2019, 7:50 PM
cblack closed D24447: Fix compatibility of build_theme.sh with Dash.
Oct 15 2019, 7:50 PM · Plasma
cblack added a comment to D24447: Fix compatibility of build_theme.sh with Dash.

Thanks. Can you please merge it? I don't have a developer access to KDE repos.

Oct 15 2019, 7:48 PM · Plasma
cblack accepted D24447: Fix compatibility of build_theme.sh with Dash.

LGTM 👍

Oct 15 2019, 7:44 PM · Plasma

Oct 14 2019

cblack updated the diff for D24537: Icons for windy weather.

Shift wind emblem to the right, clean scratch work, and rename night icons

Oct 14 2019, 1:49 AM · Frameworks
cblack added a comment to D24537: Icons for windy weather.

That cyan looks odd. It sticks out way too much and AFAIK, it isn't commonly used to represent wind. Gray on more gray is going to be tricky as well though, especially when you've got partly cloudy vs cloudy. What if the wind was a bit more monochromatic? Wind is invisible, so it only really has shapes that are associated with how it moves around objects to represent it. Perhaps we can use darker colors for lighter backgrounds and lighter colors for darker backgrounds then? Here's an idea for an alternate shape type, but you don't have to use it:

Oct 14 2019, 1:47 AM · Frameworks

Oct 13 2019

cblack added a comment to D24621: [RFC] New Konsole and Yakuake icons.

They look nice, but I'm not sure how well they fit in with other Breeze icons.
Comparison montages:


Oct 13 2019, 11:19 PM · Frameworks

Oct 10 2019

cblack updated the test plan for D24537: Icons for windy weather.
Oct 10 2019, 5:30 PM · Frameworks
cblack requested review of D24537: Icons for windy weather.
Oct 10 2019, 5:30 PM · Frameworks
cblack planned changes to D24471: [KRDB] Remove Oxygen-era colour exporting code.

So it turns out I ran into an unrelated bug that at first glance appeared to be the linked bug with my setup, but in reality, it's actually unrelated.

Oct 10 2019, 1:44 AM · Plasma
cblack updated the summary of D24471: [KRDB] Remove Oxygen-era colour exporting code.
Oct 10 2019, 1:28 AM · Plasma

Oct 8 2019

cblack added a comment to D24471: [KRDB] Remove Oxygen-era colour exporting code.

Some examples of exporting colours causing graphical artifacts:


(Adapta)

(Adwaita)

(High Contrast)

(Arc)

Oct 8 2019, 1:33 PM · Plasma
cblack added a comment to D24471: [KRDB] Remove Oxygen-era colour exporting code.

it seems to have defaulted to always on

Yes, I did that because it makes sense.

(which is pretty rare)

So, you're saying GTK2 themes are likely to follow color schemes but GTK3 are not?

I meant that it was rare for GTK2 themes in 2019 to attempt to follow the colorscheme, not that it was rare for them to not follow the colorscheme.

(including Breeze GTK) primarily use pixmaps

Basically, we cannot have GTK 2 apps follow color schemes anymore, or did that ever really work?

Oct 8 2019, 1:24 PM · Plasma
cblack added a comment to D24471: [KRDB] Remove Oxygen-era colour exporting code.

I don't understand what this is solving. Did this work before, if so, what broke it, that suddenly requires this patch?

Oct 8 2019, 6:27 AM · Plasma

Oct 7 2019

cblack added a comment to D24471: [KRDB] Remove Oxygen-era colour exporting code.

Is this the other half for fixing https://bugs.kde.org/show_bug.cgi?id=412331?

Oct 7 2019, 3:58 PM · Plasma
cblack updated the summary of D24471: [KRDB] Remove Oxygen-era colour exporting code.
Oct 7 2019, 3:49 PM · Plasma
cblack updated the summary of D24471: [KRDB] Remove Oxygen-era colour exporting code.
Oct 7 2019, 3:49 PM · Plasma
cblack requested review of D24471: [KRDB] Remove Oxygen-era colour exporting code.
Oct 7 2019, 3:48 PM · Plasma

Oct 3 2019

cblack added a comment to D24324: [GTK2] Add program to libexec for GTK2 recoloration.

I'm not sure how to verify if the assets have been generated correctly. What GTK2 programs did you test with?

Look for a theme in ~/.local/share/themes called Breeze 🎨. The reason why it has a 🎨 is to distinguish it from the system Breeze GTK2 theme. Otherwise,
there'd be two Breeze entries listed in the user's GTK2 theme list in syse5. Yes, it's clunky, but this is a toolkit older than me, so clunkiness is expected.

I would probably add a "if the user has GTK2 theme set to Breeze/Breeze Dark change the GTK2 theme to the recoloured one" but I'm not sure
what direction GTK configuration is heading with that configuration daemon being worked on, so I'd rather not mess with GTK configuration until that's ironed out.

Am I supposed to run this script myself? I did make install and it didn't seem to do anything.

Are you sure the emoji isn't going to be a problem in programs or systems with no emoji fonts?

Oct 3 2019, 3:09 AM · Plasma
cblack added a comment to D24324: [GTK2] Add program to libexec for GTK2 recoloration.

I'm not sure how to verify if the assets have been generated correctly. What GTK2 programs did you test with?

Oct 3 2019, 1:35 AM · Plasma

Oct 2 2019

cblack updated the summary of D24375: [kcms/colors] Generate colored GTK2 assets based off of user's colorscheme.
Oct 2 2019, 9:31 PM · Plasma
cblack added a dependent revision for D24324: [GTK2] Add program to libexec for GTK2 recoloration: D24375: [kcms/colors] Generate colored GTK2 assets based off of user's colorscheme.
Oct 2 2019, 9:17 PM · Plasma
cblack added a dependency for D24375: [kcms/colors] Generate colored GTK2 assets based off of user's colorscheme: D24324: [GTK2] Add program to libexec for GTK2 recoloration.
Oct 2 2019, 9:17 PM · Plasma
cblack requested review of D24375: [kcms/colors] Generate colored GTK2 assets based off of user's colorscheme.
Oct 2 2019, 9:16 PM · Plasma

Oct 1 2019

cblack committed R118:f1afc1e60897: Merge branch 'Plasma/5.17' (authored by cblack).
Merge branch 'Plasma/5.17'
Oct 1 2019, 9:36 PM
cblack committed R118:28b1d5e2969d: [Cuttlefish] Synchronize sliders (authored by cblack).
[Cuttlefish] Synchronize sliders
Oct 1 2019, 9:36 PM
cblack closed D24351: [Cuttlefish] Synchronize sliders.
Oct 1 2019, 9:36 PM · Plasma
cblack updated the test plan for D24351: [Cuttlefish] Synchronize sliders.
Oct 1 2019, 7:53 PM · Plasma
cblack updated the test plan for D24351: [Cuttlefish] Synchronize sliders.
Oct 1 2019, 7:51 PM · Plasma