I often smash my volume up key until the volume is max. I usually smash it for too long and the sound is still playing even if the volume isn't actually changing any more. By not playing a sound when the volume is already at maximum we avoid a weird sound and give an accoustic feedback that the maximum has been reached.
Diff Detail
- Repository
- R115 Plasma Audio Volume Applet
- Branch
- vol
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 26090 Build 26108: arc lint + arc unit
Not sure how I feel about this change. I often rely on auditory feedback rather than visual feedback to confirm that I'm at maximum volume.
The lack of sound is feedback that you are at maximum volume
Before it was hard to hear the difference between 90% and 100%
To be clear: the 95%->100% transition still emits a sound, but 100%->100% does not any more
Yes, that's what I rely on to know that I'm at maximum volume-when the volume of the feedback doesn't change. If I press a volume key and don't get auditory feedback, that makes me feel like I hit the volume down key by mistake, and I'm at 0% volume.
Wouldn't it be easier to tell the difference between 95% and 0% than between 95% and 100%? I can't tell the difference between 95 and 100 at all.
I'm with @cblack here. When I press the button i expect audible feedback. If any, we should block repeated feedback sounds when pressing and holding the key without the volume changing but pressing the key once should always play the respective sound.