Introduce Theme.smallestFont
Needs ReviewPublic

Authored by volkov on Aug 2 2018, 4:06 PM.


Group Reviewers

It can be useful in itself and when porting code from Plasma.

Diff Detail

R169 Kirigami
No Linters Available
No Unit Test Coverage
Build Status
Buildable 23018
Build 23036: arc lint + arc unit
volkov created this revision.Aug 2 2018, 4:06 PM
Restricted Application added a project: Kirigami. · View Herald TranscriptAug 2 2018, 4:06 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
volkov requested review of this revision.Aug 2 2018, 4:06 PM
mart requested changes to this revision.Aug 6 2018, 9:02 AM
mart added a subscriber: mart.

good idea, 2 comments:

  • the import version of platformtheme cannot change or will break existing code
  • needs a smallestfont declared also in all version of qml-base theme implementations, one in controls, one is in the kirigami repo, under controls, one is in the plasma-framework repo, under src/declarativeimports/kirigamiplasmastyle/
173 ↗(On Diff #38964)

this will break completely every import < 2.6

This revision now requires changes to proceed.Aug 6 2018, 9:02 AM
volkov added inline comments.Aug 6 2018, 1:39 PM
173 ↗(On Diff #38964)

So, should it be registered for both versions 2.2 and 2.6?
I tried to use revisions, but it looks like they don't work for properties of attached property objects:
One can import kirigami 2.2 and use smallestFont.

volkov added inline comments.Aug 7 2018, 11:52 AM
173 ↗(On Diff #38964)

Why add it to qml-base theme implementations?
Aren't they obsolete?

mart added inline comments.Feb 3 2020, 2:58 PM
173 ↗(On Diff #38964)

Register it just for 2.2 and forget about revisions.
They're a broken concept and they will be removed in Qt6 anyways

volkov updated this revision to Diff 76554.Feb 27 2020, 3:35 PM

registered for 2.2