Differential D28875

Screensharing: support variable stride
ClosedPublic
Actions

Authored by jgrulich on Apr 16 2020, 7:38 AM.

Details

Reviewers
cblack
Group Reviewers
Plasma
Commits
R838:d1f0ec4d3a4c: Screensharing: support variable stride
Summary

We were ignoring stride higher than stride calculated as width * bpp, which I assumed will always be the case, but it turns out that some drivers might use bigger stride, which might be width * bpp + some additional padding.

Test Plan

All current clients still work and also we now support bigger stride we get from gbm_bo.

Diff Detail

Repository
R838 Flatpak Support: KDE Portal for XDG Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
jgrulich created this revision.Apr 16 2020, 7:38 AM
Restricted Application added a project: Plasma. · View Herald TranscriptApr 16 2020, 7:38 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
jgrulich requested review of this revision.Apr 16 2020, 7:38 AM
jgrulich edited the summary of this revision. (Show Details)Apr 16 2020, 7:42 AM
jgrulich edited the test plan for this revision. (Show Details)
jgrulich added reviewers: Plasma, cblack.
cblack accepted this revision.Apr 16 2020, 1:11 PM
This revision is now accepted and ready to land.Apr 16 2020, 1:11 PM
Closed by commit R838:d1f0ec4d3a4c: Screensharing: support variable stride (authored by jgrulich). · Explain WhyApr 16 2020, 1:16 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/screencaststream.cpp (26 lines)

Diff 80273

View Options

src/screencaststream.cpp

Loading...