Replace foreach with range-for
ClosedPublic
Actions

Authored by ahmadsamir on Apr 23 2020, 8:55 AM.

Details

Reviewers

jgrulich

Group Reviewers

Frameworks

Commits

R282:b53859b89a13: Replace foreach with range-for

Summary

I missed one file before, now it should actually build with -DQT_NO_FOREACH.

Test Plan

make && ctest

Repository

R282 NetworkManagerQt

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Restricted Application added 1 blocking reviewer(s): jgrulich. · View Herald Transcript

ahmadsamir requested review of this revision.Apr 23 2020, 8:55 AM

This revision is now accepted and ready to land.Apr 23 2020, 9:03 AM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			src/settings/ipv4setting.cpp (30 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	80963	ee827d8		Apr 23 2020, 8:55 AM	★	★
Diff 2	80965	ee827d8	R282:b53859b89a13bff0fa1451a8bf780546d3d3d993	Apr 23 2020, 9:11 AM	★	★

Commit	Tree	Parents	Author	Summary	Date
bb6684f91ff3	ea7a307bbb52	ee827d8efba2	Ahmad Samir	Replace foreach with range-for (Show More…)	Apr 23 2020, 8:53 AM