Differential D29117

[applet] Put the toolbar in the header area
ClosedPublic
Actions

Authored by ngraham on Apr 23 2020, 4:31 AM.

Details

Reviewers
jgrulich
niccolove
manueljlin
Group Reviewers
VDG
Plasma
Maniphest Tasks
T10470: Improve the visuals of tray popups
Commits
R116:0d732531346f: [applet] Put the toolbar in the header area
Summary

This patch implements part of the mockup at T10470 by putting the toolbar in a heading
area visually connected to the titlebar.

Test Plan

Diff Detail

Repository
R116 Plasma Network Management Applet
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ngraham created this revision.Apr 23 2020, 4:31 AM
Restricted Application added a project: Plasma. · View Herald TranscriptApr 23 2020, 4:31 AM
Restricted Application added 1 blocking reviewer(s): jgrulich. · View Herald Transcript
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ngraham requested review of this revision.Apr 23 2020, 4:31 AM
jgrulich accepted this revision.Apr 23 2020, 5:57 AM
This revision is now accepted and ready to land.Apr 23 2020, 5:57 AM
manueljlin accepted this revision as: manueljlin.Apr 23 2020, 12:12 PM

Looks good 👍 Should I accept as VDG or wait for @niccolove 's review?

niccolove accepted this revision.Apr 23 2020, 12:12 PM
Closed by commit R116:0d732531346f: [applet] Put the toolbar in the header area (authored by ngraham). · Explain WhyApr 23 2020, 1:28 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 80995

View Options

applet/contents/ui/PopupDialog.qml

Loading...
View Options

applet/contents/ui/Toolbar.qml

Loading...