Differential D29093

[NetworkManager-qt] Replace foreach with range for, hopefully last pass
ClosedPublic
Actions

Authored by ahmadsamir on Apr 22 2020, 12:45 PM.

Tags

Subscribers

kde-frameworks-devel

Details

Reviewers

Group Reviewers

Commits

R282:ee827d8efba2: [NetworkManager-qt] Replace foreach with range for, hopefully last pass

Summary

Set -DQT_NO_FOREACH

Test Plan

make && ctest

Diff Detail

Repository

R282 NetworkManagerQt

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

ahmadsamir created this revision.Apr 22 2020, 12:45 PM

Restricted Application added a project: Frameworks. · View Herald TranscriptApr 22 2020, 12:45 PM

Restricted Application added 1 blocking reviewer(s): jgrulich. · View Herald Transcript

ahmadsamir requested review of this revision.Apr 22 2020, 12:45 PM

Harbormaster completed remote builds in B25681: Diff 80877.Apr 22 2020, 12:45 PM

Get the last ones

Harbormaster completed remote builds in B25683: Diff 80879.Apr 22 2020, 12:51 PM

Verbatim

Restricted Application added 1 blocking reviewer(s): jgrulich. · View Herald TranscriptApr 22 2020, 12:53 PM

Harbormaster completed remote builds in B25684: Diff 80880.Apr 22 2020, 12:53 PM

Depends on D29091.

jgrulich accepted this revision.Apr 23 2020, 6:32 AM

This revision is now accepted and ready to land.Apr 23 2020, 6:32 AM

Closed by commit R282:ee827d8efba2: [NetworkManager-qt] Replace foreach with range for, hopefully last pass (authored by ahmadsamir). · Explain WhyApr 23 2020, 8:37 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			CMakeLists.txt (1 line)
M			examples/createconnection/main.cpp (8 lines)
M			examples/main.cpp (8 lines)
M			src/settings/connectionsettings.cpp (16 lines)
M			src/settings/dcbsetting.cpp (18 lines)
M			src/settings/security8021xsetting.cpp (5 lines)
M			src/settings/tcsetting.cpp (6 lines)
M			src/settings/wirelesssecuritysetting.cpp (15 lines)
M			src/utils.cpp (14 lines)

Diff 80961

CMakeLists.txt

Loading...

examples/createconnection/main.cpp

Loading...

examples/main.cpp

Loading...

src/settings/connectionsettings.cpp

Loading...

src/settings/dcbsetting.cpp

Loading...

src/settings/security8021xsetting.cpp

Loading...

src/settings/tcsetting.cpp

Loading...

src/settings/wirelesssecuritysetting.cpp

Loading...

src/utils.cpp

Loading...