Differential D29071

FileChooser portal: add support for opening directories
ClosedPublic
Actions

Authored by jgrulich on Apr 21 2020, 8:11 PM.

Details

Reviewers
apol
Group Reviewers
Plasma
Commits
R838:976d0c5fade9: FileChooser portal: add support for opening directories
Summary

BUG: 419874

Test Plan

This is also implemented on Qt side and currently on review: https://codereview.qt-project.org/c/qt/qtbase/+/297872. Tested with xdg-portal-test-kde using mentioned Qt patch.

Diff Detail

Repository
R838 Flatpak Support: KDE Portal for XDG Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
jgrulich created this revision.Apr 21 2020, 8:11 PM
Restricted Application added a project: Plasma. · View Herald TranscriptApr 21 2020, 8:11 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
jgrulich requested review of this revision.Apr 21 2020, 8:11 PM
jgrulich edited the test plan for this revision. (Show Details)Apr 21 2020, 8:13 PM
jgrulich added reviewers: apol, Plasma.
broulik added a subscriber: broulik.Apr 21 2020, 8:24 PM
broulik added inline comments.
src/filechooser.cpp
167

This check isn't needed, but is probably consistent with the rest and should be cleaned up separately afterwards

jgrulich edited the summary of this revision. (Show Details)Apr 22 2020, 5:50 AM
apol accepted this revision.Apr 28 2020, 11:17 AM

Looks good to me.

This revision is now accepted and ready to land.Apr 28 2020, 11:17 AM
Closed by commit R838:976d0c5fade9: FileChooser portal: add support for opening directories (authored by jgrulich). · Explain WhyApr 28 2020, 11:29 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/filechooser.cpp (8 lines)

Diff 81423

View Options

src/filechooser.cpp

Loading...