Return buffer to pipewire when returning early from recordFrame
ClosedPublic

Authored by cblack on Apr 9 2020, 11:10 PM.

Details

Summary

Even when something goes wrong, the buffer should be returned to pipewire for recycling on next frame.

Test Plan

Before: when something goes wrong when screencasting, first errors are the actual issue and subsequent errors are due to pipewire not having any buffers for the pw_stream_deque_buffer call
After: when something goes wrong when screencasting, errors are always the actual issue

Diff Detail

Repository
R838 Flatpak Support: KDE Portal for XDG Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
cblack created this revision.Apr 9 2020, 11:10 PM
Restricted Application added a project: Plasma. · View Herald TranscriptApr 9 2020, 11:10 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
cblack requested review of this revision.Apr 9 2020, 11:10 PM
jgrulich accepted this revision.Apr 10 2020, 5:31 AM
This revision is now accepted and ready to land.Apr 10 2020, 5:31 AM
This revision was automatically updated to reflect the committed changes.