- User Since
- Aug 26 2018, 6:24 AM (25 w, 2 d)
Wed, Feb 13
Sat, Feb 9
Any connection created by the previous version or the basic NetworkManager plugin should continue to work even though the DNS server list will not be viewable in the new interface.
I did not provide an automatic conversion from a previously created connection to the new storage format. Neither did I create a warning (popup?) if an old style config is displayed by the editor. If there is a consensus to add either of these items, I can do that.
Nov 8 2018
Nov 7 2018
- Allocate palettes in advanced widget rather than passing them from main interface
Oct 25 2018
A couple of notes on the latest upload:
- I left the background color change code alone. Doing searches on changing widget background color, it looks like the preferred method is to use setPalette() which requires a QPalette, and after trying a couple of things I decided it made more sense to me to pass around two palettes by reference than to pass just the colors and create palettes when they were needed.
- Address review comments
Oct 18 2018
Oct 15 2018
Well for the first time since July there has been activity on network-manager-wireguard including the addition of an additional parameter supported so I am going to get going on adding it to this. Also, it looks like the pre- and post- options now do something so against my better judgment I am going to add them back in as well.
Oct 1 2018
I've uploaded everything I wanted to get done now. Are there any new comments? And by the way, what is the process once the all the comments do get cleared?
Sep 25 2018
- Fix review comments
- Add entry widget background color change based on entry validity
- Change QSpinBoxes back to QLineEdits
- Fix a case that was being reported as Acceptable rather than Intermediate
Sep 24 2018
Changes for this revision were merged into D15520
Sep 22 2018
Okay, I just uploaded changes for most of the rest of the comments but I would like to revisit a couple of earlier issues.
The first is the SpinBoxes. As I said in another comment, I don't think that the SpinBoxes are appropriate for any of the entries and would like to return these to be plain LineEdit widgets. The smallest range for any of these is the port number box at 0-65535 and I don't think any of them will be entered using the SpinBox arrows so I think simple text entry is better from an HMI perspective.
- Update from more (but not all) review comments
- Change 'setting' functions to use blank NMStringMap rather than incoming data.
Sep 19 2018
Sep 18 2018
- Remove unnecessary includes and member functions
Since I added a validator function for the WireGuard style keys, is there any way to assign a validator to the PasswordField widget without a fairly substantial rewrite of that class?
- Merge new IP list validator into this branch
- Update from review comments
- Remove changes moved to review D15520
Sep 17 2018
- Correct CMakefile I screwed up
Sep 16 2018
- Add tests for new and updated ip validators
- Update ip validators
- Add validator for WireGuard keys
- Update per review comments
- Add error messages for failure cases
- Correct overlooked comments from review D15093
Sep 15 2018
Sep 12 2018
A couple of questions on opening other review requests:
- Should I open a bug request on bugs.kde.org before opening the review?
- Is there any special way I need to mark dependencies? That is, the simpleiplistvalidator is dependent on the updates to the simpleipv4/6 validators and WireGuard is dependent on both.
- Is there a preferred unit test framework that KDE uses? And do you possibly have a pointer to a sample of other projects that use it? (Especially if they use QValidator since I tried to write some test code for my own use and I couldn't get it to not crash before it even got to main()).
- Correct capitalization
- Remove HTML from tooltip strings
- Update some tooltip strings for clarity
Sep 9 2018
I think I've gotten most of the fixes in. I made changes to simpleipv4addressvalidator and simpleipv6addressvalidator to add checking of addresses with CIDR and Port suffixes. Please check these carefully, I think I did the changes such that all existing uses will not be affected but I want to make sure. Oh, except I made one fix in ipv6 where it was disallowing "::" at the beginning of the address followed by anything. This is a totally valid and not uncommon usage so I included that in the change.
I also added a new file simpleiplistvalidator which allows the checking of comma separated lists of IPv4, IPv6, or mixed addresses.
- Fixed comment
- Expand capabilities of SimpleIP validators.
- Changes per review comments
- Update for updated ip validators
Sep 6 2018
Sep 5 2018
Sep 3 2018
I'm not sure if the author or the reviewer is supposed to check the "Done" box on the inline comments but I think that I have addressed all the various comments made, both inline and separately.
Updates from review comments
- Add copyright notices
- Delete unneeded files
- Formatting changed to agree with coding standards
- Changed validation method removing color overrides
- Removed hard coded fonts and sizes from UI files
Aug 31 2018
I've used KDE for years but this is the first time I've written code using Qt so it doesn't surprise me that I didn't use some of the preferred methods of doing things. I have a few questions below and hopefully you will have a little patience with me if any seem like stupid questions.
Aug 27 2018
Yes there is an add-on available. The original is at https://github.com/max-moser/network-manager-wireguard however I have made a couple of mods and issued pull requests but they have not been incorporated in the original yet. I anyone is interested in the latest I am using it is available at: https://github.com/Druco/network-manager-wireguard/tree/AllLocalFixes
I'll also let @jgrulich comment on this, but I'm not too fond of the manual parsing of the INI-like file used by WG. While I can't check at the moment, there should be KF5 or Qt classes to handle tihs.
In addition, I see one coding style issue right off the bat: we don't put opening braces on their own lines. That'll need to be changed in all the filed you've added. And speaking of those added files, I think you need to add your copyright to them. Finally, do we really need to duplicate passwordfield.h and passwordfield.cpp?