Differential D29086

[NetworkManager-qt] Replace foreach with range/index for loop
ClosedPublic
Actions

Authored by ahmadsamir on Apr 22 2020, 9:50 AM.

Details

Reviewers
jgrulich
Group Reviewers
Frameworks
Commits
R282:f0b1c412074a: [NetworkManager-qt] Replace foreach with range/index for loop
Test Plan

make && ctest

Diff Detail

Repository
R282 NetworkManagerQt
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ahmadsamir created this revision.Apr 22 2020, 9:50 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptApr 22 2020, 9:50 AM
Restricted Application added 1 blocking reviewer(s): jgrulich. · View Herald Transcript
ahmadsamir requested review of this revision.Apr 22 2020, 9:50 AM
jgrulich accepted this revision.Apr 22 2020, 10:00 AM
This revision is now accepted and ready to land.Apr 22 2020, 10:00 AM
ahmadsamir updated this revision to Diff 80860.Apr 22 2020, 10:03 AM

Some missing ones

jgrulich accepted this revision.Apr 22 2020, 10:06 AM
Closed by commit R282:f0b1c412074a: [NetworkManager-qt] Replace foreach with range/index for loop (authored by ahmadsamir). · Explain WhyApr 22 2020, 10:27 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 80861

View Options

src/activeconnection.cpp

Loading...
View Options

src/device.cpp

Loading...
View Options

src/dnsconfiguration.cpp

Loading...
View Options

src/fakenetwork/fakenetwork.cpp

Loading...
View Options

src/fakenetwork/settings.cpp

Loading...
View Options

src/fakenetwork/wirelessdevice.cpp

Loading...
View Options

src/settings.cpp

Loading...
View Options

src/wirelessnetwork.cpp

Loading...