Refactor and fix the mobile wifi kcm
ClosedPublic
Actions

Authored by tfella on Apr 13 2020, 4:37 PM.

Details

Reviewers

ngraham
jgrulich
jbbgameich

Group Reviewers

Plasma

Commits

R116:7e65fd05b38e: Refactor and fix the mobile wifi kcm

Summary

Previous refactoring and existing errors made editing connections impossible. Also, existing work for adding hidden networks was broken. By fixing these problems, this patch implements T12893.

The checks for signal strength being > 0 were removed to make make hidden networks show up in the list

Test Plan

Test adding and editing connections

Diff Detail

Repository

R116 Plasma Network Management Applet

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

tfella created this revision.Apr 13 2020, 4:37 PM

Restricted Application added a project: Plasma. · View Herald TranscriptApr 13 2020, 4:37 PM

Restricted Application added a reviewer: jgrulich. · View Herald Transcript

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

tfella requested review of this revision.Apr 13 2020, 4:37 PM

Harbormaster completed remote builds in B25167: Diff 80029.Apr 13 2020, 4:37 PM

tfella edited the summary of this revision. (Show Details)Apr 13 2020, 4:48 PM

Minor Fixes

Harbormaster completed remote builds in B25194: Diff 80076.Apr 14 2020, 10:09 AM

jgrulich edited reviewers, added: ngraham; removed: jgrulich.Apr 14 2020, 11:32 AM

Restricted Application added a reviewer: jgrulich. · View Herald TranscriptApr 14 2020, 11:32 AM

jgrulich removed a reviewer: jgrulich.Apr 14 2020, 11:32 AM

Restricted Application added a reviewer: jgrulich. · View Herald TranscriptApr 14 2020, 11:32 AM

I wanted to let @ngraham to review this UI wise, but I see there are no UI changes. I don't follow mobile KCM development so I'm not sure I'm the right person to review this, but it looks good to me. I haven't tried it, but I believe you.

libs/models/mobileproxymodel.cpp
66	This is no longer needed anyway as I already filter out local access points (in this meaning it is probably an AP which I share as hotspot). See https://cgit.kde.org/plasma-nm.git/diff/libs/models/networkmodel.cpp?id=5e55e45d8794eb6c4840b2916e723177c18cd695.

This revision is now accepted and ready to land.Apr 14 2020, 11:44 AM

jbbgameich accepted this revision.Apr 14 2020, 1:52 PM

nicolasfella added a subscriber: nicolasfella.Apr 14 2020, 5:18 PM

nicolasfella added inline comments.

mobile/wifi/package/contents/ui/NetworkSettings.qml
27	not needed
mobile/wifi/wifisettings.cpp
65	space after if

More fixes

Harbormaster completed remote builds in B25242: Diff 80143.Apr 14 2020, 5:30 PM

tfella marked 2 inline comments as done.Apr 14 2020, 5:31 PM

Closed by commit R116:7e65fd05b38e: Refactor and fix the mobile wifi kcm (authored by tfella). · Explain WhyApr 14 2020, 6:32 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

		Path
M		libs/models/mobileproxymodel.cpp (2 lines)
D	M	mobile/wifi/package/contents/ui/ConnectionEditor.qml (94 lines)
M		mobile/wifi/package/contents/ui/ConnectionItemDelegate.qml (4 lines)
M		mobile/wifi/package/contents/ui/NetworkSettings.qml (227 lines)
M		mobile/wifi/package/contents/ui/main.qml (2 lines)
M		mobile/wifi/wifisettings.cpp (5 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	80029	eec18ad		Apr 13 2020, 4:37 PM	★	★
Diff 2	80076	eec18ad	Minor Fixes	Apr 14 2020, 10:09 AM	★	★
Diff 3	80143	eec18ad	More fixes	Apr 14 2020, 5:30 PM	★	★
Diff 4	80146	c137041	R116:7e65fd05b38eb62adc0c324923ae73652c2d6985	Apr 14 2020, 6:32 PM	★	★