Depends on D28033
- Group Reviewers
- Maniphest Tasks
- T12812: Create re-usable Plasma Component for expandable list item and port applets to use it
- R116:b494e08b9bfa: [Applet] Port to ExpandableListItem
All functionality still works. There are minimal visual changes, mostly little things
to make the appearance consistent with other applets using the new
Labels need eliding. Full width has problems?
Button need to expand also. Click always collapse?
Listitem.qml can be removed now. Not exactly.
Btw, I didn't see itemExpanded use anywhere.
In expandedView (main patch) there is height in Layout.
Button right margin is constant, looks slightly small for known networks.
Now is not possible to cancel a connection attempt. Is there a use case?
Seems to work with all functionality working as before, well done!! Just few details:
- I noticed that expanding an active connection makes it to switch the expanded "tab view" to the second tab with details information, it first expands showing the traffic monitor and then moves to the details view instead. I see that everytime I restart plasmashell and open it.
- When connecting to an unknown wireless connection, the connect button is enabled, it's not greyed out, which is identical to the original behavior, however making it to pupup the password dialog, the button is then greyed out, which is correct, but closing it doesn't make the button again active, it's still greyed out so it doesn't restore the original state.
Both issues fixed, however I found two news:
- Getting file:///usr/lib64/qt5/qml/org/kde/plasma/extras/ExpandableListItem.qml:438:13: QML BusyIndicator: Binding loop detected for property "implicitHeight" spammed in terminal from plasmashell process, but this is not related to this review.
- You are not able to disconnect a connection which is being activated, for example when you accidentally click on one to connect and want to stop it, I don't know if it's super important, but it was there and I'm using it from time to time (wanted to use it right now).
- I'm thinking of not using the busy indicator, it makes the UI to lag and I have been experiencing it recently and it's super annoying, I don't know it's the rendering process or what, but everytime I activate a connection, the UI is super slow until it connects. Might be combination of the busy indicator and something in the background, but not using the busy indicator made it significantly less laggy. Do you experince it as well?
Yeah, the PC3 busy indicator component itself seems to be to blame for items 1 and 3. I'll look into it.
I hadn't really considered #2 as a valid use case while working on the component, but I can look into it.
It was there before, some connections may take a while to connect and if you activated them by mistake, you might avoid the waiting by just disconnecting it. For example in case of wireless connections, other connections might disappear when connecting so you have no way how to connect to the one you want, not until it connects or fails to connect.