Differential D28696

Use std::any_of
ClosedPublic
Actions

Authored by nicolasfella on Apr 9 2020, 8:20 AM.

Details

Reviewers
jgrulich
Group Reviewers
Plasma
Commits
R116:b9d6a4009345: Use std::any_of
Summary

Makes for more idiomatic code. Bumps the required C++ standard to 14 to allow auto in lambdas. Requiring 14 should be fine, KWin alrady requires it.

Diff Detail

Repository
R116 Plasma Network Management Applet
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
nicolasfella created this revision.Apr 9 2020, 8:20 AM
Restricted Application added a project: Plasma. · View Herald TranscriptApr 9 2020, 8:20 AM
Restricted Application added a reviewer: jgrulich. · View Herald Transcript
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
nicolasfella requested review of this revision.Apr 9 2020, 8:20 AM
jgrulich accepted this revision.Apr 9 2020, 8:26 AM
This revision is now accepted and ready to land.Apr 9 2020, 8:26 AM
davidre added a subscriber: davidre.Apr 9 2020, 8:42 AM
davidre added inline comments.
CMakeLists.txt
11

CXX_STANDARD_REQUIRED, too?

kded/notification.cpp
575

const auto&?

Closed by commit R116:b9d6a4009345: Use std::any_of (authored by nicolasfella). · Explain WhyApr 9 2020, 1:30 PM
This revision was automatically updated to reflect the committed changes.
nicolasfella marked 2 inline comments as done.Apr 9 2020, 1:31 PM

Revision Contents
Changeset List

PathPackages
MCMakeLists.txt (3 lines)
Mkded/notification.cpp (16 lines)

Diff 79710

View Options

CMakeLists.txt

Loading...
View Options

kded/notification.cpp

Loading...