As a name "System Monitor Pages" because the display name of the application is System Monitor.

As a prototype I made kglobalaccel use dbus activation (https://specifications.freedesktop.org/desktop-entry-spec/desktop-entry-spec-latest.html#dbus) if the desktop file specifies it is dbus activatable instead of manually parsing Exec fields. Also a patch for spectacle to see how it would work.
https://invent.kde.org/frameworks/kglobalaccel/commit/78baef0af7ec56db115f9e2c726a714a8684761b
https://invent.kde.org/graphics/spectacle/commit/a43c16d395ef5c0f0373ccfa555db783052b6797

Also the last sentence of https://community.kde.org/Plasma/Vision maybe

Change color from view background and window background mix to 100% view background

Yes and I was wondering if one page was maybe enough and not multiple like in the pictures in the top post

I was asking not in a navigational sense but more in a content organizing way. Single Page (current Kirigami.AboutPage) vs. multiple pages/tabs (KAboutDialog)

Do we need tabs? Kirigami.AboutPage can get away with no tabs and the current KAboutDialog is sometimes very small...
The only thing is that old apps sometimes can have very long developer lists, but I would very much love to help with implementation aligning the widgets and Kirigami dialogs (maybe also KAboutPluginDialog?) when it's ready

So once you have a single property you are safe and free to add new properties abi wise no matter the compiler?

Please note that the license that you base your work on is GPL while breeze icons is LGPL

This caused https://bugs.kde.org/show_bug.cgi?id=423003. I removed excluding the virtual method from the build in
https://invent.kde.org/frameworks/krunner/commit/8f7ce559b84ee0c21de0256e6591793e4b95f411

The Konqueror part should be dropped and put into Konq itself imo @dfaure

Is Krunner the only place where it works or are there other places?

It should be in the Seach category imo and not shortcuts. It has nothing to do with keyboard shortcuts.

Do we need Main and alternative which are basically just the same thing twice? There will be of course people who make use of it in their workflow

Did you have any problems with software used? (BigBlueButton and Greenlight)

Sometimes the camera feeds were frozen and I could only unfreeze them by reloading the page

What can be improved in software?

I think it should be possible to see notes and chat at the same time

Was the echo test faster after the first day, also if any one was still having problems with it?

For me it was sometimes faster, sometimes slower without a pattern that I could spot

In my testing dragging a window to a screen with a different scalefactor has no issue and @apol said for him it's better than the status quo. So I would like to land this

In D29408#674966, @meven wrote:

In D29408#674962, @davidre wrote:

I think we shouldn't use QDBUsInterface but given that we already do this is probably ok

The alternative is just less documented AFAICT.
IRC the alternative is about adding xml files that generate code.

I think we shouldn't use QDBUsInterface but given that we already do this is probably ok

Very short nice!

Ping

Ping

In D29487#673809, @meven wrote:

In D29487#673803, @davidre wrote:

Ping. Did you have time to look into

I noticed a flaw however in the current code if the first instance of spectacle is started with --new-instance a second one will always be started when the shortcut is pressed regardless of the setting.

Well it is not a flaw, it is by design.
--new-instance launches an instance without dbus connection and unique instance.
The first one without --new-instance will be the dbus unique instance.

Alright I guess. Should we maybe even hide it from the user visible options then?

Ping. Did you have time to look into

I noticed a flaw however in the current code if the first instance of spectacle is started with --new-instance a second one will always be started when the shortcut is pressed regardless of the setting.

I assume that you mean:

Action after taking a screenshot: [] Save image to default folder location
                                  [] Copy image to clipboard

What about Copy file location to clipboard after saving, would that stay in the Save settings tab?
If yes - we'd have a problem if a users sets both of the checkboxes above and has Copy file location to clipboard after saving also set.

In D29596#672772, @aprcela wrote:

@davidre One other thing I noticed: launch Spectacle with any shortcut (except 'Print' key standalone), for example Shift+Print. Spectacle saves the picture instantaneously but no window of Spectacle opens up, only a notification shows up. Is this also "works as designed" or do/should we change some behavior regarding this one?

I don't think we want to require in source builds

Flickr works here

For the leaks, I really have no idea. (also asked some friends but no help) C++ isn't my primary programming language. If you can share some document/tutorials/examples...

In C++ there is automatic and dynamic storage duration (and some others but you don't need to care about them for now). Automatic is the normal when you write

 void f() {
    int i = 0;
    [complicated code]
}

i is automatically allocated at the start of the function and deallocated at the end of the function. Objects with automatic storage duration are deallocated at the end of the scope they were declared in. You can't use a variable that you declare in a for loop or inside an if block outside of them because the scope they were declared in (the foor loop or the if block) has ended. You can also manually create a scope by wrapping code with braces.

I don't get how saving as a png fails if we have the image as QImage.

In T7266#228761, @ngraham wrote:

I wonder if this could be integrated into the new Global Shortcuts KCM (after renaming it to just "Shortcuts"). We could add a new category called "Common shortcuts" under the Applications section. What do you think, @davidre?

I think it could work. I'm not sure if it should be under Applications. I think it could be missed there. I would introduce a new section called "Common Shortcuts" or "Standard Shortcuts". Then I would like to categorize all current KStandardShortcuts (either in the kcm or on frameworks side) to have multiple things in the category like Editing or Navigation for Example. This would also make it easier to find specific shortcuts.

I didn't review the entire code yet but seems much cleaner. A very welcome refactor!
I noticed a flaw however in the current code if the first instance of spectacle is started with --new-instance a second one will always be started when the shortcut is pressed regardless of the setting.

I fail to see what the kded module actually does. Or is it the case that simply requesting the data from the engine causes it to cache the image on disk? Maybe that should be documented.

do it for all

Do it for every scrollview

Should this go to master, too? Or should we hope that we need the workaround only for 5.18 and 5.19 and the qtbug will be fixed eventually?

.

My idea would be:

Action after taking a screenshot: [] Save
                                  [] Copy

You can select one or both but not none. (Can we do that in a self explanatory way)?
Probably in general settings? And then we could add another checkbox [] Also do that when Spectacle is running

numeric

Use PropertyAction

• fix

In D29625#668203, @davidre wrote:

-1 for khotkeys.

-1 for khotkeys.

Ah I see, the select button will change the pixmap what is saved/copied but not the displayed one?

I would like to keep the option. We currently just start a new `Qprocess with "spectacle" would that still work?

Why do we introduce the distinction between delayed and immediate? Is there a difference between delayed with 0 seconds and immediate? Also every screenshot triggered by the gui arrives at spectacle core with delay <= 0 because ksmainwindow waits the delay for the taskmanager animation and animating the button.

I had a similar idea to have a setting that controls what happens on shortcut press and when gui is running because currently the ui does not work for this. What we have is

Very cool! However I can't seem to figure out a way to select a selection.
How do you think does this relate to D22074? Maybe we can integrate both patches somehow?

So on screen we have the non rectangular pixel perfect pixmap but we return a rectangular pixmap? Which size will that have?

• Rebase without test

Just a heads up you don't need to use the weird lvariable, theParam code style. See discussion in https://phabricator.kde.org/D21042

Why go through QStyle then? We have much more Plasma themes and plasma theme can also be used a quick controls style. The only problem is that in Plasma we want to have two different styles in the same process which is currently not possible. Kai had the idea of a proxy quick controls style which would select the approbiate style plasma or org.kde.desktop depending on if something is part of the shell or not (like the config windows) but that needs investigation if that is possible/feasible.

So you want to remove plasma themes?