Ping. Did you have time to look into

I noticed a flaw however in the current code if the first instance of spectacle is started with --new-instance a second one will always be started when the shortcut is pressed regardless of the setting.

I assume that you mean:

Action after taking a screenshot: [] Save image to default folder location
                                  [] Copy image to clipboard

What about Copy file location to clipboard after saving, would that stay in the Save settings tab?
If yes - we'd have a problem if a users sets both of the checkboxes above and has Copy file location to clipboard after saving also set.

In D29596#672772, @aprcela wrote:

@davidre One other thing I noticed: launch Spectacle with any shortcut (except 'Print' key standalone), for example Shift+Print. Spectacle saves the picture instantaneously but no window of Spectacle opens up, only a notification shows up. Is this also "works as designed" or do/should we change some behavior regarding this one?

I don't think we want to require in source builds

Flickr works here

For the leaks, I really have no idea. (also asked some friends but no help) C++ isn't my primary programming language. If you can share some document/tutorials/examples...

In C++ there is automatic and dynamic storage duration (and some others but you don't need to care about them for now). Automatic is the normal when you write

 void f() {
    int i = 0;
    [complicated code]
}

i is automatically allocated at the start of the function and deallocated at the end of the function. Objects with automatic storage duration are deallocated at the end of the scope they were declared in. You can't use a variable that you declare in a for loop or inside an if block outside of them because the scope they were declared in (the foor loop or the if block) has ended. You can also manually create a scope by wrapping code with braces.

I don't get how saving as a png fails if we have the image as QImage.

In T7266#228761, @ngraham wrote:

I wonder if this could be integrated into the new Global Shortcuts KCM (after renaming it to just "Shortcuts"). We could add a new category called "Common shortcuts" under the Applications section. What do you think, @davidre?

I think it could work. I'm not sure if it should be under Applications. I think it could be missed there. I would introduce a new section called "Common Shortcuts" or "Standard Shortcuts". Then I would like to categorize all current KStandardShortcuts (either in the kcm or on frameworks side) to have multiple things in the category like Editing or Navigation for Example. This would also make it easier to find specific shortcuts.

I didn't review the entire code yet but seems much cleaner. A very welcome refactor!
I noticed a flaw however in the current code if the first instance of spectacle is started with --new-instance a second one will always be started when the shortcut is pressed regardless of the setting.

I fail to see what the kded module actually does. Or is it the case that simply requesting the data from the engine causes it to cache the image on disk? Maybe that should be documented.

do it for all

Do it for every scrollview

Should this go to master, too? Or should we hope that we need the workaround only for 5.18 and 5.19 and the qtbug will be fixed eventually?

.

My idea would be:

Action after taking a screenshot: [] Save
                                  [] Copy

You can select one or both but not none. (Can we do that in a self explanatory way)?
Probably in general settings? And then we could add another checkbox [] Also do that when Spectacle is running

numeric

Use PropertyAction

• fix

In D29625#668203, @davidre wrote:

-1 for khotkeys.

-1 for khotkeys.

Ah I see, the select button will change the pixmap what is saved/copied but not the displayed one?

I would like to keep the option. We currently just start a new `Qprocess with "spectacle" would that still work?

Why do we introduce the distinction between delayed and immediate? Is there a difference between delayed with 0 seconds and immediate? Also every screenshot triggered by the gui arrives at spectacle core with delay <= 0 because ksmainwindow waits the delay for the taskmanager animation and animating the button.

I had a similar idea to have a setting that controls what happens on shortcut press and when gui is running because currently the ui does not work for this. What we have is

Very cool! However I can't seem to figure out a way to select a selection.
How do you think does this relate to D22074? Maybe we can integrate both patches somehow?

So on screen we have the non rectangular pixel perfect pixmap but we return a rectangular pixmap? Which size will that have?

• Rebase without test

Just a heads up you don't need to use the weird lvariable, theParam code style. See discussion in https://phabricator.kde.org/D21042

Why go through QStyle then? We have much more Plasma themes and plasma theme can also be used a quick controls style. The only problem is that in Plasma we want to have two different styles in the same process which is currently not possible. Kai had the idea of a proxy quick controls style which would select the approbiate style plasma or org.kde.desktop depending on if something is part of the shell or not (like the config windows) but that needs investigation if that is possible/feasible.

So you want to remove plasma themes?

Can you add some more explanation what the code does in the summary?

Superseeded by total rewrite of the kcm

In D28744#659447, @ngraham wrote:

I find that I'm not able to set shortcuts involving the space key. The key sequence get repeated twice in the button and the Apply button ever becomes enabled. Can you reproduce?

Couldn't we put the tray icon in the plasma theme?

• Reinstate the pointingHand mouseAreas
• Make delegate automatically expand if it's the only one

• Make the delegate use states

I did some digging and think that things should be repainted when they change screen
https://code.woboq.org/qt5/qtbase/src/widgets/kernel/qwidgetwindow.cpp.html#_ZN13QWidgetWindow18handleScreenChangeEv

Yeah I don't think we are going to just randomly change that many constants based on two screenshots. This needs a wide discussion imo with what goals to achieve and the problems with the current breeze and much more comparisons.

rebasae

• Use model.* properties
• Use placeholder message
• Still don't know why model properties are undefined when switching components

In T10568#228110, @ach wrote:

FWIW I agree with David argument in the bug report and to reject the suggestion for 2 more global shortcuts.

Nevertheless you have IMHO a valid point: hard discoverability. The global shortcut
settings page could be enhanced. Enhancing this would not only help others finding
you personal favourite feature(s) but all others too.

Adding 'User Feedback' what global shortcuts people really set, could help in
future decision what action is probably a candidate for a global shortcut.

stay healthy, Achim

In D29140#656817, @guoyunhe wrote:

To totally solve the issue, there are several solutions I can find:

1. POTD need to have a daemon process that can always access network. The lock screen send request to the daemon through DBus or other protocol.
2. Create an invisible lock screen widget in the desktop, so it fetches and updates the POTD even before screen locks.
   
   The second option is much easier to do. Both will cause some performance impact.

Actually everything in the sidebad is very blurry at 2x

In D29154#656690, @apol wrote:

This is what it looks like for me with the patch applied.

scale 1x:

scale 2x:

master:
scale 1x:

scale 2x:

I can see a noticeable wonky-ness on 1x master, so I'd say this patch helps.

Maybe todo remove?

In D29154#656585, @apol wrote:

+1

I did the same thing for kirigami @ D29100 and plasma-framework @ D29102 yesterday after looking at Qt's code and assessing it was the right thing to do.
I am not familiar with Breeze's code but the patch is sound.

I do have all of the dpis so if you tell me how I'll test it.

This should probably fix the BUG 418869.

Correct code style when I'm touching these lines either way