Feed Advanced Search

Today

davidre added a comment to D27540: Status indicator for individual widgets in KCModule.

How does it look? Will this be opt in for other users of KConfigDialogManager?

I'd say you should try it. ;-)
I really need wider feedback on how it behaves in different context. Currently the patch makes it mandatory for everyone.

I use KConfigDialogManager to manage the settings in Spectacle MainWindow which are instant apply by
connect(mConfigManager, &KConfigDialogManager::widgetModified, mConfigManager, &KConfigDialogManager::updateSettings); and I don't like it that they appear there too

You mean they appear and stick around? Or they appear/disappear immediately?
If they stick around I'd indeed have to check why the state isn't recomputed on the updateSettings call...

a setting which is currently dirty or which differs from default value.

What is your idea behind this? After first seeing this patch my intuition was that it would show for unsaved changes. But then I was confused when I open a SettingsDialog that there were already marks even though I changed nothing! I would expect them only for unsaved changes, I don't know how other platforms handle this if they have something similiar?

Currently it helps the user find out the unsaved changes (the least useful in some way, or your immediate memory is not good) but it also helps the user find out which of her settings differ from the default values (and that's indeed something you will forget over time and wonder "why the hell is the defaults button enabled").

Hope the extra context helps.

Fri, Feb 21, 1:19 PM · Frameworks
davidre added a reviewer for D27540: Status indicator for individual widgets in KCModule: VDG.
Fri, Feb 21, 12:17 PM · Frameworks
davidre added a comment to D27540: Status indicator for individual widgets in KCModule.

How does it look? Will this be opt in for other users of KConfigDialogManager?

I'd say you should try it. ;-)
I really need wider feedback on how it behaves in different context. Currently the patch makes it mandatory for everyone.

Fri, Feb 21, 12:16 PM · Frameworks
davidre added a comment to D27540: Status indicator for individual widgets in KCModule.

The editmarks should probably respect the visibility of the associated widget. In this picture I use a invisble lineedit to manage the settings of the QButtonGroup beneath (QButtonGroup isn't supported by KCOnfigDialogManager)

Fri, Feb 21, 12:08 PM · Frameworks
davidre added a comment to D27540: Status indicator for individual widgets in KCModule.

How does it look? Will this be opt in for other users of KConfigDialogManager?

Fri, Feb 21, 11:49 AM · Frameworks
davidre added a comment to D27035: [KMessageWidget] Draw it with QPainter instead of using stylesheet.

So I think this is ready to be merged and I would do so this weekend

Fri, Feb 21, 7:59 AM · Frameworks
davidre added inline comments to D27373: Port general settings and save setting to ui files.
Fri, Feb 21, 7:49 AM · Spectacle
davidre committed R166:e8b4c291cc2d: Use KConfigDialogManager to manage main window settings (authored by davidre).
Use KConfigDialogManager to manage main window settings
Fri, Feb 21, 7:37 AM
davidre closed D27415: Use KConfigDialogManager to manage main window settings.
Fri, Feb 21, 7:37 AM · Spectacle
davidre updated the summary of D27415: Use KConfigDialogManager to manage main window settings.
Fri, Feb 21, 7:36 AM · Spectacle

Yesterday

davidre committed R94:009a3bb37129: Use "mail-mark-important" icon consistently (authored by davidre).
Use "mail-mark-important" icon consistently
Thu, Feb 20, 9:16 AM
davidre closed D27507: Use "mail-mark-important" icon consistently.
Thu, Feb 20, 9:16 AM · KDE PIM

Wed, Feb 19

davidre added a reviewer for D27421: [Cuttleffish] Use proper QSortFilterProxyModel: Plasma.
Wed, Feb 19, 8:24 PM · Plasma
davidre updated the diff for D27035: [KMessageWidget] Draw it with QPainter instead of using stylesheet.

Code style and typos

Wed, Feb 19, 6:45 PM · Frameworks
davidre added a reviewer for D27507: Use "mail-mark-important" icon consistently: VDG.
Wed, Feb 19, 3:46 PM · KDE PIM
davidre retitled D27507: Use "mail-mark-important" icon consistently from Use "mail-mark-important" consistently to Use "mail-mark-important" icon consistently.
Wed, Feb 19, 3:46 PM · KDE PIM
davidre updated the summary of D27507: Use "mail-mark-important" icon consistently.
Wed, Feb 19, 3:41 PM · KDE PIM
davidre added reviewers for D27507: Use "mail-mark-important" icon consistently: KDE PIM, mlaurent.
Wed, Feb 19, 3:40 PM · KDE PIM
davidre requested review of D27507: Use "mail-mark-important" icon consistently.
Wed, Feb 19, 3:39 PM · KDE PIM
davidre added a comment to D27481: Panel spacer that can center things.

I think the deisgn og the spacer could be better in edit mode to clearly mark it as a spacer but that can be done in the future if desired.

Wed, Feb 19, 3:01 PM · Plasma
davidre added a comment to D27481: Panel spacer that can center things.

I think the deisgn og the spacer could be better in edit mode to clearly mark it as a spacer but that can be done in the future if desired.

Wed, Feb 19, 1:27 PM · Plasma
davidre added a comment to D27463: KconfigXT: Add a value attribute to Enum field choices.

Could you also add documentation to whatever https://api.kde.org/frameworks/kconfig/html/kconfig_compiler.html is generated from?

Wed, Feb 19, 8:55 AM · Frameworks

Tue, Feb 18

davidre added a comment to D27484: Set application display name to non-lowercase variant (& typo fixed).

I would push to release/19.12, given this is also a typo fix, okay?

Tue, Feb 18, 9:31 PM
davidre added a comment to D27470: Set good default value for cursor theme and size in KRDB.

This looks like a good kcms to convert to KConfigXT...

Tue, Feb 18, 9:43 AM · Plasma
davidre added a comment to D27450: Refresh developer page.

Can you explain the process of choosing which frameworks to highlight?

Why are we listing flatpack as the first deployment option and distros last? Is the order random or do you want to show a preference here?

For frameworks, 3 of them were suggested by Carson Black. And the other were mentioned in a couple of places outside api.kde.org . I guess you can consider that the choosing was random

for packaging, It was random. Pls suggest the preference order so that I can make the necessary changes

Tue, Feb 18, 9:14 AM

Mon, Feb 17

davidre added a comment to T12716: Standardize Qt logging categories used in KF.

Very well thought through proposal! +

Mon, Feb 17, 9:37 PM · Frameworks
davidre added a comment to D27465: Make the icon hitboxes for the System Tray Plasmoid larger when Kirigami Tablet Mode is enabled.

Do your second step here imo

Mon, Feb 17, 8:58 PM · Plasma
davidre added a comment to D27463: KconfigXT: Add a value attribute to Enum field choices.

If you touch the xsd do you neeed to increase the version number?

Mon, Feb 17, 7:56 PM · Frameworks
davidre added a comment to D27438: Increase System Tray Plasmoid spacing value slightly.

There is now not clickable space between items:


At least it should be clickable

For future reference, how do you get that size examining mode in Plasma Desktop Workspace?

Mon, Feb 17, 5:31 PM · Plasma
davidre requested changes to D27438: Increase System Tray Plasmoid spacing value slightly.

There is now not clickable space between items:


At least it should be clickable

Mon, Feb 17, 9:08 AM · Plasma
davidre added a comment to T12708: Drop units singleton being exported from the Kirigami desktop theme plugin.

units is the id of the Object in the org.kde.desktop style (and in the default units file). But that is not true for all styles: In kirigamiplasmadesktopstyle it's unitsRoot and in kirigamiplasmastyle it doesn't have an id. The proper way to acess Units is through Kirigami.Units. If you are using plasma.core it also clashes with units. (I hope that's correct)

Mon, Feb 17, 8:59 AM · KF6
davidre requested changes to D24375: [kcms/colors] Generate colored GTK2 assets based off of user's colorscheme.
Mon, Feb 17, 8:50 AM · Plasma
davidre added inline comments to D27450: Refresh developer page.
Mon, Feb 17, 8:50 AM
davidre added a comment to D27450: Refresh developer page.

Can you explain the process of choosing which frameworks to highlight?

Mon, Feb 17, 8:47 AM
davidre added a comment to D24375: [kcms/colors] Generate colored GTK2 assets based off of user's colorscheme.

Can we not add more stuff to krdb, please?

Mon, Feb 17, 8:40 AM · Plasma

Sun, Feb 16

davidre added a comment to D27442: fix(kcm): use explicit Kirigami.Units over singleton from a theme.

I think the commit message got bit messed up David, pls fix before commiting :)

Sun, Feb 16, 7:25 PM · Plasma
davidre added a comment to D27438: Increase System Tray Plasmoid spacing value slightly.

After clicking through the before after I still think it's to much

Sun, Feb 16, 7:22 PM · Plasma
davidre added a comment to D27438: Increase System Tray Plasmoid spacing value slightly.

I think 0 doesn't look cramped at all. Increasing the spacing also increases the space usage . -1 from me

Sun, Feb 16, 5:50 PM · Plasma
davidre added a comment to D27415: Use KConfigDialogManager to manage main window settings.

I guess? Note that I authored this diff :)

Sun, Feb 16, 8:05 AM · Spectacle

Sat, Feb 15

davidre committed R118:86d2622b581c: Remove unused (authored by davidre).
Remove unused
Sat, Feb 15, 12:31 PM
davidre updated the diff for D27421: [Cuttleffish] Use proper QSortFilterProxyModel.

Add new files

Sat, Feb 15, 11:48 AM · Plasma
davidre requested review of D27421: [Cuttleffish] Use proper QSortFilterProxyModel.
Sat, Feb 15, 11:47 AM · Plasma
davidre committed R120:22dd942bf70e: Merge branch 'Plasma/5.18' (authored by davidre).
Merge branch 'Plasma/5.18'
Sat, Feb 15, 11:38 AM

Fri, Feb 14

davidre requested review of D27415: Use KConfigDialogManager to manage main window settings.
Fri, Feb 14, 5:11 PM · Spectacle
davidre updated the diff for D27035: [KMessageWidget] Draw it with QPainter instead of using stylesheet.

remove debug remains

Fri, Feb 14, 4:53 PM · Frameworks
davidre updated the diff for D27035: [KMessageWidget] Draw it with QPainter instead of using stylesheet.

Explicitly set TextColor and palettes of the labels and react to parent changes . For example necessary for konsole
that uses stylesheet which break palette propagation and reparents the widget after creation.

Fri, Feb 14, 4:51 PM · Frameworks
davidre added a comment to D27380: [GTK Config] Construct font style by hand instead of relying on Qt function.

Stretch is in https://doc.qt.io/qt-5/qfont.html#Stretch-enum

Fri, Feb 14, 8:50 AM · Plasma

Thu, Feb 13

davidre committed R296:d9b52d900471: Fix size of the header in GridViewKCM (authored by davidre).
Fix size of the header in GridViewKCM
Thu, Feb 13, 8:52 PM
davidre closed D27315: Fix size of the header in GridViewKCM.
Thu, Feb 13, 8:52 PM · Frameworks
davidre committed R120:a58bbc050723: Don't delay ksplash until the entire slideshow is loaded (authored by davidre).
Don't delay ksplash until the entire slideshow is loaded
Thu, Feb 13, 8:48 PM
davidre closed D27084: Don't delay ksplash until the entire slideshow is loaded.
Thu, Feb 13, 8:48 PM · Plasma
davidre committed R166:0c996daac97a: Don't return early out of the constructor (authored by davidre).
Don't return early out of the constructor
Thu, Feb 13, 4:32 PM
davidre added a reviewer for D27373: Port general settings and save setting to ui files: ngraham.
Thu, Feb 13, 4:09 PM · Spectacle
davidre updated the diff for D27373: Port general settings and save setting to ui files.

remove unused variable

Thu, Feb 13, 4:08 PM · Spectacle
davidre requested review of D27373: Port general settings and save setting to ui files.
Thu, Feb 13, 3:58 PM · Spectacle

Wed, Feb 12

davidre added a comment to T12691: Upstream QML configuration window code so it can be used by QML-based apps.

For reference the dialog from plasma-framework:
https://cgit.kde.org/plasma-framework.git/tree/src/plasmaquick/configview.h

Wed, Feb 12, 9:22 PM · Elisa, Plasma, Kirigami

Tue, Feb 11

davidre added a comment to D27084: Don't delay ksplash until the entire slideshow is loaded.

Ping

Tue, Feb 11, 10:42 AM · Plasma
davidre added a reviewer for D27315: Fix size of the header in GridViewKCM: broulik.
Tue, Feb 11, 10:32 AM · Frameworks
davidre requested review of D27315: Fix size of the header in GridViewKCM.
Tue, Feb 11, 10:31 AM · Frameworks

Mon, Feb 10

davidre committed R113:1c3884a79b30: Use defaults of KColorSchemeManager in ColorSchemeChooser (authored by davidre).
Use defaults of KColorSchemeManager in ColorSchemeChooser
Mon, Feb 10, 9:59 AM
davidre added a comment to D27272: Add status icons: data-error, data-warning, data-information.

I think the emblem icons look great in your "After" screenshot.

Wouldn't it be easier to have KDevelop use these emblem icons from their current names rather than symlinking the icons you want to use to new files with different names? Semantically it seems wrong; status icons are monochrome and use the action icon style. See https://hig.kde.org/style/icons/action_status.html.

Mon, Feb 10, 8:44 AM · Frameworks

Fri, Feb 7

davidre added a comment to T12667: Many duplicates apps.

As I said on Telegram, consistency is not merging two on the outside similar looking things. It's making our software look and behave in similar ways like having reusable components and solutions or the most common elements (hello Frameworks!). The same is true for KParts using this technology we can build applications that all serve their specific purpose but have the same look and behavior of their core part (for example Konsole and Yakuake). Of course you could merge all these apps but that way you end up with behemoths of apps with giant codebases and complicated configuration options to support all possible use cases with code that is overly complex and brittle because of said options.

Fri, Feb 7, 6:56 PM · Goal: Consistency
davidre retitled D27084: Don't delay ksplash until the entire slideshow is loaded from Don't delay ksplash until the entire lideshow is loaded to Don't delay ksplash until the entire slideshow is loaded.
Fri, Feb 7, 3:42 PM · Plasma
davidre added a comment to D27084: Don't delay ksplash until the entire slideshow is loaded.

Ping

Fri, Feb 7, 3:42 PM · Plasma
davidre added a comment to D27035: [KMessageWidget] Draw it with QPainter instead of using stylesheet.

Ping, how should I proceed?

Fri, Feb 7, 3:41 PM · Frameworks
davidre committed R118:bd130c6b0225: [Cuttlefish] Remove last traces of themes and plasma themes (authored by davidre).
[Cuttlefish] Remove last traces of themes and plasma themes
Fri, Feb 7, 3:34 PM
davidre closed D27136: [Cuttlefish] Remove last traces of themes and plasma themes.
Fri, Feb 7, 3:34 PM · Plasma
davidre added a comment to D25123: New yakuake logo/icon.

If you land this please update the summary before. No need to have all the variants in the commit message it should be about the actual change. Thanks :)

Fri, Feb 7, 7:55 AM · Yakuake, Frameworks

Wed, Feb 5

davidre committed R166:3d2447435d3e: Set the current capture mode index at the end of the constructor of KSWidget (authored by davidre).
Set the current capture mode index at the end of the constructor of KSWidget
Wed, Feb 5, 1:44 PM

Mon, Feb 3

davidre requested review of D27136: [Cuttlefish] Remove last traces of themes and plasma themes.
Mon, Feb 3, 5:38 PM · Plasma
davidre committed R118:ab316a3fd9db: Merge branch 'Plasma/5.18' (authored by davidre).
Merge branch 'Plasma/5.18'
Mon, Feb 3, 3:06 PM
davidre committed R118:fcd8b650d119: [Cuttlefish] --warnings (authored by davidre).
[Cuttlefish] --warnings
Mon, Feb 3, 3:04 PM
davidre closed D27128: [Cuttlefish] --warnings.
Mon, Feb 3, 3:04 PM · Plasma
davidre updated the summary of D27128: [Cuttlefish] --warnings.
Mon, Feb 3, 2:58 PM · Plasma
davidre requested review of D27128: [Cuttlefish] --warnings.
Mon, Feb 3, 2:21 PM · Plasma

Sun, Feb 2

davidre added a comment to D26951: Remove old code that is not used anymore.

I just took a look at KSelector and it actually inherits minimum and maximum properties from QAbstractSlider so we could just drop these custom properties for KF6

Sun, Feb 2, 2:11 PM · Frameworks
davidre closed D26951: Remove old code that is not used anymore.
Sun, Feb 2, 1:56 PM · Frameworks
davidre committed R265:db859852b577: Remove old code that is not used anymore (authored by davidre).
Remove old code that is not used anymore
Sun, Feb 2, 1:56 PM
davidre updated the diff for D26951: Remove old code that is not used anymore.

Update comment

Sun, Feb 2, 1:46 PM · Frameworks

Sat, Feb 1

davidre added a comment to D27093: Provide better name for GTK Settings Sync service.

I would drop the KDE/Qt Part because the settings are not specific to them but general settings and this service is needed to apply those settings to some applications. So "Applies Settings to Gnome/GTK applications'

Sat, Feb 1, 9:42 PM · Plasma
davidre updated the summary of D27084: Don't delay ksplash until the entire slideshow is loaded.
Sat, Feb 1, 9:38 AM · Plasma
davidre requested review of D27084: Don't delay ksplash until the entire slideshow is loaded.
Sat, Feb 1, 9:36 AM · Plasma

Fri, Jan 31

davidre added a comment to D27035: [KMessageWidget] Draw it with QPainter instead of using stylesheet.

Something like this:

Fri, Jan 31, 3:32 PM · Frameworks
davidre added a comment to D27035: [KMessageWidget] Draw it with QPainter instead of using stylesheet.

Uh-oh, now it looks like this in Konsole:

Compare to the current appearance:

I recall wrestling with this issue in D12508. Might be worth looking over that.

Fri, Jan 31, 1:49 PM · Frameworks
davidre accepted D27064: API dox: tell default values of KMessageWidget's wordWrap/closeButtonVisible.
Fri, Jan 31, 1:37 PM · Frameworks
davidre added inline comments to D27064: API dox: tell default values of KMessageWidget's wordWrap/closeButtonVisible.
Fri, Jan 31, 1:30 PM · Frameworks
davidre added a comment to D27035: [KMessageWidget] Draw it with QPainter instead of using stylesheet.

Better :) with corners I mean the 1-3 pixels left due to the rounding corners. These pixels were once also drawn as background although they are outside of the frame. It may be a minor detail, but imho such details are important. But indeed, the screenshots look good.

Next test: open a file in kate. Now either change the file externally or delete it. Kate should show an animated KMessageWidget. Does it also correctly work with a small kate? I.e. small width of kate window?

Fri, Jan 31, 12:34 PM · Frameworks
davidre updated the diff for D27035: [KMessageWidget] Draw it with QPainter instead of using stylesheet.

Use parentWidget()

Fri, Jan 31, 12:33 PM · Frameworks
davidre added inline comments to D27035: [KMessageWidget] Draw it with QPainter instead of using stylesheet.
Fri, Jan 31, 12:33 PM · Frameworks
davidre awarded D27036: KApiDox: add "Plasma Workspaces Libraries" group info a Like token.
Fri, Jan 31, 12:19 PM · Plasma
davidre committed R166:a9c01acfaf66: Take screenshot with currently selected options (authored by davidre).
Take screenshot with currently selected options
Fri, Jan 31, 10:03 AM
davidre closed D26929: Take screenshot with currently selected options.
Fri, Jan 31, 10:03 AM · Spectacle
davidre added a comment to D26929: Take screenshot with currently selected options.

It's harder to fix because on 19.12 we save not the last capture mode but the index of the combobox which doesn't map directly to the capture mode. And I don't want to change what's being saved in the config on stable or duplicate the combobox mapping here (which also is broken) so I will push this only to master

Fri, Jan 31, 10:02 AM · Spectacle
davidre updated the summary of D26929: Take screenshot with currently selected options.
Fri, Jan 31, 9:59 AM · Spectacle

Thu, Jan 30

davidre added inline comments to D27035: [KMessageWidget] Draw it with QPainter instead of using stylesheet.
Thu, Jan 30, 11:20 PM · Frameworks
davidre added a comment to D27035: [KMessageWidget] Draw it with QPainter instead of using stylesheet.

Kate with this patch and Oxygen style:


The misplacement I spotted earlier is specific to QtCurve and also happens with the current KMessageWidget.

Thu, Jan 30, 5:18 PM · Frameworks
davidre updated the diff for D27035: [KMessageWidget] Draw it with QPainter instead of using stylesheet.

Draw opaque and mix the colors manually again.

Thu, Jan 30, 5:11 PM · Frameworks
davidre updated the diff for D27039: [KStyle] Set the color of KMessageWidgets to the correct one from the current color scheme.

Fix code style

Thu, Jan 30, 5:09 PM · Frameworks
davidre added a comment to D27035: [KMessageWidget] Draw it with QPainter instead of using stylesheet.

Does that also work in Kate for floating messages like when the search wraps? What I want to know is whether the corners behind the green frame are transparent in this case, or whether the corners are painted solid. If I remember correctly, these kind of bugs were the reason to use Qt StyleSheets. And it must work with all styles.

Please do NOT yet commit, especially since we'd only have two days of testing period: Saturday, 1st of February is the next frameworks tag.

Thu, Jan 30, 4:51 PM · Frameworks
davidre added a comment to D27035: [KMessageWidget] Draw it with QPainter instead of using stylesheet.

Does that also work in Kate for floating messages like when the search wraps? What I want to know is whether the corners behind the green frame are transparent in this case, or whether the corners are painted solid. If I remember correctly, these kind of bugs were the reason to use Qt StyleSheets. And it must work with all styles.

Please do NOT yet commit, especially since we'd only have two days of testing period: Saturday, 1st of February is the next frameworks tag.

Should or shouldn't it be transparent? Also I don't understand which part should be transparent and which shouldn't? The border was never transparent and the background also not. Screenshots:

Thu, Jan 30, 4:46 PM · Frameworks