In D23162#512165, @ngraham wrote:

Thanks very much for the patch!

For patches that change the UI, it's customary to add a screenshot to the Test Plan section -- or even better, a video depicting it being used! Also the summary section is a good place to explain what your patch does, what problems it's solving, why you did it the way you did, etc.

In terms of behavior, maybe it would make sense to re-work the config UI so that each option has a radio button, and then only one can be active at once. Also, While this feature is on, I wonder if it makes sense to disable the Copy to Clipboard button on the main UI, since the screenshot will always be copied automatically.

+1 to radio buttons.
I would not disable the button since you could always want to copy the screenshot again after copying something else

Thanks! I also thought about adding such a functionality.

In D23080#510815, @ngraham wrote:

IMO the ideal state of affairs would be to somehow emulate the colors of the standard Qt tab widget:

Not too contrasty, but not too subtle either.

Should this set sectionDelegate: true and not expose this to the outside?

Can we revisit this? If you are notified about multiple mails there is no way to get from the notification to KMail currently since no buttons are shown.

Something to look out for https://phabricator.kde.org/D22684?vs=62444&id=63145

restore me as the author

That should work

Arc mess up

Rework

• Use virtual desktops kcm list style and Kirigami actions
• Remove info button. The copyright info can be accessed by clicking on the item

In T10968#193645, @KonqiDragon wrote:

Maybe make a app pages with homepages style like in Konsole? Where everything will be written about this programs.

Boring:

Kool:

We have many apps and not all of them have the manpower to do this. The kde.org/applications are autogenerated. If all apps had pages with manually written content many of them would be quickly out of date again. See also the list in T10827.
Because of this the current approach is better. Autogenerated sites for all apps and for the apps that have their own website and the manpower to maintain them we link to it.

So the alternative approach would be something like this:

diff --git a/src/qmlcontrols/kcmcontrols/qml/ScrollView.qml b/src/qmlcontrols/kcmcontrols/qml/ScrollView.qml
index 8ef57a2..443f063 100644
--- a/src/qmlcontrols/kcmcontrols/qml/ScrollView.qml
+++ b/src/qmlcontrols/kcmcontrols/qml/ScrollView.qml
@@ -48,14 +48,28 @@ QtControls.ScrollView {
     onViewChanged: {
         view.parent = scroll;
         view.anchors.fill = view.parent;
+        setMargins();
     }

Sorry my bad, I misread the diff. I thought you added a new flag (as proposed above) and looked at exportGtkTheme but that flag is an existing one. And to my shame it doesn't even have a green background.

It seems the header with the new flag is missing from the diff.

@kossebau also wrote

An alternative approach could be to set the respective anchor.*margin to view.parent.*padding.

Commit message

Last touches

• remove QDebug
• don't restore image if we are in random mode
• if we have seen all images generate a new random order

Thanks

Also update description

I don't know, I just saw that the name was wrong.
But maybe we could just use "Screenshot capture utility" as does the desktop file.

Would love to have more feedback on this

Ping? Maybe @davidedmundson has insight why it is only added to the history if the app quits

How can we move this forward? Are there things I overlooked? Is it sill crashing sometimes? Code comments?

String freeze is in two days if I'm reading https://community.kde.org/Schedules/Applications/19.08_Release_Schedule correctly.

Can we get this into 19.08?

In T11124#191741, @ndavis wrote:

Thanks, can you give me an example of an application where I can find this behavior? I can't find anything in the applications I have installed.

Some of the Buttons in Spectacle are Toolbuttons instead of Pushbuttons. Namely "Save" and "Copy to Clipboard"

Yes you're right, I think I retestet the wrong version. However pasting still works.
It seems related to shortly quitting after copying. If I add
QTimer::singleShot(250, &QApplication::quit); to imageExported it appears in the history, but then we can't show the notification.

Break line

For me it is the same behavior as master:

• If you copy and quit on copy is checked it shows up in the history
• If you copy and then exit manually it doesn't show up in the history but you can still paste it (for example into KolourPaint)

Notice that you have to check "Avoid empty clipboard" in Klipper settings. I think we came to the conclusion that this is the same behavior as for text.

• Only restore wallpaper on startup
• Guard against empty path

I couldn't understand why this was being called with an empty string so I just guard
against it at the call site. Maybe this also helps @ngrahams crash but I still don't know
where it is coming from.

rebase
Now that we fixed Klipper this should work

• Also hide when onClick is checked

• Update comment

In D22148#493852, @ngraham wrote:

I think this is fine. Let's get it into 19.08.0. Thanks a lot, @davidre!

Any more comments? I think we have to get this into 19.08

• fuzzyisnull

MS Windows style only draws the border if the state of the toolbutton is raised. This is different compared to the other tyles I checked which draw them exactly the same for None, Enabled and Raised.

• remove autogenerated line in license and superfluous NoPen call
• Draw the button raised

So I'm crashing when I hit apply and then ok because addURL is called from qml with an empty string and I don't understand why. In main.qml I have

onConfiguredImageChanged: {
      if (modelImage != configuredImage) {
          console.log("configured Image" + wallpaper.configuration.Image);
          console.log(configuredImage + "!=" + modelImage)
          imageWallpaper.addUrl(configuredImage);
      }
  }
  onModelImageChanged:{
      Qt.callLater(loadImage);
      console.log("mic to "+modelImage);
      wallpaper.configuration.Image = modelImage;
      console.log("mic:" + wallpaper.configuration.Image +" configimage:" +configuredImage);

I may have introduced a similar crash or made it easier to trigger Nate's crash.

With MS Windows 9x as widget style the Button is missing it's border.

• Remember current slide between starts

In D22121#492179, @msdobrescu wrote:

Thanks, selecting from any image is useful, to avoid starting always from the top one. But should not enable the button until a check is done.

Ideally if you want a specific image you should use a static wallpaper. But I see what you mean, I think it would be useful to remember the current slide between restarts.

In D22121#492173, @msdobrescu wrote:

I'd say it is some half-implemented feature, probably. Could it be useful to navigate by keyboard and check/uncheck images, by using space, for example?