Feed Advanced Search

Yesterday

davidre requested review of D25846: [Cuttlefish] Use the same actions in all menus.
Tue, Dec 10, 2:20 PM · Plasma
davidre committed R118:e56bc283019f: [Cuttlefish] Set context properties before loading file (authored by davidre).
[Cuttlefish] Set context properties before loading file
Tue, Dec 10, 2:03 PM
davidre closed D25841: [Cuttlefish] Set context properties before loading file.
Tue, Dec 10, 2:03 PM · Plasma
davidre committed R118:43c4d215bd5e: [Cuttlefish] Replace deprectated method KDeclarative::setupBindings() (authored by davidre).
[Cuttlefish] Replace deprectated method KDeclarative::setupBindings()
Tue, Dec 10, 1:20 PM
davidre closed D25842: [Cuttlefish] Replace deprectated method KDeclarative::setupBindings().
Tue, Dec 10, 1:20 PM · Plasma
davidre requested review of D25842: [Cuttlefish] Replace deprectated method KDeclarative::setupBindings().
Tue, Dec 10, 12:44 PM · Plasma
davidre updated the diff for D25841: [Cuttlefish] Set context properties before loading file.

codestyle++

Tue, Dec 10, 12:27 PM · Plasma
davidre requested review of D25841: [Cuttlefish] Set context properties before loading file.
Tue, Dec 10, 12:25 PM · Plasma

Sun, Dec 8

davidre added a comment to T12276: Remove KConcatenateRowsProxyModel.

As per the api docs you can QConcatenateTablesProxyModel starting with Qt 5.13

Sun, Dec 8, 9:15 AM · KF6
davidre committed R118:5f9d11836097: [Cuttlefish] Make it clear that picker mode still works (authored by davidre).
[Cuttlefish] Make it clear that picker mode still works
Sun, Dec 8, 9:13 AM
davidre closed D25806: [Cuttlefish] Make it clear that picker mode still works.
Sun, Dec 8, 9:13 AM · Plasma

Sat, Dec 7

davidre added reviewers for D25806: [Cuttlefish] Make it clear that picker mode still works: Plasma, cblack, ngraham.
Sat, Dec 7, 11:17 PM · Plasma
davidre requested review of D25806: [Cuttlefish] Make it clear that picker mode still works.
Sat, Dec 7, 11:17 PM · Plasma

Fri, Dec 6

davidre committed R166:d91ed7254b29: Remove width and height from appstream image tag (authored by davidre).
Remove width and height from appstream image tag
Fri, Dec 6, 8:17 PM
davidre committed R166:1bda1379a19c: Use up-to-date Screenshot in appstream xml file (authored by davidre).
Use up-to-date Screenshot in appstream xml file
Fri, Dec 6, 7:57 PM
davidre committed R234:2581b01775e7: Use screenshot with English Ui (authored by davidre).
Use screenshot with English Ui
Fri, Dec 6, 1:39 PM
davidre committed R234:286a37064ea6: Add spectacle (authored by davidre).
Add spectacle
Fri, Dec 6, 1:25 PM
davidre updated the diff for D23316: Port towards KConfig XT.

Rebase once more

Fri, Dec 6, 8:20 AM · Spectacle
davidre added a comment to D23316: Port towards KConfig XT.

All functionality works perfectly for me. However this regressed the default width of the settings window. Not it's not wide enough to accommodate all controls without an ugly horizontal scrollbar:

Fri, Dec 6, 8:17 AM · Spectacle
davidre requested changes to D23446: Shortcuts displayed in capture mode ComboBox.
Fri, Dec 6, 8:11 AM · Spectacle
davidre added a comment to D23446: Shortcuts displayed in capture mode ComboBox.

I still think this a cool feature, but I have the feeling this can be done in a much shorter patch. This seems to me a bit like overkill. Would be awesome if maybe somebody else could weigh in.

Fri, Dec 6, 8:07 AM · Spectacle
davidre accepted D23723: Save image to clipboard if --nonotify is used.
Fri, Dec 6, 7:58 AM · Spectacle

Thu, Dec 5

davidre committed R166:f5a8279feb8e: Merge branch 'release/19.12' (authored by davidre).
Merge branch 'release/19.12'
Thu, Dec 5, 3:20 PM
davidre closed D25765: Fix issue preventing spectacle from opening.
Thu, Dec 5, 3:18 PM · Spectacle
davidre committed R166:a9f1e8557038: Fix issue preventing spectacle from opening (authored by davidre).
Fix issue preventing spectacle from opening
Thu, Dec 5, 3:18 PM
davidre requested review of D25765: Fix issue preventing spectacle from opening.
Thu, Dec 5, 3:08 PM · Spectacle
davidre updated the diff for D23316: Port towards KConfig XT.

rebase

Thu, Dec 5, 1:47 PM · Spectacle
davidre updated the diff for D23316: Port towards KConfig XT.

Need a bit more height

Thu, Dec 5, 1:45 PM · Spectacle

Mon, Dec 2

davidre closed D25681: Get icon size from QStyle.
Mon, Dec 2, 12:50 PM · KF6, Plasma
davidre committed R103:3e01b440e53a: Get icon size from QStyle (authored by davidre).
Get icon size from QStyle
Mon, Dec 2, 12:50 PM
davidre updated the diff for D25681: Get icon size from QStyle.

const

Mon, Dec 2, 12:43 PM · KF6, Plasma
davidre added a task to D25681: Get icon size from QStyle: T11637: Investigate if KIconThemes is needed as a framework.
Mon, Dec 2, 12:42 PM · KF6, Plasma
davidre added a revision to T11637: Investigate if KIconThemes is needed as a framework: D25681: Get icon size from QStyle.
Mon, Dec 2, 12:42 PM · KF6
davidre added a project to D25681: Get icon size from QStyle: KF6.
Mon, Dec 2, 12:41 PM · KF6, Plasma
davidre requested review of D25681: Get icon size from QStyle.
Mon, Dec 2, 12:41 PM · KF6, Plasma
davidre added a comment to T12276: Remove KConcatenateRowsProxyModel.

According to https://community.kde.org/Frameworks/Policies

In addition, a Qt LTS release remains supported until the next Qt release after the next Qt LTS release. For instance, when Qt 5.15 is released, Qt 5.12 remains supported until Qt 5.16, to give time for people to migrate from Qt 5.12 LTS to Qt 5.15 LTS. When Qt 5.16 is released, both Qt 5.12 LTS and Qt 5.13 are dropped, to go back to "last 3 minor Qt releases".

That means we would support 5.12 until the end? Can we still mark it as deprecated sometime?

Mon, Dec 2, 12:16 PM · KF6
davidre added a comment to T2050: sunsetting KHotKeys.

There is also the case of the Konqueror gesture things? Are these gestures only local to Konqueror or are they somehow global and go for that reason through khotkeys? As I'm not a user of Konqueror maybe @dfaue can offer some insight?

Mon, Dec 2, 11:59 AM · KF6, Plasma
davidre added a subtask for T11567: Delete khotkeys: T2050: sunsetting KHotKeys.
Mon, Dec 2, 11:56 AM · KF6
davidre added a parent task for T2050: sunsetting KHotKeys: T11567: Delete khotkeys.
Mon, Dec 2, 11:56 AM · KF6, Plasma

Sat, Nov 30

davidre closed D25626: Fix EcmGenerateExportHeader tests on Windows.
Sat, Nov 30, 2:08 PM · Build System, Frameworks
davidre committed R240:bfdcec82d926: Fix EcmGenerateExportHeader tests on Windows (authored by davidre).
Fix EcmGenerateExportHeader tests on Windows
Sat, Nov 30, 2:08 PM
davidre added a comment to D25626: Fix EcmGenerateExportHeader tests on Windows.

Yay, thanks for fixing this. Not sure if if(MSVC) is the proper condition, due to not being into the windows side of things, so that part better has someone check who enters the dark side now and then. :)
Otherwise +1 for this.

I used it because it is the same condition inside ECMGenerateExportHeader.cmake which enables __declspec(deprecated(text)).

Sat, Nov 30, 12:26 PM · Build System, Frameworks
davidre retitled D25626: Fix EcmGenerateExportHeader tests on Windows from Fix EcmGenerateExportHeader tests on windows to Fix EcmGenerateExportHeader tests on Windows.
Sat, Nov 30, 12:22 PM · Build System, Frameworks
davidre added reviewers for D25626: Fix EcmGenerateExportHeader tests on Windows: kossebau, Windows, Frameworks.
Sat, Nov 30, 12:19 PM · Build System, Frameworks
davidre requested review of D25626: Fix EcmGenerateExportHeader tests on Windows.
Sat, Nov 30, 12:18 PM · Build System, Frameworks

Thu, Nov 28

davidre added a comment to T12275: Create QQC2 Equivalent of TableView.

Do we need additional API compared to https://doc.qt.io/qt-5/qml-qtquick-tableview.html?

That tableview is a grid of delegates in a flickable.

It does not have the frame + scrollbars + themed delegates

Maybe it is enough to have a common flickable container and have every user duplicate that little bit?

Thu, Nov 28, 12:12 PM · KF6
davidre added a comment to D25581: [TabBar] Use window color instead of button color.

In Breeze it uses the window color I think? See breezestyle.cpp#L5767 and the following lines

Thu, Nov 28, 9:40 AM · Plasma
davidre committed R275:68f3b292ca03: Deprecate KRecursiveFilterProxyModel (authored by davidre).
Deprecate KRecursiveFilterProxyModel
Thu, Nov 28, 8:41 AM
davidre closed D25546: Deprecate KRecursiveFilterProxyModel.
Thu, Nov 28, 8:41 AM · KF6, Frameworks

Wed, Nov 27

davidre updated the diff for D25546: Deprecate KRecursiveFilterProxyModel.

address comments

Wed, Nov 27, 12:57 PM · KF6, Frameworks
davidre moved T12276: Remove KConcatenateRowsProxyModel from Backlog to Waiting on KF6 Branching on the KF6 board.
Wed, Nov 27, 12:50 PM · KF6
davidre created T12276: Remove KConcatenateRowsProxyModel.
Wed, Nov 27, 12:50 PM · KF6
davidre added a comment to T12275: Create QQC2 Equivalent of TableView.

Do we need additional API compared to https://doc.qt.io/qt-5/qml-qtquick-tableview.html?

Wed, Nov 27, 11:46 AM · KF6

Tue, Nov 26

davidre added a task to D25546: Deprecate KRecursiveFilterProxyModel: T12269: Remove KRecursiveFilterProxyModel.
Tue, Nov 26, 2:01 PM · KF6, Frameworks
davidre added a revision to T12269: Remove KRecursiveFilterProxyModel: D25546: Deprecate KRecursiveFilterProxyModel.
Tue, Nov 26, 2:01 PM · KF6
davidre added a project to D25546: Deprecate KRecursiveFilterProxyModel: KF6.
Tue, Nov 26, 2:00 PM · KF6, Frameworks
davidre requested review of D25546: Deprecate KRecursiveFilterProxyModel.
Tue, Nov 26, 1:59 PM · KF6, Frameworks
davidre moved T12269: Remove KRecursiveFilterProxyModel from Backlog to Waiting on KF6 Branching on the KF6 board.
Tue, Nov 26, 1:39 PM · KF6
davidre created T12269: Remove KRecursiveFilterProxyModel.
Tue, Nov 26, 1:38 PM · KF6
davidre added a comment to T11576: Port kolourpaint away from kdelibs4support.

Gwenview has a quality thingy in it's save dialog D23106

Tue, Nov 26, 12:01 PM · KF6
davidre added a comment to D25227: Document Kirigami.Theme Better.

Ping.

Tue, Nov 26, 11:55 AM · Documentation, Kirigami
davidre updated the diff for D23316: Port towards KConfig XT.

Correctly read default value dependent on another config entry

Tue, Nov 26, 9:49 AM · Spectacle

Mon, Nov 25

davidre added a subtask for T12187: Meta task: KDED: T12180: Review all KDED modules.
Mon, Nov 25, 9:42 PM · KF6
davidre added a parent task for T12180: Review all KDED modules: T12187: Meta task: KDED.
Mon, Nov 25, 9:42 PM · KF6
davidre added a parent task for T11567: Delete khotkeys: T12180: Review all KDED modules.
Mon, Nov 25, 9:39 PM · KF6
davidre added a subtask for T12180: Review all KDED modules: T11567: Delete khotkeys.
Mon, Nov 25, 9:39 PM · KF6
davidre added a comment to T2050: sunsetting KHotKeys.

Good to see this porting in place. +++

With my Plasma hat on, is it worth leaving this alone till Plasma 6
(if it ain't broke...)

Or is it worth dropping before the next LTS so we don't have a burden to maintain?

Thoughts?

I think we can't remove it right now without having 100% feature parity. For example there is this weird action available by default that opens google in your browser (see https://cgit.kde.org/khotkeys.git/tree/data/defaults.khotkeys#n307).

Mon, Nov 25, 9:36 PM · KF6, Plasma
davidre moved T2050: sunsetting KHotKeys from Backlog to In Progress on the KF6 board.
Mon, Nov 25, 9:28 PM · KF6, Plasma
davidre added a comment to T7267: Global Shortcuts.
In T7267#208671, @GB_2 wrote:

Also, I think the search should look through all components/categories instead of you having to manually find the correct component/category.

Mon, Nov 25, 8:34 AM · Plasma: KCM Redesign

Sat, Nov 23

davidre committed R39:6055d726226c: Remove unused include (authored by davidre).
Remove unused include
Sat, Nov 23, 9:11 AM
davidre added a comment to D25369: Shorten POTD provider names and remove description that is not used anywhere.

I didn't find good solutions for QQC2. It has been a blocker for a long time https://bugs.kde.org/show_bug.cgi?id=403153

Sat, Nov 23, 8:19 AM · Plasma

Fri, Nov 22

davidre added a comment to D25475: Save combobox value instead of index.

I added a similar fix earlier today to
D23316

Fri, Nov 22, 9:28 PM · Spectacle
davidre updated the diff for D23316: Port towards KConfig XT.

Also use enum for the last selected captureMode

Fri, Nov 22, 12:19 PM · Spectacle
davidre moved T12063: KGlobalAccel cleanup and improvement for desktop files from Backlog to Needs Input on the KF6 board.
Fri, Nov 22, 8:52 AM · KF6

Thu, Nov 21

davidre updated the diff for D23316: Port towards KConfig XT.
  • Fix typo in update file
Thu, Nov 21, 3:11 PM · Spectacle
davidre updated the diff for D23316: Port towards KConfig XT.

address comments

Thu, Nov 21, 9:58 AM · Spectacle

Wed, Nov 20

davidre added a comment to D25427: [WIP][Wayland] Allow to take full resolution screenshot when scaling is used.

This approach will probably fail when the geometry stretches across multiple outputs with different scales.

I am well aware, this a naive and basic approach to gather some learning feedback.
And Those changes are only needed for Wayland.
I need to break the geometry by screen get their scale and then put all together in a virtualScreenGeometry according to the passed Geometry.
But I need to learn how to get there, dig in the code and/or ask questions if I may.
I have a two screens system at home to test this.

Wed, Nov 20, 7:30 PM · KWin
davidre added a comment to D25427: [WIP][Wayland] Allow to take full resolution screenshot when scaling is used.

This approach will probably fail when the geometry stretches across multiple outputs with different scales.

Wed, Nov 20, 6:33 PM · KWin

Mon, Nov 18

davidre added a comment to T12063: KGlobalAccel cleanup and improvement for desktop files.

In the future if we want to embrace the use of desktop files also for shortcuts.

IMHO having a desktop file specifying DBus callbacks is working well enough that it should be the sole way of an app registering global shortcuts. Then we only need code in client apps if they want to do any kind of configuration

The old method suffers from not working before an app is first run, and not cleaning up when an app is removed.

It'd be a radical change, but global shortcuts are generally used by plasma not apps.

We have this new infra in-place already, so we could try and build on that, port things and see how it goes already.

Mon, Nov 18, 11:53 AM · KF6
davidre committed R103:60c98f48e926: Add copyright header to update program (authored by davidre).
Add copyright header to update program
Mon, Nov 18, 11:37 AM
davidre committed R103:e47d5343290f: Fix build (authored by davidre).
Fix build
Mon, Nov 18, 11:32 AM
davidre committed R103:507bc58bf3e8: Port to KGlobalAccel (authored by davidre).
Port to KGlobalAccel
Mon, Nov 18, 10:15 AM
davidre closed D25086: Port to KGlobalAccel.
Mon, Nov 18, 10:15 AM · Plasma
davidre added a comment to T12063: KGlobalAccel cleanup and improvement for desktop files.

Another thing is the magic isConfigurationAction property that is used which changes behavior of some functions if present which doesn't make things easier if you want to configure stuff and you have to read the code to see if you need it or not.

Mon, Nov 18, 10:13 AM · KF6
davidre renamed T12063: KGlobalAccel cleanup and improvement for desktop files from KGlobalAccel cleanup and improvement for desktop filess to KGlobalAccel cleanup and improvement for desktop files.
Mon, Nov 18, 10:09 AM · KF6
davidre added a parent task for T12063: KGlobalAccel cleanup and improvement for desktop files: T2050: sunsetting KHotKeys.
Mon, Nov 18, 10:09 AM · KF6
davidre added a subtask for T2050: sunsetting KHotKeys: T12063: KGlobalAccel cleanup and improvement for desktop files.
Mon, Nov 18, 10:09 AM · KF6, Plasma
davidre created T12063: KGlobalAccel cleanup and improvement for desktop files.
Mon, Nov 18, 10:09 AM · KF6

Sun, Nov 17

davidre added a comment to D25351: [Style KCM] Change name to KDE/Qt Application Style.

Why KDE/Qt Application style? Every Qt Application will have that style and not only KDE Applications. I also fear that somehow this will strengthen the false idea of some users that Applications and Plasma are intertwined.

Sun, Nov 17, 9:45 AM · Plasma

Sat, Nov 16

davidre committed R275:b39de5f50611: Use correct @since version for KNumberModel (authored by davidre).
Use correct @since version for KNumberModel
Sat, Nov 16, 3:24 PM
davidre committed R275:ddc161fc9d57: Add missing explicit to KNumberModel constructor (authored by davidre).
Add missing explicit to KNumberModel constructor
Sat, Nov 16, 3:20 PM
davidre committed R275:60ed535b920e: Add KNumberModel to README.md (authored by davidre).
Add KNumberModel to README.md
Sat, Nov 16, 3:17 PM
davidre added a comment to D25086: Port to KGlobalAccel.

No, I wanted to let David take a second look. But I can commit later.

Sat, Nov 16, 9:07 AM · Plasma

Thu, Nov 14

davidre added a comment to D25307: kwriteconfig: add delete option.

Also, I don't see anything wrong with adding this, since it merely exposes deleteEntry method already in the API. Some projects do rely on it, so why should it be kept away from actual human beings?

Thu, Nov 14, 8:16 PM · Frameworks
davidre added a comment to D25307: kwriteconfig: add delete option.

What shortcuts had you in mind to delete?

My specific interest is deleting shortcuts of removed KWin scripts. ( e.g. https://github.com/esjeon/krohnkite/issues/31 ) Such shortcuts keep appearing on Global Shortcuts dialog unless manually deleted. Also, while developing the script, I leave garbage values behind, and having this around will be handy.

As noted in that issue for removing shortcuts modifying kglobalshortcutsrc is not enough as kglobaccel will write back. A reliable way to do that is via DBus.

Thu, Nov 14, 6:37 PM · Frameworks
davidre added a comment to D25307: kwriteconfig: add delete option.

I don't think deleting a entry from a config file makes sense. If you delete an entry you will get the default value on the next read.

Thu, Nov 14, 5:33 PM · Frameworks
davidre added a comment to D25191: replace bespoke xkb geometry parser with xkb.

Is the FooBar class for testing? I don't see it used anywhere. (and would guess soofrom the name)

Thu, Nov 14, 4:22 PM · Plasma
davidre added a comment to D25293: Use dbus-send instead of qdbus for global shortcuts.

Sorry, it doesn't work for me either. I didn't relog before testing and I guess it was still using the qdbus commands. KLauncher gets the right arguments I think:

What does this mean? Sorry, I'm pretty new to dbus.

I don't know but KGlobalAccel uses KLauncher to execute the command found in the Exec line of the desktop file.
However I noticed something weird when manually using your dbus-send commands. dbus-send --session --dest='org.kde.Spectacle' --type=method_call '/' 'org.kde.Spectacle.StartAgent' only seemed to work every second time.

Thu, Nov 14, 3:06 PM · Spectacle
davidre updated subscribers of D23316: Port towards KConfig XT.

Maybe we can do this for 20.03 with 19.12 now branched. This would leave us some time to test it. What do you think @ngraham?

Thu, Nov 14, 11:35 AM · Spectacle
davidre requested changes to D25293: Use dbus-send instead of qdbus for global shortcuts.
Thu, Nov 14, 8:07 AM · Spectacle