Move KeySequenceItem to KGlobalAccel -> Became KeySequenceRecorder in KGuiAddons
Open, Needs TriagePublic

Description

How does that clashes with a mostly API less KGlobalAccel?

Would allow removing the dep on KGlobalAccel, and also see https://phabricator.kde.org/T12122

mwolff created this task.Nov 23 2019, 11:30 AM

For now I would like to start by moving the recording logic to KGlobalAccel so we don't have two copies and subtle differences between both and bugs because of that because one gets fixed and the doesn't.

davidre added a comment.EditedOct 21 2020, 11:38 AM

So KXmlGui supports being build without KGlobalAccel. The only dependecy I need from other frameworks right now is KKeyServer::isShiftAsModifierAllowed which is a big switch. If I copy that, it can even be put into KGuiAddons. There could be other ways to achieve the same but for let's do a 1:1 transfer of the logic.

KeySequenceRecorder is now in GuiAddons and both controls are using it

Can this be marked as resolved?

Not yet I think. We still need a new place for KeySequenceItem and not sure if we are happy with KKeySequenceWidget in XmlGui. Currently both do conflict checking and need KGlobalAccel and KConfig(Gui) for that. On top of that they show message boxes so also Widgets

davidre moved this task from Backlog to In Progress on the KF6 board.Mar 27 2021, 1:58 PM
ervin renamed this task from Move KeySequenceItem to KGlobalAccel to Move KeySequenceItem to KGlobalAccel -> Became KeySequenceRecorder in KGuiAddons.Mar 27 2021, 2:18 PM
ervin moved this task from In Progress to Done on the KF6 board.