Differential D28008

Don't use deprecated QList::toSet
AbandonedPublic
Actions

Authored by carewolf on Mar 12 2020, 11:58 AM.

Details

Reviewers
mlaurent
vkrause
dvratil

Diff Detail

Repository
R459 Akonadi Contacts
Branch
release/19.12
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 23622
Build 23640: arc lint + arc unit
carewolf created this revision.Mar 12 2020, 11:58 AM
Restricted Application added a project: KDE PIM. · View Herald TranscriptMar 12 2020, 11:58 AM
Restricted Application added a subscriber: kde-pim. · View Herald Transcript
carewolf requested review of this revision.Mar 12 2020, 11:58 AM
mlaurent added a comment.Mar 12 2020, 1:05 PM

it will build against 5.13 ?

carewolf updated this revision to Diff 77503.Mar 12 2020, 1:23 PM

Build with <5.14

dvratil requested changes to this revision.Mar 16 2020, 6:26 PM
dvratil added a subscriber: dvratil.
dvratil added inline comments.
src/akonadi-contacts/collectionfiltermodel.cpp
58

This will crash, since you are getting an iterator for a temporary (so begin and end iterators will belong to two different containers)

This revision now requires changes to proceed.Mar 16 2020, 6:26 PM
carewolf abandoned this revision.Mar 17 2020, 10:04 AM

Done in separate change

Revision Contents
Changeset List

Diff 77503

View Options

src/akonadi-contacts/collectionfiltermodel.cpp

Loading...