mpyne (Michael Pyne)
User

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Monday

  • Clear sailing ahead.

User Details

User Since
Mar 23 2016, 2:38 AM (156 w, 2 d)
Availability
Available

Recent Activity

Thu, Mar 14

mpyne committed R499:5694547d0757: Break dependency cycle between ECM and Qt5. (authored by mpyne).
Break dependency cycle between ECM and Qt5.
Thu, Mar 14, 2:54 AM

Sat, Mar 9

mpyne committed R365:318635fdd6b5: dep-resolv: Fix bug handling negated dependencies. (authored by mpyne).
dep-resolv: Fix bug handling negated dependencies.
Sat, Mar 9, 3:15 AM

Sun, Mar 3

mpyne committed R365:3732ffc47495: git: Minor fix to correct msg shown to user when git-stash pop fails. (authored by mpyne).
git: Minor fix to correct msg shown to user when git-stash pop fails.
Sun, Mar 3, 12:14 AM

Feb 20 2019

mpyne accepted D19127: Do not complain about missing qmake if it can actually be found or is going to be built as part of Qt 5.

Good to go! If you have commit access you'll need to commit to the Gitlab instance rather than git.kde.org directly. In my case I'd just run git remote add gitlab git@invent.kde.org:kde/kdesrc-build.git first, git fetch gitlab to ensure it's fully downloaded, and then run something like git push gitlab master to push to the proper remote.

Feb 20 2019, 3:41 AM
mpyne added a comment to D19171: Fix typo in qt5 module set name..

The existing Qt5 mention is meant to be special-cased by kdesrc-build and other users of this file (like the build.kde.org infrastructure) so I would not bother changing it just because kdesrc-build now supports Qt 5.

Feb 20 2019, 3:33 AM

Feb 19 2019

mpyne committed R344:15dcf1c21597: Merge branch 'Applications/18.12' (authored by mpyne).
Merge branch 'Applications/18.12'
Feb 19 2019, 12:41 AM
mpyne committed R344:5c1470d2f7f4: Fix crash in filtering playlist to playing album/artist. (authored by mpyne).
Fix crash in filtering playlist to playing album/artist.
Feb 19 2019, 12:41 AM
mpyne requested changes to D19127: Do not complain about missing qmake if it can actually be found or is going to be built as part of Qt 5.

Aside from the absPathToExecutable2 new function the updated logic is sound. You'll want to keep the check you added to call absPathToExecutable without the preferred paths if the program couldn't be found even after that change as well, so don't get rid of that extra call you added to account for when the preferred paths don't find the program being sought.

Feb 19 2019, 12:13 AM

Feb 18 2019

mpyne committed R344:24b0edd1545c: Fix crash with threaded file loading. (authored by mpyne).
Fix crash with threaded file loading.
Feb 18 2019, 10:26 PM
mpyne accepted D18885: Fix displaying covers from cover.jpg files.

This is good to commit. Note that JuK's repository is in testing for a trial KDE is running of GitLab, so you'll need to commit to the JuK repository at https://invent.kde.org/kde/juk

Feb 18 2019, 5:22 PM

Feb 9 2019

mpyne committed R365:991f4e1fb7f9: Merge branch 'add-qt5-support' into 'master' (authored by mpyne).
Merge branch 'add-qt5-support' into 'master'
Feb 9 2019, 3:16 AM
mpyne committed R365:114908104674: Add support for building Qt5 modules. (authored by mpyne).
Add support for building Qt5 modules.
Feb 9 2019, 3:16 AM
mpyne committed R365:34cef6ec14dd: first-run: Add Fedora 29 packages and installer metadata. (authored by mpyne).
first-run: Add Fedora 29 packages and installer metadata.
Feb 9 2019, 1:56 AM

Feb 8 2019

mpyne committed R365:0ceb50e9fefb: first-run: Ignore kde structure by default. (authored by mpyne).
first-run: Ignore kde structure by default.
Feb 8 2019, 11:46 PM

Jan 14 2019

mpyne committed R365:13c3f7f1633a: WIP: Add support for building Qt5 modules. (authored by mpyne).
WIP: Add support for building Qt5 modules.
Jan 14 2019, 12:20 AM

Jan 13 2019

mpyne committed R365:143a94025043: Fix crash that was introduced by the recent 'improved test'. (authored by mpyne).
Fix crash that was introduced by the recent 'improved test'.
Jan 13 2019, 9:02 PM

Jan 12 2019

mpyne committed R365:d9f11a3e954b: test: Add plumbing to allow for tracepoints during test. (authored by mpyne).
test: Add plumbing to allow for tracepoints during test.
Jan 12 2019, 9:28 PM
mpyne committed R365:b01505bec941: Fix cxxflags being set to a space when globally empty. (authored by mpyne).
Fix cxxflags being set to a space when globally empty.
Jan 12 2019, 9:27 PM
mpyne added a comment to D18165: Do not pass -DCMAKE_CXX_FLAGS to CMake if cxxflags is empty.

This bug should be fixed (at its precise source) in commit b01505bec941f06be52ca3ac88d9b6937e1f4c88.

Jan 12 2019, 8:59 PM
mpyne added a comment to D18165: Do not pass -DCMAKE_CXX_FLAGS to CMake if cxxflags is empty.

I'll take a look and fix but if further review is needed may I invite you to the trial GitLab instance at https://invent.kde.org/kde/kdesrc-build/merge_requests ? (kdesrc-build is a participant in the trial).

Jan 12 2019, 6:10 PM

Jan 10 2019

mpyne accepted D18137: delete copy constructor and assignment operator of some public classes.

The KSharedDataCache change is definitely correct. I've not done much with the kdelibs migrator but I agree with the logic and the implementation. Have you tried building some of the other frameworks or Plasma after implementing this patch? That's the only real risk I can think of.

Jan 10 2019, 3:43 AM · Frameworks

Jan 7 2019

mpyne committed R365:0f4cc4b9d283: first-run: Remove kde-language support. (authored by mpyne).
first-run: Remove kde-language support.
Jan 7 2019, 1:37 AM
mpyne committed R365:c6e61dffe9ff: non-kde-deps: Add shell handler and metadata for distro dependencies. (authored by mpyne).
non-kde-deps: Add shell handler and metadata for distro dependencies.
Jan 7 2019, 1:37 AM
mpyne committed R365:d5240196124e: util: Add a method to locate data files, cleanup basedir detection. (authored by mpyne).
util: Add a method to locate data files, cleanup basedir detection.
Jan 7 2019, 1:37 AM
mpyne committed R365:402fc30fb80c: Breakout KDE modules into a specific subclass. (authored by mpyne).
Breakout KDE modules into a specific subclass.
Jan 7 2019, 1:37 AM

Jan 6 2019

mpyne committed R365:845e9da4ac26: first-run: Add basic installer and packages for Debian distros. (authored by mpyne).
first-run: Add basic installer and packages for Debian distros.
Jan 6 2019, 3:28 AM
mpyne committed R365:9b298270d448: CI: Remove needless build stage, document a working full build. (authored by mpyne).
CI: Remove needless build stage, document a working full build.
Jan 6 2019, 3:28 AM
mpyne committed R344:066c3ff1726f: Add README.md (authored by David Planella <david.planella@ubuntu.com>).
Add README.md
Jan 6 2019, 1:16 AM

Dec 29 2018

mpyne committed R365:c72e6e6e1865: first-run: Add needed OpenSuse packages needed to install dolphin. (authored by mpyne).
first-run: Add needed OpenSuse packages needed to install dolphin.
Dec 29 2018, 5:34 AM
mpyne committed R365:739ddb56cb6a: first-run: Use absolute paths when generating .kdesrc-buildrc. (authored by mpyne).
first-run: Use absolute paths when generating .kdesrc-buildrc.
Dec 29 2018, 5:34 AM
mpyne committed R365:068700c3527f: Remove dead implementation of --initial-setup. (authored by mpyne).
Remove dead implementation of --initial-setup.
Dec 29 2018, 5:34 AM

Dec 28 2018

mpyne committed R344:04aecdab49ee: Merge branch 'Applications/18.12' into 'Applications/18.12' (authored by mpyne).
Merge branch 'Applications/18.12' into 'Applications/18.12'
Dec 28 2018, 11:16 AM
mpyne committed R344:3cf1c4111895: ci: add the template for creating the flatpak (authored by bshah).
ci: add the template for creating the flatpak
Dec 28 2018, 11:16 AM
mpyne committed R365:a0d3da8b8d29: CI: Add kdesrc-build test suite to Gitlab CI. (authored by mpyne).
CI: Add kdesrc-build test suite to Gitlab CI.
Dec 28 2018, 5:11 AM
mpyne committed R365:616859ca4823: I always forget git itself :(. (authored by mpyne).
I always forget git itself :(.
Dec 28 2018, 5:06 AM
mpyne committed R365:820009933cdb: CI: Add remaining required modules. (authored by mpyne).
CI: Add remaining required modules.
Dec 28 2018, 4:59 AM
mpyne committed R365:bf032f70fb3b: CI: Add cmake as a test dependency. (authored by mpyne).
CI: Add cmake as a test dependency.
Dec 28 2018, 4:48 AM
mpyne committed R365:8b43686328ff: CI: Add kdesrc-build test suite to Gitlab CI. (authored by mpyne).
CI: Add kdesrc-build test suite to Gitlab CI.
Dec 28 2018, 4:46 AM
mpyne committed R365:efc3b42794c9: Merge remote-tracking branch 'gitlab/master' into make_it_mojo (authored by mpyne).
Merge remote-tracking branch 'gitlab/master' into make_it_mojo
Dec 28 2018, 3:58 AM
mpyne committed R365:26c9fc5f09ef: README: Light proofreading and capitalization fixes. (authored by mpyne).
README: Light proofreading and capitalization fixes.
Dec 28 2018, 1:54 AM
mpyne committed R365:c1a92f3d547a: Merge branch '10-set-stop-on-failure-by-default' into 'master' (authored by mpyne).
Merge branch '10-set-stop-on-failure-by-default' into 'master'
Dec 28 2018, 1:54 AM
mpyne committed R365:f6888c9f958e: Adjust default config file to set some more user-friendly defaults for new… (authored by ngraham).
Adjust default config file to set some more user-friendly defaults for new…
Dec 28 2018, 1:53 AM
mpyne committed R365:87844085c697: Merge branch 'quickstart-doc' into 'master' (authored by mpyne).
Merge branch 'quickstart-doc' into 'master'
Dec 28 2018, 1:53 AM

Dec 27 2018

mpyne committed R365:6475925a6790: WIP: Adjust README.md for style and readability. (authored by mpyne).
WIP: Adjust README.md for style and readability.
Dec 27 2018, 12:55 AM

Dec 26 2018

mpyne committed R365:eebceff7c148: first-run: Add additional Arch requirements. (authored by mpyne).
first-run: Add additional Arch requirements.
Dec 26 2018, 2:10 AM
mpyne committed R365:e84022a7acd6: Add Arch package for IO::Socket::SSL as a kdesrc-build dep. (authored by ngraham).
Add Arch package for IO::Socket::SSL as a kdesrc-build dep.
Dec 26 2018, 1:30 AM
mpyne closed D17768: Add additional required Perl module package for Arch.
Dec 26 2018, 1:30 AM
mpyne added a comment to D17768: Add additional required Perl module package for Arch.

Probably because we're using kdesrc-build as a testcase for the Gitlab instance at invent.kde.org. I'll go ahead and push.

Dec 26 2018, 1:25 AM

Dec 25 2018

mpyne committed R365:e743b5bb9f30: Fix broken cmdline parsing when --stop-on-failure in use. (authored by mpyne).
Fix broken cmdline parsing when --stop-on-failure in use.
Dec 25 2018, 10:24 PM
mpyne accepted D17768: Add additional required Perl module package for Arch.

This is perfect, you've already put more testing than I have been able to put for Arch. If you have future such fixes you can feel free to push, especially if already tested (I've only been able to test OpenSUSE up to this point).

Dec 25 2018, 1:25 AM
mpyne accepted D17771: Fix Python 3 warning.
Dec 25 2018, 1:23 AM

Dec 22 2018

mpyne committed R344:6a1d0ec47448: Merge branch 'Applications/18.12' (authored by mpyne).
Merge branch 'Applications/18.12'
Dec 22 2018, 5:20 PM
mpyne committed R344:468a5169347c: Port sort function for list of playlists to KF5. (authored by mpyne).
Port sort function for list of playlists to KF5.
Dec 22 2018, 5:20 PM
mpyne committed R344:bcf4f68bc369: Merge branch 'Applications/18.12' (authored by mpyne).
Merge branch 'Applications/18.12'
Dec 22 2018, 5:20 PM
mpyne committed R344:dc3124e40b73: Force sorting on so that special playlist sort to top. (authored by mpyne).
Force sorting on so that special playlist sort to top.
Dec 22 2018, 5:20 PM
mpyne committed R344:f9721878bd29: Fix the "Show Columns" menu to show correct state on startup. (authored by mpyne).
Fix the "Show Columns" menu to show correct state on startup.
Dec 22 2018, 5:20 PM
mpyne committed R344:f7c1b49d01a6: Simplify Playlist constructors and cleanup header. (authored by mpyne).
Simplify Playlist constructors and cleanup header.
Dec 22 2018, 5:20 PM
mpyne committed R344:7096017772e6: Remove dead code for playlist tool tip. (authored by mpyne).
Remove dead code for playlist tool tip.
Dec 22 2018, 5:20 PM
mpyne committed R344:c6afa4c528fa: Disable tag updating from inline editor. (authored by mpyne).
Disable tag updating from inline editor.
Dec 22 2018, 5:20 PM
mpyne committed R344:3b931e905015: Merge branch 'Applications/18.12' (authored by mpyne).
Merge branch 'Applications/18.12'
Dec 22 2018, 5:20 PM
mpyne committed R344:a15af145e282: Remove debug spam for power management. (authored by mpyne).
Remove debug spam for power management.
Dec 22 2018, 5:20 PM
mpyne committed R344:4d63212ff403: Add cover art support for Ogg formats (Opus, Vorbis) (authored by mpyne).
Add cover art support for Ogg formats (Opus, Vorbis)
Dec 22 2018, 5:20 PM
mpyne committed R344:abb256f289d4: Remove needless event filter, add alt. row colors, sane column weights. (authored by mpyne).
Remove needless event filter, add alt. row colors, sane column weights.
Dec 22 2018, 5:20 PM
mpyne committed R344:6e518da461c8: Prefer QVector to QList for most auxiliary lists. (authored by mpyne).
Prefer QVector to QList for most auxiliary lists.
Dec 22 2018, 5:20 PM
mpyne committed R365:a7090fc71168: Try to streamline 'quick start' documentation. (authored by mpyne).
Try to streamline 'quick start' documentation.
Dec 22 2018, 5:16 PM
mpyne committed R365:d285496cc466: cmdline: Make -v stand for --version, not --verbose. (authored by mpyne).
cmdline: Make -v stand for --version, not --verbose.
Dec 22 2018, 5:16 PM

Dec 19 2018

mpyne committed R344:13505df0e240: Apply some cleanup to file loading code. (authored by mpyne).
Apply some cleanup to file loading code.
Dec 19 2018, 11:14 PM
mpyne committed R344:eb4a4d1556aa: Use a thread pool for the threaded music loader. (authored by mpyne).
Use a thread pool for the threaded music loader.
Dec 19 2018, 11:14 PM
mpyne committed R344:3cf74c353e75: Move initial music load to a separate thread. (authored by mpyne).
Move initial music load to a separate thread.
Dec 19 2018, 8:20 PM
mpyne committed R365:d72cf7e2f1e3: qmake: Remove builddir hack for Qt 5. (authored by mpyne).
qmake: Remove builddir hack for Qt 5.
Dec 19 2018, 12:36 AM

Dec 18 2018

mpyne committed R268:c96d012b6d47: Fix KGlobalAccel build with Qt 5.13 prerelease. (authored by mpyne).
Fix KGlobalAccel build with Qt 5.13 prerelease.
Dec 18 2018, 3:31 PM
mpyne closed D17647: Fix KGlobalAccel build with Qt 5.13 prerelease.
Dec 18 2018, 3:31 PM · Frameworks
mpyne requested review of D17647: Fix KGlobalAccel build with Qt 5.13 prerelease.
Dec 18 2018, 4:03 AM · Frameworks

Dec 9 2018

mpyne committed R244:1285c4bf5552: cmake macros: Port away from deprecated ECM var in kcoreaddons_add_plugin (authored by mpyne).
cmake macros: Port away from deprecated ECM var in kcoreaddons_add_plugin
Dec 9 2018, 4:31 PM
mpyne closed D17446: cmake macros: Port away from deprecated ECM var in kcoreaddons_add_plugin.
Dec 9 2018, 4:31 PM · Frameworks
mpyne requested review of D17446: cmake macros: Port away from deprecated ECM var in kcoreaddons_add_plugin.
Dec 9 2018, 3:57 AM · Frameworks

Dec 5 2018

mpyne accepted D17291: Add .arcconfig.
Dec 5 2018, 7:03 PM
mpyne committed R365:671140a69e88: Apply a consistent ordering of module list generation. (authored by mpyne).
Apply a consistent ordering of module list generation.
Dec 5 2018, 6:14 PM

Dec 1 2018

mpyne committed R344:cfcd545be85a: scrobbler: Don't prompt to unlock KWallet if not using scrobbler. (authored by mpyne).
scrobbler: Don't prompt to unlock KWallet if not using scrobbler.
Dec 1 2018, 11:55 PM
mpyne committed R344:8b463f4fbcd1: scrobbler: fix missing QNetworkAccessManager when session active. (authored by mpyne).
scrobbler: fix missing QNetworkAccessManager when session active.
Dec 1 2018, 11:50 PM
mpyne committed R344:436b00699582: Merge branch 'Applications/18.12' (authored by mpyne).
Merge branch 'Applications/18.12'
Dec 1 2018, 11:50 PM
mpyne closed D17140: Scrobbler: fix issue where if session key is not empty, a QNetworkAccessManager never gets created..
Dec 1 2018, 11:50 PM
mpyne added a comment to D17140: Scrobbler: fix issue where if session key is not empty, a QNetworkAccessManager never gets created..

Thanks for the patch! Since the m_networkAccessManager is now sure to be constructed once the Scrobbler constructor runs, I decided instead to just initialize that variable directly without making it conditional, and remove its creation in getAuthToken.

Dec 1 2018, 11:19 PM
mpyne added a comment to R425:c576e4695542: Fix build by adding missing header..

Yes, good point. I've applied in Applications/18.12 as well.

Dec 1 2018, 10:20 PM
mpyne committed R425:80f49cb726dc: Fix build by adding missing header. (authored by mpyne).
Fix build by adding missing header.
Dec 1 2018, 10:20 PM

Nov 23 2018

mpyne committed R365:79bf67bbbca1: doc: Add cmake for asciidoctor, remove remote-tracked webfonts. (authored by mpyne).
doc: Add cmake for asciidoctor, remove remote-tracked webfonts.
Nov 23 2018, 8:36 PM
mpyne committed R365:f665ef2270b8: doc: Add source reference documentation for ksb::Module. (authored by mpyne).
doc: Add source reference documentation for ksb::Module.
Nov 23 2018, 5:59 AM
mpyne committed R365:483e67ed9279: Remove dead code from ksb::Module. (authored by mpyne).
Remove dead code from ksb::Module.
Nov 23 2018, 5:59 AM
mpyne committed R365:a59467e2d529: vim-syntax: include-dependencies is no longer only for module-sets. (authored by mpyne).
vim-syntax: include-dependencies is no longer only for module-sets.
Nov 23 2018, 5:59 AM
mpyne committed R365:f4a91b345e3f: test: Ignore cmake install output to keep test suite results readable. (authored by mpyne).
test: Ignore cmake install output to keep test suite results readable.
Nov 23 2018, 5:59 AM

Nov 22 2018

mpyne committed R425:c576e4695542: Fix build by adding missing header. (authored by mpyne).
Fix build by adding missing header.
Nov 22 2018, 3:32 AM
mpyne added a comment to D17078: Make it possible to use KAboutData/License/Person from QML.
In D17078#363886, @apol wrote:

You can't change parameters in methods or constructors, it's a BIC.

https://community.kde.org/Policies/Binary_Compatibility_Issues_With_C%2B%2B

Nov 22 2018, 12:44 AM · Frameworks

Nov 18 2018

mpyne committed R365:86989e34ccc8: setup: Allow to interactively choose {src,build} dirs. (authored by janpr).
setup: Allow to interactively choose {src,build} dirs.
Nov 18 2018, 9:48 PM
mpyne closed D16757: Custom build/source directories.
Nov 18 2018, 9:48 PM
mpyne committed R365:a17da6dbdb37: setup: Fix Perl warning on regex use. (authored by mpyne).
setup: Fix Perl warning on regex use.
Nov 18 2018, 9:48 PM
mpyne accepted D16757: Custom build/source directories.

OK, I've already committed (commit 86989e34ccc81c9695c8e638ea8fee1b6343d267) but if our git servers don't close this review request it should be OK for you to close this.

Nov 18 2018, 8:59 PM

Nov 17 2018

mpyne added a comment to D16757: Custom build/source directories.

Not asking about source-dir/build-dir (but mentioning them in the resulting file) was deliberate, as a way of reducing the number of options that must be completed to go from nothing to a working configuration.

Nov 17 2018, 5:21 PM

Nov 11 2018

mpyne committed R344:1862b0f61b32: hidpi: Port remaining icon uses to use QIcon for HiDPI support. (authored by mpyne).
hidpi: Port remaining icon uses to use QIcon for HiDPI support.
Nov 11 2018, 11:51 PM
mpyne committed R344:6a35bbe0b8b7: Merge branch 'Applications/18.12' (authored by mpyne).
Merge branch 'Applications/18.12'
Nov 11 2018, 11:51 PM
mpyne committed R344:c31920fab02d: hidpi: Mark cover art as being at native display resolution. (authored by mpyne).
hidpi: Mark cover art as being at native display resolution.
Nov 11 2018, 11:51 PM