I wanted to thank you all for your feedback. It sounds to me that, based on that feedback:

The change has been implemented in commit 4aa5a0f7f93703d22e2cc81442d64a1bb2d81a46

Sorry I didn't notice this as kdesrc-build development has moved to invent.kde.org

In R344:a800c1b3ffeb1672cf889e707baf2b181d7fc8f1#3895515, @markusxx wrote:

This introduced a possible regression, could you please have a look at it: https://bugs.kde.org/show_bug.cgi?id=420718

Thanks! This is a much better way to implement this, even if I had found git-diff-index in my search when I was implementing this I'm sure I would have missed the --quiet and --exit-code cmdline options that make this a simple check. Please let me know if you're not able to commit and I will do so instead.

Agreed, let's commit.

Thanks Harald. Patch looks good and I've checked that the file name pattern is what Dr. Konqi uses by default. One question though, @broulik you mentioned there's also text/x-apport, should that be changed here too or is this changeset just for *.kcrash.txt? If the apport mention is for something else then I'd say to go ahead and commit.

Looks good to me as well. Thanks for the work on this!