mpyne (Michael Pyne)
User

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Mar 23 2016, 2:38 AM (95 w, 5 d)
Availability
Available

Recent Activity

Yesterday

mpyne committed R365:590f46255ed3: setup: Use Wiki's default paths, include deps by default. (authored by mpyne).
setup: Use Wiki's default paths, include deps by default.
Sun, Jan 21, 5:24 PM
mpyne committed R365:f61f72a83a21: doc: Update kdesrc-build Getting Started docs. (authored by mpyne).
doc: Update kdesrc-build Getting Started docs.
Sun, Jan 21, 5:24 PM
mpyne committed R365:c8f4ca45864b: doc: Minor administrative updates. (authored by mpyne).
doc: Minor administrative updates.
Sun, Jan 21, 5:24 PM

Fri, Jan 19

mpyne committed R344:516a69f91712: Refactor and extract SearchPlaylist's playlist item sync code. (authored by mpyne).
Refactor and extract SearchPlaylist's playlist item sync code.
Fri, Jan 19, 4:21 AM
mpyne committed R344:39523ee366ae: Merge remote-tracking branch 'origin/Applications/17.12' (authored by mpyne).
Merge remote-tracking branch 'origin/Applications/17.12'
Fri, Jan 19, 4:21 AM
mpyne committed R344:e8c2dbbfce00: Immediately update dynamic/search playlist items upon a change. (authored by mpyne).
Immediately update dynamic/search playlist items upon a change.
Fri, Jan 19, 3:23 AM

Sat, Jan 13

mpyne added a comment to D9748: Give Juk a playback power inhibitor..

It may be the case that Solid isn't ready for this yet. The code in Solid's freedesktop backend (solid/src/solid/power/backends/freedesktop/fdinhibition.cpp) appears to handle this DBus stuff as well but even though I made sure to enable the fdo backend, it doesn't work for me either.

Sat, Jan 13, 2:35 AM
mpyne added a comment to D9748: Give Juk a playback power inhibitor..

Of course I "experimental" when the last commit to the relevant code in Solid seems to have been in 2014... I suppose it's as good as it will get for now. But still I will want to fix our own CMake checks first before I recompile Solid with the support enabled.

Sat, Jan 13, 12:19 AM
mpyne added a comment to D9748: Give Juk a playback power inhibitor..

It seems that the support in Solid is still experimental as this didn't even compile for me now that I've finally been able to test it. Turns out it's an optional feature in Solid which is disabled by default.

Sat, Jan 13, 12:18 AM

Fri, Jan 12

mpyne added a comment to D9748: Give Juk a playback power inhibitor..

This revision is probably closer to what an implementation could look like. Solid::Inhibition::result returns a Solid::Job which doesn't look usable (I would have expected a Solid::InhibitionJob here). Though it still doesn't inhibit power management that I can tell. I wonder if the API is finished and known working? Dragon's code currently seems to use DBus where I mistakenly thought it used code similar to the first revision.

Fri, Jan 12, 9:44 PM
mpyne committed R365:aa8b857b4982: Fix crash from missing $ctx object. (authored by mpyne).
Fix crash from missing $ctx object.
Fri, Jan 12, 9:00 PM
mpyne committed R365:1e6b6e5dbe2f: Downgrade missing dependency warning. (authored by mpyne).
Downgrade missing dependency warning.
Fri, Jan 12, 1:15 AM
mpyne accepted D9823: Optimize: use QMetaObject::invokeMethod with functor.

LGTM

Fri, Jan 12, 12:23 AM · Frameworks
mpyne requested changes to D9748: Give Juk a playback power inhibitor..

I'm sorry for wasting your time yesterday, especially since it takes so long between reviews. But after reading more into the Solid code it looks like we actually have to process this as a multiple step process.

Fri, Jan 12, 12:05 AM

Thu, Jan 11

mpyne requested changes to D9748: Give Juk a playback power inhibitor..

The patch looks good (though you say it doesn't actually work??)

Thu, Jan 11, 1:10 AM

Thu, Jan 4

mpyne committed R365:eaaea392ebf0: Revert use of List::Util's any. It requires Perl 5.20. (authored by mpyne).
Revert use of List::Util's any. It requires Perl 5.20.
Thu, Jan 4, 10:22 PM

Fri, Dec 29

mpyne committed R365:8f58ff9ef00a: cmdline query mode should imply --pretend. (authored by mpyne).
cmdline query mode should imply --pretend.
Fri, Dec 29, 2:05 AM

Mon, Dec 25

mpyne committed R365:559432cdc7cf: Add test for reading/referring to user-set rcfile opts. (authored by mpyne).
Add test for reading/referring to user-set rcfile opts.
Mon, Dec 25, 6:17 AM

Sun, Dec 24

mpyne committed R365:b068c0187776: Merge remote-tracking branch 'origin/master' into testing-restructure (authored by mpyne).
Merge remote-tracking branch 'origin/master' into testing-restructure
Sun, Dec 24, 9:35 PM
mpyne committed R365:8fd27ea43d91: Migrate module list creation and script execution out of `new`. (authored by mpyne).
Migrate module list creation and script execution out of `new`.
Sun, Dec 24, 9:33 PM
mpyne committed R365:17bc829bcb29: getopt: Use right flags to declare boolean options. (authored by mpyne).
getopt: Use right flags to declare boolean options.
Sun, Dec 24, 9:33 PM
mpyne committed R365:fc79e4c09a0b: Ensure FindBin puts its output in correct package namespace. (authored by mpyne).
Ensure FindBin puts its output in correct package namespace.
Sun, Dec 24, 9:33 PM
mpyne committed R365:0e80bd175262: Move --run handling outside of Application->new. (authored by mpyne).
Move --run handling outside of Application->new.
Sun, Dec 24, 9:33 PM
mpyne committed R365:b0f4b638c7cb: test: Add unit test for bug 388180 first-use persistent options. (authored by mpyne).
test: Add unit test for bug 388180 first-use persistent options.
Sun, Dec 24, 12:26 AM
mpyne committed R365:65d2e1b24556: GIT_SILENT This will come later. (authored by mpyne).
GIT_SILENT This will come later.
Sun, Dec 24, 12:26 AM

Sat, Dec 23

mpyne committed R365:d6d40e129f14: persistence: Fix regression in saving options, v2. (authored by mpyne).
persistence: Fix regression in saving options, v2.
Sat, Dec 23, 11:19 PM
mpyne committed R365:25e7bfc26fba: persistence: Fix regression in saving options. (authored by mpyne).
persistence: Fix regression in saving options.
Sat, Dec 23, 11:16 PM
mpyne committed R365:852b4b759e3e: Refactor Application::getModuleList. (authored by mpyne).
Refactor Application::getModuleList.
Sat, Dec 23, 10:33 PM
mpyne committed R365:9bcaeb7a244b: Rebuild a testing structure. (authored by mpyne).
Rebuild a testing structure.
Sat, Dec 23, 10:33 PM
mpyne committed R365:3da4f253a12a: Move some of option and cmdline data into BuildContext. (authored by mpyne).
Move some of option and cmdline data into BuildContext.
Sat, Dec 23, 10:33 PM

Dec 22 2017

mpyne committed R365:fdbaaaa548f9: kde-projects: Fix runtime check for YAML modules. (authored by mpyne).
kde-projects: Fix runtime check for YAML modules.
Dec 22 2017, 9:09 PM
mpyne committed R365:62b5614f9bd3: Standardize how we define is-a relationships. (authored by mpyne).
Standardize how we define is-a relationships.
Dec 22 2017, 9:09 PM

Dec 21 2017

mpyne committed R365:19d054971c3a: cmake: Use non-deprecated ECM vars and paths. (authored by mpyne).
cmake: Use non-deprecated ECM vars and paths.
Dec 21 2017, 9:51 PM
mpyne committed R365:ca586bf17aeb: kde-projects: Rename XML reader class. (authored by mpyne).
kde-projects: Rename XML reader class.
Dec 21 2017, 9:51 PM
mpyne committed R365:c1ed57c3dffa: kde-projects: Remove easy references to XML database. (authored by mpyne).
kde-projects: Remove easy references to XML database.
Dec 21 2017, 9:51 PM
mpyne committed R365:5b117f83a7fe: git: Remove snapshot code, sysadmins won't be bringing it back. (authored by mpyne).
git: Remove snapshot code, sysadmins won't be bringing it back.
Dec 21 2017, 9:51 PM
mpyne committed R365:305e69ee7f7f: Check for needed modules at startup. (authored by mpyne).
Check for needed modules at startup.
Dec 21 2017, 9:51 PM
mpyne committed R365:54bb06dd3113: yaml: Prefer YAML::Syck or YAML::PP over YAML modules. (authored by mpyne).
yaml: Prefer YAML::Syck or YAML::PP over YAML modules.
Dec 21 2017, 9:51 PM
mpyne committed R365:e1d38b76e514: GIT_SILENT Bump reported version. (authored by mpyne).
GIT_SILENT Bump reported version.
Dec 21 2017, 12:10 AM
mpyne committed R365:537ca8dec198: persistence: Serialize persistent data as JSON instead of Perl code. (authored by mpyne).
persistence: Serialize persistent data as JSON instead of Perl code.
Dec 21 2017, 12:10 AM

Dec 20 2017

mpyne committed R365:0d2256a66ccc: Print build message even when progress output unsupported. (authored by mpyne).
Print build message even when progress output unsupported.
Dec 20 2017, 7:54 PM
mpyne committed R365:0ad53f6119bb: Merge remote-tracking branch 'origin/kill_proj_xml' (authored by mpyne).
Merge remote-tracking branch 'origin/kill_proj_xml'
Dec 20 2017, 7:54 PM

Dec 19 2017

mpyne added a comment to D9334: Remove cmake 3.10+ warning for users of K_PLUGIN_FACTORY and K_PLUGIN_FACTORY_WITH_JSON.
In D9334#180830, @mpyne wrote:

In fact this appears to force files containing K_PLUGIN_FACTORY* into being evaluated by CMake's AUTOMOC (other warning fixes removed files from consideration by CMake AUTOMOC).

CMake itself appears to have had an interface change for AUTOMOC between 3.8 and 3.9+.

In particular, https://cmake.org/cmake/help/v3.8/manual/cmake-qt.7.html#automoc

If the macro is found in a C++ implementation file, the moc output will be put into a file named according to <basename>.moc, following the Qt conventions. The moc file may be included by the user in the C++ implementation file with a preprocessor #include. If it is not so included, it will be added to a separate file which is compiled into the target.

vs. https://cmake.org/cmake/help/v3.9/manual/cmake-qt.7.html#automoc

If the macro is found in a C++ implementation file, the moc output will be put into a file named according to <basename>.moc, following the Qt conventions. The <basename>.moc must be included by the user in the C++ implementation file with a preprocessor #include.

Not sure if this is a behavioural change, or rather a fix in the docu.

Dec 19 2017, 2:59 AM · Frameworks

Dec 18 2017

mpyne added a comment to D9334: Remove cmake 3.10+ warning for users of K_PLUGIN_FACTORY and K_PLUGIN_FACTORY_WITH_JSON.

In fact this appears to force files containing K_PLUGIN_FACTORY* into being evaluated by CMake's AUTOMOC (other warning fixes removed files from consideration by CMake AUTOMOC).

Dec 18 2017, 9:36 PM · Frameworks

Dec 17 2017

mpyne committed R365:e33ab11cee14: util: Remove redundant directory empty checking code. (authored by mpyne).
util: Remove redundant directory empty checking code.
Dec 17 2017, 2:32 AM
mpyne committed R365:6403bcc99340: kde-projects: Move git branch filter where it belongs. (authored by mpyne).
kde-projects: Move git branch filter where it belongs.
Dec 17 2017, 2:23 AM
mpyne committed R365:2ee9fb3f5b08: kde-projects: Update comments and remove dead code. (authored by mpyne).
kde-projects: Update comments and remove dead code.
Dec 17 2017, 2:23 AM
mpyne committed R365:9b618146004f: kde-projects: Fix logic for declaring a module was selected by name. (authored by mpyne).
kde-projects: Fix logic for declaring a module was selected by name.
Dec 17 2017, 2:23 AM
mpyne committed R365:cf926b46efce: kde-projects: Track how a module became a selection candidate. (authored by mpyne).
kde-projects: Track how a module became a selection candidate.
Dec 17 2017, 2:23 AM
mpyne committed R365:3f7b1d2750a9: git: Checkout the git branch as part of initial clone. (authored by mpyne).
git: Checkout the git branch as part of initial clone.
Dec 17 2017, 2:23 AM
mpyne committed R365:b9d7377a5e65: kde-projects: Skip modules at git-clone if needed branch not there. (authored by mpyne).
kde-projects: Skip modules at git-clone if needed branch not there.
Dec 17 2017, 2:23 AM
mpyne committed R365:e27eb8911a40: ipc: Only split log messages once on a comma. (authored by mpyne).
ipc: Only split log messages once on a comma.
Dec 17 2017, 2:23 AM

Dec 15 2017

mpyne committed R365:28afade793de: kde_projects: Consolidate metadata module creating code. (authored by mpyne).
kde_projects: Consolidate metadata module creating code.
Dec 15 2017, 10:43 PM
mpyne committed R365:e406fc0814e2: Merge branch 'master' into kill_proj_xml (authored by mpyne).
Merge branch 'master' into kill_proj_xml
Dec 15 2017, 10:43 PM

Dec 11 2017

mpyne added a comment to D9277: Remove cmake warning about generating moc file.

@aacid you might be thinking of my KI18n fix for ui*.h files in D9118, but I'm sure there's other examples.

Dec 11 2017, 3:03 AM · Frameworks
mpyne added a comment to D9128: [knewstuff] Respect global variable.

OK, if no one else has objections I'd say to commit.

Dec 11 2017, 3:02 AM · Frameworks

Dec 6 2017

mpyne accepted D9128: [knewstuff] Respect global variable.

I think the change looks good. But if the cache here is holding a *weak* pointer to a Cache then every user of this s_cache should be checking for null pointers each time, right? We can do the improved lifetime checking here but I think it would also have worked fine to check weak pointers before using them. Though maybe weak pointers were just there to avoid circular references?

Dec 6 2017, 11:42 PM · Frameworks

Dec 5 2017

mpyne committed R249:6e3b70843566: cmake: Mark UIC-generated .h files to skip AUTOMOC by default. (authored by mpyne).
cmake: Mark UIC-generated .h files to skip AUTOMOC by default.
Dec 5 2017, 1:08 AM
mpyne closed D9118: ki18n cmake macros: Mark UIC-generated .h files to skip AUTOMOC by default.
Dec 5 2017, 1:08 AM · Frameworks

Dec 3 2017

mpyne added a comment to D9120: Fix a memory leak.

I think ~KuitStaticData() *does* delete domainSetups. But deleting that QHash doesn't delete the underlying values. That means the real leak is at "Kuit::setupForDomain(QByteArray const&) (kuitmarkup.cpp:504)".

Dec 3 2017, 4:52 PM · Frameworks
mpyne added a comment to D9118: ki18n cmake macros: Mark UIC-generated .h files to skip AUTOMOC by default.
In D9118#174892, @aacid wrote:

Will this cause trouble with older cmake versions?

Dec 3 2017, 3:53 PM · Frameworks
mpyne committed R344:3df63ba076c0: Remove FindTunePimp CMake module. (authored by mpyne).
Remove FindTunePimp CMake module.
Dec 3 2017, 4:22 AM
mpyne committed R344:2f0126aa301c: Merge remote-tracking branch 'origin/Applications/17.12' (authored by mpyne).
Merge remote-tracking branch 'origin/Applications/17.12'
Dec 3 2017, 4:22 AM

Dec 2 2017

mpyne created D9118: ki18n cmake macros: Mark UIC-generated .h files to skip AUTOMOC by default.
Dec 2 2017, 10:00 PM · Frameworks
mpyne added a comment to D8256: Add _XOPEN_SOURCE to C definitions.

As I mentioned on the KDE bug, there is a possibility that changes like this would break FreeBSD. FreeBSD operates by a model of exporting symbols by default for legacy/BSD-specific needs. However if a feature flag is set, it limits its exports to *only* that required by the feature flag. Notably, all BSD-specific exports are removed in FreeBSD if you set a feature flag that doesn't also standardize that BSD feature, and unlike C libraries like musl and glibc, they don't support any feature flags to specifically request BSD-specific exports be exported.

Dec 2 2017, 8:31 PM · Build System, Frameworks
mpyne committed R344:741957e01c7a: Fix build when tunepimp is available. (authored by mpyne).
Fix build when tunepimp is available.
Dec 2 2017, 8:15 PM

Nov 25 2017

mpyne accepted D8992: Warn about errors when parsing json files.
Nov 25 2017, 9:44 PM · Frameworks

Nov 18 2017

mpyne accepted D8871: Don't look for /etc/kderc every single time.

+1

Nov 18 2017, 12:48 AM · Frameworks
mpyne accepted D8829: Make status bar a bit smaller..

Looks good, please commit.

Nov 18 2017, 12:47 AM

Nov 17 2017

mpyne accepted D8829: Make status bar a bit smaller..

The change is good (and looks better as well) but please change the type of the QWidget *parent in the StatusBar constructor before committing.

Nov 17 2017, 2:59 AM

Nov 10 2017

mpyne accepted D8737: Port to python3.
Nov 10 2017, 3:35 AM

Nov 9 2017

mpyne accepted D8716: Fix build with gcc 4.8.

This is fine to commit, but please add a comment to the effect of //FIXME: Workaround for GCC 4.8, remove .data() in 2019. I can confirm this works fine with more recent GCCs (it seems this is a compiler bug as the QTBUG commentary states). I'm not sure which GCC compiler is the first to have this bug fixed but I can't imagine that I'd wait past 2019 either way.

Nov 9 2017, 12:13 AM

Nov 5 2017

mpyne committed R365:0acbba6c5267: setIgnoredSelectors needs a listref. (authored by mpyne).
setIgnoredSelectors needs a listref.
Nov 5 2017, 11:43 PM
mpyne committed R365:db8c751e197c: qmake: Improve Qt5 build support. (authored by mpyne).
qmake: Improve Qt5 build support.
Nov 5 2017, 11:43 PM
mpyne committed R365:edf763ff6eeb: qmake: Don't panic in pretend mode. (authored by mpyne).
qmake: Don't panic in pretend mode.
Nov 5 2017, 11:43 PM

Oct 19 2017

mpyne committed R365:94c584d2af7a: qt: Building qt5/qtbase requires the builddir hack as well. (authored by mpyne).
qt: Building qt5/qtbase requires the builddir hack as well.
Oct 19 2017, 1:43 AM

Oct 15 2017

mpyne committed R365:24df79c6018e: qt5: Use the old "builddir hack" for Qt5's own QMake-using modules. (authored by mpyne).
qt5: Use the old "builddir hack" for Qt5's own QMake-using modules.
Oct 15 2017, 4:26 AM
mpyne committed R365:812482378e6e: Ignore modern SCMs too, if using the "lndir" reimplementation. (authored by mpyne).
Ignore modern SCMs too, if using the "lndir" reimplementation.
Oct 15 2017, 4:26 AM
mpyne committed R365:7f808f5ec675: Ensure all potential logdirs setup prior to async execution. (authored by mpyne).
Ensure all potential logdirs setup prior to async execution.
Oct 15 2017, 4:26 AM

Oct 12 2017

mpyne committed R344:ee358b1b8d5a: systemtray: Fix crash with scroll-to-next. (authored by mpyne).
systemtray: Fix crash with scroll-to-next.
Oct 12 2017, 2:27 AM

Oct 8 2017

mpyne added a comment to D8207: Use https for KDE urls.

I support the idea, but I think there's a few more spots where we can convert http:// to https://. I ran ag --only-matching --no-heading 'http:.*k.*\.org' in the kcoreaddons source directory, with the current version of this patch already applied, and got the following output:

Oct 8 2017, 9:37 PM · Frameworks

Oct 7 2017

mpyne committed R344:57be37b33ef1: mpris2: Really fix missing embedded cover art. (authored by mpyne).
mpris2: Really fix missing embedded cover art.
Oct 7 2017, 8:35 PM
mpyne committed R344:44079ec0f483: Fix build failure on FreeBSD. (authored by mpyne).
Fix build failure on FreeBSD.
Oct 7 2017, 8:14 PM
mpyne committed R344:b7ed1ed7b7bc: mpris2: Re-add cover info to MPRIS metadata for tracks with embedded art. (authored by mpyne).
mpris2: Re-add cover info to MPRIS metadata for tracks with embedded art.
Oct 7 2017, 8:14 PM
mpyne committed R344:90f1694a3efc: mpris2: Do not set MPRIS2 metadata for empty fields. (authored by mpyne).
mpris2: Do not set MPRIS2 metadata for empty fields.
Oct 7 2017, 2:33 AM
mpyne committed R344:ff245950731b: Simplify the "atom" type for changes to filename or TagLib metadata. (authored by mpyne).
Simplify the "atom" type for changes to filename or TagLib metadata.
Oct 7 2017, 1:13 AM
mpyne committed R344:280ac1e377ea: Simplify FileHandle (remove custom refcount, enforce more invariants). (authored by mpyne).
Simplify FileHandle (remove custom refcount, enforce more invariants).
Oct 7 2017, 1:13 AM
mpyne committed R344:8c16505933ea: tagtransactionmanager: Remove my custom global static. (authored by mpyne).
tagtransactionmanager: Remove my custom global static.
Oct 7 2017, 1:13 AM

Oct 5 2017

mpyne committed R244:4bdc7bb199ec: desktoptojson: Improve legacy service type detection heuristic. (authored by mpyne).
desktoptojson: Improve legacy service type detection heuristic.
Oct 5 2017, 12:55 AM
mpyne closed D8002: Improve DesktopFileParser heuristic for finding old-style service desktop entries.
Oct 5 2017, 12:55 AM · Frameworks

Oct 4 2017

mpyne added inline comments to D8002: Improve DesktopFileParser heuristic for finding old-style service desktop entries.
Oct 4 2017, 11:20 PM · Frameworks
mpyne committed R344:230b5b8f330a: Use KFormat for time duration and other status label code cleanups. (authored by mpyne).
Use KFormat for time duration and other status label code cleanups.
Oct 4 2017, 3:22 AM
mpyne committed R344:0598677dd64f: Decouple StatusLabel from PlayerManager, cleanup StatusLabel. (authored by mpyne).
Decouple StatusLabel from PlayerManager, cleanup StatusLabel.
Oct 4 2017, 3:22 AM

Oct 2 2017

mpyne committed R344:a68bf16496c6: Simplify change detection signaling in tag editor. (authored by mpyne).
Simplify change detection signaling in tag editor.
Oct 2 2017, 3:28 AM
mpyne committed R344:567606d7e474: Ensure that File->Quit doesn't bypass JuK::queryClose. (authored by mpyne).
Ensure that File->Quit doesn't bypass JuK::queryClose.
Oct 2 2017, 3:28 AM
mpyne committed R344:3d153778adbb: Use a less magical way of hooking widgets together in tag editor. (authored by mpyne).
Use a less magical way of hooking widgets together in tag editor.
Oct 2 2017, 3:28 AM
mpyne committed R344:d7c56f4f5de4: Fix stupid typo breaking combo boxes in tag editor. (authored by mpyne).
Fix stupid typo breaking combo boxes in tag editor.
Oct 2 2017, 3:28 AM
mpyne committed R344:c8e8d5f3f2a7: Add final markers for virtual functions in Playlist observer iface. (authored by mpyne).
Add final markers for virtual functions in Playlist observer iface.
Oct 2 2017, 3:28 AM
mpyne committed R344:d61c5adb24d2: Fix broken signal/slot in File Renamer .ui. (authored by mpyne).
Fix broken signal/slot in File Renamer .ui.
Oct 2 2017, 3:28 AM

Oct 1 2017

mpyne committed R344:be2d64955c0c: Remove dead code (SortedStringList). (authored by mpyne).
Remove dead code (SortedStringList).
Oct 1 2017, 11:21 PM