mpyne (Michael Pyne)
User

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Monday

  • Clear sailing ahead.

User Details

User Since
Mar 23 2016, 2:38 AM (78 w, 3 d)
Availability
Available

Recent Activity

Fri, Sep 8

mpyne committed R365:cfac4d8ebd52: Bump copyright year, better late than never. (authored by mpyne).
Bump copyright year, better late than never.
Fri, Sep 8, 11:25 PM
mpyne committed R365:07f9d8f08f8a: Show git version in --version if running kdesrc-build from git. (authored by mpyne).
Show git version in --version if running kdesrc-build from git.
Fri, Sep 8, 11:25 PM

Wed, Aug 30

mpyne committed R344:ce7335456367: Fix invalid signal/slot connection warnings. (authored by mpyne).
Fix invalid signal/slot connection warnings.
Wed, Aug 30, 3:33 AM
mpyne committed R344:b0d8e7b75c82: Remove splash screen. (authored by mpyne).
Remove splash screen.
Wed, Aug 30, 3:33 AM
mpyne committed R344:17828b060c97: Finish cache port from KStandardDirs to QStandardPaths. (authored by mpyne).
Finish cache port from KStandardDirs to QStandardPaths.
Wed, Aug 30, 3:33 AM
mpyne committed R344:b32995305a02: Port away from KSaveFile. (authored by mpyne).
Port away from KSaveFile.
Wed, Aug 30, 3:33 AM
mpyne committed R344:f8ee589bc23e: Use QStringBuilder by default. (authored by mpyne).
Use QStringBuilder by default.
Wed, Aug 30, 3:33 AM

Tue, Aug 29

mpyne committed R344:99a06b6e9f69: Port Cache playlist away from KGlobal::dirs(). (authored by mpyne).
Port Cache playlist away from KGlobal::dirs().
Tue, Aug 29, 3:01 AM
mpyne committed R344:78517970124c: Fix stray playlist saving porting error. (authored by mpyne).
Fix stray playlist saving porting error.
Tue, Aug 29, 3:01 AM

Mon, Aug 28

mpyne committed R344:9072d16f091b: Port MediaFiles away from KFileDialog. (authored by mpyne).
Port MediaFiles away from KFileDialog.
Mon, Aug 28, 3:43 AM
mpyne committed R344:9b9521ca3ae4: Port away from K* widgets in cover dialog. (authored by mpyne).
Port away from K* widgets in cover dialog.
Mon, Aug 28, 3:43 AM
mpyne committed R344:b3dd3f67b9ce: Don't crash in BIC cache error handler if .m3u playlist was read. (authored by mpyne).
Don't crash in BIC cache error handler if .m3u playlist was read.
Mon, Aug 28, 3:43 AM

Sun, Aug 27

mpyne committed R344:cd5bc7a32bf2: Remove now-redundant "endl" with debug output. (authored by mpyne).
Remove now-redundant "endl" with debug output.
Sun, Aug 27, 11:05 PM
mpyne committed R344:b8c9ea7965ad: GIT_SILENT Remove redundant tageditor QObject connect. (authored by mpyne).
GIT_SILENT Remove redundant tageditor QObject connect.
Sun, Aug 27, 11:05 PM
mpyne committed R344:2790a72465a4: Fix upcoming playlist crashes. (authored by kkasper).
Fix upcoming playlist crashes.
Sun, Aug 27, 9:24 PM
mpyne closed D7553: Fix upcoming playlist. by committing R344:2790a72465a4: Fix upcoming playlist crashes. (authored by kkasper).
Sun, Aug 27, 9:24 PM
mpyne added a comment to D7553: Fix upcoming playlist..

Well, the KDE convention is usually to use Phabricator anyways, so in that regard you're already doing the right thing. :)

Sun, Aug 27, 8:59 PM
mpyne committed R344:d726a5800049: Make volume popup actually popup. (authored by mpyne).
Make volume popup actually popup.
Sun, Aug 27, 8:37 PM
mpyne committed R344:be4fbb0eaaec: Fix track position/volume slider appearance in toolbars. (authored by mpyne).
Fix track position/volume slider appearance in toolbars.
Sun, Aug 27, 8:37 PM
mpyne accepted D7553: Fix upcoming playlist..

OK, it's fine to commit then, all this Playlist code mixing the data model with the UI needs to be nuked from orbit anyways, but that will have to happen later. :)

Sun, Aug 27, 4:07 PM
mpyne committed R344:24246f52b168: Fix QActions in systray. (authored by mpyne).
Fix QActions in systray.
Sun, Aug 27, 4:43 AM
mpyne committed R344:647e8ce5feab: Cleanup AdvancedSearchPlaylist. (authored by mpyne).
Cleanup AdvancedSearchPlaylist.
Sun, Aug 27, 2:30 AM
mpyne committed R344:7fe64d10d66e: Fix 'trying to add empty file warnings'. (authored by mpyne).
Fix 'trying to add empty file warnings'.
Sun, Aug 27, 2:30 AM
mpyne committed R344:2889fd1fa4b7: More QAction streamlining. (authored by mpyne).
More QAction streamlining.
Sun, Aug 27, 12:11 AM

Sat, Aug 26

mpyne added a comment to D7553: Fix upcoming playlist..

Only question I have is why moving insertItem to add at beginning instead of end would help with the crash here. Or is it just a 'related' fix? The takeItem fix is correct.

Sat, Aug 26, 11:29 PM
mpyne committed R344:3dc41085def2: Port KAction -> QAction. (authored by mpyne).
Port KAction -> QAction.
Sat, Aug 26, 4:32 AM
mpyne committed R344:76924566a0d2: GIT_SILENT: Suppress fallthrough warnings. (authored by mpyne).
GIT_SILENT: Suppress fallthrough warnings.
Sat, Aug 26, 4:32 AM
mpyne committed R344:6b804079aaeb: Port away from kDebug. (authored by mpyne).
Port away from kDebug.
Sat, Aug 26, 3:53 AM
mpyne committed R344:8e49c93e0396: Port KIcon to QIcon. (authored by mpyne).
Port KIcon to QIcon.
Sat, Aug 26, 3:53 AM
mpyne committed R344:ec1a2b14cbaa: Remove undefined-behavior null check. (authored by mpyne).
Remove undefined-behavior null check.
Sat, Aug 26, 2:49 AM
mpyne committed R344:a022fe908991: Avoid masking virtal function. (authored by mpyne).
Avoid masking virtal function.
Sat, Aug 26, 2:49 AM
mpyne committed R344:ff147582c9f7: Remove KSharedPtr. (authored by mpyne).
Remove KSharedPtr.
Sat, Aug 26, 2:33 AM
mpyne committed R344:016c25a56bbf: Remove K3B exporter for now rather than porting it. (authored by mpyne).
Remove K3B exporter for now rather than porting it.
Sat, Aug 26, 1:09 AM
mpyne committed R344:094ed8686166: Avoid deprecated KGlobal::config. (authored by mpyne).
Avoid deprecated KGlobal::config.
Sat, Aug 26, 1:01 AM
mpyne committed R344:925bc93ade79: KIntSpinBox -> QSpinBox. (authored by mpyne).
KIntSpinBox -> QSpinBox.
Sat, Aug 26, 1:01 AM
mpyne committed R344:551e52cbdf4c: KPushButton -> QPushButton. (authored by mpyne).
KPushButton -> QPushButton.
Sat, Aug 26, 12:40 AM

Fri, Aug 25

mpyne committed R344:fce1c72a69e3: Remove a KSharedPtr. (authored by mpyne).
Remove a KSharedPtr.
Fri, Aug 25, 3:45 AM
mpyne committed R344:f00e55c1d531: Let automoc handle the #includes. (authored by mpyne).
Let automoc handle the #includes.
Fri, Aug 25, 3:44 AM
mpyne committed R344:b9bd918ee346: Port away from deprecated KPushButton. (authored by mpyne).
Port away from deprecated KPushButton.
Fri, Aug 25, 3:40 AM
mpyne committed R344:a2815d69eba7: Assorted CMake and include cleanups/modernizations. (authored by mpyne).
Assorted CMake and include cleanups/modernizations.
Fri, Aug 25, 3:40 AM

Aug 23 2017

mpyne committed R365:9f70d018b9c9: git: Keep the tags up to date at initial clone and after. (authored by mpyne).
git: Keep the tags up to date at initial clone and after.
Aug 23 2017, 1:43 AM
mpyne committed R365:2d87974100e3: Quiet --pretend output further. (authored by mpyne).
Quiet --pretend output further.
Aug 23 2017, 1:43 AM
mpyne committed R365:02c616cbb089: Reduce importance of qtdir option, default to ''. (authored by mpyne).
Reduce importance of qtdir option, default to ''.
Aug 23 2017, 1:43 AM

Aug 13 2017

mpyne added a comment to D7281: KCoreAddons: Enforce hidden symbol visibility in nested private classes.

@mpyne: Beware, I have such patches prepared for all of KF :)

Aug 13 2017, 4:21 PM · Frameworks

Aug 12 2017

mpyne created D7281: KCoreAddons: Enforce hidden symbol visibility in nested private classes.
Aug 12 2017, 11:41 PM · Frameworks
mpyne committed R244:077ef6797eb6: desktopfileparser: Fix non-compliant key/value parsing. (authored by mpyne).
desktopfileparser: Fix non-compliant key/value parsing.
Aug 12 2017, 11:23 PM
mpyne closed D7170: Fix errorneous whitespace handling in Desktop Entry parsing from DesktopFileParser by committing R244:077ef6797eb6: desktopfileparser: Fix non-compliant key/value parsing..
Aug 12 2017, 11:23 PM · Frameworks

Aug 9 2017

mpyne updated the diff for D7170: Fix errorneous whitespace handling in Desktop Entry parsing from DesktopFileParser.

Joins the regex for the Type= line with its use.

Aug 9 2017, 3:48 AM · Frameworks
mpyne committed R237:11ee92d92b1e: kconfigini: Strip leading whitespace when reading entry values. (authored by mpyne).
kconfigini: Strip leading whitespace when reading entry values.
Aug 9 2017, 3:42 AM
mpyne closed D7169: Fix errorneous whitespace handling in Desktop Entry parsing from KConfigIni by committing R237:11ee92d92b1e: kconfigini: Strip leading whitespace when reading entry values..
Aug 9 2017, 3:42 AM · Frameworks

Aug 7 2017

mpyne created D7170: Fix errorneous whitespace handling in Desktop Entry parsing from DesktopFileParser.
Aug 7 2017, 2:03 AM · Frameworks
mpyne created D7169: Fix errorneous whitespace handling in Desktop Entry parsing from KConfigIni.
Aug 7 2017, 1:44 AM · Frameworks

Aug 2 2017

mpyne committed R365:613b973e0e6d: Allow repeated ignore-modules decls. (authored by mpyne).
Allow repeated ignore-modules decls.
Aug 2 2017, 2:41 AM

Aug 1 2017

mpyne committed R365:0c565a6ad978: Re-fix my module search path fixup. (authored by mpyne).
Re-fix my module search path fixup.
Aug 1 2017, 1:47 AM

Jul 30 2017

mpyne committed R365:b7b4bb99f92f: Merge branch 'streamline-drivers' (authored by mpyne).
Merge branch 'streamline-drivers'
Jul 30 2017, 7:11 PM
mpyne committed R365:9031e6c85fdd: Add install-environment-driver option. (authored by mpyne).
Add install-environment-driver option.
Jul 30 2017, 7:11 PM
mpyne committed R365:58f9b7b5d564: Install session driver support scripts. (authored by mpyne).
Install session driver support scripts.
Jul 30 2017, 7:11 PM

Jul 27 2017

mpyne committed R241:15451d505fdb: Fix build on musl libc by exposing setgroups(2). (authored by mpyne).
Fix build on musl libc by exposing setgroups(2).
Jul 27 2017, 3:42 AM
mpyne closed D6597: Add magic define to enable setgroups(2) by committing R241:15451d505fdb: Fix build on musl libc by exposing setgroups(2)..
Jul 27 2017, 3:42 AM · Frameworks
mpyne committed R303:c42f18a7fc1a: Use proper feature flag to include kill(2). (authored by mpyne).
Use proper feature flag to include kill(2).
Jul 27 2017, 3:33 AM
mpyne closed D6598: Declare _POSIX_SOURCE to ensure kill(2) is declared by committing R303:c42f18a7fc1a: Use proper feature flag to include kill(2)..
Jul 27 2017, 3:33 AM · Frameworks
mpyne committed R106:3588e85cd8a6: softraid: Remove dead code and associated warning. (authored by mpyne).
softraid: Remove dead code and associated warning.
Jul 27 2017, 1:53 AM
mpyne closed D6658: Fix mdstat parsing of inactive RAID arrays, remove dead code by committing R106:3588e85cd8a6: softraid: Remove dead code and associated warning..
Jul 27 2017, 1:53 AM · Plasma
mpyne committed R106:09d8fdf91465: Properly check if mdraid array is active. (authored by mpyne).
Properly check if mdraid array is active.
Jul 27 2017, 1:53 AM

Jul 24 2017

mpyne committed R365:38bf5d6ff146: env-driver: Complete porting std config to KF5. (authored by mpyne).
env-driver: Complete porting std config to KF5.
Jul 24 2017, 3:28 AM
mpyne committed R365:b376b6c6384b: env-driver: Quote value for assignment in eval. (authored by mpyne).
env-driver: Quote value for assignment in eval.
Jul 24 2017, 3:28 AM
mpyne committed R365:84aad277bebe: Simplify environment/session driver scripts. (authored by mpyne).
Simplify environment/session driver scripts.
Jul 24 2017, 3:28 AM
mpyne committed R365:6062a3523782: kdesrc-build-setup: Remove dev question, add drivers. (authored by mpyne).
kdesrc-build-setup: Remove dev question, add drivers.
Jul 24 2017, 3:28 AM
mpyne committed R365:65ad4c424f82: Add install-environment-driver option. (authored by mpyne).
Add install-environment-driver option.
Jul 24 2017, 12:18 AM
mpyne committed R365:b5940ba40cbc: Install session driver support scripts. (authored by mpyne).
Install session driver support scripts.
Jul 24 2017, 12:18 AM

Jul 23 2017

mpyne committed R245:2382c3f8d366: Require sys/types.h for dev_t unconditionally. (authored by mpyne).
Require sys/types.h for dev_t unconditionally.
Jul 23 2017, 3:40 PM
mpyne closed D6596: Fix dev_t declaration for Solid UDisks2 backend by committing R245:2382c3f8d366: Require sys/types.h for dev_t unconditionally..
Jul 23 2017, 3:40 PM · Frameworks

Jul 22 2017

mpyne added a comment to D6597: Add magic define to enable setgroups(2).

With the help of the KDE sysadmins, I've tested this to build on FreeBSD. BSD-specific defines remain available on FreeBSD unless you start to use _POSIX_C_SOURCE, _ANSI_SOURCE, or _XOPEN_SOURCE. So _BSD_SOURCE and _DEFAULT_SOURCE appear to be safe for FreeBSD.

Jul 22 2017, 11:57 PM · Frameworks
mpyne added a comment to D6596: Fix dev_t declaration for Solid UDisks2 backend.

If there are objections to this please let me know in next few days. A similar Differential request to this has already been opened and abandoned.

Jul 22 2017, 8:44 PM · Frameworks
mpyne added a comment to D6658: Fix mdstat parsing of inactive RAID arrays, remove dead code.

If anyone has objections please let me know in the next few days.

Jul 22 2017, 8:41 PM · Plasma
mpyne committed R106:7c551f82de4b: FreeBSD build fix, v4. (authored by mpyne).
FreeBSD build fix, v4.
Jul 22 2017, 6:36 PM

Jul 21 2017

mpyne committed R106:5bef0ecaa071: FreeBSD compile fix, try 3. (authored by mpyne).
FreeBSD compile fix, try 3.
Jul 21 2017, 11:46 PM
mpyne added a comment to D6631: Fix compilation with strict libc (such as musl).

Sorry, looks like it's still unhappy (another different error). This time it's complaining about gettimeofday()
According to https://github.com/kinetiknz/cubeb/issues/6 defining XOPEN_SOURCE will sort this, but i'm not sure if musl is okay with that?

Jul 21 2017, 11:42 PM · Plasma

Jul 19 2017

mpyne accepted D6789: API dox: add note about moc include need with K_PLUGIN_FACTORY(_WITH_JSON).
Jul 19 2017, 10:34 PM · Frameworks
mpyne accepted D6672: add KAboutLicense::spdx and introduce orLater qualification.
Jul 19 2017, 9:38 PM · Frameworks
mpyne added a comment to D6631: Fix compilation with strict libc (such as musl).

Thanks for the quick fix.

Getting closer - got a different error this time...
https://build.kde.org/job/Plasma%20ksysguard%20kf5-qt5%20FreeBSDQt5.7/7/

Jul 19 2017, 9:31 PM · Plasma
mpyne committed R106:8c650abc851c: Fix FreeBSD build, try 2. (authored by mpyne).
Fix FreeBSD build, try 2.
Jul 19 2017, 9:29 PM

Jul 17 2017

mpyne added a comment to D6672: add KAboutLicense::spdx and introduce orLater qualification.

Ah drat. We could still get rid of the second private ctor though, by moving the defaults from the private to the public and calling the full private ctor:

Jul 17 2017, 7:47 PM · Frameworks
mpyne added a comment to D6631: Fix compilation with strict libc (such as musl).
Jul 17 2017, 7:33 PM · Plasma
mpyne committed R106:6db11670e942: Fix build regression on FreeBSD (authored by mpyne).
Fix build regression on FreeBSD
Jul 17 2017, 7:31 PM
mpyne added a comment to D6672: add KAboutLicense::spdx and introduce orLater qualification.

I like delegating constructors, but we can't use them in Frameworks yet. :(

Jul 17 2017, 5:12 PM · Frameworks
mpyne accepted D6700: disable compiler warning on testing deprecated function.
Jul 17 2017, 2:07 AM · Frameworks
mpyne requested changes to D6672: add KAboutLicense::spdx and introduce orLater qualification.

Still a couple of things:

Jul 17 2017, 2:06 AM · Frameworks

Jul 13 2017

mpyne requested changes to D6672: add KAboutLicense::spdx and introduce orLater qualification.

AFAICT we do need to maintain BIC here even for private ctors. The inline comment has more detail. Other than that and with using a flag enum instead of a bool I like the patch and the approach, and how you've maintained the same basic approach the existing code does.

Jul 13 2017, 4:24 PM · Frameworks

Jul 12 2017

mpyne created D6658: Fix mdstat parsing of inactive RAID arrays, remove dead code.
Jul 12 2017, 8:09 PM · Plasma
mpyne committed R106:257591cf462d: Fix compilation with strict libc (such as musl). (authored by mpyne).
Fix compilation with strict libc (such as musl).
Jul 12 2017, 3:18 PM
mpyne closed D6631: Fix compilation with strict libc (such as musl) by committing R106:257591cf462d: Fix compilation with strict libc (such as musl)..
Jul 12 2017, 3:18 PM · Plasma

Jul 11 2017

mpyne updated the summary of D6631: Fix compilation with strict libc (such as musl).
Jul 11 2017, 3:40 PM · Plasma
mpyne created D6631: Fix compilation with strict libc (such as musl).
Jul 11 2017, 3:30 PM · Plasma

Jul 10 2017

mpyne created D6598: Declare _POSIX_SOURCE to ensure kill(2) is declared.
Jul 10 2017, 12:10 AM · Frameworks

Jul 9 2017

mpyne created D6597: Add magic define to enable setgroups(2).
Jul 9 2017, 11:49 PM · Frameworks
mpyne created D6596: Fix dev_t declaration for Solid UDisks2 backend.
Jul 9 2017, 11:37 PM · Frameworks
mpyne committed R365:a23ed5fd2437: Uniformly handle deferred option assignment. (authored by mpyne).
Uniformly handle deferred option assignment.
Jul 9 2017, 9:49 PM

Jul 8 2017

mpyne committed R244:b8cb28bcd070: kdirwatch: Avoid potential crash if d-ptr destroyed before KDirWatch. (authored by rjvbb).
kdirwatch: Avoid potential crash if d-ptr destroyed before KDirWatch.
Jul 8 2017, 7:01 PM

Jul 1 2017

mpyne committed R239:16d159e7b910: Search for KEmoticons, which is a dependency per the CMake config.cmake.in. (authored by mpyne).
Search for KEmoticons, which is a dependency per the CMake config.cmake.in.
Jul 1 2017, 2:20 AM