- User Since
- Mar 23 2016, 2:38 AM (134 w, 5 d)
Sat, Oct 20
Fri, Oct 19
Sun, Oct 14
I've added shell support for /etc/os-release at commit f3f100de6410d5ad9b84bef2d237ee2540e0f043
Anyone have a chance to look at this?
Sat, Oct 13
Mon, Oct 8
Wed, Sep 26
Sun, Sep 23
Still in action. Latest updates (in the make_it_mojo branch) significantly simplify the event-driven logic by moving the event handling in a big huge chain of promise->thens.
Sep 22 2018
Sep 16 2018
Sep 15 2018
I agree as maintainer that this would be useful.
Sep 7 2018
It occurred to me while I was at work today that an attacker in position to MITM the search result we get back would also be able to MITM the lyrics page directly. Given that I'm less worried about whitelisting as that is barely even a speedbump. Encoding is technically still a good idea but I think the default mode should be enough for most normal pages.
Wikia doesn't support HTTPS so I'm at least a little leery of just dumping potentially-malicious output into a clickable link. A simple whitelist might be sufficient to at least make an attack along this vector more annoying than it would be worth.
Sep 2 2018
I vaguely remember this being required, it probably got dropped in the port to KF5 by accident. I concur with your diagnosis and suggested fix. Please commit!
Sorry, if I'd been able to check this earlier I'd have warned against pushing, this was the kind of concern I was addressing with my earlier comment about FreeBSD. I had run into a lot of those issues when trying to get KF5 to build on Alpine.
Aug 25 2018
The ECM documentation points to a specific change that may be related: https://api.kde.org/ecm/kde-module/KDECMakeSettings.html#build-settings
I don't know the cause myself but the ECM version works up until 5.38.0 in my own testing. So presumably the change in behavior is something introduced in that release of ECM?
I'd say to leave the code alone if this the change isn't needed to fix a bug.
LGTM and there's been plenty of time for a NAK. I say let's commit.
Aug 22 2018
As long as older versions of LLVM result in the Python binding generation step being skipped completely (we already check for libclang in the find-package for this, right?), I don't think the dependency increase is a problem.
This change has worked fine for me in my testing (including KDE games and Plasma themes) so I think it's fine to commit.
Aug 19 2018
Aug 18 2018
LGTM but then I don't use the Python bindings. Have you already tried the kcoreaddons build to see if this makes it work where it had failed before?
Aug 15 2018
Aug 14 2018
Aug 13 2018
Jul 20 2018
The patch looks OK but I'm a bit worried about trying to lock the cache at the same time we're potentially trying to delete a KSharedDataCache so I'm going to recompile and do some stress and sanity tests first.
Jul 15 2018
I don't use Baloo directly but I've taken a look from a code sanity perspective and agree with @dhaumann that the change is a proper port of the existing logic.
Jul 9 2018
Jul 7 2018
Jul 4 2018
Jul 2 2018
Jul 1 2018
Jun 29 2018
I've tested, it compiles and installs fine and seems to work in my testing with qdbusviewer to verify that the inhibition is set during playback. I'm not sure of a better way to test on my system since I don't go crazy with power management anyways but it's at least good enough to commit and get out to a wider user base for testing.
May 27 2018
May 16 2018
May 12 2018
OK thanks. Please commit whenever you're ready.
May 9 2018
Looks good to me, but do you know if there are any other directories we'd need to check (on Unixy systems) besides /usr?