mpyne (Michael Pyne)
User

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Mar 23 2016, 2:38 AM (172 w, 6 d)
Availability
Available

Recent Activity

Fri, Jul 12

mpyne committed R365:1609668a0e2b: initial-setup: Add missing Fedora packages. (authored by usta).
initial-setup: Add missing Fedora packages.
Fri, Jul 12, 1:23 AM
mpyne closed D22319: Forgotten bzr for fedora packages.
Fri, Jul 12, 1:23 AM · kdesrc-build
mpyne added a comment to D22319: Forgotten bzr for fedora packages.
In D22319#493438, @usta wrote:

Change is good to commit. Please let me know if you're not able to commit and I can on your behalf.

I had kde git account on the other hand i didnt made any commits since about 2 years, maybe because of that or maybe there is another type of write access needed by kdesrc-build repo ,
i couldnt able to push my changes.

remote: error: hook declined to update refs/heads/master
To git.kde.org:kdesrc-build.git

! [remote rejected] master -> master (hook declined)

error: failed to push some refs to 'git@git.kde.org:kdesrc-build.git'

Could you tell me if i am doing something wrong ?

Fri, Jul 12, 1:09 AM · kdesrc-build

Wed, Jul 10

mpyne committed R365:21afc50ed5fa: buildsystem: Remove link to deleted wiki page. (authored by mpyne).
buildsystem: Remove link to deleted wiki page.
Wed, Jul 10, 1:22 AM
mpyne accepted D22319: Forgotten bzr for fedora packages.

Change is good to commit. Please let me know if you're not able to commit and I can on your behalf.

Wed, Jul 10, 12:16 AM · kdesrc-build

Sun, Jul 7

mpyne committed R365:00d2ae89d95a: git: Improve detection of local changes. (authored by mpyne).
git: Improve detection of local changes.
Sun, Jul 7, 12:02 AM

Fri, Jul 5

mpyne committed R344:23e632fd3f45: Merge branch 'ltoscano/juk-selectable-track-title' into Applications/19.04 (authored by mpyne).
Merge branch 'ltoscano/juk-selectable-track-title' into Applications/19.04
Fri, Jul 5, 2:51 PM

Thu, Jul 4

mpyne committed R365:99c87f4922cd: sample-rc: Give the only anon module-set a name. (authored by mpyne).
sample-rc: Give the only anon module-set a name.
Thu, Jul 4, 3:54 PM

Sun, Jun 23

mpyne committed R344:75e25a39c3e6: renamer: Stretch the content, not the label of confirm dialog. (authored by mpyne).
renamer: Stretch the content, not the label of confirm dialog.
Sun, Jun 23, 9:48 PM
mpyne committed R344:fea7e6ca67bd: Merge branch 'Applications/19.04' (authored by mpyne).
Merge branch 'Applications/19.04'
Sun, Jun 23, 9:48 PM
mpyne committed R344:4c921d333a50: m3u: Add M3U tracks to playlist in the order provided in the file. (authored by mpyne).
m3u: Add M3U tracks to playlist in the order provided in the file.
Sun, Jun 23, 9:48 PM
mpyne committed R344:f23803e7e0c4: renamer: Fix missing accept button in confirm dialog. (authored by mpyne).
renamer: Fix missing accept button in confirm dialog.
Sun, Jun 23, 9:14 PM
mpyne committed R344:2edcd727ee7a: Merge branch 'Applications/19.04' (authored by mpyne).
Merge branch 'Applications/19.04'
Sun, Jun 23, 7:30 PM
mpyne committed R344:f768d0ccd0f0: Found a few more compiler warnings to fix [-Wsuggest-override]. (authored by mpyne).
Found a few more compiler warnings to fix [-Wsuggest-override].
Sun, Jun 23, 7:30 PM
mpyne committed R344:55a6bd7170e5: Fix drag-and-drop of playlist items onto a playlist icon. (authored by mpyne).
Fix drag-and-drop of playlist items onto a playlist icon.
Sun, Jun 23, 7:30 PM
mpyne committed R344:5f3e09d4d59e: GIT_SILENT Remove unused include. (authored by mpyne).
GIT_SILENT Remove unused include.
Sun, Jun 23, 7:30 PM
mpyne committed R365:bf94eac4e56e: Merge branch 'master' into make_it_mojo (authored by mpyne).
Merge branch 'master' into make_it_mojo
Sun, Jun 23, 3:16 PM
mpyne committed R365:0d96a0e67880: build-system: Don't auto-clean build dir on repeated failure. (authored by mpyne).
build-system: Don't auto-clean build dir on repeated failure.
Sun, Jun 23, 3:16 PM

Mon, Jun 17

mpyne committed R365:3ffe4dbb17cd: mojo: Embed Mojolicious 8.19. (authored by mpyne).
mojo: Embed Mojolicious 8.19.
Mon, Jun 17, 3:41 AM
mpyne committed R365:c1037a34462b: mojo: Implement list-build and dependency-tree. (authored by mpyne).
mojo: Implement list-build and dependency-tree.
Mon, Jun 17, 3:41 AM
mpyne committed R365:c95776100798: mojo: Signal handler should still kill the process once handled. (authored by mpyne).
mojo: Signal handler should still kill the process once handled.
Mon, Jun 17, 3:41 AM

Jun 16 2019

mpyne committed R365:a469a387b8f2: mojo: Don't use debug function during cleanup. (authored by mpyne).
mojo: Don't use debug function during cleanup.
Jun 16 2019, 1:30 AM
mpyne committed R365:133f9a498509: mojo: Fix uninit warning when LC_ALL unset. (authored by mpyne).
mojo: Fix uninit warning when LC_ALL unset.
Jun 16 2019, 1:30 AM
mpyne committed R365:ef5156d64a32: mojo: Add Mojolicious pkg to GitLab CI, make --metadata-only work. (authored by mpyne).
mojo: Add Mojolicious pkg to GitLab CI, make --metadata-only work.
Jun 16 2019, 1:30 AM
mpyne committed R365:21a6056563e0: mojo: Port to ksb::BuildException in new-to-master code. (authored by mpyne).
mojo: Port to ksb::BuildException in new-to-master code.
Jun 16 2019, 1:30 AM
mpyne committed R365:ae0722fe1b45: test: Remove dead code in mojo-fied test. (authored by mpyne).
test: Remove dead code in mojo-fied test.
Jun 16 2019, 1:30 AM
mpyne committed R365:66319bec5d66: mojo: Correct testcase for bug 394497. (authored by mpyne).
mojo: Correct testcase for bug 394497.
Jun 16 2019, 1:30 AM
mpyne committed R365:c7de57d6db8c: Merge branch 'master' into make_it_mojo (authored by mpyne).
Merge branch 'master' into make_it_mojo
Jun 16 2019, 1:30 AM
mpyne committed R499:8312cab989b3: Remove duplicate project entries. (authored by mpyne).
Remove duplicate project entries.
Jun 16 2019, 1:26 AM

Jun 14 2019

mpyne committed R365:a9d08e8d4f6e: Update poppler cmake flags to new unstable ABI define. (authored by mpyne).
Update poppler cmake flags to new unstable ABI define.
Jun 14 2019, 11:35 PM
mpyne closed D21649: Fix poppler builds for kitinerary.
Jun 14 2019, 11:35 PM

Jun 8 2019

mpyne accepted D21649: Fix poppler builds for kitinerary.
Jun 8 2019, 6:47 PM

May 25 2019

mpyne accepted D21377: Only install missing Arch packages.

Great idea, thanks!

May 25 2019, 1:18 AM
mpyne accepted D21387: Make sample shell include work with custom Qt.

I was under the impression that LD_LIBRARY_PATH shouldn't be required if the paths to Qt are setup properly, but as long as you've tested that it's necessary I've no objection.

May 25 2019, 1:17 AM

May 18 2019

mpyne committed R344:1312b772a21a: Finish removing deprecated code. (authored by mpyne).
Finish removing deprecated code.
May 18 2019, 7:46 PM
mpyne committed R344:adf074673705: Remove broken/unused MusicBrainz feature and code. (authored by mpyne).
Remove broken/unused MusicBrainz feature and code.
May 18 2019, 7:46 PM
mpyne committed R344:3b703e1bb2f0: Remove deprecated code, fix NowPlaying bar height. (authored by mpyne).
Remove deprecated code, fix NowPlaying bar height.
May 18 2019, 7:46 PM
mpyne committed R344:7264132f038b: A few more FileRenamer cleanups since I was there. (authored by mpyne).
A few more FileRenamer cleanups since I was there.
May 18 2019, 6:48 PM
mpyne committed R344:44d6bb2d7c7d: Remove more compiler warnings for deprecated functions/uses. (authored by mpyne).
Remove more compiler warnings for deprecated functions/uses.
May 18 2019, 6:48 PM
mpyne committed R344:7d681172b19e: Remove deprecated use of QSignalMapper. (authored by mpyne).
Remove deprecated use of QSignalMapper.
May 18 2019, 6:48 PM
mpyne committed R344:f10458fac288: Merge branch 'Applications/19.04' (authored by mpyne).
Merge branch 'Applications/19.04'
May 18 2019, 6:48 PM
mpyne committed R344:dc2d9c8e0fe6: Add 'override' decl to fix compiler warnings, fix drag-and-drop. (authored by mpyne).
Add 'override' decl to fix compiler warnings, fix drag-and-drop.
May 18 2019, 6:48 PM

May 4 2019

mpyne committed R365:74d70dec915a: session-env: Set correct libname on Debian systems. (authored by jbbgameich).
session-env: Set correct libname on Debian systems.
May 4 2019, 8:35 PM
mpyne closed D19864: Set correct libname on debian systems as well.
May 4 2019, 8:35 PM
mpyne committed R365:b7f93bfed5df: first-run: Add support for Mageia 6 distribution. (authored by jjorge).
first-run: Add support for Mageia 6 distribution.
May 4 2019, 8:35 PM
mpyne closed D20936: Add support for Mageia distro.
May 4 2019, 8:35 PM · kdesrc-build
mpyne committed R365:6385f5e429dd: Add support for Meson build system. (authored by mpyne).
Add support for Meson build system.
May 4 2019, 8:35 PM

May 1 2019

mpyne accepted D20936: Add support for Mageia distro.

The patch works in my testing and looks reasonable. Are you able to commit or should I?

May 1 2019, 11:46 PM · kdesrc-build
mpyne committed R365:cd7af4eed524: meson: Fix build system integration bugs, add docs. (authored by mpyne).
meson: Fix build system integration bugs, add docs.
May 1 2019, 2:07 AM
mpyne committed R365:e54200ee3ce1: env: Do not prepend /bin when {qt,kde}dir is blank. (authored by mpyne).
env: Do not prepend /bin when {qt,kde}dir is blank.
May 1 2019, 1:24 AM

Apr 27 2019

mpyne committed R365:3cc8391c81b3: doc: Fix typo dependend -> depended. (authored by yurchor).
doc: Fix typo dependend -> depended.
Apr 27 2019, 4:32 PM
mpyne closed D20174: Fix typo: dependend -> depended.

I have committed the doc fix (and maintained your authorship). I expect that we will be able to automatically migrate git modules to the new location if it is decided to use Gitlab for all KDE git repositories, but in the meantime it does require manually running some git commands.

Apr 27 2019, 4:31 PM · Documentation

Apr 23 2019

mpyne committed R365:a3dee93b0ac1: WIP: Add support for Meson build system. (authored by mpyne).
WIP: Add support for Meson build system.
Apr 23 2019, 1:10 AM

Apr 20 2019

mpyne accepted D20279: Attempt to fixup dependency data declarations for non-KDE modules.

I like the change! We'll need to watch for things to add to ignored-projects as @bcooksley points out.

Apr 20 2019, 6:05 PM

Apr 13 2019

mpyne committed R365:2ca160487d2e: dep-resolv: Fix Perl warning about non-numeric comparison. (authored by mpyne).
dep-resolv: Fix Perl warning about non-numeric comparison.
Apr 13 2019, 2:23 AM
mpyne accepted D20174: Fix typo: dependend -> depended.

Looks good, thank you!

Apr 13 2019, 12:53 AM · Documentation

Mar 30 2019

mpyne accepted D20092: New class KOSRelease - a parser for os-release files.

+1 to @aacid's comment about relicensing.

Mar 30 2019, 4:19 PM · Frameworks

Mar 26 2019

mpyne accepted D19864: Set correct libname on debian systems as well.

Right then, sounds good.

Mar 26 2019, 1:51 AM

Mar 24 2019

mpyne committed R365:290244f144e4: kde_projects: All use of fullProjectPath for non-KDE modules. (authored by mpyne).
kde_projects: All use of fullProjectPath for non-KDE modules.
Mar 24 2019, 6:05 PM
mpyne closed D20008: Fix uninitialized value in SimpleJobPrivate.
Mar 24 2019, 5:13 PM · Frameworks
mpyne committed R241:920d2c4ca7d5: kjobs: Fix compiler warning for uninit value in SimpleJobPrivate. (authored by mpyne).
kjobs: Fix compiler warning for uninit value in SimpleJobPrivate.
Mar 24 2019, 5:13 PM

Mar 23 2019

mpyne requested review of D20008: Fix uninitialized value in SimpleJobPrivate.
Mar 23 2019, 11:05 PM · Frameworks
mpyne committed R365:ba2f176db89d: CI: Submodule tests require git config. (authored by mpyne).
CI: Submodule tests require git config.
Mar 23 2019, 10:51 PM
mpyne committed R365:27840ef81238: CI: Add git as a required build test tool for submodule test. (authored by mpyne).
CI: Add git as a required build test tool for submodule test.
Mar 23 2019, 10:28 PM
mpyne committed R365:3097d57e0e4f: git: Do not try to git-stash in git supermodules. (authored by mpyne).
git: Do not try to git-stash in git supermodules.
Mar 23 2019, 10:24 PM
mpyne added a comment to D19864: Set correct libname on debian systems as well.

I have a question, and also it would be good to know if there's a standardized convention for this kind of detection between Debian, BSD, Fedora, etc. etc.

Mar 23 2019, 3:36 PM
mpyne accepted D19615: Define _BSD_SOURCE for strdup and timerclear.
Mar 23 2019, 2:39 PM
mpyne accepted D19614: Include <strings.h> for strcasecmp.

Looks good. The way these compat changes normally impact working code against glibc / FreeBSD is to accidentally enable stricter symbol definitions, that shouldn't be an issue here and I've confirmed the header is also present on FreeBSD.

Mar 23 2019, 2:38 PM

Mar 14 2019

mpyne committed R499:5694547d0757: Break dependency cycle between ECM and Qt5. (authored by mpyne).
Break dependency cycle between ECM and Qt5.
Mar 14 2019, 2:54 AM

Mar 9 2019

mpyne committed R365:318635fdd6b5: dep-resolv: Fix bug handling negated dependencies. (authored by mpyne).
dep-resolv: Fix bug handling negated dependencies.
Mar 9 2019, 3:15 AM

Mar 3 2019

mpyne committed R365:3732ffc47495: git: Minor fix to correct msg shown to user when git-stash pop fails. (authored by mpyne).
git: Minor fix to correct msg shown to user when git-stash pop fails.
Mar 3 2019, 12:14 AM

Feb 20 2019

mpyne accepted D19127: Do not complain about missing qmake if it can actually be found or is going to be built as part of Qt 5.

Good to go! If you have commit access you'll need to commit to the Gitlab instance rather than git.kde.org directly. In my case I'd just run git remote add gitlab git@invent.kde.org:kde/kdesrc-build.git first, git fetch gitlab to ensure it's fully downloaded, and then run something like git push gitlab master to push to the proper remote.

Feb 20 2019, 3:41 AM
mpyne added a comment to D19171: Fix typo in qt5 module set name..

The existing Qt5 mention is meant to be special-cased by kdesrc-build and other users of this file (like the build.kde.org infrastructure) so I would not bother changing it just because kdesrc-build now supports Qt 5.

Feb 20 2019, 3:33 AM

Feb 19 2019

mpyne committed R344:15dcf1c21597: Merge branch 'Applications/18.12' (authored by mpyne).
Merge branch 'Applications/18.12'
Feb 19 2019, 12:41 AM
mpyne committed R344:5c1470d2f7f4: Fix crash in filtering playlist to playing album/artist. (authored by mpyne).
Fix crash in filtering playlist to playing album/artist.
Feb 19 2019, 12:41 AM
mpyne requested changes to D19127: Do not complain about missing qmake if it can actually be found or is going to be built as part of Qt 5.

Aside from the absPathToExecutable2 new function the updated logic is sound. You'll want to keep the check you added to call absPathToExecutable without the preferred paths if the program couldn't be found even after that change as well, so don't get rid of that extra call you added to account for when the preferred paths don't find the program being sought.

Feb 19 2019, 12:13 AM

Feb 18 2019

mpyne committed R344:24b0edd1545c: Fix crash with threaded file loading. (authored by mpyne).
Fix crash with threaded file loading.
Feb 18 2019, 10:26 PM
mpyne accepted D18885: Fix displaying covers from cover.jpg files.

This is good to commit. Note that JuK's repository is in testing for a trial KDE is running of GitLab, so you'll need to commit to the JuK repository at https://invent.kde.org/kde/juk

Feb 18 2019, 5:22 PM

Feb 9 2019

mpyne committed R365:991f4e1fb7f9: Merge branch 'add-qt5-support' into 'master' (authored by mpyne).
Merge branch 'add-qt5-support' into 'master'
Feb 9 2019, 3:16 AM
mpyne committed R365:114908104674: Add support for building Qt5 modules. (authored by mpyne).
Add support for building Qt5 modules.
Feb 9 2019, 3:16 AM
mpyne committed R365:34cef6ec14dd: first-run: Add Fedora 29 packages and installer metadata. (authored by mpyne).
first-run: Add Fedora 29 packages and installer metadata.
Feb 9 2019, 1:56 AM

Feb 8 2019

mpyne committed R365:0ceb50e9fefb: first-run: Ignore kde structure by default. (authored by mpyne).
first-run: Ignore kde structure by default.
Feb 8 2019, 11:46 PM

Jan 14 2019

mpyne committed R365:13c3f7f1633a: WIP: Add support for building Qt5 modules. (authored by mpyne).
WIP: Add support for building Qt5 modules.
Jan 14 2019, 12:20 AM

Jan 13 2019

mpyne committed R365:143a94025043: Fix crash that was introduced by the recent 'improved test'. (authored by mpyne).
Fix crash that was introduced by the recent 'improved test'.
Jan 13 2019, 9:02 PM

Jan 12 2019

mpyne committed R365:d9f11a3e954b: test: Add plumbing to allow for tracepoints during test. (authored by mpyne).
test: Add plumbing to allow for tracepoints during test.
Jan 12 2019, 9:28 PM
mpyne committed R365:b01505bec941: Fix cxxflags being set to a space when globally empty. (authored by mpyne).
Fix cxxflags being set to a space when globally empty.
Jan 12 2019, 9:27 PM
mpyne added a comment to D18165: Do not pass -DCMAKE_CXX_FLAGS to CMake if cxxflags is empty.

This bug should be fixed (at its precise source) in commit b01505bec941f06be52ca3ac88d9b6937e1f4c88.

Jan 12 2019, 8:59 PM
mpyne added a comment to D18165: Do not pass -DCMAKE_CXX_FLAGS to CMake if cxxflags is empty.

I'll take a look and fix but if further review is needed may I invite you to the trial GitLab instance at https://invent.kde.org/kde/kdesrc-build/merge_requests ? (kdesrc-build is a participant in the trial).

Jan 12 2019, 6:10 PM

Jan 10 2019

mpyne accepted D18137: delete copy constructor and assignment operator of some public classes.

The KSharedDataCache change is definitely correct. I've not done much with the kdelibs migrator but I agree with the logic and the implementation. Have you tried building some of the other frameworks or Plasma after implementing this patch? That's the only real risk I can think of.

Jan 10 2019, 3:43 AM · Frameworks

Jan 7 2019

mpyne committed R365:0f4cc4b9d283: first-run: Remove kde-language support. (authored by mpyne).
first-run: Remove kde-language support.
Jan 7 2019, 1:37 AM
mpyne committed R365:c6e61dffe9ff: non-kde-deps: Add shell handler and metadata for distro dependencies. (authored by mpyne).
non-kde-deps: Add shell handler and metadata for distro dependencies.
Jan 7 2019, 1:37 AM
mpyne committed R365:d5240196124e: util: Add a method to locate data files, cleanup basedir detection. (authored by mpyne).
util: Add a method to locate data files, cleanup basedir detection.
Jan 7 2019, 1:37 AM
mpyne committed R365:402fc30fb80c: Breakout KDE modules into a specific subclass. (authored by mpyne).
Breakout KDE modules into a specific subclass.
Jan 7 2019, 1:37 AM

Jan 6 2019

mpyne committed R365:845e9da4ac26: first-run: Add basic installer and packages for Debian distros. (authored by mpyne).
first-run: Add basic installer and packages for Debian distros.
Jan 6 2019, 3:28 AM
mpyne committed R365:9b298270d448: CI: Remove needless build stage, document a working full build. (authored by mpyne).
CI: Remove needless build stage, document a working full build.
Jan 6 2019, 3:28 AM
mpyne committed R344:066c3ff1726f: Add README.md (authored by David Planella <david.planella@ubuntu.com>).
Add README.md
Jan 6 2019, 1:16 AM

Dec 29 2018

mpyne committed R365:c72e6e6e1865: first-run: Add needed OpenSuse packages needed to install dolphin. (authored by mpyne).
first-run: Add needed OpenSuse packages needed to install dolphin.
Dec 29 2018, 5:34 AM
mpyne committed R365:739ddb56cb6a: first-run: Use absolute paths when generating .kdesrc-buildrc. (authored by mpyne).
first-run: Use absolute paths when generating .kdesrc-buildrc.
Dec 29 2018, 5:34 AM
mpyne committed R365:068700c3527f: Remove dead implementation of --initial-setup. (authored by mpyne).
Remove dead implementation of --initial-setup.
Dec 29 2018, 5:34 AM

Dec 28 2018

mpyne committed R344:04aecdab49ee: Merge branch 'Applications/18.12' into 'Applications/18.12' (authored by mpyne).
Merge branch 'Applications/18.12' into 'Applications/18.12'
Dec 28 2018, 11:16 AM