mpyne (Michael Pyne)
User

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Mar 23 2016, 2:38 AM (134 w, 5 d)
Availability
Available

Recent Activity

Today

mpyne committed R365:cabaa3435d5a: first-run: Make it possible to run system installer on first run. (authored by mpyne).
first-run: Make it possible to run system installer on first run.
Mon, Oct 22, 2:38 AM
mpyne committed R365:8f5daca914fd: first-run: Reduce use of ksb::Util, remove dead code. (authored by mpyne).
first-run: Reduce use of ksb::Util, remove dead code.
Mon, Oct 22, 2:38 AM
mpyne committed R365:a6bbfba12a8c: first-run: Make --initial-setup work in minimal env, impl sample-rc. (authored by mpyne).
first-run: Make --initial-setup work in minimal env, impl sample-rc.
Mon, Oct 22, 2:38 AM
mpyne committed R365:e4f6829c16f9: sample-rc: Remove ancient sample file. (authored by mpyne).
sample-rc: Remove ancient sample file.
Mon, Oct 22, 2:38 AM

Yesterday

mpyne committed R365:6b48a781caff: Clean up --help, add stub for initial setup helper. (authored by mpyne).
Clean up --help, add stub for initial setup helper.
Sun, Oct 21, 2:00 AM

Sat, Oct 20

mpyne committed R365:b8b62d30e4aa: GIT_SILENT Bump version for semi-annual tagging. (authored by mpyne).
GIT_SILENT Bump version for semi-annual tagging.
Sat, Oct 20, 10:49 PM
mpyne requested review of D16343: Add Craft blueprint for Juk.
Sat, Oct 20, 7:59 PM
mpyne committed R344:b4cdf1c10090: Merge branch 'Applications/18.08' (authored by mpyne).
Merge branch 'Applications/18.08'
Sat, Oct 20, 2:52 AM
mpyne committed R344:e2012e793598: systray: Make SHIFT+Mousewheel change the volume, not the song. (authored by mpyne).
systray: Make SHIFT+Mousewheel change the volume, not the song.
Sat, Oct 20, 2:52 AM

Fri, Oct 19

mpyne committed R344:798f35bcceef: PlayerManager: Also update current track seek when track changes. (authored by mpyne).
PlayerManager: Also update current track seek when track changes.
Fri, Oct 19, 3:02 AM
mpyne committed R344:336433840275: Do not auto-save playlists just because play queue changes. (authored by mpyne).
Do not auto-save playlists just because play queue changes.
Fri, Oct 19, 2:13 AM
mpyne committed R344:f07d305eb627: PlayerManager: Queue up next tracks instead of stop/play cycle. (authored by mpyne).
PlayerManager: Queue up next tracks instead of stop/play cycle.
Fri, Oct 19, 2:13 AM
mpyne committed R344:6985bc77565b: playlistbox: Do not hardcode icon sizes in playlist item icon. (authored by mpyne).
playlistbox: Do not hardcode icon sizes in playlist item icon.
Fri, Oct 19, 2:13 AM
mpyne committed R344:387818ec35dd: PlayerManager: Always perform setup on construction. (authored by mpyne).
PlayerManager: Always perform setup on construction.
Fri, Oct 19, 2:13 AM
mpyne committed R344:d5123cc6d03d: PlayerManager: Move the start/restart handler where it belongs. (authored by mpyne).
PlayerManager: Move the start/restart handler where it belongs.
Fri, Oct 19, 2:13 AM

Sun, Oct 14

mpyne added a comment to T9507: kdesrc-build: Add flag to import Perl deps on popular distros.

I've added shell support for /etc/os-release at commit f3f100de6410d5ad9b84bef2d237ee2540e0f043

Sun, Oct 14, 10:48 PM · kdesrc-build
mpyne committed R365:f3f100de6410: Add support library for handling /etc/os-release. (authored by mpyne).
Add support library for handling /etc/os-release.
Sun, Oct 14, 10:44 PM
mpyne added a comment to D15563: Ballot website - styling improvements.

Anyone have a chance to look at this?

Sun, Oct 14, 10:43 PM
mpyne committed R241:cf3b0d102855: kio_help: Fix crash in QCoreApplication when accessing help://. (authored by mpyne).
kio_help: Fix crash in QCoreApplication when accessing help://.
Sun, Oct 14, 4:09 PM
mpyne closed D16189: kio_help: Fix crash in QCoreApplication when accessing help://.
Sun, Oct 14, 4:09 PM · Frameworks

Sat, Oct 13

mpyne requested review of D16189: kio_help: Fix crash in QCoreApplication when accessing help://.
Sat, Oct 13, 11:20 PM · Frameworks

Mon, Oct 8

mpyne committed R365:63de897a5d87: svn: Clean up and streamline, remove obsolete features. (authored by mpyne).
svn: Clean up and streamline, remove obsolete features.
Mon, Oct 8, 11:41 PM
mpyne committed R365:e04c9e204aa6: mojo: Use Mojo::JSON instead of requiring JSON::{PP,XS}. (authored by mpyne).
mojo: Use Mojo::JSON instead of requiring JSON::{PP,XS}.
Mon, Oct 8, 11:41 PM
mpyne committed R365:f37751b128be: doc: Update build-docs helper script. (authored by mpyne).
doc: Update build-docs helper script.
Mon, Oct 8, 11:41 PM
mpyne committed R365:1eaad3d2ea44: mojo: Check for Mojo::Promise too. (authored by mpyne).
mojo: Check for Mojo::Promise too.
Mon, Oct 8, 5:58 PM
mpyne committed R365:ea5ed02ce5cd: mojo: Add a backend-support class to allow headless ops. (authored by mpyne).
mojo: Add a backend-support class to allow headless ops.
Mon, Oct 8, 5:58 PM
mpyne committed R365:00d9c269d7c4: mojo: Remove dead code and improve comments. (authored by mpyne).
mojo: Remove dead code and improve comments.
Mon, Oct 8, 5:58 PM
mpyne committed R365:2f85def1e870: mojo: Breakup metadata reading from module list setup. (authored by mpyne).
mojo: Breakup metadata reading from module list setup.
Mon, Oct 8, 5:57 PM

Wed, Sep 26

mpyne accepted D15303: LyricWiki: link to the actual lyrics page.
Wed, Sep 26, 3:35 AM

Sun, Sep 23

mpyne committed R365:94c9beb3bf7e: sample-rc: Fix configure-based option name. (authored by mpyne).
sample-rc: Fix configure-based option name.
Sun, Sep 23, 7:07 PM
mpyne created T9727: Validate cxxflags options works for all build types.
Sun, Sep 23, 3:49 PM · kdesrc-build
mpyne added a comment to T9506: kdesrc-build: Complete integration of Mojolicious web framework.

Still in action. Latest updates (in the make_it_mojo branch) significantly simplify the event-driven logic by moving the event handling in a big huge chain of promise->thens.

Sun, Sep 23, 2:40 PM · kdesrc-build
mpyne moved T9506: kdesrc-build: Complete integration of Mojolicious web framework from Backlog to Doing on the kdesrc-build board.
Sun, Sep 23, 2:38 PM · kdesrc-build
mpyne committed R365:01888c0bb380: git: Remove old kde: alias if installed. (authored by mpyne).
git: Remove old kde: alias if installed.
Sun, Sep 23, 12:24 AM
mpyne committed R365:2c09ca0d8bc4: Use HTTPS instead of Git protocol as default git transport. (authored by ouwerkerk).
Use HTTPS instead of Git protocol as default git transport.
Sun, Sep 23, 12:24 AM

Sep 22 2018

mpyne committed R365:26fb89a039b5: mojo: Show the :-) if build succeeded when no updates happened. (authored by mpyne).
mojo: Show the :-) if build succeeded when no updates happened.
Sep 22 2018, 1:03 AM
mpyne committed R365:1ff7067ae5e6: mojo: Minor accumulated bugfixes. (authored by mpyne).
mojo: Minor accumulated bugfixes.
Sep 22 2018, 1:03 AM
mpyne committed R365:c7ef41833cf8: mojo: Prefer the existing phase failure output. (authored by mpyne).
mojo: Prefer the existing phase failure output.
Sep 22 2018, 1:03 AM
mpyne committed R365:c8021bbc8ada: Remove the log directory cleanup msg. (authored by mpyne).
Remove the log directory cleanup msg.
Sep 22 2018, 1:03 AM
mpyne committed R365:978b2ad028cf: mojo: Make skipping build when source has not changed work again. (authored by mpyne).
mojo: Make skipping build when source has not changed work again.
Sep 22 2018, 1:03 AM
mpyne committed R365:cf5dbf4e83cd: mojo: Ensure promise chain handles each item promise by trapping errors. (authored by mpyne).
mojo: Ensure promise chain handles each item promise by trapping errors.
Sep 22 2018, 1:03 AM
mpyne committed R365:dbde741cca51: mojo: Use "promise chain" to drive main build flow. (authored by mpyne).
mojo: Use "promise chain" to drive main build flow.
Sep 22 2018, 1:03 AM
mpyne committed R365:9a23149f79d3: mojo: Simplify update code and fix deadlock with update failure. (authored by mpyne).
mojo: Simplify update code and fix deadlock with update failure.
Sep 22 2018, 1:03 AM
mpyne committed R365:558dd31d44a8: mojo: Add helper class to create "promise chains". (authored by mpyne).
mojo: Add helper class to create "promise chains".
Sep 22 2018, 1:03 AM
mpyne committed R365:d022bb04297e: Merge remote-tracking branch 'origin/master' into make_it_mojo (authored by mpyne).
Merge remote-tracking branch 'origin/master' into make_it_mojo
Sep 22 2018, 1:03 AM
mpyne committed R365:5e0d22eed542: mojo: Move phase-handling code to a more central spot. (authored by mpyne).
mojo: Move phase-handling code to a more central spot.
Sep 22 2018, 1:03 AM

Sep 16 2018

mpyne requested review of D15563: Ballot website - styling improvements.
Sep 16 2018, 9:40 PM

Sep 15 2018

mpyne added a comment to T9591: Publish JuK in the Microsoft Store.

I agree as maintainer that this would be useful.

Sep 15 2018, 11:04 PM · Windows

Sep 7 2018

mpyne accepted D15303: LyricWiki: link to the actual lyrics page.

It occurred to me while I was at work today that an attacker in position to MITM the search result we get back would also be able to MITM the lyrics page directly. Given that I'm less worried about whitelisting as that is barely even a speedbump. Encoding is technically still a good idea but I think the default mode should be enough for most normal pages.

Sep 7 2018, 11:41 PM
mpyne requested changes to D15303: LyricWiki: link to the actual lyrics page.

Wikia doesn't support HTTPS so I'm at least a little leery of just dumping potentially-malicious output into a clickable link. A simple whitelist might be sufficient to at least make an attack along this vector more annoying than it would be worth.

Sep 7 2018, 2:36 AM

Sep 2 2018

mpyne accepted D15222: Set the tick interval, because the default value is 0.

I vaguely remember this being required, it probably got dropped in the port to KF5 by accident. I concur with your diagnosis and suggested fix. Please commit!

Sep 2 2018, 8:38 PM
mpyne added a comment to D8256: Add _XOPEN_SOURCE to C definitions.

Sorry, if I'd been able to check this earlier I'd have warned against pushing, this was the kind of concern I was addressing with my earlier comment about FreeBSD. I had run into a lot of those issues when trying to get KF5 to build on Alpine.

Sep 2 2018, 2:53 PM · Build System, Frameworks

Aug 25 2018

mpyne added a comment to D15076: Build failures with KSyntaxHighlighting 5.49.

The ECM documentation points to a specific change that may be related: https://api.kde.org/ecm/kde-module/KDECMakeSettings.html#build-settings

Aug 25 2018, 11:37 PM · KDE Edu
mpyne added a comment to D15076: Build failures with KSyntaxHighlighting 5.49.

I don't know the cause myself but the ECM version works up until 5.38.0 in my own testing. So presumably the change in behavior is something introduced in that release of ECM?

Aug 25 2018, 11:32 PM · KDE Edu
mpyne set the image for kdesrc-build to F6215292: profile.
Aug 25 2018, 7:33 PM
mpyne triaged T9507: kdesrc-build: Add flag to import Perl deps on popular distros as High priority.
Aug 25 2018, 7:32 PM · kdesrc-build
mpyne triaged T9506: kdesrc-build: Complete integration of Mojolicious web framework as High priority.
Aug 25 2018, 7:30 PM · kdesrc-build
mpyne added a comment to D13627: [KSharedDataCache] Assume lock before flush changes.

I'd say to leave the code alone if this the change isn't needed to fix a bug.

Aug 25 2018, 2:02 AM · Frameworks
mpyne accepted D14908: Bindings: Add support for scoped enums.

LGTM and there's been plenty of time for a NAK. I say let's commit.

Aug 25 2018, 1:56 AM · Build System, Frameworks

Aug 22 2018

mpyne committed R169:b23e642e5ac4: Explicitly request Qt 5.7's QtQuick to make use of Connections.enabled (authored by mpyne).
Explicitly request Qt 5.7's QtQuick to make use of Connections.enabled
Aug 22 2018, 11:48 PM
mpyne closed D14984: Explicitly request Qt 5.7's QtQuick to make use of Connections.enabled.
Aug 22 2018, 11:48 PM · Kirigami
mpyne added a comment to D14908: Bindings: Add support for scoped enums.

As long as older versions of LLVM result in the Python binding generation step being skipped completely (we already check for libclang in the find-package for this, right?), I don't think the dependency increase is a problem.

Aug 22 2018, 3:05 AM · Build System, Frameworks
mpyne requested review of D14984: Explicitly request Qt 5.7's QtQuick to make use of Connections.enabled.
Aug 22 2018, 2:42 AM · Kirigami
mpyne accepted D13627: [KSharedDataCache] Assume lock before flush changes.

This change has worked fine for me in my testing (including KDE games and Plasma themes) so I think it's fine to commit.

Aug 22 2018, 2:24 AM · Frameworks

Aug 19 2018

mpyne committed R365:d30194ce2f7a: mojo: Show progress bar after showing log entries. (authored by mpyne).
mojo: Show progress bar after showing log entries.
Aug 19 2018, 8:26 PM

Aug 18 2018

mpyne added a comment to D14908: Bindings: Add support for scoped enums.

LGTM but then I don't use the Python bindings. Have you already tried the kcoreaddons build to see if this makes it work where it had failed before?

Aug 18 2018, 6:32 PM · Build System, Frameworks

Aug 15 2018

mpyne committed R365:685e68eab34c: logs: Postpone log dir mutable setup until a log is to be generated. (authored by mpyne).
logs: Postpone log dir mutable setup until a log is to be generated.
Aug 15 2018, 10:40 PM

Aug 14 2018

mpyne committed R365:b0a2d048bd3b: Show a message post-build if there were compile warnings. (authored by mpyne).
Show a message post-build if there were compile warnings.
Aug 14 2018, 9:04 PM
mpyne committed R365:472490fe0dc9: Provide detail to make return statement. (authored by mpyne).
Provide detail to make return statement.
Aug 14 2018, 9:04 PM

Aug 13 2018

mpyne committed R365:3afdce72adff: mojo: Fix position of module names in progress. (authored by mpyne).
mojo: Fix position of module names in progress.
Aug 13 2018, 1:05 PM

Jul 20 2018

mpyne added a comment to D13627: [KSharedDataCache] Assume lock before flush changes.

The patch looks OK but I'm a bit worried about trying to lock the cache at the same time we're potentially trying to delete a KSharedDataCache so I'm going to recompile and do some stress and sanity tests first.

Jul 20 2018, 9:28 PM · Frameworks

Jul 15 2018

mpyne committed R249:543b8ae67c57: libintl: Determine if _nl_msg_cat_cntr exists before use (authored by awilcox).
libintl: Determine if _nl_msg_cat_cntr exists before use
Jul 15 2018, 6:13 PM
mpyne accepted D12233: Avoid manipulation of lists with quadratic complexity.

I don't use Baloo directly but I've taken a look from a code sanity perspective and agree with @dhaumann that the change is a proper port of the existing logic.

Jul 15 2018, 5:51 PM · Baloo, Frameworks

Jul 9 2018

mpyne committed R365:15642ae064fc: mojo: Be consistent with phase names so U/I works right. (authored by mpyne).
mojo: Be consistent with phase names so U/I works right.
Jul 9 2018, 3:05 AM
mpyne committed R365:77b8c2d9b9a2: mojo: Fix the U/I showing update/build status in random order. (authored by mpyne).
mojo: Fix the U/I showing update/build status in random order.
Jul 9 2018, 3:05 AM
mpyne committed R365:1d92318697a3: mojo: Add some detail and color to build_done and build_progress (authored by mpyne).
mojo: Add some detail and color to build_done and build_progress
Jul 9 2018, 3:05 AM
mpyne committed R365:a49ecb14d519: mojo: Clean up some of the duplicate spam to the U/I. (authored by mpyne).
mojo: Clean up some of the duplicate spam to the U/I.
Jul 9 2018, 3:05 AM
mpyne committed R365:362ef0f7fdb9: mojo: Reorganize event notification code for new clients. (authored by mpyne).
mojo: Reorganize event notification code for new clients.
Jul 9 2018, 3:05 AM
mpyne committed R365:cfd2d8c128e9: mojo: Complete porting build-status.pl into kdesrc-build. (authored by mpyne).
mojo: Complete porting build-status.pl into kdesrc-build.
Jul 9 2018, 3:05 AM
mpyne committed R365:049e9bfce2de: mojo: Add some detail back to the default U/I. (authored by mpyne).
mojo: Add some detail back to the default U/I.
Jul 9 2018, 3:05 AM
mpyne committed R365:68e22f673a5a: mojo: Remove old StatusView code in favor of event-driven U/I. (authored by mpyne).
mojo: Remove old StatusView code in favor of event-driven U/I.
Jul 9 2018, 3:05 AM
mpyne committed R365:d29cc1313cb4: mojo: WIP for promise-based U/I. (authored by mpyne).
mojo: WIP for promise-based U/I.
Jul 9 2018, 3:05 AM
mpyne committed R365:11dd34f4c1a4: mojo: WIP 2, using new UI iface. (authored by mpyne).
mojo: WIP 2, using new UI iface.
Jul 9 2018, 3:05 AM

Jul 7 2018

mpyne added a comment to D13627: [KSharedDataCache] Assume lock before flush changes.

https://phabricator.kde.org/source/kiconthemes/browse/master/src/kiconloader.cpp$603
So the problem maybe not here as IconLoader loads icons but in icon writer
@davidedmundson , @dfaure who writes icon-cache.kcache in ~/.cache ?

Jul 7 2018, 4:07 PM · Frameworks

Jul 4 2018

mpyne committed R344:117646dd6232: Bring back inline tag editing. (authored by mpyne).
Bring back inline tag editing.
Jul 4 2018, 11:35 PM
mpyne committed R365:3dbada64198c: setup: Make the setup script work with cmake-installed kdesrc-build. (authored by mpyne).
setup: Make the setup script work with cmake-installed kdesrc-build.
Jul 4 2018, 8:22 PM
mpyne committed R365:ff11a6b079eb: Merge remote-tracking branch 'origin/master' into make_it_mojo (authored by mpyne).
Merge remote-tracking branch 'origin/master' into make_it_mojo
Jul 4 2018, 8:00 PM

Jul 2 2018

mpyne committed R344:7d165d3b9b5f: Remove slight bias in random track selection. (authored by mpyne).
Remove slight bias in random track selection.
Jul 2 2018, 2:21 AM
mpyne committed R344:cb388f252a4e: GIT_SILENT Remove unused header. (authored by mpyne).
GIT_SILENT Remove unused header.
Jul 2 2018, 2:21 AM

Jul 1 2018

mpyne committed R365:7f92da7b307c: Don't double-set CMAKE_PREFIX_PATH if set by user. (authored by mpyne).
Don't double-set CMAKE_PREFIX_PATH if set by user.
Jul 1 2018, 11:18 PM
mpyne committed R365:14b5093bf153: Fake a JSON module to make --pretend work without kde-build-metadata. (authored by mpyne).
Fake a JSON module to make --pretend work without kde-build-metadata.
Jul 1 2018, 11:18 PM

Jun 29 2018

mpyne accepted D9748: Give Juk a playback power inhibitor..

I've tested, it compiles and installs fine and seems to work in my testing with qdbusviewer to verify that the inhibition is set during playback. I'm not sure of a better way to test on my system since I don't go crazy with power management anyways but it's at least good enough to commit and get out to a wider user base for testing.

Jun 29 2018, 4:09 AM

May 27 2018

mpyne committed R365:ca30f09b511e: Add testcase for bug 394497 (ignore-modules/include-dependencies). (authored by mpyne).
Add testcase for bug 394497 (ignore-modules/include-dependencies).
May 27 2018, 8:51 PM
mpyne committed R365:fe41e0645de8: Fix --ignore-modules with --include-dependencies active. (authored by mpyne).
Fix --ignore-modules with --include-dependencies active.
May 27 2018, 8:51 PM

May 16 2018

mpyne committed R365:4a875d8d7877: kde-cmake: Add CMAKE_{MODULE,PREFIX}_PATH consistently. (authored by mpyne).
kde-cmake: Add CMAKE_{MODULE,PREFIX}_PATH consistently.
May 16 2018, 3:27 AM

May 12 2018

mpyne added a comment to D12739: Ignore system standard path when prepending environment variables.

OK thanks. Please commit whenever you're ready.

May 12 2018, 12:26 AM

May 9 2018

mpyne accepted D12739: Ignore system standard path when prepending environment variables.

Looks good to me, but do you know if there are any other directories we'd need to check (on Unixy systems) besides /usr?

May 9 2018, 11:59 PM

May 1 2018

mpyne committed R365:ac5cc6f1ba4c: doc: Correct spelling of --set-module-option-value (authored by mpyne).
doc: Correct spelling of --set-module-option-value
May 1 2018, 2:30 AM
mpyne committed R365:829624ebfcf5: Reboot a small test suite. (authored by mpyne).
Reboot a small test suite.
May 1 2018, 2:30 AM

Apr 26 2018

mpyne committed R344:f523576b0b6a: Merge remote-tracking branch 'origin/master' into Applications/18.04 (authored by mpyne).
Merge remote-tracking branch 'origin/master' into Applications/18.04
Apr 26 2018, 1:15 AM