mpyne (Michael Pyne)
User

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Mar 23 2016, 2:38 AM (165 w, 5 d)
Availability
Available

Recent Activity

Sat, May 25

mpyne accepted D21377: Only install missing Arch packages.

Great idea, thanks!

Sat, May 25, 1:18 AM
mpyne accepted D21387: Make sample shell include work with custom Qt.

I was under the impression that LD_LIBRARY_PATH shouldn't be required if the paths to Qt are setup properly, but as long as you've tested that it's necessary I've no objection.

Sat, May 25, 1:17 AM

Sat, May 18

mpyne committed R344:1312b772a21a: Finish removing deprecated code. (authored by mpyne).
Finish removing deprecated code.
Sat, May 18, 7:46 PM
mpyne committed R344:adf074673705: Remove broken/unused MusicBrainz feature and code. (authored by mpyne).
Remove broken/unused MusicBrainz feature and code.
Sat, May 18, 7:46 PM
mpyne committed R344:3b703e1bb2f0: Remove deprecated code, fix NowPlaying bar height. (authored by mpyne).
Remove deprecated code, fix NowPlaying bar height.
Sat, May 18, 7:46 PM
mpyne committed R344:7264132f038b: A few more FileRenamer cleanups since I was there. (authored by mpyne).
A few more FileRenamer cleanups since I was there.
Sat, May 18, 6:48 PM
mpyne committed R344:44d6bb2d7c7d: Remove more compiler warnings for deprecated functions/uses. (authored by mpyne).
Remove more compiler warnings for deprecated functions/uses.
Sat, May 18, 6:48 PM
mpyne committed R344:7d681172b19e: Remove deprecated use of QSignalMapper. (authored by mpyne).
Remove deprecated use of QSignalMapper.
Sat, May 18, 6:48 PM
mpyne committed R344:f10458fac288: Merge branch 'Applications/19.04' (authored by mpyne).
Merge branch 'Applications/19.04'
Sat, May 18, 6:48 PM
mpyne committed R344:dc2d9c8e0fe6: Add 'override' decl to fix compiler warnings, fix drag-and-drop. (authored by mpyne).
Add 'override' decl to fix compiler warnings, fix drag-and-drop.
Sat, May 18, 6:48 PM

Sat, May 4

mpyne committed R365:74d70dec915a: session-env: Set correct libname on Debian systems. (authored by jbbgameich).
session-env: Set correct libname on Debian systems.
Sat, May 4, 8:35 PM
mpyne closed D19864: Set correct libname on debian systems as well.
Sat, May 4, 8:35 PM
mpyne committed R365:b7f93bfed5df: first-run: Add support for Mageia 6 distribution. (authored by jjorge).
first-run: Add support for Mageia 6 distribution.
Sat, May 4, 8:35 PM
mpyne closed D20936: Add support for Mageia distro.
Sat, May 4, 8:35 PM · kdesrc-build
mpyne committed R365:6385f5e429dd: Add support for Meson build system. (authored by mpyne).
Add support for Meson build system.
Sat, May 4, 8:35 PM

Wed, May 1

mpyne accepted D20936: Add support for Mageia distro.

The patch works in my testing and looks reasonable. Are you able to commit or should I?

Wed, May 1, 11:46 PM · kdesrc-build
mpyne committed R365:cd7af4eed524: meson: Fix build system integration bugs, add docs. (authored by mpyne).
meson: Fix build system integration bugs, add docs.
Wed, May 1, 2:07 AM
mpyne committed R365:e54200ee3ce1: env: Do not prepend /bin when {qt,kde}dir is blank. (authored by mpyne).
env: Do not prepend /bin when {qt,kde}dir is blank.
Wed, May 1, 1:24 AM

Sat, Apr 27

mpyne committed R365:3cc8391c81b3: doc: Fix typo dependend -> depended. (authored by yurchor).
doc: Fix typo dependend -> depended.
Sat, Apr 27, 4:32 PM
mpyne closed D20174: Fix typo: dependend -> depended.

I have committed the doc fix (and maintained your authorship). I expect that we will be able to automatically migrate git modules to the new location if it is decided to use Gitlab for all KDE git repositories, but in the meantime it does require manually running some git commands.

Sat, Apr 27, 4:31 PM · Documentation

Apr 23 2019

mpyne committed R365:a3dee93b0ac1: WIP: Add support for Meson build system. (authored by mpyne).
WIP: Add support for Meson build system.
Apr 23 2019, 1:10 AM

Apr 20 2019

mpyne accepted D20279: Attempt to fixup dependency data declarations for non-KDE modules.

I like the change! We'll need to watch for things to add to ignored-projects as @bcooksley points out.

Apr 20 2019, 6:05 PM

Apr 13 2019

mpyne committed R365:2ca160487d2e: dep-resolv: Fix Perl warning about non-numeric comparison. (authored by mpyne).
dep-resolv: Fix Perl warning about non-numeric comparison.
Apr 13 2019, 2:23 AM
mpyne accepted D20174: Fix typo: dependend -> depended.

Looks good, thank you!

Apr 13 2019, 12:53 AM · Documentation

Mar 30 2019

mpyne accepted D20092: New class KOSRelease - a parser for os-release files.

+1 to @aacid's comment about relicensing.

Mar 30 2019, 4:19 PM · Frameworks

Mar 26 2019

mpyne accepted D19864: Set correct libname on debian systems as well.

Right then, sounds good.

Mar 26 2019, 1:51 AM

Mar 24 2019

mpyne committed R365:290244f144e4: kde_projects: All use of fullProjectPath for non-KDE modules. (authored by mpyne).
kde_projects: All use of fullProjectPath for non-KDE modules.
Mar 24 2019, 6:05 PM
mpyne closed D20008: Fix uninitialized value in SimpleJobPrivate.
Mar 24 2019, 5:13 PM · Frameworks
mpyne committed R241:920d2c4ca7d5: kjobs: Fix compiler warning for uninit value in SimpleJobPrivate. (authored by mpyne).
kjobs: Fix compiler warning for uninit value in SimpleJobPrivate.
Mar 24 2019, 5:13 PM

Mar 23 2019

mpyne requested review of D20008: Fix uninitialized value in SimpleJobPrivate.
Mar 23 2019, 11:05 PM · Frameworks
mpyne committed R365:ba2f176db89d: CI: Submodule tests require git config. (authored by mpyne).
CI: Submodule tests require git config.
Mar 23 2019, 10:51 PM
mpyne committed R365:27840ef81238: CI: Add git as a required build test tool for submodule test. (authored by mpyne).
CI: Add git as a required build test tool for submodule test.
Mar 23 2019, 10:28 PM
mpyne committed R365:3097d57e0e4f: git: Do not try to git-stash in git supermodules. (authored by mpyne).
git: Do not try to git-stash in git supermodules.
Mar 23 2019, 10:24 PM
mpyne added a comment to D19864: Set correct libname on debian systems as well.

I have a question, and also it would be good to know if there's a standardized convention for this kind of detection between Debian, BSD, Fedora, etc. etc.

Mar 23 2019, 3:36 PM
mpyne accepted D19615: Define _BSD_SOURCE for strdup and timerclear.
Mar 23 2019, 2:39 PM
mpyne accepted D19614: Include <strings.h> for strcasecmp.

Looks good. The way these compat changes normally impact working code against glibc / FreeBSD is to accidentally enable stricter symbol definitions, that shouldn't be an issue here and I've confirmed the header is also present on FreeBSD.

Mar 23 2019, 2:38 PM

Mar 14 2019

mpyne committed R499:5694547d0757: Break dependency cycle between ECM and Qt5. (authored by mpyne).
Break dependency cycle between ECM and Qt5.
Mar 14 2019, 2:54 AM

Mar 9 2019

mpyne committed R365:318635fdd6b5: dep-resolv: Fix bug handling negated dependencies. (authored by mpyne).
dep-resolv: Fix bug handling negated dependencies.
Mar 9 2019, 3:15 AM

Mar 3 2019

mpyne committed R365:3732ffc47495: git: Minor fix to correct msg shown to user when git-stash pop fails. (authored by mpyne).
git: Minor fix to correct msg shown to user when git-stash pop fails.
Mar 3 2019, 12:14 AM

Feb 20 2019

mpyne accepted D19127: Do not complain about missing qmake if it can actually be found or is going to be built as part of Qt 5.

Good to go! If you have commit access you'll need to commit to the Gitlab instance rather than git.kde.org directly. In my case I'd just run git remote add gitlab git@invent.kde.org:kde/kdesrc-build.git first, git fetch gitlab to ensure it's fully downloaded, and then run something like git push gitlab master to push to the proper remote.

Feb 20 2019, 3:41 AM
mpyne added a comment to D19171: Fix typo in qt5 module set name..

The existing Qt5 mention is meant to be special-cased by kdesrc-build and other users of this file (like the build.kde.org infrastructure) so I would not bother changing it just because kdesrc-build now supports Qt 5.

Feb 20 2019, 3:33 AM

Feb 19 2019

mpyne committed R344:15dcf1c21597: Merge branch 'Applications/18.12' (authored by mpyne).
Merge branch 'Applications/18.12'
Feb 19 2019, 12:41 AM
mpyne committed R344:5c1470d2f7f4: Fix crash in filtering playlist to playing album/artist. (authored by mpyne).
Fix crash in filtering playlist to playing album/artist.
Feb 19 2019, 12:41 AM
mpyne requested changes to D19127: Do not complain about missing qmake if it can actually be found or is going to be built as part of Qt 5.

Aside from the absPathToExecutable2 new function the updated logic is sound. You'll want to keep the check you added to call absPathToExecutable without the preferred paths if the program couldn't be found even after that change as well, so don't get rid of that extra call you added to account for when the preferred paths don't find the program being sought.

Feb 19 2019, 12:13 AM

Feb 18 2019

mpyne committed R344:24b0edd1545c: Fix crash with threaded file loading. (authored by mpyne).
Fix crash with threaded file loading.
Feb 18 2019, 10:26 PM
mpyne accepted D18885: Fix displaying covers from cover.jpg files.

This is good to commit. Note that JuK's repository is in testing for a trial KDE is running of GitLab, so you'll need to commit to the JuK repository at https://invent.kde.org/kde/juk

Feb 18 2019, 5:22 PM

Feb 9 2019

mpyne committed R365:991f4e1fb7f9: Merge branch 'add-qt5-support' into 'master' (authored by mpyne).
Merge branch 'add-qt5-support' into 'master'
Feb 9 2019, 3:16 AM
mpyne committed R365:114908104674: Add support for building Qt5 modules. (authored by mpyne).
Add support for building Qt5 modules.
Feb 9 2019, 3:16 AM
mpyne committed R365:34cef6ec14dd: first-run: Add Fedora 29 packages and installer metadata. (authored by mpyne).
first-run: Add Fedora 29 packages and installer metadata.
Feb 9 2019, 1:56 AM

Feb 8 2019

mpyne committed R365:0ceb50e9fefb: first-run: Ignore kde structure by default. (authored by mpyne).
first-run: Ignore kde structure by default.
Feb 8 2019, 11:46 PM

Jan 14 2019

mpyne committed R365:13c3f7f1633a: WIP: Add support for building Qt5 modules. (authored by mpyne).
WIP: Add support for building Qt5 modules.
Jan 14 2019, 12:20 AM

Jan 13 2019

mpyne committed R365:143a94025043: Fix crash that was introduced by the recent 'improved test'. (authored by mpyne).
Fix crash that was introduced by the recent 'improved test'.
Jan 13 2019, 9:02 PM

Jan 12 2019

mpyne committed R365:d9f11a3e954b: test: Add plumbing to allow for tracepoints during test. (authored by mpyne).
test: Add plumbing to allow for tracepoints during test.
Jan 12 2019, 9:28 PM
mpyne committed R365:b01505bec941: Fix cxxflags being set to a space when globally empty. (authored by mpyne).
Fix cxxflags being set to a space when globally empty.
Jan 12 2019, 9:27 PM
mpyne added a comment to D18165: Do not pass -DCMAKE_CXX_FLAGS to CMake if cxxflags is empty.

This bug should be fixed (at its precise source) in commit b01505bec941f06be52ca3ac88d9b6937e1f4c88.

Jan 12 2019, 8:59 PM
mpyne added a comment to D18165: Do not pass -DCMAKE_CXX_FLAGS to CMake if cxxflags is empty.

I'll take a look and fix but if further review is needed may I invite you to the trial GitLab instance at https://invent.kde.org/kde/kdesrc-build/merge_requests ? (kdesrc-build is a participant in the trial).

Jan 12 2019, 6:10 PM

Jan 10 2019

mpyne accepted D18137: delete copy constructor and assignment operator of some public classes.

The KSharedDataCache change is definitely correct. I've not done much with the kdelibs migrator but I agree with the logic and the implementation. Have you tried building some of the other frameworks or Plasma after implementing this patch? That's the only real risk I can think of.

Jan 10 2019, 3:43 AM · Frameworks

Jan 7 2019

mpyne committed R365:0f4cc4b9d283: first-run: Remove kde-language support. (authored by mpyne).
first-run: Remove kde-language support.
Jan 7 2019, 1:37 AM
mpyne committed R365:c6e61dffe9ff: non-kde-deps: Add shell handler and metadata for distro dependencies. (authored by mpyne).
non-kde-deps: Add shell handler and metadata for distro dependencies.
Jan 7 2019, 1:37 AM
mpyne committed R365:d5240196124e: util: Add a method to locate data files, cleanup basedir detection. (authored by mpyne).
util: Add a method to locate data files, cleanup basedir detection.
Jan 7 2019, 1:37 AM
mpyne committed R365:402fc30fb80c: Breakout KDE modules into a specific subclass. (authored by mpyne).
Breakout KDE modules into a specific subclass.
Jan 7 2019, 1:37 AM

Jan 6 2019

mpyne committed R365:845e9da4ac26: first-run: Add basic installer and packages for Debian distros. (authored by mpyne).
first-run: Add basic installer and packages for Debian distros.
Jan 6 2019, 3:28 AM
mpyne committed R365:9b298270d448: CI: Remove needless build stage, document a working full build. (authored by mpyne).
CI: Remove needless build stage, document a working full build.
Jan 6 2019, 3:28 AM
mpyne committed R344:066c3ff1726f: Add README.md (authored by David Planella <david.planella@ubuntu.com>).
Add README.md
Jan 6 2019, 1:16 AM

Dec 29 2018

mpyne committed R365:c72e6e6e1865: first-run: Add needed OpenSuse packages needed to install dolphin. (authored by mpyne).
first-run: Add needed OpenSuse packages needed to install dolphin.
Dec 29 2018, 5:34 AM
mpyne committed R365:739ddb56cb6a: first-run: Use absolute paths when generating .kdesrc-buildrc. (authored by mpyne).
first-run: Use absolute paths when generating .kdesrc-buildrc.
Dec 29 2018, 5:34 AM
mpyne committed R365:068700c3527f: Remove dead implementation of --initial-setup. (authored by mpyne).
Remove dead implementation of --initial-setup.
Dec 29 2018, 5:34 AM

Dec 28 2018

mpyne committed R344:04aecdab49ee: Merge branch 'Applications/18.12' into 'Applications/18.12' (authored by mpyne).
Merge branch 'Applications/18.12' into 'Applications/18.12'
Dec 28 2018, 11:16 AM
mpyne committed R344:3cf1c4111895: ci: add the template for creating the flatpak (authored by bshah).
ci: add the template for creating the flatpak
Dec 28 2018, 11:16 AM
mpyne committed R365:a0d3da8b8d29: CI: Add kdesrc-build test suite to Gitlab CI. (authored by mpyne).
CI: Add kdesrc-build test suite to Gitlab CI.
Dec 28 2018, 5:11 AM
mpyne committed R365:616859ca4823: I always forget git itself :(. (authored by mpyne).
I always forget git itself :(.
Dec 28 2018, 5:06 AM
mpyne committed R365:820009933cdb: CI: Add remaining required modules. (authored by mpyne).
CI: Add remaining required modules.
Dec 28 2018, 4:59 AM
mpyne committed R365:bf032f70fb3b: CI: Add cmake as a test dependency. (authored by mpyne).
CI: Add cmake as a test dependency.
Dec 28 2018, 4:48 AM
mpyne committed R365:8b43686328ff: CI: Add kdesrc-build test suite to Gitlab CI. (authored by mpyne).
CI: Add kdesrc-build test suite to Gitlab CI.
Dec 28 2018, 4:46 AM
mpyne committed R365:efc3b42794c9: Merge remote-tracking branch 'gitlab/master' into make_it_mojo (authored by mpyne).
Merge remote-tracking branch 'gitlab/master' into make_it_mojo
Dec 28 2018, 3:58 AM
mpyne committed R365:26c9fc5f09ef: README: Light proofreading and capitalization fixes. (authored by mpyne).
README: Light proofreading and capitalization fixes.
Dec 28 2018, 1:54 AM
mpyne committed R365:c1a92f3d547a: Merge branch '10-set-stop-on-failure-by-default' into 'master' (authored by mpyne).
Merge branch '10-set-stop-on-failure-by-default' into 'master'
Dec 28 2018, 1:54 AM
mpyne committed R365:f6888c9f958e: Adjust default config file to set some more user-friendly defaults for new… (authored by ngraham).
Adjust default config file to set some more user-friendly defaults for new…
Dec 28 2018, 1:53 AM
mpyne committed R365:87844085c697: Merge branch 'quickstart-doc' into 'master' (authored by mpyne).
Merge branch 'quickstart-doc' into 'master'
Dec 28 2018, 1:53 AM

Dec 27 2018

mpyne committed R365:6475925a6790: WIP: Adjust README.md for style and readability. (authored by mpyne).
WIP: Adjust README.md for style and readability.
Dec 27 2018, 12:55 AM

Dec 26 2018

mpyne committed R365:eebceff7c148: first-run: Add additional Arch requirements. (authored by mpyne).
first-run: Add additional Arch requirements.
Dec 26 2018, 2:10 AM
mpyne committed R365:e84022a7acd6: Add Arch package for IO::Socket::SSL as a kdesrc-build dep. (authored by ngraham).
Add Arch package for IO::Socket::SSL as a kdesrc-build dep.
Dec 26 2018, 1:30 AM
mpyne closed D17768: Add additional required Perl module package for Arch.
Dec 26 2018, 1:30 AM
mpyne added a comment to D17768: Add additional required Perl module package for Arch.

Probably because we're using kdesrc-build as a testcase for the Gitlab instance at invent.kde.org. I'll go ahead and push.

Dec 26 2018, 1:25 AM

Dec 25 2018

mpyne committed R365:e743b5bb9f30: Fix broken cmdline parsing when --stop-on-failure in use. (authored by mpyne).
Fix broken cmdline parsing when --stop-on-failure in use.
Dec 25 2018, 10:24 PM
mpyne accepted D17768: Add additional required Perl module package for Arch.

This is perfect, you've already put more testing than I have been able to put for Arch. If you have future such fixes you can feel free to push, especially if already tested (I've only been able to test OpenSUSE up to this point).

Dec 25 2018, 1:25 AM
mpyne accepted D17771: Fix Python 3 warning.
Dec 25 2018, 1:23 AM

Dec 22 2018

mpyne committed R344:6a1d0ec47448: Merge branch 'Applications/18.12' (authored by mpyne).
Merge branch 'Applications/18.12'
Dec 22 2018, 5:20 PM
mpyne committed R344:468a5169347c: Port sort function for list of playlists to KF5. (authored by mpyne).
Port sort function for list of playlists to KF5.
Dec 22 2018, 5:20 PM
mpyne committed R344:bcf4f68bc369: Merge branch 'Applications/18.12' (authored by mpyne).
Merge branch 'Applications/18.12'
Dec 22 2018, 5:20 PM
mpyne committed R344:dc3124e40b73: Force sorting on so that special playlist sort to top. (authored by mpyne).
Force sorting on so that special playlist sort to top.
Dec 22 2018, 5:20 PM
mpyne committed R344:f9721878bd29: Fix the "Show Columns" menu to show correct state on startup. (authored by mpyne).
Fix the "Show Columns" menu to show correct state on startup.
Dec 22 2018, 5:20 PM
mpyne committed R344:f7c1b49d01a6: Simplify Playlist constructors and cleanup header. (authored by mpyne).
Simplify Playlist constructors and cleanup header.
Dec 22 2018, 5:20 PM
mpyne committed R344:7096017772e6: Remove dead code for playlist tool tip. (authored by mpyne).
Remove dead code for playlist tool tip.
Dec 22 2018, 5:20 PM
mpyne committed R344:c6afa4c528fa: Disable tag updating from inline editor. (authored by mpyne).
Disable tag updating from inline editor.
Dec 22 2018, 5:20 PM
mpyne committed R344:3b931e905015: Merge branch 'Applications/18.12' (authored by mpyne).
Merge branch 'Applications/18.12'
Dec 22 2018, 5:20 PM
mpyne committed R344:a15af145e282: Remove debug spam for power management. (authored by mpyne).
Remove debug spam for power management.
Dec 22 2018, 5:20 PM
mpyne committed R344:4d63212ff403: Add cover art support for Ogg formats (Opus, Vorbis) (authored by mpyne).
Add cover art support for Ogg formats (Opus, Vorbis)
Dec 22 2018, 5:20 PM
mpyne committed R344:abb256f289d4: Remove needless event filter, add alt. row colors, sane column weights. (authored by mpyne).
Remove needless event filter, add alt. row colors, sane column weights.
Dec 22 2018, 5:20 PM
mpyne committed R344:6e518da461c8: Prefer QVector to QList for most auxiliary lists. (authored by mpyne).
Prefer QVector to QList for most auxiliary lists.
Dec 22 2018, 5:20 PM