skelly (Stephen Kelly)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Apr 30 2016, 3:34 PM (177 w, 20 h)
Availability
Available

Recent Activity

Jun 1 2017

skelly accepted D5821: KViewStateSerializer: Fix crash when view is destroyed before state serializer.
Jun 1 2017, 11:52 PM · Frameworks

May 28 2017

skelly added a comment to D5289: Import Find{Clang,LLVM} from KDevelop for Python bindings generation.

My preference would be to use the ClangConfig.cmake instead of introducing these new files.

May 28 2017, 11:34 AM · Build System, Frameworks

Feb 12 2017

skelly added a comment to D4509: Python bindings: Some comment-only tidyups and PEP-8 fixes..

The PEP-8 changes are some blank line changes.

Feb 12 2017, 8:45 PM · Build System, Frameworks
skelly added inline comments to D4510: Python bindings: Restore handling of deprecated constructs..
Feb 12 2017, 7:38 PM · Build System, Frameworks
skelly added inline comments to D4509: Python bindings: Some comment-only tidyups and PEP-8 fixes..
Feb 12 2017, 7:37 PM · Build System, Frameworks
skelly added a comment to D4509: Python bindings: Some comment-only tidyups and PEP-8 fixes..

Is anything here actually a PEP 8 fix?

Feb 12 2017, 7:35 PM · Build System, Frameworks

Feb 5 2017

skelly added a reverting change for R240:2e20aeab6e86: Automatically mark classes with pure virtual functions as /Abstract/.: R240:7476b10fda3e: Revert "Automatically mark classes with pure virtual functions as /Abstract/.".
Feb 5 2017, 10:47 PM
skelly committed R240:7476b10fda3e: Revert "Automatically mark classes with pure virtual functions as /Abstract/." (authored by skelly).
Revert "Automatically mark classes with pure virtual functions as /Abstract/."
Feb 5 2017, 10:47 PM

Feb 4 2017

skelly committed R237:36e17c3d1c6a: Don't export KEntryMap (authored by skelly).
Don't export KEntryMap
Feb 4 2017, 12:51 PM
skelly committed R244:64e6795c97b6: Bindings: Port the regex to new ECM behavior (authored by skelly).
Bindings: Port the regex to new ECM behavior
Feb 4 2017, 12:40 PM
skelly committed R240:66a7d95e6d4a: Bindings: Remove unused member (authored by skelly).
Bindings: Remove unused member
Feb 4 2017, 11:56 AM
skelly committed R240:2e20aeab6e86: Automatically mark classes with pure virtual functions as /Abstract/. (authored by Shaheed Haque <srhaque@theiet.org>).
Automatically mark classes with pure virtual functions as /Abstract/.
Feb 4 2017, 11:52 AM
skelly committed R240:98d065773413: Bindings: Take account of visibility of classes (authored by Shaheed Haque <srhaque@theiet.org>).
Bindings: Take account of visibility of classes
Feb 4 2017, 11:52 AM
skelly committed R240:4e17330a4520: Bindings: Generalize the skippable_attribute method (authored by skelly).
Bindings: Generalize the skippable_attribute method
Feb 4 2017, 11:52 AM
skelly committed R240:050f15ef6a0c: Bindings: Take account of visibility attribute on APIs (authored by Shaheed Haque <srhaque@theiet.org>).
Bindings: Take account of visibility attribute on APIs
Feb 4 2017, 11:52 AM
skelly committed R240:119b57aea046: Bindings: Remove unused method (authored by skelly).
Bindings: Remove unused method
Feb 4 2017, 11:52 AM
skelly committed R240:352dc8e84349: Bindings: Add an end marker to the regex pattern (authored by Shaheed Haque <srhaque@theiet.org>).
Bindings: Add an end marker to the regex pattern
Feb 4 2017, 11:52 AM

Jan 31 2017

skelly committed R240:cf14610d1fff: Bindings: Remove unused import (authored by skelly).
Bindings: Remove unused import
Jan 31 2017, 1:36 AM
skelly committed R240:fbecbe4916ed: Remove delimiters from licence header (authored by skelly).
Remove delimiters from licence header
Jan 31 2017, 1:36 AM
skelly committed R240:ca74d0c2101a: Bindings: Add missing documentation of the "name" for MethodCode (authored by Shaheed Haque <srhaque@theiet.org>).
Bindings: Add missing documentation of the "name" for MethodCode
Jan 31 2017, 1:36 AM
skelly committed R240:88662e587871: Update some documenation for the ModuleCodeDb (authored by Shaheed Haque <srhaque@theiet.org>).
Update some documenation for the ModuleCodeDb
Jan 31 2017, 1:36 AM
skelly committed R240:58d2577cf92c: Remove some delimiters from the licence header (authored by Shaheed Haque <srhaque@theiet.org>).
Remove some delimiters from the licence header
Jan 31 2017, 1:36 AM
skelly committed R240:2cbc7897ddec: Fix documentation for function database (authored by Shaheed Haque <srhaque@theiet.org>).
Fix documentation for function database
Jan 31 2017, 1:36 AM

Jan 29 2017

skelly added a comment to T5016: Sort out Python bindings generation.

@arojas Is something comparable already done like that elsewhere in KDE? Like for documentation for example?

Jan 29 2017, 4:37 PM · Language Bindings, Build System

Jan 28 2017

skelly added a comment to T5016: Sort out Python bindings generation.

@arojas Does that imply that 'make' alone should not build the bindings? I don't think that's generally desirable.

Jan 28 2017, 3:48 PM · Language Bindings, Build System

Jan 21 2017

skelly committed R240:1bb97996f4f5: Bindings: Add missing rules to debug output (authored by skelly).
Bindings: Add missing rules to debug output
Jan 21 2017, 10:58 AM

Jan 18 2017

skelly committed R240:3e6eb0562e5f: Bindings: Test file in subdirectory. (authored by skelly).
Bindings: Test file in subdirectory.
Jan 18 2017, 11:32 PM
skelly committed R240:34fb39fe3446: Bindings: Fix default param handling (authored by skelly).
Bindings: Fix default param handling
Jan 18 2017, 11:32 PM
skelly committed R240:c7940ff6b0c4: Bindings: Handle const-ref parameters with {} initializer (authored by skelly).
Bindings: Handle const-ref parameters with {} initializer
Jan 18 2017, 11:04 PM
skelly committed R240:ded67db971a2: Bindings: Handle const-ref of non-record parameter defaults (authored by skelly).
Bindings: Handle const-ref of non-record parameter defaults
Jan 18 2017, 11:04 PM
skelly committed R240:68611eca6d20: Bindings: Handle parameter initializers using {} gracefully (authored by skelly).
Bindings: Handle parameter initializers using {} gracefully
Jan 18 2017, 10:26 PM
skelly committed R240:22a487a08743: Bindings: Add explicit handling of nullptr as a parameter default (authored by skelly).
Bindings: Add explicit handling of nullptr as a parameter default
Jan 18 2017, 10:26 PM
skelly added a comment to D3987: Use nullptr in all Frameworks (just diff in KIO shown here).

It's true that QFlags has a ctor taking a nullptr. The bindings-related problem was in our handling of enums by prepending a namespace, so we would end up with Qt::nullptr. I've fixed that in ECM, and also fixed handling of = {} for various types too.

Jan 18 2017, 10:23 PM · Frameworks
skelly added a comment to D3987: Use nullptr in all Frameworks (just diff in KIO shown here).
In D3987#78468, @dfaure wrote:

{} sounds like the best solution to me.

Jan 18 2017, 9:26 PM · Frameworks

Jan 16 2017

skelly committed R240:01f52b2b03f9: Change minimum CMake requirement to be the same as ECM (authored by skelly).
Change minimum CMake requirement to be the same as ECM
Jan 16 2017, 12:11 AM

Jan 15 2017

skelly committed R244:e31b6e7f0b9f: Exclude method which requires QWidget (authored by skelly).
Exclude method which requires QWidget
Jan 15 2017, 2:12 PM
skelly updated subscribers of T5016: Sort out Python bindings generation.

@sitter FYI

Jan 15 2017, 1:35 PM · Language Bindings, Build System
skelly committed R284:fd2bb9770818: Add missing install dir (authored by skelly).
Add missing install dir
Jan 15 2017, 1:16 PM
skelly committed R265:657f3a3c73b7: Add missing install dir (authored by skelly).
Add missing install dir
Jan 15 2017, 1:16 PM
skelly committed R265:5c225775f7e3: Add python bindings (authored by skelly).
Add python bindings
Jan 15 2017, 1:13 PM
skelly committed R284:3aed9b9498ed: Add python bindings (authored by skelly).
Add python bindings
Jan 15 2017, 1:05 PM
skelly committed R288:0c72b170a259: Add python bindings (authored by skelly).
Add python bindings
Jan 15 2017, 12:55 PM
skelly committed R283:598c82f5d53d: Add python bindings (authored by skelly).
Add python bindings
Jan 15 2017, 12:42 PM
skelly committed R240:379ae36a1426: Bindings: Use installed python modules if making a dependent module (authored by skelly).
Bindings: Use installed python modules if making a dependent module
Jan 15 2017, 12:41 PM
skelly committed R237:51410384458b: Add python bindings (authored by skelly).
Add python bindings
Jan 15 2017, 11:50 AM
skelly committed R237:eab822e20620: Add missing export decoration (authored by skelly).
Add missing export decoration
Jan 15 2017, 11:50 AM
skelly committed R244:ce90417f6aef: Add missing include (authored by skelly).
Add missing include
Jan 15 2017, 11:43 AM
skelly committed R244:fac0028a613c: Add python bindings (authored by skelly).
Add python bindings
Jan 15 2017, 11:43 AM
skelly committed R244:1d9864166baa: Add missing forward declaration (authored by skelly).
Add missing forward declaration
Jan 15 2017, 11:43 AM
skelly committed R270:9f68555a1ff6: Add python bindings (authored by skelly).
Add python bindings
Jan 15 2017, 11:37 AM
skelly committed R276:b2c53618571a: Add python bindings (authored by skelly).
Add python bindings
Jan 15 2017, 11:34 AM
skelly committed R276:a43e4ab2584c: Apply filter to proxy immediately (authored by skelly).
Apply filter to proxy immediately
Jan 15 2017, 11:34 AM
skelly committed R240:dec469837d64: Bindings: Skip implementations of inline methods while parsing (authored by skelly).
Bindings: Skip implementations of inline methods while parsing
Jan 15 2017, 11:29 AM
skelly committed R240:4488938320f9: Bindings: Make it possible for rules to modify the typedef type (authored by skelly).
Bindings: Make it possible for rules to modify the typedef type
Jan 15 2017, 11:29 AM
skelly committed R240:c81d97caa5be: Bindings: Add a generic rule function to mark a container abstract (authored by skelly).
Bindings: Add a generic rule function to mark a container abstract
Jan 15 2017, 11:29 AM
skelly committed R240:9348f743b1f3: Bindings: Output all python bindings in the same build location (authored by skelly).
Bindings: Output all python bindings in the same build location
Jan 15 2017, 11:29 AM
skelly committed R240:636d6acc7adf: Bindings: Fix handling of forward declarations (authored by skelly).
Bindings: Fix handling of forward declarations
Jan 15 2017, 11:29 AM
skelly committed R240:8c347c61abaf: Bindings: Use lists in function API instead of strings (authored by skelly).
Bindings: Use lists in function API instead of strings
Jan 15 2017, 11:29 AM
skelly committed R240:3c31028dad2f: Bindings: Add missing test function implementation (authored by skelly).
Bindings: Add missing test function implementation
Jan 15 2017, 11:29 AM
skelly committed R240:006f45016664: Bindings: Make the module name part of the test name (authored by skelly).
Bindings: Make the module name part of the test name
Jan 15 2017, 11:29 AM

Jan 13 2017

skelly added a comment to T5016: Sort out Python bindings generation.

I added https://commits.kde.org/extra-cmake-modules/29b9db8d67c67d4d1303e8dd9804f698fbaefbe1 in an attempt to resolve the issue of multiple packages installing the same __init__.py file.

Jan 13 2017, 7:45 PM · Language Bindings, Build System
skelly committed R240:29b9db8d67c6: Bindings: Add a script to generate __init__.py file for bindings (authored by skelly).
Bindings: Add a script to generate __init__.py file for bindings
Jan 13 2017, 7:43 PM
skelly committed R249:ff1e3a6f3e91: Add python bindings (authored by skelly).
Add python bindings
Jan 13 2017, 7:21 PM
skelly committed R240:173d9984ef62: Bindings: Fix logic for finding the clang driver (authored by skelly).
Bindings: Fix logic for finding the clang driver
Jan 13 2017, 6:59 PM
skelly committed R240:115ab483d8dc: Bindings: Try to find libclang4 before trying to find libclang3 (authored by skelly).
Bindings: Try to find libclang4 before trying to find libclang3
Jan 13 2017, 6:59 PM
skelly committed R240:4332f9eea11b: Bindings: Determine the clang suffix from the filename if cached (authored by skelly).
Bindings: Determine the clang suffix from the filename if cached
Jan 13 2017, 6:59 PM
skelly committed R273:c9c359151b18: Bindings: Make it possible to customize the installation directory (authored by skelly).
Bindings: Make it possible to customize the installation directory
Jan 13 2017, 6:41 PM
skelly committed R271:3c62bc4b72e7: Bindings: Make it possible to customize the installation directory (authored by skelly).
Bindings: Make it possible to customize the installation directory
Jan 13 2017, 6:37 PM
skelly committed R236:1f98aeebb19f: Bindings: Make it possible to customize the installation directory (authored by skelly).
Bindings: Make it possible to customize the installation directory
Jan 13 2017, 6:29 PM
skelly added a comment to T5016: Sort out Python bindings generation.

Update on the installation directory issue. Instead of using 'dist-packages', the default is now 'site-packages', and packagers can now customize the install location for a package by passing

Jan 13 2017, 6:20 PM · Language Bindings, Build System
skelly committed R275:aba81ad61927: Bindings: Make it possible to customize the installation directory (authored by skelly).
Bindings: Make it possible to customize the installation directory
Jan 13 2017, 6:10 PM
skelly committed R240:029798941a10: Bindings: Make it possible to customise the installation directory (authored by skelly).
Bindings: Make it possible to customise the installation directory
Jan 13 2017, 6:09 PM
skelly committed R240:8cf274317b43: Bindings: Add rules engine for typedefs (authored by skelly).
Bindings: Add rules engine for typedefs
Jan 13 2017, 6:09 PM
skelly committed R240:af9f502f9629: Bindings: Implement ModuleCode and MethodCode databases (authored by skelly).
Bindings: Implement ModuleCode and MethodCode databases
Jan 13 2017, 6:09 PM

Jan 11 2017

skelly committed R240:39454cd89330: Bindings: Use diagnostic level specific text when reporting (authored by skelly).
Bindings: Use diagnostic level specific text when reporting
Jan 11 2017, 11:13 PM
skelly added a comment to T5016: Sort out Python bindings generation.

Update on bug https://bugs.kde.org/show_bug.cgi?id=374801 , myself and @arojas fixed it. Packagers may want to cherry-pick the 8aa6843404f9c6faef66cb9c76358158eafc1af1 commit in ECM, and ed1b9ce2bb2a2e51410e0a1754a72c110010a6a0 if you encounter other problems to diagnose.

Jan 11 2017, 9:33 PM · Language Bindings, Build System
skelly committed R240:ed1b9ce2bb2a: Bindings: Fix logging output severity for parsing messages (authored by skelly).
Bindings: Fix logging output severity for parsing messages
Jan 11 2017, 9:31 PM
skelly committed R240:8aa6843404f9: Explicitly pass -std=gnu++14 to clang when generating bindings (authored by skelly).
Explicitly pass -std=gnu++14 to clang when generating bindings
Jan 11 2017, 9:09 PM

Jan 10 2017

skelly committed R236:9f82215e24b5: Fix license for rules file (authored by skelly).
Fix license for rules file
Jan 10 2017, 8:51 AM
skelly committed R240:51b7b4942136: Bindings: Correctly handle access specifiers within macros (authored by skelly).
Bindings: Correctly handle access specifiers within macros
Jan 10 2017, 8:46 AM

Jan 9 2017

skelly added a comment to T5016: Sort out Python bindings generation.

If anyone else here can reproduce the issue in https://bugs.kde.org/show_bug.cgi?id=374801 I would appreciate if you could dig into it and figure out what the problem is.

Jan 9 2017, 9:35 PM · Language Bindings, Build System
skelly committed R240:b5a18440f45d: Extend unit test with code similar to kguiaddons (authored by skelly).
Extend unit test with code similar to kguiaddons
Jan 9 2017, 8:36 PM
skelly added a comment to T5016: Sort out Python bindings generation.

@arojas I raised that issue in June: http://comments.gmane.org/gmane.comp.kde.distributions/92 and it came up in November: https://www.mail-archive.com/kde-frameworks-devel@kde.org/msg39376.html

Jan 9 2017, 8:19 PM · Language Bindings, Build System

Jan 5 2017

skelly committed R273:cab88ae67fe6: Bindings: Ensure that KFontUtils works in the test (authored by skelly).
Bindings: Ensure that KFontUtils works in the test
Jan 5 2017, 11:01 PM
skelly committed R240:b05981a8fdf8: Bindings: Add some content to the test source (authored by skelly).
Bindings: Add some content to the test source
Jan 5 2017, 10:25 PM
skelly committed R240:c05dcfa4c4f3: Bindings: Improve diagnostics for the rules engine (authored by Shaheed Haque <srhaque@theiet.org>).
Bindings: Improve diagnostics for the rules engine
Jan 5 2017, 10:25 PM
skelly committed R240:e4775dbe9a3a: Bindings: Remove db member from Rule (authored by skelly).
Bindings: Remove db member from Rule
Jan 5 2017, 10:25 PM
skelly committed R240:94fcc53ab498: Bindings: Fix copy-pasta in documentation (authored by skelly).
Bindings: Fix copy-pasta in documentation
Jan 5 2017, 10:25 PM
skelly committed R240:67798115b790: Remove gitignore file (authored by skelly).
Remove gitignore file
Jan 5 2017, 10:25 PM
skelly committed R240:13f66631495e: Skip attributes on enums when generating bindings (authored by Shaheed Haque <srhaque@theiet.org>).
Skip attributes on enums when generating bindings
Jan 5 2017, 8:32 PM

Jan 4 2017

skelly added a comment to T5016: Sort out Python bindings generation.

Thanks for filing this.

Jan 4 2017, 12:19 AM · Language Bindings, Build System

Jan 3 2017

skelly committed R236:810b7ef9478d: Add python bindings (authored by skelly).
Add python bindings
Jan 3 2017, 12:37 AM
skelly committed R240:4a986d8db8e9: Revert "Enable -Wsuggest-override for g++ >= 5.0.0" (authored by skelly).
Revert "Enable -Wsuggest-override for g++ >= 5.0.0"
Jan 3 2017, 12:36 AM
skelly added a reverting change for R240:d1d637fadd6d: Enable -Wsuggest-override for g++ >= 5.0.0: R240:4a986d8db8e9: Revert "Enable -Wsuggest-override for g++ >= 5.0.0".
Jan 3 2017, 12:36 AM
skelly committed R273:497b835e2ea9: Remove duplicated tests (authored by skelly).
Remove duplicated tests
Jan 3 2017, 12:14 AM
skelly committed R275:1fff8ac1b941: Remove duplicate tests (authored by skelly).
Remove duplicate tests
Jan 3 2017, 12:11 AM
skelly committed R271:7da0f6cc4f3c: Remove duplicated tests (authored by skelly).
Remove duplicated tests
Jan 3 2017, 12:11 AM

Jan 2 2017

skelly committed R271:6cb6c5a0581c: Add python bindings for KDBusAddons (authored by skelly).
Add python bindings for KDBusAddons
Jan 2 2017, 2:00 PM
skelly committed R273:9d981bb9ece3: Add Python bindings for KGuiAddons (authored by skelly).
Add Python bindings for KGuiAddons
Jan 2 2017, 1:59 PM

Sep 10 2016

skelly committed R172:f268aefabbcd: Merged revisions 1067822 via svnmerge from svn+ssh://skelly@svn.kde. (authored by skelly).
Merged revisions 1067822 via svnmerge from svn+ssh://skelly@svn.kde.
Sep 10 2016, 6:42 AM