Differential D28011

Fix build with 5.14.2 and 5.15 beta2
ClosedPublic
Actions

Authored by carewolf on Mar 12 2020, 12:13 PM.

Details

Reviewers
mlaurent
Commits
R84:9265e46139d8: Fix build with 5.14.2 and 5.15 beta2

Diff Detail

Repository
R84 PIM: KMail Transport
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
carewolf created this revision.Mar 12 2020, 12:13 PM
Restricted Application added a project: KDE PIM. · View Herald TranscriptMar 12 2020, 12:13 PM
Restricted Application added a subscriber: kde-pim. · View Herald Transcript
carewolf requested review of this revision.Mar 12 2020, 12:13 PM
anthonyfieroni added a subscriber: anthonyfieroni.Mar 12 2020, 12:39 PM

Your changes, all of sets and lists constructors by iterators should be guarded https://doc.qt.io/qt-5/qlist.html#QList-4 to be build with Qt 5.13 and earlier.

mlaurent requested changes to this revision.Mar 12 2020, 1:03 PM

same as "anthonyfieroni" :)

This revision now requires changes to proceed.Mar 12 2020, 1:03 PM
carewolf updated this revision to Diff 77569.Mar 13 2020, 3:27 PM

Update to also build with <5.14

mlaurent accepted this revision.Mar 13 2020, 9:13 PM
This revision is now accepted and ready to land.Mar 13 2020, 9:13 PM
Closed by commit R84:9265e46139d8: Fix build with 5.14.2 and 5.15 beta2 (authored by carewolf). · Explain WhyMar 13 2020, 9:59 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/kmailtransport/servertest.cpp (4 lines)

Diff 77600

View Options

src/kmailtransport/servertest.cpp

Loading...