Rebase
- Queries
- All Stories
- Search
- Advanced Search
Advanced Search
Sep 21 2018
Sep 16 2018
Sep 12 2018
Looks like this was already pushed @ 3b7d0f2cbf66b06e12c57be26b262b71d8030d1a
Sep 8 2018
Sep 7 2018
Aug 31 2018
Adding release managers, not sure who else can review this
Aug 29 2018
Alright. IMO it's cleaner to just drop API that is eventually no longer going to work (deprecated != not working), but in practice it won't make any difference since nothing uses this code.
Add deprecation markers, update DecodingQuality enum
Does krita use the ifdef'd code at all? If not, it may be simpler to just remove it completely.
Aug 28 2018
In D15091#316243, @rdieter wrote:I was asking mostly because that's what pyqt upstream strongly suggested (to use all sip_flags) when I asked them.
Aug 27 2018
In D15091#316150, @rdieter wrote:Why are you simply not using all PYQT_CONFIGURATION["sip_flags"]?
Aug 26 2018
Use a regex to account for the case where -n an its arg are not space-separated
In D14912#315763, @bruns wrote:Thats on Arch?
sip.h is python version agnostic, and in fact we install it under /usr/include. Would it be possible to also check this path?
Aug 25 2018
Python3 still can't be used after this change: python2 is explicitely required at FindPythonModuleGeneration.cmake:177 (and all subsequent calls to sip_generator.py are done with ${GPB_PYTHON2_COMMAND}). This can be adjusted in another review though.
Aug 21 2018
Escape semicolon
In D14962#312931, @sirgienko wrote:Hi, @arojas
First, Thanks!
Second, I couldn't found julia 1.0.0. As I see, there are problems with JULIA_LIBDL_COMMAND: cmake drop ; symbol (I don't see the symbol in message output).
I add escaping for this symbol (\) and all start works fine.
Do you haven't problem with version 1.0.0?
Use correct version
Fix indentation
Use QT_VERSION_CHECK macro
Aug 20 2018
In D14945#311947, @filipesaraiva wrote:Thanks @arojas, do you know if this change break the compatibility with previous versions of Sage?
Aug 19 2018
Aug 18 2018
This adds a new build time dependency to all frameworks which support bindings. Any chance to simply port it to python 3 instead?
Aug 17 2018
In D12761#309635, @asturmlechner wrote:ping, is this ready to merge?
Jul 21 2018
Jul 20 2018
Jul 19 2018
Jul 18 2018
Jul 17 2018
Fix build with older sip
I just tested on Neon Dev with PyQt 5.11 and python plugins build and work fine
In D14182#293778, @rempt wrote:Hm, I'm afraid it doesn't work for me on Neon 18.04:
Remove space after '-n', apparently sip doesn't like it
New patch at https://phabricator.kde.org/D14182
In D14061#293606, @rempt wrote:Argh... I guess the only thing I can do now is add a manual override cmake flag.
No idea about this error (the location of the QtCore/QtCoremod.sip hasn't changed in 5.11 so it should be found as before, and in any case it should be unrelated to this patch).
Jul 15 2018
Jul 14 2018
This has been approved for two weeks and fixes a major issue... could the fix be pushed and then keep working on the auto test later? It already missed 5.48
Jul 13 2018
8ee0958ae632e49773b79f837daaf40305777d06 is still wrong: ${PYQT5_VERSION} is the alphanumeric version string, it can't be compared with 5.11.0. Either
We are comparing string-formatted versions, so you should use STRGREATER, not VERSION_GREATER. Otherwise this will give unexpected results: on my system the if() evalulates to false even though I have PyQt 5.11, and in the appimage it seems to evaluate to TRUE with PyQt 5.9.
Oh, STRGREATER_EQUAL requires cmake 3.7. If can be safely changed to STRGREATER, since PYQt 5.11.0 was withdrawn upstream so no distro shound be using it.
Jul 12 2018
I do, just let me know what's the preferred merge workflow: push to 4.1 then merge to master or push to master and cherry-pick in 4.1?
Jul 11 2018
In D13967#290458, @nicolasfella wrote:Thanks! The purpose part is already released, so I guess the second case will only be relevant for people who self-compile KDE Connect with an older Purpose version.
Sure it will, at least in all packaging systems I know of. The issue here is the time between one update and the other one, when there would be two plugins (if purpose is updated first) or none (if kdeconnect is updated first). I'd suggest to bump KF5_MIN_VERSION to 5.48 to at least prevent the latter.