Differential D14945

Fix sagemath backend with sagemath 8.3
ClosedPublic
Actions

Authored by arojas on Aug 20 2018, 10:12 AM.

Details

Reviewers
sirgienko
asemke
Commits
R55:bd9a2d12b3f0: Fix sagemath backend with sagemath 8.3
R55:18f4feb25158: Fix sagemath backend with sagemath 8.3
Summary

The --simple-prompt support wasn't merged in 8.3

Test Plan

The sagemath backend works with 8.3 instead of throwing an error

Diff Detail

Repository
R55 Cantor
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
arojas created this revision.Aug 20 2018, 10:12 AM
Restricted Application added a project: KDE Edu. · View Herald TranscriptAug 20 2018, 10:12 AM
Restricted Application added a subscriber: kde-edu. · View Herald Transcript
arojas requested review of this revision.Aug 20 2018, 10:12 AM
sirgienko accepted this revision.Aug 20 2018, 11:21 AM

Thanks!

This revision is now accepted and ready to land.Aug 20 2018, 11:21 AM
Closed by commit R55:18f4feb25158: Fix sagemath backend with sagemath 8.3 (authored by arojas). · Explain WhyAug 20 2018, 11:24 AM
This revision was automatically updated to reflect the committed changes.
filipesaraiva added a subscriber: filipesaraiva.Aug 20 2018, 11:56 AM

Thanks @arojas, do you know if this change break the compatibility with previous versions of Sage?

arojas added a comment.Aug 20 2018, 12:00 PM
In D14945#311947, @filipesaraiva wrote:

Thanks @arojas, do you know if this change break the compatibility with previous versions of Sage?

This commit only changes the result of the version check for sagemath 8.3, it has no effect whatsoever for older versions.

filipesaraiva added a comment.Aug 20 2018, 12:02 PM

Nice, thanks again!

Revision Contents
Changeset List

PathPackages
Msrc/backends/sage/sagesession.cpp (2 lines)

Diff 40047

View Options

src/backends/sage/sagesession.cpp

Loading...