| rdieter | |
| asturmlechner | |
| lbeltrame | |
| pino |
Drop functions and API that depend on removed libraw features. The soversion was intended to be set to '30.0.0', quite an unusual value. This didn't work due to a typo, so in practice the soversion was 5 (the major lib version). Bump it to 6 to account for the removed API.
Patch based on digikam commit f5bc69c288dda2509dbdfd9c3c54cd82d88c38ef
Builds with libraw 0.18 and 0.19. Gwenview, kdegraphics-thumbnailers and kphotoalbum build fine after the patch.
| Lint Skipped |
| Unit Tests Skipped |
No need to break the API/ABI of libkdcraw just because of changes in libraw -- just mark the public stuff affected as deprecated.
Regarding the internal usage: please keep the old code for older versions of libraw; see the libraw_version.h header (provided by libraw) with some defines & macros for this.
Alright. IMO it's cleaner to just drop API that is eventually no longer going to work (deprecated != not working), but in practice it won't make any difference since nothing uses this code.
I've opened D15149 to fix the soversion mess, I'd appreciate if someone could give it a quick look (I don't know if there's anybody currently in charge of this library - agateau is listed as maintainer who if I'm not mistaken is no longer active)