Differential D14915

Bindings: Check if bindings can be generated for a specific python version
ClosedPublic
Actions

Authored by bruns on Aug 17 2018, 11:17 PM.

Details

Reviewers
arojas
Group Reviewers
Frameworks
Commits
R240:4275cfc3f75d: Bindings: Check if bindings can be generated for a specific python version
Summary

The generated C++ sources include <sip.h>, so it must be available.
Check for it in the version specific directories and fall back to
the default include directories.

Test Plan

install python2-devel and python3-devel
install one of python{x}-sip-devel

bindings should be generated for the matching python version.

Diff Detail

Repository
R240 Extra CMake Modules
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
bruns created this revision.Aug 17 2018, 11:17 PM
Restricted Application added projects: Frameworks, Build System. · View Herald TranscriptAug 17 2018, 11:17 PM
Restricted Application added subscribers: kde-buildsystem, kde-frameworks-devel. · View Herald Transcript
bruns requested review of this revision.Aug 17 2018, 11:17 PM
arojas added a subscriber: arojas.Aug 26 2018, 8:51 AM

sip.h is python version agnostic, and in fact we install it under /usr/include. Would it be possible to also check this path?

bruns planned changes to this revision.Aug 26 2018, 2:25 PM

sure ...

bruns updated this revision to Diff 40471.Aug 26 2018, 3:41 PM
bruns edited the summary of this revision. (Show Details)
bruns edited the test plan for this revision. (Show Details)

Also check for sip.h in the default paths (e.g. /usr/include/)

arojas accepted this revision.Aug 31 2018, 1:10 PM
This revision is now accepted and ready to land.Aug 31 2018, 1:10 PM
Closed by commit R240:4275cfc3f75d: Bindings: Check if bindings can be generated for a specific python version (authored by bruns). · Explain WhyAug 31 2018, 9:45 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 40795

View Options

find-modules/FindPythonModuleGeneration.cmake

Loading...