Differential D15345

Mark phonon as required
ClosedPublic
Actions

Authored by arojas on Sep 8 2018, 10:00 AM.

Details

Reviewers
pino
Group Reviewers
KDE Edu
Commits
R333:7fe3cd3c6654: Mark phonon as required
Summary

klettres doesn't build without phonon:

/build/klettres/src/klettres-18.08.1/src/soundfactory.cpp:31:10: fatal error: phonon/MediaObject: No such file or directory
#include <phonon/MediaObject>

^~~~~~~~~~~~~~~~~~~~

compilation terminated.

Test Plan

Try to build without phonon, cmake errors out instead of proceeding with the build

Diff Detail

Repository
R333 KLettres
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
arojas created this revision.Sep 8 2018, 10:00 AM
Restricted Application added a project: KDE Edu. · View Herald TranscriptSep 8 2018, 10:00 AM
Restricted Application added a subscriber: kde-edu. · View Herald Transcript
arojas requested review of this revision.Sep 8 2018, 10:00 AM
pino accepted this revision.Sep 8 2018, 10:07 AM
pino added a subscriber: pino.

Please commit it in the Applications/18.08 branch.

This revision is now accepted and ready to land.Sep 8 2018, 10:07 AM
Closed by commit R333:7fe3cd3c6654: Mark phonon as required (authored by arojas). · Explain WhySep 8 2018, 10:11 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
MCMakeLists.txt (2 lines)

Diff 41192

View Options

CMakeLists.txt

Loading...