Fix build with libraw 0.19
AbandonedPublic

Authored by asturmlechner on Aug 29 2018, 3:54 PM.

Details

Reviewers
rempt
Group Reviewers
Krita
Summary

Patch taken from arojas in https://phabricator.kde.org/D15132 applied
with little offset.

BUG: 396121

Test Plan

Built fine against libraw-0.19 with krita.git master.

Diff Detail

Repository
R37 Krita
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 2774
Build 2792: arc lint + arc unit
asturmlechner created this revision.Aug 29 2018, 3:54 PM
Restricted Application added a reviewer: Krita. · View Herald TranscriptAug 29 2018, 3:54 PM
Restricted Application added a project: Krita. · View Herald Transcript
asturmlechner requested review of this revision.Aug 29 2018, 3:54 PM
asturmlechner edited the summary of this revision. (Show Details)Aug 29 2018, 4:00 PM

Does krita use the ifdef'd code at all? If not, it may be simpler to just remove it completely.

rempt added a comment.Aug 29 2018, 4:33 PM

Honestly, I don't know. I've often been on the verge of removing the raw plugin completely, even.

rempt accepted this revision.Sep 7 2018, 7:55 AM

I think we already pushed this, didn't we?

This revision is now accepted and ready to land.Sep 7 2018, 7:55 AM

I think we already pushed this, didn't we?

D15132 was pushed, but for libkdcraw ;) Thanks, may look into copying arojas' docu changes as well so that the codebase remains similar.

Update with changes in D15132

Looks like this was already pushed @ 3b7d0f2cbf66b06e12c57be26b262b71d8030d1a

asturmlechner abandoned this revision.Sep 12 2018, 5:39 PM

Thanks, should have pulled before update...