You may use Linux to develop software that's intended to be used also on Mac and Windows. You can't expect developers to have build environment for every platform

I object. This warning is for developers. It tells them the icons are missing for some platforms.

In D26202#595846, @tcanabrava wrote:

I Just reverted this and I'm working on a full build of kde using kdesrc-build --refresh-build, I'll reopen this patch when *all* projects build sucessfully, with a unittest for each one that broke.

In D26454#593182, @cgiboudeaux wrote:

After updating, I'm getting that:

15:42:28 - systemsettings(16291) -  : <Unknown File>:7: TypeError: Cannot read property 'contentX' of null

** (process:16291): WARNING **: 15:42:30.200: _ag_value_from_string: error parsing type "as" ``[
              'https://www.googleapis.com/auth/userinfo.email',
              'https://www.googleapis.com/auth/userinfo.profile',
              'https://www.googleapis.com/auth/calendar',
              'https://www.googleapis.com/auth/tasks',
              'https://www.google.com/m8/feeds/',
              'https://www.googleapis.com/auth/drive',
              'https://www.googleapis.com/auth/youtube.upload',
          ]'': 424:expected value

After updating, I'm getting that:

@rhaferkamp ping?

Note that you don't have a LGPL-2.0-or-later COPYING file in this repo (there's also no LGPL-2.0-only).

+1. ctest -R mimetreeparser-basicobjecttreeparsertest passes with this change

In D25753#572894, @winterz wrote:

please send me a list of urls that don't have https: and I'll add them to the whitelist

In T11933#212862, @jriddell wrote:

How about this for renaming the variable in Cmake?
https://phabricator.kde.org/D25769

The sphinx doc URL is https://www.sphinx-doc.org (it just doesn't work without www)

@asturmlechner ping?

In D23550#569554, @kossebau wrote:

In D23550#569552, @cgiboudeaux wrote:

In D23550#569485, @kossebau wrote:

ping :) No-one any opinion?

Sure :)
-1. The Config file is supposed to look for the lowest supported version.

So, which is meant to be the lowest supported version for a built kcoreaddons which was compiled against e.g. Qt 5.13 (and thus uses its additional API)?

In D23550#569485, @kossebau wrote:

ping :) No-one any opinion?

I applied the patch to our openexr package instead.

In D25304#562561, @arojas wrote:

I don't see how that commit is related.
openEXR 2.3 installs libXXX.so and 2.4 installs libXXX-2_4.so

This is expected afaics.

No, it's not. That line in openexr is supposed to link libXXX-2_4.so (${verlibname}) to libXXX.so (${baselibname}) but it does so in the wrong dir

In D25304#562553, @arojas wrote:

This is a bug in openexr. It does actually try to install the unsuffixed symlinks, but it doesn't take DESTDIR into account, so it tries to install them to the root filesystem instead of doing so inside DESTDIR as it should. It is fixed in https://github.com/openexr/openexr/commit/4e54bde78f65c0fef8a9f794aaacea07813fba09

Note: openEXR >= 2.4 provides CMake configuration modules (OpenEXRConfig.cmake and IlmBaseConfig.cmake). We could also look for those and use the current code as a fallback if the modules can't be found

Also tested with CMake 3.1 which is the version required by Qt 5.12. It won't report the component, however.

Note: this is 2 different commits.

In T11933#207937, @jriddell wrote:

• New name for https://community.kde.org/Applications/19.12_Release_Notes
  
  How about https://community.kde.org/19.12_Release_Notes or https://community.kde.org/Releases/19.12_Release_Notes. I think I prefer the first

tested successfully locally. I don't see menus opening on the top left corner when running vlc or hp-systray.

LGTM

Another issue caused by the new CMake 3.5 dependency, some tests fail:

Thanks! tested successfully

In D24841#552577, @dfaure wrote:

Where did -std=gnu++14 come from? The old code above certainly didn't set it.

Maybe some projects were doing set(CMAKE_CXX_STANDARD 14) before including KDECompilerSettings? We could test the var here to avoid overwriting it...

I'm seeing build failures in several repositories seemingly caused by 6e3c794 (eg akonadi, kasync)

I can't test since I don't need these files.

Note: the metainfo file says this framework is tier 3.