Feed Advanced Search

Today

cgiboudeaux added inline comments to D27601: KConfig: Convert to SPDX license statements.
Mon, Feb 24, 10:11 AM · Frameworks
cgiboudeaux accepted D27602: KDbusAddons: Convert license statement to SPDX.
Mon, Feb 24, 9:52 AM · Frameworks
cgiboudeaux accepted D27603: KDNSSD: Convert license headers to SPDX statements.
Mon, Feb 24, 9:49 AM · Frameworks

Sat, Feb 15

cgiboudeaux accepted D27419: Update Japanese holidays.
Sat, Feb 15, 8:45 AM · Frameworks, KDE PIM

Thu, Feb 13

cgiboudeaux accepted D27361: KCalendarCore: Convert license statements to SPDX markers.
Thu, Feb 13, 4:57 PM · KDE PIM
cgiboudeaux updated subscribers of D27363: KHolidays: Convert license statements to SPDX expressions.
Thu, Feb 13, 1:04 PM · Frameworks
cgiboudeaux added inline comments to D27361: KCalendarCore: Convert license statements to SPDX markers.
Thu, Feb 13, 12:53 PM · KDE PIM
cgiboudeaux added inline comments to D27245: Ki18n: Convert license headers to SPDX statements.
Thu, Feb 13, 11:34 AM · Frameworks
cgiboudeaux added a comment to D27245: Ki18n: Convert license headers to SPDX statements.

some headers have 3 leading whitespaces, some 4. Can you clarify?

Thu, Feb 13, 10:34 AM · Frameworks
cgiboudeaux accepted D27103: KItemModels: Convert license headers to SPDX markers.

Please push after fixing the remaining issues

Thu, Feb 13, 8:52 AM · Frameworks
cgiboudeaux added inline comments to D27103: KItemModels: Convert license headers to SPDX markers.
Thu, Feb 13, 8:51 AM · Frameworks
cgiboudeaux accepted D27106: Attica: Convert license statements to SPDX markers.
Thu, Feb 13, 8:26 AM · Frameworks

Mon, Feb 10

cgiboudeaux accepted D27297: KGuiAddons: Convert license headers to SPDX statements.

LGTM

Mon, Feb 10, 5:55 PM · Frameworks
cgiboudeaux accepted D27277: Properly search for PipeWire libs.

Just one thing left to fix before pushing

Mon, Feb 10, 3:35 PM · Plasma
cgiboudeaux added inline comments to D27277: Properly search for PipeWire libs.
Mon, Feb 10, 3:14 PM · Plasma
cgiboudeaux added inline comments to D27277: Properly search for PipeWire libs.
Mon, Feb 10, 3:12 PM · Plasma

Sat, Feb 8

cgiboudeaux accepted D27234: KPlotting: Convert license statements to SPDX.
Sat, Feb 8, 12:28 PM · Frameworks
cgiboudeaux added inline comments to D27234: KPlotting: Convert license statements to SPDX.
Sat, Feb 8, 11:46 AM · Frameworks
cgiboudeaux added inline comments to D27234: KPlotting: Convert license statements to SPDX.
Sat, Feb 8, 10:41 AM · Frameworks
cgiboudeaux accepted D27092: Prison: Convert license statements to SPDX identifiers.
Sat, Feb 8, 10:38 AM · Frameworks
cgiboudeaux accepted D27231: BluezQt: Convert license statements to SPDX.

LGTM once the license file is fixed

Sat, Feb 8, 9:52 AM · Frameworks
cgiboudeaux accepted D27104: KArchive: Convert license statements to SPDX headers.
Sat, Feb 8, 8:39 AM · Frameworks

Thu, Feb 6

cgiboudeaux added inline comments to D27103: KItemModels: Convert license headers to SPDX markers.
Thu, Feb 6, 9:32 PM · Frameworks
cgiboudeaux added a comment to D27103: KItemModels: Convert license headers to SPDX markers.

same remark as for D27106. Check if FileContributor is more appropriate.

Thu, Feb 6, 9:28 PM · Frameworks
cgiboudeaux accepted D27091: Sonnet: Convert license statements to SPDX.
Thu, Feb 6, 9:24 PM · Frameworks

Wed, Feb 5

cgiboudeaux added a comment to D27092: Prison: Convert license statements to SPDX identifiers.

+1 LGTM

Wed, Feb 5, 9:12 PM · Frameworks
cgiboudeaux added inline comments to D27106: Attica: Convert license statements to SPDX markers.
Wed, Feb 5, 8:44 PM · Frameworks

Mon, Feb 3

cgiboudeaux added inline comments to D27104: KArchive: Convert license statements to SPDX headers.
Mon, Feb 3, 12:07 AM · Frameworks

Sat, Feb 1

cgiboudeaux added a comment to D27091: Sonnet: Convert license statements to SPDX.

+1 LGTM

Sat, Feb 1, 6:12 PM · Frameworks
cgiboudeaux committed R477:45a87de50895: Merge remote-tracking branch 'origin/release/19.12' (authored by cgiboudeaux).
Merge remote-tracking branch 'origin/release/19.12'
Sat, Feb 1, 12:46 PM
cgiboudeaux committed R477:17fedad11cba: Handle 410 Gone errors during Calendar sync (authored by gbs).
Handle 410 Gone errors during Calendar sync
Sat, Feb 1, 12:44 PM
cgiboudeaux closed D27062: Handle 410 Gone errors during Calendar sync.
Sat, Feb 1, 12:44 PM · KDE PIM

Fri, Jan 31

cgiboudeaux accepted D26931: KIdleTime: Convert license statements to SPDX.
Fri, Jan 31, 1:50 PM · Frameworks

Mon, Jan 27

cgiboudeaux added a comment to D26931: KIdleTime: Convert license statements to SPDX.

Convert to SPDX-FileCopyrightText tags

some files have <year> by <author>, can I suggest removing this "by"?

Mon, Jan 27, 6:03 PM · Frameworks
cgiboudeaux added a comment to D26931: KIdleTime: Convert license statements to SPDX.

Convert to SPDX-FileCopyrightText tags

Mon, Jan 27, 6:01 PM · Frameworks

Sun, Jan 26

cgiboudeaux added a comment to D26931: KIdleTime: Convert license statements to SPDX.

LGTM

Sun, Jan 26, 8:46 PM · Frameworks

Jan 22 2020

cgiboudeaux accepted D26819: Fix missing link libraries to CMakeLists.txt.
Jan 22 2020, 11:50 AM · KDE PIM
cgiboudeaux requested changes to D26818: Fix missing link libraries to CMakeLists.txt.

If you need to add KF5::SyntaxHighlighting, that means it's not supposed to be a PRIVATE link target, what KF5LibKSieveConfig.cmake.in confirms.

Jan 22 2020, 7:40 AM · KDE PIM

Jan 20 2020

cgiboudeaux added a comment to D26752: ECMAddAppIcon: Do not warn about mac and window icons if isnt a OS specific build.

Hi @cgiboudeaux and @bcooksley, there is a reason of why this patch is valid. Have you read the commit message ?

In Kirogi we provide a valid icon (svg) with a valid prefix (sc), as you probably know *sc* stands for for scalable (SVG) files.

Jan 20 2020, 9:03 AM · Build System, Frameworks

Jan 19 2020

cgiboudeaux added a comment to D26752: ECMAddAppIcon: Do not warn about mac and window icons if isnt a OS specific build.
Jan 19 2020, 5:23 PM · Build System, Frameworks
cgiboudeaux added a comment to D26752: ECMAddAppIcon: Do not warn about mac and window icons if isnt a OS specific build.

That’s not a developer issue, it’s a packaging issue.

Jan 19 2020, 1:12 PM · Build System, Frameworks
cgiboudeaux added a comment to D26762: Rename library/target to KF5::DAV.

+1 after updating the review title

Jan 19 2020, 1:09 PM · KDE PIM
cgiboudeaux added a comment to D26752: ECMAddAppIcon: Do not warn about mac and window icons if isnt a OS specific build.

You may use Linux to develop software that's intended to be used also on Mac and Windows. You can't expect developers to have build environment for every platform

Jan 19 2020, 12:01 PM · Build System, Frameworks
cgiboudeaux added inline comments to D26762: Rename library/target to KF5::DAV.
Jan 19 2020, 11:46 AM · KDE PIM
cgiboudeaux requested changes to D26752: ECMAddAppIcon: Do not warn about mac and window icons if isnt a OS specific build.

I object. This warning is for developers. It tells them the icons are missing for some platforms.

Jan 19 2020, 10:00 AM · Build System, Frameworks

Jan 17 2020

cgiboudeaux committed R871:535cc003005d: Merge branch 'Plasma/5.18' (authored by cgiboudeaux).
Merge branch 'Plasma/5.18'
Jan 17 2020, 12:22 PM
cgiboudeaux committed R871:807d9dccab08: installdbgsymbols_suse: Pass --plus-content debug to zypper (authored by fvogt).
installdbgsymbols_suse: Pass --plus-content debug to zypper
Jan 17 2020, 12:21 PM
cgiboudeaux closed D24751: installdbgsymbols_suse: Pass --plus-content debug to zypper.
Jan 17 2020, 12:21 PM · Plasma
cgiboudeaux accepted D24751: installdbgsymbols_suse: Pass --plus-content debug to zypper.
Jan 17 2020, 10:57 AM · Plasma
cgiboudeaux added a comment to D26202: Refactor KConfigXT.

I Just reverted this and I'm working on a full build of kde using kdesrc-build --refresh-build, I'll reopen this patch when *all* projects build sucessfully, with a unittest for each one that broke.

Jan 17 2020, 10:35 AM · Frameworks

Jan 13 2020

cgiboudeaux committed R156:f26e97cfc930: Merge remote-tracking branch 'origin/release/19.12' (authored by cgiboudeaux).
Merge remote-tracking branch 'origin/release/19.12'
Jan 13 2020, 2:58 PM
cgiboudeaux closed D26454: Google provider: limit requested OAuth scopes.

After updating, I'm getting that:

15:42:28 - systemsettings(16291) -  : <Unknown File>:7: TypeError: Cannot read property 'contentX' of null

** (process:16291): WARNING **: 15:42:30.200: _ag_value_from_string: error parsing type "as" ``[
              'https://www.googleapis.com/auth/userinfo.email',
              'https://www.googleapis.com/auth/userinfo.profile',
              'https://www.googleapis.com/auth/calendar',
              'https://www.googleapis.com/auth/tasks',
              'https://www.google.com/m8/feeds/',
              'https://www.googleapis.com/auth/drive',
              'https://www.googleapis.com/auth/youtube.upload',
          ]'': 424:expected value
Jan 13 2020, 2:57 PM
cgiboudeaux committed R156:5952bf25358b: Remove the extra comma (authored by cgiboudeaux).
Remove the extra comma
Jan 13 2020, 2:57 PM
cgiboudeaux reopened D26454: Google provider: limit requested OAuth scopes.

After updating, I'm getting that:

Jan 13 2020, 2:49 PM

Jan 8 2020

cgiboudeaux added a watcher for KF6: cgiboudeaux.
Jan 8 2020, 9:24 AM

Dec 20 2019

cgiboudeaux added a comment to D8843: Use URLs in multiget requests as returned by the Server.

@rhaferkamp ping?

Dec 20 2019, 8:10 AM · KDE PIM

Dec 15 2019

cgiboudeaux accepted D26011: Align ECM and Qt setup with Frameworks conventions.
Dec 15 2019, 10:02 AM · Frameworks

Dec 14 2019

cgiboudeaux added inline comments to D25975: Relicense some files to LGPLv2+ or v2v3, OK by all contributors according to relicensecheck.pl.
Dec 14 2019, 11:47 AM · Frameworks
cgiboudeaux accepted D25975: Relicense some files to LGPLv2+ or v2v3, OK by all contributors according to relicensecheck.pl.
Dec 14 2019, 11:37 AM · Frameworks
cgiboudeaux added inline comments to D25975: Relicense some files to LGPLv2+ or v2v3, OK by all contributors according to relicensecheck.pl.
Dec 14 2019, 11:05 AM · Frameworks
cgiboudeaux added a comment to D25975: Relicense some files to LGPLv2+ or v2v3, OK by all contributors according to relicensecheck.pl.

Note that you don't have a LGPL-2.0-or-later COPYING file in this repo (there's also no LGPL-2.0-only).

Dec 14 2019, 9:21 AM · Frameworks

Dec 11 2019

cgiboudeaux committed R237:975aaeeff483: kconfig EBN transport protocol cleanup (authored by jhayes).
kconfig EBN transport protocol cleanup
Dec 11 2019, 9:09 AM
cgiboudeaux closed D25829: kconfig EBN transport protocol cleanup.
Dec 11 2019, 9:09 AM · Frameworks
cgiboudeaux committed R296:ab35bc727cb7: kdeclarative EBN spelling cleanup (authored by jhayes).
kdeclarative EBN spelling cleanup
Dec 11 2019, 9:08 AM
cgiboudeaux closed D25864: kdeclarative EBN spelling cleanup.
Dec 11 2019, 9:08 AM · Frameworks
cgiboudeaux accepted D25864: kdeclarative EBN spelling cleanup.
Dec 11 2019, 9:07 AM · Frameworks
cgiboudeaux committed R175:98e731d68581: kholidays EBN transport protocol cleanup (authored by jhayes).
kholidays EBN transport protocol cleanup
Dec 11 2019, 9:04 AM
cgiboudeaux closed D25866: kholidays EBN transport protocol cleanup.
Dec 11 2019, 9:04 AM · Frameworks
cgiboudeaux accepted D25866: kholidays EBN transport protocol cleanup.
Dec 11 2019, 9:03 AM · Frameworks

Dec 10 2019

cgiboudeaux added inline comments to D25848: Fix typo in method name "unknowTagValue".
Dec 10 2019, 2:51 PM · KDE PIM

Dec 6 2019

cgiboudeaux accepted D25790: Make basicobjecttreeparsertest independent of host timezone.

+1. ctest -R mimetreeparser-basicobjecttreeparsertest passes with this change

Dec 6 2019, 5:50 PM · KDE PIM
cgiboudeaux added a comment to D25753: EBN extra-cmake-modules transport cleanup.

please send me a list of urls that don't have https: and I'll add them to the whitelist

Dec 6 2019, 12:17 PM · Build System, Frameworks

Dec 5 2019

cgiboudeaux committed R240:f082ed20e6a8: EBN extra-cmake-modules transport cleanup (authored by jhayes).
EBN extra-cmake-modules transport cleanup
Dec 5 2019, 9:14 PM
cgiboudeaux closed D25753: EBN extra-cmake-modules transport cleanup.
Dec 5 2019, 9:14 PM · Build System, Frameworks
cgiboudeaux accepted D25753: EBN extra-cmake-modules transport cleanup.
Dec 5 2019, 9:12 PM · Build System, Frameworks
cgiboudeaux added a comment to T11933: Debrand KDE Applications as Release Service.

How about this for renaming the variable in Cmake?
https://phabricator.kde.org/D25769

Dec 5 2019, 5:37 PM · KDE Promo, KDE Applications, Goal: All About the Apps
cgiboudeaux added a comment to D25753: EBN extra-cmake-modules transport cleanup.

The sphinx doc URL is https://www.sphinx-doc.org (it just doesn't work without www)

Dec 5 2019, 5:22 PM · Build System, Frameworks
cgiboudeaux added a comment to D19521: Switch from UsePkgConfig to FindPkgConfig.

@asturmlechner ping?

Dec 5 2019, 10:22 AM
cgiboudeaux committed R283:49ed872608fa: Install .pri file for KAuthCore (authored by volkov).
Install .pri file for KAuthCore
Dec 5 2019, 10:14 AM
cgiboudeaux closed D25397: Install .pri file for KAuthCore.
Dec 5 2019, 10:14 AM · Frameworks
cgiboudeaux committed R304:19bbe83f5527: EBN kmoretools cleanup transport protocol (authored by jhayes).
EBN kmoretools cleanup transport protocol
Dec 5 2019, 10:11 AM
cgiboudeaux closed D25493: EBN kmoretools cleanup transport protocol.
Dec 5 2019, 10:11 AM · Frameworks
cgiboudeaux committed R240:9f441190a36a: EBN extra-cmake-modules comments spelling cleanup (authored by jhayes).
EBN extra-cmake-modules comments spelling cleanup
Dec 5 2019, 9:37 AM
cgiboudeaux closed D25752: EBN extra-cmake-modules comments spelling cleanup.
Dec 5 2019, 9:37 AM · Build System, Frameworks
cgiboudeaux committed R267:b86aa2b10f7d: EBN cleanup of autotests transfer protocol (authored by jhayes).
EBN cleanup of autotests transfer protocol
Dec 5 2019, 9:35 AM
cgiboudeaux closed D25448: EBN cleanup of autotests transfer protocol.
Dec 5 2019, 9:35 AM · Frameworks
cgiboudeaux committed R6:8c0352356062: EBN KActivites transfer protocol cleanup (authored by jhayes).
EBN KActivites transfer protocol cleanup
Dec 5 2019, 9:34 AM
cgiboudeaux closed D25719: EBN KActivites transfer protocol cleanup.
Dec 5 2019, 9:34 AM · Frameworks
cgiboudeaux committed R296:342a575c0dd5: EBN kdeclarative transfer protocol cleanup (authored by jhayes).
EBN kdeclarative transfer protocol cleanup
Dec 5 2019, 9:33 AM
cgiboudeaux closed D25721: EBN kdeclarative transfer protocol cleanup.
Dec 5 2019, 9:33 AM · Frameworks
cgiboudeaux added inline comments to D25753: EBN extra-cmake-modules transport cleanup.
Dec 5 2019, 9:28 AM · Build System, Frameworks
cgiboudeaux requested changes to D25753: EBN extra-cmake-modules transport cleanup.
Dec 5 2019, 9:27 AM · Build System, Frameworks

Nov 29 2019

cgiboudeaux added a comment to D23550: CMake config files: use as min dep version the Qt version we built against.

ping :) No-one any opinion?

Sure :)
-1. The Config file is supposed to look for the lowest supported version.

So, which is meant to be the lowest supported version for a built kcoreaddons which was compiled against e.g. Qt 5.13 (and thus uses its additional API)?

Nov 29 2019, 9:12 PM · Frameworks
cgiboudeaux added a comment to D23550: CMake config files: use as min dep version the Qt version we built against.

ping :) No-one any opinion?

Nov 29 2019, 8:54 PM · Frameworks
cgiboudeaux updated the task description for T11933: Debrand KDE Applications as Release Service.
Nov 29 2019, 9:16 AM · KDE Promo, KDE Applications, Goal: All About the Apps
cgiboudeaux updated the task description for T11933: Debrand KDE Applications as Release Service.
Nov 29 2019, 9:12 AM · KDE Promo, KDE Applications, Goal: All About the Apps

Nov 26 2019

cgiboudeaux committed R55:4723d4c3e5ea: Fix build with Ninja on FreeBSD. (authored by cgiboudeaux).
Fix build with Ninja on FreeBSD.
Nov 26 2019, 10:23 AM
cgiboudeaux committed R44:f91ca2958231: Merge remote-tracking branch 'origin/release/19.12' (authored by cgiboudeaux).
Merge remote-tracking branch 'origin/release/19.12'
Nov 26 2019, 8:34 AM
cgiboudeaux committed R44:163968040f4b: IMAP resource: do not prompt for password with GSSAPI auth (authored by lachs).
IMAP resource: do not prompt for password with GSSAPI auth
Nov 26 2019, 8:33 AM
cgiboudeaux closed D25499: IMAP resource: do not prompt for password with GSSAPI auth.
Nov 26 2019, 8:33 AM · KDE PIM