some headers have 3 leading whitespaces, some 4. Can you clarify?
Sat, Feb 15
Thu, Feb 13
Please push after fixing the remaining issues
Mon, Feb 10
Just one thing left to fix before pushing
Sat, Feb 8
LGTM once the license file is fixed
Thu, Feb 6
same remark as for D27106. Check if FileContributor is more appropriate.
Wed, Feb 5
Mon, Feb 3
Sat, Feb 1
Fri, Jan 31
Mon, Jan 27
Sun, Jan 26
Jan 22 2020
If you need to add KF5::SyntaxHighlighting, that means it's not supposed to be a PRIVATE link target, what KF5LibKSieveConfig.cmake.in confirms.
Jan 20 2020
Jan 19 2020
+1 after updating the review title
You may use Linux to develop software that's intended to be used also on Mac and Windows. You can't expect developers to have build environment for every platform
I object. This warning is for developers. It tells them the icons are missing for some platforms.
Jan 17 2020
I Just reverted this and I'm working on a full build of kde using kdesrc-build --refresh-build, I'll reopen this patch when *all* projects build sucessfully, with a unittest for each one that broke.
Jan 13 2020
After updating, I'm getting that:15:42:28 - systemsettings(16291) - : <Unknown File>:7: TypeError: Cannot read property 'contentX' of null ** (process:16291): WARNING **: 15:42:30.200: _ag_value_from_string: error parsing type "as" ``[ 'https://www.googleapis.com/auth/userinfo.email', 'https://www.googleapis.com/auth/userinfo.profile', 'https://www.googleapis.com/auth/calendar', 'https://www.googleapis.com/auth/tasks', 'https://www.google.com/m8/feeds/', 'https://www.googleapis.com/auth/drive', 'https://www.googleapis.com/auth/youtube.upload', ]'': 424:expected value
After updating, I'm getting that:
Jan 8 2020
Dec 20 2019
Dec 15 2019
Dec 14 2019
Note that you don't have a LGPL-2.0-or-later COPYING file in this repo (there's also no LGPL-2.0-only).
Dec 11 2019
Dec 10 2019
Dec 6 2019
+1. ctest -R mimetreeparser-basicobjecttreeparsertest passes with this change
please send me a list of urls that don't have https: and I'll add them to the whitelist
Dec 5 2019
How about this for renaming the variable in Cmake?
The sphinx doc URL is https://www.sphinx-doc.org (it just doesn't work without www)
Nov 29 2019
So, which is meant to be the lowest supported version for a built kcoreaddons which was compiled against e.g. Qt 5.13 (and thus uses its additional API)?