Differential D26762

Rename library/target to KF5::DAV
ClosedPublic
Actions

Authored by vkrause on Jan 19 2020, 11:35 AM.

Details

Reviewers
mlaurent
Group Reviewers
KDE PIM
Commits
R490:746d587a7183: Rename library/target to KF5::DAV
R490:650654f552d0: Rename library/target to KF5::DAV
Summary

Prepares this for the move to Frameworks after 20.04.

Diff Detail

Repository
R490 KDAV Library
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
vkrause created this revision.Jan 19 2020, 11:35 AM
Restricted Application added a project: KDE PIM. · View Herald TranscriptJan 19 2020, 11:35 AM
Restricted Application added a subscriber: kde-pim. · View Herald Transcript
vkrause requested review of this revision.Jan 19 2020, 11:35 AM
krop added a subscriber: krop.Jan 19 2020, 11:46 AM
krop added inline comments.
CMakeLists.txt
51

to be consistent with the other frameworks (eg karchive → KF5Archive), I think it shall use KF5DAV everywhere

vkrause updated this revision to Diff 73869.Jan 19 2020, 12:14 PM

Remove K prefix from target name.

krop added a comment.Jan 19 2020, 1:08 PM

+1 after updating the review title

vkrause retitled this revision from Rename library/target to KF5::KDAV to Rename library/target to KF5::DAV.Jan 19 2020, 1:36 PM
mlaurent accepted this revision.Jan 23 2020, 6:38 PM
mlaurent added a subscriber: mlaurent.

Seems ok for me

This revision is now accepted and ready to land.Jan 23 2020, 6:38 PM
Closed by commit R490:746d587a7183: Rename library/target to KF5::DAV (authored by vkrause). · Explain WhyJan 24 2020, 4:41 PM
This revision was automatically updated to reflect the committed changes.
cfeck added a subscriber: cfeck.Feb 8 2020, 3:35 PM

This landed in release/19.12 branch. Was this intentional?

mlaurent added a subscriber: winterz.Feb 8 2020, 4:00 PM

For me it's an error.
@winterz please revert it

winterz added a subscriber: kossebau.Feb 9 2020, 1:46 PM

thanks for the revert.
this patch was needed in the 19.12 branch until @kossebau patched modules/ECMGeneratePriFile.cmake in extra-cmake-modules

Revision Contents
Changeset List

Diff 74317

View Options

CMakeLists.txt

Loading...
View Options

KF5DAVConfig.cmake.in

Loading...
View Options

KPimKDAVConfig.cmake.in

Loading...
View Options

autotests/CMakeLists.txt

Loading...
View Options

metainfo.yaml

Loading...
View Options

src/CMakeLists.txt

Loading...
View Options

src/common/davcollection.h

Loading...
View Options

src/common/davcollectiondeletejob.h

Loading...
View Options

src/common/davcollectionmodifyjob.h

Loading...
View Options

src/common/davcollectionsfetchjob.h

Loading...
View Options

src/common/davcollectionsmultifetchjob.h

Loading...
View Options

src/common/daverror.h

Loading...
View Options

src/common/davitem.h

Loading...
View Options

src/common/davitemcreatejob.h

Loading...
View Options

src/common/davitemdeletejob.h

Loading...
View Options

src/common/davitemfetchjob.h

Loading...
View Options

src/common/davitemmodifyjob.h

Loading...
View Options

src/common/davitemsfetchjob.h

Loading...
View Options

src/common/davitemslistjob.h

Loading...
View Options

src/common/davjobbase.h

Loading...
View Options

src/common/davmultigetprotocol_p.h

Loading...
View Options

src/common/davprincipalhomesetsfetchjob.h

Loading...
View Options

src/common/davprincipalsearchjob.h

Loading...
View Options

src/common/davprotocolbase_p.h

Loading...
View Options

src/common/davurl.h

Loading...
View Options

src/common/etagcache.h

Loading...
View Options

src/common/protocolinfo.h

Loading...
View Options

test/CMakeLists.txt

Loading...