Awesome feature!

BTW, using -Bsymbolic-functions in KF5 could probably reduce startup times: https://wiki.qt.io/Performance_Tip_Startup_Time

Why not add support for QPlatformTheme::FontDialog in KdePlatformTheme::createPlatformDialogHelper()?

Moved to https://invent.kde.org/frameworks/kwindowsystem/-/merge_requests/7

Moved to https://invent.kde.org/multimedia/k3b/-/merge_requests/1

kf5 version is still not bumped.

Moved to https://invent.kde.org/frameworks/kio/-/merge_requests/76

Outdated and no chance it will be reviewed.

Moved to https://invent.kde.org/libraries/qca/-/merge_requests/35

Moved to https://invent.kde.org/graphics/gwenview/-/merge_requests/10

Moved to https://invent.kde.org/plasma/plasma-integration/-/merge_requests/1

fixed current screen resolution

Moved to https://invent.kde.org/plasma/breeze/-/merge_requests/7

@yuyichao, your patch changes requested resolution,
If I choose screen size to be 800x600, it can be surprising to see the remote session starting with 1600x1200.

alberts really old machine seems to gain a lot, why?

DialogIsQtWindow was introduced in https://codereview.qt-project.org/c/qt/qtbase/+/144710

registered for 2.2

imageReader.setQuality(0); was added in https://phabricator.kde.org/R320:c249f8547f2d1913e0570d78a0240c5f8865c336 when I ported JpegCreator to QImageReader.
But as I mentioned there, it doesn't really influence on the decoding speed, and it was only needed to preserve the old behavior as much as possible.
This change looks good to me, +1.

change branch

build metadata from desktop files into the plugins

before:

Qt Core

> cat qt_lib_widgets.pri | grep depends
QT.widgets.depends = core gui

Fix for .pri: D25397

What about qmake?
I came across the following error:

g++ -Wl,-z,relro -o ... /usr/lib/x86_64-linux-gnu/libQt5Gui.so /usr/lib/x86_64-linux-gnu/libKF5Auth.so /usr/lib/x86_64-linux-gnu/libKF5CoreAddons.so /usr/lib/x86_64-linux-gnu/libQt5Core.so /usr/lib/x86_64-linux-gnu/libGL.so -lpthread   
/usr/bin/ld: ...: undefined reference to symbol '_ZN5KAuth11ActionReplyD1Ev'
/usr/bin/ld: //usr/lib/x86_64-linux-gnu/libKF5AuthCore.so.5: error adding symbols: DSO missing from command line

Hmmm, unfortunately arc created a needless merge commit :(

Do you mean that it doesn't work on X11?

Why rebase? I can cherry-pick this change to master without conflicts.

It will require adding the following methods:

Action::setFileDescriptors()
Action::addFileDescriptor()
Action::fileDescriptors()
ActionReply::setFileDescriptors()
ActionReply::addFileDescriptor()
ActionReply::fileDescriptors()

and

ExecuteJob::fileDescriptors()
ExecuteJob::newFileDescriptors()

with the condition that for progress data they can be used only with direct signal-slot connections,
because without UnixFileDescriptor we cannot guarantee the open state of file descriptors.
It doesn't seem better than exposing this class.

Without UnixFileDescriptor you could try to write

int fd = ...
Action action(...);
action.addArgument(QStringLiteral("fd"), fd);

but then KAuth won't be able to detect that it'a file descriptor and will pass it to a helper as int.

Yes, UnixFileDescriptor allows to use existing methods Action::setArguments() and ActionReply::setData().

moved dbus stuff to DBusHelperProxy

fix breaking API and ABI of KAuth::ActionReply

DBus is an internal dependency for KAuth. With the wrapper users don't have to link with QtDBus.

Passing file descriptors with KAuth: D24245

D24245 - support for passing Unix file descriptors in KAuth.

Wouldn't it be better to avoid creation of a temporary file by opening an original file for writing in the helper and passing the file descriptor back to the main process?

Oh, thanks.

fixed

This is for non-sandboxed applications that want to use KDE file dialog.