volkov (Alexander Volkov)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
May 20 2016, 1:05 PM (178 w, 4 d)
Availability
Available

Recent Activity

Tue, Oct 1

volkov added a comment to D24245: Add support for passing Unix file descriptors.

It will require adding the following methods:

Action::setFileDescriptors()
Action::addFileDescriptor()
Action::fileDescriptors()
ActionReply::setFileDescriptors()
ActionReply::addFileDescriptor()
ActionReply::fileDescriptors()

and

ExecuteJob::fileDescriptors()
ExecuteJob::newFileDescriptors()

with the condition that for progress data they can be used only with direct signal-slot connections,
because without UnixFileDescriptor we cannot guarantee the open state of file descriptors.
It doesn't seem better than exposing this class.

Tue, Oct 1, 7:35 AM · Frameworks

Sun, Sep 29

volkov added a comment to D24245: Add support for passing Unix file descriptors.

Without UnixFileDescriptor you could try to write

int fd = ...
Action action(...);
action.addArgument(QStringLiteral("fd"), fd);

but then KAuth won't be able to detect that it'a file descriptor and will pass it to a helper as int.

Sun, Sep 29, 12:22 PM · Frameworks
volkov added a comment to D24245: Add support for passing Unix file descriptors.

Yes, UnixFileDescriptor allows to use existing methods Action::setArguments() and ActionReply::setData().

Sun, Sep 29, 11:49 AM · Frameworks

Sat, Sep 28

volkov added inline comments to D24245: Add support for passing Unix file descriptors.
Sat, Sep 28, 8:49 AM · Frameworks

Fri, Sep 27

volkov updated the summary of D24245: Add support for passing Unix file descriptors.
Fri, Sep 27, 8:17 PM · Frameworks
volkov updated the diff for D24245: Add support for passing Unix file descriptors.

moved dbus stuff to DBusHelperProxy

Fri, Sep 27, 8:15 PM · Frameworks
volkov added inline comments to D24245: Add support for passing Unix file descriptors.
Fri, Sep 27, 8:14 PM · Frameworks
volkov added a comment to D24245: Add support for passing Unix file descriptors.
Fri, Sep 27, 8:13 PM · Frameworks
volkov added a dependency for D24259: WIP: Save file directly if possible when root privileges are required: D24245: Add support for passing Unix file descriptors.
Fri, Sep 27, 1:19 PM · Frameworks, Kate
volkov added a dependent revision for D24245: Add support for passing Unix file descriptors: D24259: WIP: Save file directly if possible when root privileges are required.
Fri, Sep 27, 1:19 PM · Frameworks
volkov requested review of D24259: WIP: Save file directly if possible when root privileges are required.
Fri, Sep 27, 1:16 PM · Frameworks, Kate
volkov updated the diff for D24245: Add support for passing Unix file descriptors.

fix breaking API and ABI of KAuth::ActionReply

Fri, Sep 27, 1:13 PM · Frameworks

Thu, Sep 26

volkov added a comment to D24245: Add support for passing Unix file descriptors.

DBus is an internal dependency for KAuth. With the wrapper users don't have to link with QtDBus.

Thu, Sep 26, 6:37 PM · Frameworks
volkov added a comment to D6709: Add support for sharing file descriptor between KIO slave and KAuth helper.

Passing file descriptors with KAuth: D24245

Thu, Sep 26, 4:32 PM · Frameworks
volkov added a comment to D5394: KAuth integration in document saving - vol. 2.

D24245 - support for passing Unix file descriptors in KAuth.

Thu, Sep 26, 4:26 PM · Kate, Frameworks, KTextEditor
volkov requested review of D24245: Add support for passing Unix file descriptors.
Thu, Sep 26, 4:22 PM · Frameworks

Tue, Sep 24

Restricted Application added a project to D5394: KAuth integration in document saving - vol. 2: Kate.

Wouldn't it be better to avoid creation of a temporary file by opening an original file for writing in the helper and passing the file descriptor back to the main process?

Tue, Sep 24, 12:27 PM · Kate, Frameworks, KTextEditor

Sep 16 2019

volkov committed R120:e8e97f8c5fb9: Remove QT_VERSION checks (authored by volkov).
Remove QT_VERSION checks
Sep 16 2019, 12:17 PM

Sep 10 2019

volkov committed R345:6b59a9a86568: Get rid of dependency on KIconThemes (authored by volkov).
Get rid of dependency on KIconThemes
Sep 10 2019, 10:18 AM
volkov committed R345:6fdf3c6f52ba: Fix shrinking of group boxes' titles (authored by volkov).
Fix shrinking of group boxes' titles
Sep 10 2019, 10:17 AM
volkov closed D22816: Get rid of dependency on KIconThemes.
Sep 10 2019, 10:17 AM
volkov closed D22825: Fix shrinking of group boxes' titles.
Sep 10 2019, 10:13 AM

Jul 30 2019

volkov added a reviewer for D22825: Fix shrinking of group boxes' titles: marten.
Jul 30 2019, 11:20 AM
volkov requested review of D22825: Fix shrinking of group boxes' titles.
Jul 30 2019, 11:20 AM
volkov committed R302:71a16579073f: Restore "Check if group < LastGroup, as KIconEffect doesn't handle UserGroup… (authored by volkov).
Restore "Check if group < LastGroup, as KIconEffect doesn't handle UserGroup…
Jul 30 2019, 10:44 AM
volkov closed D22809: Restore "Check if group < LastGroup, as KIconEffect doesn't handle UserGroup anyway".
Jul 30 2019, 10:44 AM · Frameworks
volkov added a comment to D22815: Fix finding (KF5)Plasma.

Oh, thanks.

Jul 30 2019, 10:33 AM

Jul 29 2019

volkov added a reviewer for D22816: Get rid of dependency on KIconThemes: marten.
Jul 29 2019, 9:23 PM
volkov requested review of D22816: Get rid of dependency on KIconThemes.
Jul 29 2019, 9:21 PM
volkov committed R345:b23f46652022: Add support for High DPI (authored by volkov).
Add support for High DPI
Jul 29 2019, 3:57 PM
volkov closed D22808: Add support for High DPI.
Jul 29 2019, 3:56 PM
volkov added a reviewer for D22809: Restore "Check if group < LastGroup, as KIconEffect doesn't handle UserGroup anyway": broulik.
Jul 29 2019, 3:50 PM · Frameworks
volkov requested review of D22809: Restore "Check if group < LastGroup, as KIconEffect doesn't handle UserGroup anyway".
Jul 29 2019, 3:50 PM · Frameworks
volkov added a reviewer for D22808: Add support for High DPI: marten.
Jul 29 2019, 3:25 PM
volkov requested review of D22808: Add support for High DPI.
Jul 29 2019, 3:25 PM
volkov added inline comments to D6313: Support Icon Scale from Icon naming specification 0.13.
Jul 29 2019, 3:12 PM · Frameworks, Plasma
volkov added inline comments to D6313: Support Icon Scale from Icon naming specification 0.13.
Jul 29 2019, 2:47 PM · Frameworks, Plasma
volkov committed R345:0613aa47e415: Make dependency on Plasma optional (authored by volkov).
Make dependency on Plasma optional
Jul 29 2019, 2:08 PM
volkov closed D22806: Make dependency on Plasma optional.
Jul 29 2019, 2:08 PM
volkov added a reviewer for D22806: Make dependency on Plasma optional: marten.
Jul 29 2019, 12:24 PM
volkov requested review of D22806: Make dependency on Plasma optional.
Jul 29 2019, 12:24 PM

Jul 26 2019

volkov added a reviewer for D22766: Fix positioning of output identifiers on screens with different dprs: Plasma.
Jul 26 2019, 4:18 PM · Plasma
volkov requested review of D22766: Fix positioning of output identifiers on screens with different dprs.
Jul 26 2019, 4:16 PM · Plasma

Jul 25 2019

volkov updated the diff for D22737: xcb: Fix setStrut() for High-DPI scaling.

fixed

Jul 25 2019, 1:05 PM · Frameworks
volkov added inline comments to D22737: xcb: Fix setStrut() for High-DPI scaling.
Jul 25 2019, 1:02 PM · Frameworks
volkov added a reviewer for D22737: xcb: Fix setStrut() for High-DPI scaling: Frameworks.
Jul 25 2019, 11:36 AM · Frameworks
volkov requested review of D22737: xcb: Fix setStrut() for High-DPI scaling.
Jul 25 2019, 11:35 AM · Frameworks

Jul 16 2019

volkov added a comment to D22482: WIP: Show file dialog in directory mode when only directory is requested.

This is for non-sandboxed applications that want to use KDE file dialog.

Jul 16 2019, 7:14 AM · Plasma

Jul 15 2019

volkov requested review of D22482: WIP: Show file dialog in directory mode when only directory is requested.
Jul 15 2019, 8:23 PM · Plasma

Jun 28 2019

volkov committed R467:9d0f1447f976: Merge remote-tracking branch 'origin/Applications/19.04' (authored by volkov).
Merge remote-tracking branch 'origin/Applications/19.04'
Jun 28 2019, 9:50 AM
volkov committed R467:7548d001a58a: Avoid leaking of file descriptors to child processes (authored by volkov).
Avoid leaking of file descriptors to child processes
Jun 28 2019, 9:50 AM
volkov closed D22123: Avoid leaking of file descriptors to child processes.
Jun 28 2019, 9:49 AM

Jun 27 2019

volkov retitled D22123: Avoid leaking of file descriptors to child processes from Avoid leaking file descriptors to child processes to Avoid leaking of file descriptors to child processes.
Jun 27 2019, 7:13 PM
volkov added a reviewer for D22123: Avoid leaking of file descriptors to child processes: KDE Applications.
Jun 27 2019, 4:08 PM
volkov requested review of D22123: Avoid leaking of file descriptors to child processes.
Jun 27 2019, 4:08 PM

Jun 24 2019

volkov abandoned D21363: Fix build with poppler < 0.51.

It's specific only for AstraLinux.

Jun 24 2019, 10:21 AM · Okular
volkov committed R467:9821f9aa4c3b: Merge remote-tracking branch 'origin/Applications/19.04' (authored by volkov).
Merge remote-tracking branch 'origin/Applications/19.04'
Jun 24 2019, 10:12 AM
volkov committed R467:1137f7641998: Fix detection of recommendation about DAO mode from growisofs (authored by volkov).
Fix detection of recommendation about DAO mode from growisofs
Jun 24 2019, 10:11 AM
volkov closed D21880: Fix detection of recommendation about DAO mode from growisofs.
Jun 24 2019, 10:11 AM

Jun 21 2019

volkov added a comment to D21880: Fix detection of recommendation about DAO mode from growisofs.

The last release of dvd+rw-tools was made in 2008, and dvd+rw-format printed :-( even then.

Jun 21 2019, 10:11 AM

Jun 20 2019

volkov added a comment to D20790: Add highdpi support for RDP and VNC.

This change allows to show remote contents as is.
For example, remote desktop may be started with QT_SCREEN_SCALE_FACTORS=2 and it will look good on highdpi monitor.

Jun 20 2019, 10:38 AM

Jun 18 2019

volkov requested review of D21887: Fix -Wimplicit-fallthrough warnings.
Jun 18 2019, 8:24 PM
volkov added a reviewer for D21880: Fix detection of recommendation about DAO mode from growisofs: KDE Applications.
Jun 18 2019, 12:10 PM
volkov requested review of D21880: Fix detection of recommendation about DAO mode from growisofs.
Jun 18 2019, 12:09 PM

Jun 17 2019

volkov added a comment to D20790: Add highdpi support for RDP and VNC.

Yes, remote contents should not be scaled.

Jun 17 2019, 4:08 PM
volkov added a comment to D20790: Add highdpi support for RDP and VNC.

Have you installed libkrdc_vncplugin.so into the system?
KRDC doesn't search for plugins in the build tree.

Jun 17 2019, 3:35 PM
volkov updated the diff for D20790: Add highdpi support for RDP and VNC.

fix initialization order

Jun 17 2019, 3:31 PM
volkov updated the diff for D20790: Add highdpi support for RDP and VNC.

rebased
thanks for noticing

Jun 17 2019, 10:42 AM

Jun 14 2019

volkov committed R467:1c673165a680: Merge remote-tracking branch 'origin/Applications/19.04' (authored by volkov).
Merge remote-tracking branch 'origin/Applications/19.04'
Jun 14 2019, 10:38 AM
volkov committed R467:8b8b4674cada: Fix available writing modes when formatting DVD-RW (authored by volkov).
Fix available writing modes when formatting DVD-RW
Jun 14 2019, 10:32 AM
volkov closed D21751: Fix available writing modes when formatting DVD-RW.
Jun 14 2019, 10:32 AM

Jun 13 2019

volkov added a comment to D21751: Fix available writing modes when formatting DVD-RW.

No, this change is only for DVD-RW, not DVD+RW.

Jun 13 2019, 6:22 AM

Jun 11 2019

volkov added a reviewer for D21751: Fix available writing modes when formatting DVD-RW: KDE Applications.
Jun 11 2019, 5:46 PM
volkov requested review of D21751: Fix available writing modes when formatting DVD-RW.
Jun 11 2019, 5:45 PM

Jun 10 2019

volkov added a comment to D20790: Add highdpi support for RDP and VNC.

This change prevents highdpi scaling of the remote desktop.
It's double-scaled on your gif and looks pixelated.

Jun 10 2019, 11:14 AM
volkov committed R223:3311ba3a67da: Use lambdas instead of QSignalMapper (authored by volkov).
Use lambdas instead of QSignalMapper
Jun 10 2019, 11:10 AM
volkov closed D17481: Use lambdas instead of QSignalMapper.
Jun 10 2019, 11:10 AM · Okular
volkov committed R467:9957433a5fb1: Use lambda instead of QSignalMapper (authored by volkov).
Use lambda instead of QSignalMapper
Jun 10 2019, 10:59 AM
volkov closed D15288: Use lambda instead of QSignalMapper.
Jun 10 2019, 10:58 AM
volkov added a comment to D15290: Use lambdas instead of QSignalMapper.

Well, I don't have time to contribute to this project, so I don't know what to do with it.

Jun 10 2019, 10:56 AM
volkov committed R254:bf6b348eb4f5: Use lambdas instead of QSignalMapper (authored by volkov).
Use lambdas instead of QSignalMapper
Jun 10 2019, 10:54 AM
volkov closed D15290: Use lambdas instead of QSignalMapper.
Jun 10 2019, 10:54 AM
volkov committed R436:87f3b0754638: vnc: Optimize and simplify repainting (authored by volkov).
vnc: Optimize and simplify repainting
Jun 10 2019, 10:44 AM
volkov closed D21096: vnc: Optimize and simplify repainting.
Jun 10 2019, 10:44 AM

May 25 2019

volkov added a comment to D21363: Fix build with poppler < 0.51.

My OS (AstraLinux) is based on Debian stretch and has poppler 0.48, Qt 5.11, KF5 5.46.
And probably it will be a headache to update poppler on it, cause it's rather low-level library (cups-filters depends on it).

May 25 2019, 11:35 AM · Okular

May 23 2019

volkov added reviewers for D21363: Fix build with poppler < 0.51: Okular, sander.
May 23 2019, 10:31 AM · Okular
volkov added a comment to D21320: Fix build with poppler < 0.51.

Sorry. I didn't add #include <config-okular-poppler.h> to formfields.h.
Correct fix: D21363.

May 23 2019, 10:31 AM · Okular
volkov requested review of D21363: Fix build with poppler < 0.51.
May 23 2019, 10:28 AM · Okular

May 22 2019

volkov committed R223:f29f6727a2a8: Merge remote-tracking branch 'origin/Applications/19.04' (authored by volkov).
Merge remote-tracking branch 'origin/Applications/19.04'
May 22 2019, 12:40 PM
volkov committed R223:32786e6b3d8d: Fix build with poppler < 0.51 (authored by volkov).
Fix build with poppler < 0.51
May 22 2019, 12:33 PM
volkov closed D21320: Fix build with poppler < 0.51.
May 22 2019, 12:33 PM · Okular

May 21 2019

volkov added a reviewer for D21320: Fix build with poppler < 0.51: Okular.
May 21 2019, 3:49 PM · Okular
volkov requested review of D21320: Fix build with poppler < 0.51.
May 21 2019, 3:49 PM · Okular
volkov added inline comments to D14655: Reimplement signature form field and related utility classes in poppler generator.
May 21 2019, 3:26 PM · Okular

May 16 2019

volkov committed R420:358221c1e4b9: Replace Q_DECL_OVERRIDE by override (authored by volkov).
Replace Q_DECL_OVERRIDE by override
May 16 2019, 2:28 PM
volkov closed D21240: Replace Q_DECL_OVERRIDE by override.
May 16 2019, 2:28 PM
volkov added a reviewer for D21240: Replace Q_DECL_OVERRIDE by override: mlaurent.
May 16 2019, 1:54 PM
volkov requested review of D21240: Replace Q_DECL_OVERRIDE by override.
May 16 2019, 1:53 PM
volkov committed R420:dcdbc8a70317: Add .arcconfig (authored by volkov).
Add .arcconfig
May 16 2019, 1:24 PM

May 15 2019

volkov added a comment to D21231: Add initial HiDPI support.

Complete HiDPI support requires D21230.

May 15 2019, 5:01 PM