- User Since
- May 20 2016, 1:05 PM (226 w, 4 d)
Jul 22 2020
Why not add support for QPlatformTheme::FontDialog in KdePlatformTheme::createPlatformDialogHelper()?
Jul 16 2020
Jul 13 2020
kf5 version is still not bumped.
Outdated and no chance it will be reviewed.
Jul 10 2020
fixed current screen resolution
Jul 6 2020
May 28 2020
May 20 2020
@yuyichao, your patch changes requested resolution,
If I choose screen size to be 800x600, it can be surprising to see the remote session starting with 1600x1200.
May 1 2020
Apr 27 2020
alberts really old machine seems to gain a lot, why?
Apr 8 2020
DialogIsQtWindow was introduced in https://codereview.qt-project.org/c/qt/qtbase/+/144710
Feb 27 2020
registered for 2.2
Jan 14 2020
imageReader.setQuality(0); was added in https://phabricator.kde.org/R320:c249f8547f2d1913e0570d78a0240c5f8865c336 when I ported JpegCreator to QImageReader.
But as I mentioned there, it doesn't really influence on the decoding speed, and it was only needed to preserve the old behavior as much as possible.
This change looks good to me, +1.
Dec 30 2019
build metadata from desktop files into the plugins
Dec 27 2019
Dec 24 2019
Dec 2 2019
Nov 19 2019
> cat qt_lib_widgets.pri | grep depends QT.widgets.depends = core gui
Fix for .pri: D25397
What about qmake?
I came across the following error:
g++ -Wl,-z,relro -o ... /usr/lib/x86_64-linux-gnu/libQt5Gui.so /usr/lib/x86_64-linux-gnu/libKF5Auth.so /usr/lib/x86_64-linux-gnu/libKF5CoreAddons.so /usr/lib/x86_64-linux-gnu/libQt5Core.so /usr/lib/x86_64-linux-gnu/libGL.so -lpthread /usr/bin/ld: ...: undefined reference to symbol '_ZN5KAuth11ActionReplyD1Ev' /usr/bin/ld: //usr/lib/x86_64-linux-gnu/libKF5AuthCore.so.5: error adding symbols: DSO missing from command line
Nov 11 2019
Hmmm, unfortunately arc created a needless merge commit :(
Oct 28 2019
Do you mean that it doesn't work on X11?
Why rebase? I can cherry-pick this change to master without conflicts.
Oct 1 2019
It will require adding the following methods:
Action::setFileDescriptors() Action::addFileDescriptor() Action::fileDescriptors() ActionReply::setFileDescriptors() ActionReply::addFileDescriptor() ActionReply::fileDescriptors()
with the condition that for progress data they can be used only with direct signal-slot connections,
because without UnixFileDescriptor we cannot guarantee the open state of file descriptors.
It doesn't seem better than exposing this class.
Sep 29 2019
Without UnixFileDescriptor you could try to write
int fd = ... Action action(...); action.addArgument(QStringLiteral("fd"), fd);
but then KAuth won't be able to detect that it'a file descriptor and will pass it to a helper as int.
Yes, UnixFileDescriptor allows to use existing methods Action::setArguments() and ActionReply::setData().
Sep 28 2019
Sep 27 2019
moved dbus stuff to DBusHelperProxy
fix breaking API and ABI of KAuth::ActionReply
Sep 26 2019
DBus is an internal dependency for KAuth. With the wrapper users don't have to link with QtDBus.
Passing file descriptors with KAuth: D24245
D24245 - support for passing Unix file descriptors in KAuth.
Sep 24 2019
Wouldn't it be better to avoid creation of a temporary file by opening an original file for writing in the helper and passing the file descriptor back to the main process?
Sep 16 2019
Sep 10 2019
Jul 30 2019
Jul 29 2019
Jul 26 2019
Jul 25 2019
Jul 16 2019
This is for non-sandboxed applications that want to use KDE file dialog.