- User Since
- May 20 2016, 1:05 PM (152 w, 6 d)
Ideally, QWidget::mouseDoubleClickEvent() could be used instead of double tap gesture...
removed needless image scaling
Wed, Apr 24
Tue, Apr 16
Beams look ugly when their width is >= 4 pixels.
The idea is to draw them with the same width regardless of DPI.
Another option is to not set Qt::FlatCap for thick pens, but I prefer this one.
Mon, Apr 15
Fri, Apr 12
use QPen::setWidthF() instead of QPen::setWidth()
reduced beam width
Thu, Apr 11
Hi, thanks for the review.
I know about the issues, I've uploaded the patch to avoid losing it :)
Wed, Apr 10
Mon, Apr 8
Well, actually, it was caught by @hetzenecker: https://phabricator.kde.org/D7581?id=22415#change-vIXPDUvyb3sZ
You are welcome!
I started to implement highdpi support from scratch, but then I found this change and it was a huge help!
re-target to master
Sat, Apr 6
Fri, Apr 5
Another approach: D20267
Thu, Apr 4
add a comment about turning off opacity effect
Wed, Apr 3
D9078 should fix thumbnails.
turn off opacity effect for highdpi with Qt < 5.12.4
Tue, Apr 2
Currently there is a bug in Qt which makes QGraphicsOpacityEffect not working: https://codereview.qt-project.org/#/c/257946/
rebase + refactoring
Mon, Apr 1
He also mentioned that those are minor issues that coulbe be fixed later.
This change is rather big and complicated, so it would be better to leave it with fixing one main issue on HiDPI displays.
@hetzenecker wrote: "Extracted QRect scaling to helper methods (there seems to be rounding errors now, those still have to be fixed)",
so I guess this is the only thing that needs to be checked for this patch.
Yes, I can do it. But what issues exactly?
I rebased and tested the patch on higdpi screen, it works.
Mar 26 2019
Fix for tiny cards: D20061
Mar 21 2019
Mar 20 2019
This is strange. I can't reproduce it.
Could you provide more information?
- Wayland or X11
- version of Qt
- env | grep QT
Mar 4 2019
Mar 3 2019
+1 to adding gesture recognizers to KWidgetsAddons
Feb 18 2019
Feb 13 2019
Feb 12 2019
modify existing desktop file instead of installing a new one
I guess that there is a short period of time when UDisks daemon is in inconsistent state, i.e. org.freedesktop.UDisks2.Filesystem interface is removed for CD-ROM device, but the device's properties still have Optical=true.
Adding "updateBackend(udi);" before "emit deviceAdded(udi);" gives Udisks time to become consistent.
Feb 11 2019
Wouldn't it be better to add mime types to org.kde.gwenview.desktop during the build?
https://lxr.kde.org/ doesn't respond, so I can't find an example for now.
Gwenview supports these formats only when it is built with KDcraw.
I used the approach from okular: when okular is built with support for a set of formats, then a separate desktop file is installed for them.
And the added gwenviewApplication_raw.desktop contains translations because it is just a modified copy of org.kde.gwenview.desktop.
Feb 9 2019
Feb 8 2019
Jan 22 2019
Jan 21 2019
extend the comment
fix commit description
Jan 19 2019
re-target to Plasma/5.12
Jan 18 2019
Jan 17 2019
Jan 16 2019
It makes sense to sync with Calligra.
Jan 15 2019
Looks like the bug is caused by removing the line "updateBackend(udi);"
This change causes a bug: when you eject a mounted CD from the applet, then CD-ROM tray closes immediately after ejecting.