volkov (Alexander Volkov)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
May 20 2016, 1:05 PM (133 w, 4 d)
Availability
Available

Recent Activity

Yesterday

volkov added a reviewer for D17481: Use lambdas instead of QSignalMapper: Okular.
Mon, Dec 10, 3:28 PM · Okular
volkov requested review of D17481: Use lambdas instead of QSignalMapper.
Mon, Dec 10, 3:26 PM · Okular

Tue, Dec 4

volkov added a comment to D16269: Show correct current download and upload speed.

The problem with this change is that speed is shown in bytes, not in bytes/s.

Tue, Dec 4, 10:06 AM · Plasma

Mon, Dec 3

volkov added a comment to D16269: Show correct current download and upload speed.

I mentioned in D14835 that the total number of received/transmitted bytes is more useful than the current speed.
One can see the current speed on the graph.

Mon, Dec 3, 4:24 PM · Plasma

Sun, Dec 2

volkov committed R119:c419eaa8d805: Use QFlags::QFlags() ctor instead of nullptr. (authored by volkov).
Use QFlags::QFlags() ctor instead of nullptr.
Sun, Dec 2, 11:40 AM

Tue, Nov 20

volkov added a comment to D16109: Get rid of QMetaObject::invokeMethod() with 'const char *member' arg.

ping

Tue, Nov 20, 10:02 AM · Gwenview

Mon, Nov 19

volkov committed R127:dfe65276b274: Use lambdas instead of std::bind() (authored by volkov).
Use lambdas instead of std::bind()
Mon, Nov 19, 11:52 AM
volkov added a reviewer for D15288: Use lambda instead of QSignalMapper: aacid.
Mon, Nov 19, 11:51 AM
volkov closed D16250: Use lambdas instead of std::bind().
Mon, Nov 19, 11:47 AM · Frameworks
volkov committed R104:962ca65570f9: Prefer to set current mode in resolution combobox (authored by volkov).
Prefer to set current mode in resolution combobox
Mon, Nov 19, 11:02 AM
volkov added a comment to D16250: Use lambdas instead of std::bind().

https://clang.llvm.org/extra/clang-tidy/checks/modernize-avoid-bind.html

std::bind can be hard to read and can result in larger object files and binaries due to type information that will not be produced by equivalent lambdas.

Mon, Nov 19, 10:53 AM · Frameworks
volkov closed D16400: Prefer to set current mode in resolution combobox.
Mon, Nov 19, 10:40 AM · Plasma

Nov 2 2018

volkov added a reviewer for D16612: Connect slots explicitly instead of using auto-connections: Frameworks.
Nov 2 2018, 4:07 PM · Frameworks
volkov requested review of D16612: Connect slots explicitly instead of using auto-connections.
Nov 2 2018, 4:06 PM · Frameworks

Nov 1 2018

volkov added a comment to D16543: qtests: Connect slots explicitly instead of using auto-connections.

Maybe bump up required Qt version?
Qt 5.9 is the current LTS release and the next LTS release Qt 5.12 is coming soon.

Nov 1 2018, 2:03 PM
volkov added inline comments to D16543: qtests: Connect slots explicitly instead of using auto-connections.
Nov 1 2018, 11:42 AM
volkov committed R478:f4013f88af6c: Fix warnings about nullptr for flags (authored by volkov).
Fix warnings about nullptr for flags
Nov 1 2018, 10:57 AM
volkov closed D16545: Fix warnings about nullptr for flags.
Nov 1 2018, 10:57 AM

Oct 31 2018

volkov committed R121:4f2c8ba512f3: Connect slots explicitly instead of using auto-connections (authored by volkov).
Connect slots explicitly instead of using auto-connections
Oct 31 2018, 3:36 PM
volkov closed D16547: Connect slots explicitly instead of using auto-connections.
Oct 31 2018, 3:35 PM · Plasma
volkov added a reviewer for D16547: Connect slots explicitly instead of using auto-connections: Plasma.
Oct 31 2018, 2:54 PM · Plasma
volkov updated the diff for D16547: Connect slots explicitly instead of using auto-connections.

rename slot

Oct 31 2018, 2:54 PM · Plasma
volkov requested review of D16547: Connect slots explicitly instead of using auto-connections.
Oct 31 2018, 2:51 PM · Plasma
volkov added a reviewer for D16545: Fix warnings about nullptr for flags: KDiagram.
Oct 31 2018, 2:40 PM
volkov requested review of D16545: Fix warnings about nullptr for flags.
Oct 31 2018, 2:39 PM
volkov added a reviewer for D16543: qtests: Connect slots explicitly instead of using auto-connections: KDiagram.
Oct 31 2018, 1:20 PM
volkov requested review of D16543: qtests: Connect slots explicitly instead of using auto-connections.
Oct 31 2018, 1:20 PM
volkov committed R478:20f99670f739: KChart: Connect slots explicitly instead of using auto-connections (authored by volkov).
KChart: Connect slots explicitly instead of using auto-connections
Oct 31 2018, 1:09 PM
volkov closed D16540: KChart: Connect slots explicitly instead of using auto-connections.
Oct 31 2018, 1:09 PM
volkov added a reviewer for D16540: KChart: Connect slots explicitly instead of using auto-connections: KDiagram.
Oct 31 2018, 11:56 AM
volkov requested review of D16540: KChart: Connect slots explicitly instead of using auto-connections.
Oct 31 2018, 11:55 AM
volkov committed R36:43ae86b022d8: libzipplugin: Simplify registration of progress callbacks (authored by volkov).
libzipplugin: Simplify registration of progress callbacks
Oct 31 2018, 10:36 AM
volkov closed D16276: libzipplugin: Simplify registration of progress callbacks.
Oct 31 2018, 10:36 AM · Ark

Oct 30 2018

volkov added a comment to D10895: Add sanitizer support in CMake.

Why not use include(ECMEnableSanitizers)?

Oct 30 2018, 12:22 PM · Kube

Oct 29 2018

volkov added a comment to D16276: libzipplugin: Simplify registration of progress callbacks.

The constant 0.001 is taken from libzip. It means that the callback will be called each time when compressing more than 1/1000 part of a file.
At least it doesn't change the old behavior.

Oct 29 2018, 5:10 PM · Ark

Oct 24 2018

volkov added a reviewer for D16400: Prefer to set current mode in resolution combobox: Plasma.
Oct 24 2018, 2:11 PM · Plasma
volkov requested review of D16400: Prefer to set current mode in resolution combobox.
Oct 24 2018, 2:11 PM · Plasma

Oct 22 2018

volkov committed R345:6fc243172bae: Remove unused local variable (authored by volkov).
Remove unused local variable
Oct 22 2018, 7:10 PM
volkov committed R345:a3f28b64216d: Use the multi-arg overload of QString::arg() (authored by volkov).
Use the multi-arg overload of QString::arg()
Oct 22 2018, 7:10 PM
volkov committed R345:e0bd36bd7f97: Use QHash instead of QMap for a pointer key (authored by volkov).
Use QHash instead of QMap for a pointer key
Oct 22 2018, 7:10 PM
volkov committed R345:ff6fdf86211d: Drop register keyword (authored by volkov).
Drop register keyword
Oct 22 2018, 7:10 PM
volkov committed R345:154d399fa07b: Fix printing of number in debug message (authored by volkov).
Fix printing of number in debug message
Oct 22 2018, 7:10 PM
volkov added reviewers for D16251: qca-gcrypt: Add support for HKDF: iromanov, Frameworks.
Oct 22 2018, 12:54 PM

Oct 17 2018

volkov added a reviewer for D16276: libzipplugin: Simplify registration of progress callbacks: Ark.
Oct 17 2018, 3:34 PM · Ark
volkov requested review of D16276: libzipplugin: Simplify registration of progress callbacks.
Oct 17 2018, 3:33 PM · Ark
volkov committed R486:32343842d359: Fix build with botan < 2 and openssl < 1.1 (authored by volkov).
Fix build with botan < 2 and openssl < 1.1
Oct 17 2018, 11:55 AM
volkov closed D16248: Fix build with botan < 2 and openssl < 1.1.
Oct 17 2018, 11:55 AM
volkov added inline comments to D16248: Fix build with botan < 2 and openssl < 1.1.
Oct 17 2018, 10:36 AM

Oct 16 2018

volkov added a reviewer for D16251: qca-gcrypt: Add support for HKDF: dfaure.
Oct 16 2018, 3:31 PM
volkov requested review of D16251: qca-gcrypt: Add support for HKDF.
Oct 16 2018, 3:29 PM
volkov added a comment to D16250: Use lambdas instead of std::bind().

Lambdas are more readable.

Oct 16 2018, 3:03 PM · Frameworks
volkov added a reviewer for D16250: Use lambdas instead of std::bind(): KWin.
Oct 16 2018, 2:13 PM · Frameworks
volkov requested review of D16250: Use lambdas instead of std::bind().
Oct 16 2018, 2:11 PM · Frameworks
volkov added reviewers for D16248: Fix build with botan < 2 and openssl < 1.1: dfaure, bcooksley.
Oct 16 2018, 11:03 AM
volkov added a comment to D15510: Introduce HKDF.

D16248

Oct 16 2018, 11:02 AM
volkov requested review of D16248: Fix build with botan < 2 and openssl < 1.1.
Oct 16 2018, 11:01 AM

Oct 15 2018

volkov added a reviewer for D16226: Reformat library code using kde-dev-scripts/astyle-kdelibs: Frameworks.
Oct 15 2018, 2:05 PM
volkov requested review of D16226: Reformat library code using kde-dev-scripts/astyle-kdelibs.
Oct 15 2018, 2:04 PM
volkov committed R486:7ba030cdbf13: Reformat code using kde-dev-scripts/astyle-kdelibs (authored by volkov).
Reformat code using kde-dev-scripts/astyle-kdelibs
Oct 15 2018, 12:08 PM
volkov committed R486:f57d661416ec: Introduce HKDF (authored by volkov).
Introduce HKDF
Oct 15 2018, 11:31 AM
volkov closed D15510: Introduce HKDF.
Oct 15 2018, 11:31 AM

Oct 13 2018

volkov committed R345:ff7f9e254694: Get rid of dependency on KInit (authored by volkov).
Get rid of dependency on KInit
Oct 13 2018, 9:09 AM
volkov closed D16161: Get rid of dependency on KInit.
Oct 13 2018, 9:09 AM

Oct 12 2018

volkov added a reviewer for D16161: Get rid of dependency on KInit: marten.
Oct 12 2018, 4:47 PM
volkov requested review of D16161: Get rid of dependency on KInit.
Oct 12 2018, 4:45 PM
volkov committed R260:2ad1dd48dc26: Use PMFs instead of C-strings to store and emit signals (authored by volkov).
Use PMFs instead of C-strings to store and emit signals
Oct 12 2018, 3:00 PM
volkov committed R260:219b343e4663: Emit signals from internal implementaions directly (authored by volkov).
Emit signals from internal implementaions directly
Oct 12 2018, 3:00 PM
volkov updated the summary of D16109: Get rid of QMetaObject::invokeMethod() with 'const char *member' arg.
Oct 12 2018, 2:56 PM · Gwenview
volkov updated the diff for D16109: Get rid of QMetaObject::invokeMethod() with 'const char *member' arg.

simplify, leave only invokeMethod() -> QTimer::singleShot() change

Oct 12 2018, 2:55 PM · Gwenview

Oct 11 2018

volkov added a comment to D16109: Get rid of QMetaObject::invokeMethod() with 'const char *member' arg.

Yes, but gwenview requires at least 5.9.
And code is longer with QMetaObject::invokeMethod, compare:
QTimer::singleShot(0, this, &FileOpsContextManagerItem::updateActions);
and
QMetaObject::invokeMethod(this, &FileOpsContextManagerItem::updateActions, Qt::QueuedConnection);

Oct 11 2018, 10:44 AM · Gwenview

Oct 10 2018

volkov added a reviewer for D16109: Get rid of QMetaObject::invokeMethod() with 'const char *member' arg: Gwenview.
Oct 10 2018, 3:59 PM · Gwenview
volkov requested review of D16109: Get rid of QMetaObject::invokeMethod() with 'const char *member' arg.
Oct 10 2018, 3:58 PM · Gwenview

Oct 8 2018

volkov added a comment to D15510: Introduce HKDF.

BTW, should I create a review request to reformat code with astyle-kdelibs?

Oct 8 2018, 11:41 AM
volkov updated the diff for D15510: Introduce HKDF.

more reinterpret_casts

Oct 8 2018, 11:27 AM
volkov updated the diff for D15510: Introduce HKDF.

fixed

Oct 8 2018, 11:18 AM
volkov added inline comments to D15510: Introduce HKDF.
Oct 8 2018, 11:15 AM

Oct 6 2018

volkov abandoned D15969: Add support for systemd's suspend-then-hibernate.
Oct 6 2018, 7:31 AM · Plasma

Oct 5 2018

volkov requested review of D15969: Add support for systemd's suspend-then-hibernate.
Oct 5 2018, 4:55 PM · Plasma
volkov committed R122:531dfa5e9b11: Avoid creation of needless temporary containers (authored by volkov).
Avoid creation of needless temporary containers
Oct 5 2018, 12:01 PM
volkov committed R122:168178b25f25: Add missing emit keyword (authored by volkov).
Add missing emit keyword
Oct 5 2018, 12:01 PM
volkov committed R110:66a0c467dd51: Avoid creation of needless temporary containers (authored by volkov).
Avoid creation of needless temporary containers
Oct 5 2018, 11:05 AM
volkov closed D15946: Avoid creation of needless temporary containers.
Oct 5 2018, 11:04 AM · Plasma
volkov added inline comments to D15946: Avoid creation of needless temporary containers.
Oct 5 2018, 11:03 AM · Plasma

Oct 4 2018

volkov committed R110:f5d9943ea65a: Remove unused QPointer includes (authored by volkov).
Remove unused QPointer includes
Oct 4 2018, 3:43 PM
volkov committed R110:dcb4a6cf8cc1: Don't leak Edid (authored by volkov).
Don't leak Edid
Oct 4 2018, 3:42 PM
volkov updated the diff for D15946: Avoid creation of needless temporary containers.

fixed

Oct 4 2018, 3:06 PM · Plasma
volkov added inline comments to D15946: Avoid creation of needless temporary containers.
Oct 4 2018, 2:55 PM · Plasma
volkov added a reviewer for D15946: Avoid creation of needless temporary containers: Plasma.
Oct 4 2018, 2:32 PM · Plasma
volkov requested review of D15946: Avoid creation of needless temporary containers.
Oct 4 2018, 2:30 PM · Plasma
volkov committed R110:56932fc204a4: Fix qstring-insensitive-allocation clazy warning (authored by volkov).
Fix qstring-insensitive-allocation clazy warning
Oct 4 2018, 2:29 PM
volkov committed R110:13c9d74d686f: Remove unused member variable (authored by volkov).
Remove unused member variable
Oct 4 2018, 1:52 PM

Oct 1 2018

volkov committed R40:e261f1ff0488: Use lambdas instead of QSignalMapper (authored by volkov).
Use lambdas instead of QSignalMapper
Oct 1 2018, 7:47 PM
volkov closed D15292: Use lambdas instead of QSignalMapper.
Oct 1 2018, 7:47 PM · Kate

Sep 28 2018

volkov committed R260:bf9ed0fe0760: Use refs with non-trivial types in range-for (authored by volkov).
Use refs with non-trivial types in range-for
Sep 28 2018, 11:49 AM
volkov committed R260:7f06194a25cd: Use constFirst() instead if first() for temporaries (authored by volkov).
Use constFirst() instead if first() for temporaries
Sep 28 2018, 11:49 AM
volkov committed R260:5af1f4cf7930: Use QColor ctor that takes ints as it's more performant (authored by volkov).
Use QColor ctor that takes ints as it's more performant
Sep 28 2018, 11:49 AM
volkov committed R260:61068da1bdca: Use QVariant::toUrl() instead of QVariant::value<QUrl>() (authored by volkov).
Use QVariant::toUrl() instead of QVariant::value<QUrl>()
Sep 28 2018, 11:49 AM
volkov committed R260:b136f5ec5e8f: Use qEnvironmentVariableIsEmpty() to save memory allocations (authored by volkov).
Use qEnvironmentVariableIsEmpty() to save memory allocations
Sep 28 2018, 11:49 AM
volkov committed R260:3c4db4461993: Use the multi-arg overload of QString::arg() to save memory allocations (authored by volkov).
Use the multi-arg overload of QString::arg() to save memory allocations
Sep 28 2018, 11:49 AM
volkov committed R260:5de94511ec81: Add missing emit keyword (authored by volkov).
Add missing emit keyword
Sep 28 2018, 10:34 AM