volkov (Alexander Volkov)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
May 20 2016, 1:05 PM (152 w, 6 d)
Availability
Available

Recent Activity

Yesterday

volkov added a comment to D13901: Touch support for Gwenview.

Ideally, QWidget::mouseDoubleClickEvent() could be used instead of double tap gesture...
https://codereview.qt-project.org/#/c/259787/

Thu, Apr 25, 5:05 PM · Gwenview
volkov added reviewers for D20821: Add HiDPI support: sars, davidedmundson, ngraham.
Thu, Apr 25, 3:13 PM
volkov requested review of D20821: Add HiDPI support.
Thu, Apr 25, 3:12 PM
volkov updated the diff for D20806: Add HiDPI support.

removed needless image scaling

Thu, Apr 25, 2:51 PM
volkov added inline comments to D20806: Add HiDPI support.
Thu, Apr 25, 2:50 PM
volkov added a reviewer for D20806: Add HiDPI support: sars.
Thu, Apr 25, 12:46 PM
volkov requested review of D20806: Add HiDPI support.
Thu, Apr 25, 12:44 PM

Wed, Apr 24

volkov committed R410:e41c3cce214e: Avoid tiny cards on high screen resolutions (authored by volkov).
Avoid tiny cards on high screen resolutions
Wed, Apr 24, 3:57 PM
volkov closed D20061: Avoid tiny cards on high screen resolutions.
Wed, Apr 24, 3:57 PM
volkov requested review of D20790: WIP: Add highdpi support for RDP and VNC.
Wed, Apr 24, 3:19 PM

Tue, Apr 16

volkov added a comment to D20445: signalplotter: Add highdpi support.

Beams look ugly when their width is >= 4 pixels.
The idea is to draw them with the same width regardless of DPI.
Another option is to not set Qt::FlatCap for thick pens, but I prefer this one.

Tue, Apr 16, 9:59 AM · Plasma

Mon, Apr 15

volkov added inline comments to D20445: signalplotter: Add highdpi support.
Mon, Apr 15, 3:43 PM · Plasma

Fri, Apr 12

volkov updated the diff for D20445: signalplotter: Add highdpi support.

use QPen::setWidthF() instead of QPen::setWidth()

Fri, Apr 12, 9:44 PM · Plasma
volkov updated the diff for D20445: signalplotter: Add highdpi support.

reduced beam width

Fri, Apr 12, 4:38 PM · Plasma

Thu, Apr 11

volkov added a comment to D20445: signalplotter: Add highdpi support.

Hi, thanks for the review.
I know about the issues, I've uploaded the patch to avoid losing it :)

Thu, Apr 11, 9:51 AM · Plasma

Wed, Apr 10

volkov requested review of D20445: signalplotter: Add highdpi support.
Wed, Apr 10, 4:31 PM · Plasma

Mon, Apr 8

volkov committed R260:b6e6ec6e92d0: Drop unnecessary PaintUtils::containingRect() (authored by volkov).
Drop unnecessary PaintUtils::containingRect()
Mon, Apr 8, 5:13 PM
volkov closed D20251: Drop unnecessary PaintUtils::containingRect().
Mon, Apr 8, 5:12 PM · Gwenview
volkov updated subscribers of D20251: Drop unnecessary PaintUtils::containingRect().

Well, actually, it was caught by @hetzenecker: https://phabricator.kde.org/D7581?id=22415#change-vIXPDUvyb3sZ

Mon, Apr 8, 5:12 PM · Gwenview
volkov added a comment to D7581: HiDPI Support for Gwenview.

You are welcome!
I started to implement highdpi support from scratch, but then I found this change and it was a huge help!

Mon, Apr 8, 12:54 PM · Gwenview
volkov added a comment to D19920: Add High DPI support.

ping

Mon, Apr 8, 11:24 AM
volkov updated the diff for D20251: Drop unnecessary PaintUtils::containingRect().

re-target to master

Mon, Apr 8, 11:22 AM · Gwenview

Sat, Apr 6

volkov updated the diff for D20267: Add HiDPI support for thumbnails.

small fixes

Sat, Apr 6, 9:34 AM · Gwenview

Fri, Apr 5

volkov updated the diff for D20267: Add HiDPI support for thumbnails.

fixed

Fri, Apr 5, 6:59 PM · Gwenview
volkov added a comment to D9078: HiDPI fixes for thumbnails in gwenview.

Another approach: D20267

Fri, Apr 5, 1:47 PM
volkov added a reviewer for D20267: Add HiDPI support for thumbnails: Gwenview.
Fri, Apr 5, 1:47 PM · Gwenview
volkov requested review of D20267: Add HiDPI support for thumbnails.
Fri, Apr 5, 1:46 PM · Gwenview

Thu, Apr 4

volkov added a reviewer for D20251: Drop unnecessary PaintUtils::containingRect(): Gwenview.
Thu, Apr 4, 3:13 PM · Gwenview
volkov requested review of D20251: Drop unnecessary PaintUtils::containingRect().
Thu, Apr 4, 3:12 PM · Gwenview
volkov committed R260:97e7de52276b: HiDPI Support for Gwenview (authored by volkov).
HiDPI Support for Gwenview
Thu, Apr 4, 3:06 PM
volkov closed D7581: HiDPI Support for Gwenview.
Thu, Apr 4, 2:41 PM · Gwenview
volkov updated the diff for D7581: HiDPI Support for Gwenview.

add a comment about turning off opacity effect

Thu, Apr 4, 12:11 PM · Gwenview

Wed, Apr 3

volkov added a comment to D7581: HiDPI Support for Gwenview.

D9078 should fix thumbnails.

Wed, Apr 3, 4:11 PM · Gwenview
volkov updated the diff for D7581: HiDPI Support for Gwenview.

turn off opacity effect for highdpi with Qt < 5.12.4

Wed, Apr 3, 3:26 PM · Gwenview
volkov added inline comments to D7581: HiDPI Support for Gwenview.
Wed, Apr 3, 11:16 AM · Gwenview

Tue, Apr 2

volkov added a comment to D7581: HiDPI Support for Gwenview.

Currently there is a bug in Qt which makes QGraphicsOpacityEffect not working: https://codereview.qt-project.org/#/c/257946/

Tue, Apr 2, 5:06 PM · Gwenview
volkov updated the diff for D7581: HiDPI Support for Gwenview.

rebase + refactoring

Tue, Apr 2, 5:02 PM · Gwenview
volkov commandeered D7581: HiDPI Support for Gwenview.
Tue, Apr 2, 4:57 PM · Gwenview

Mon, Apr 1

volkov added a comment to D7581: HiDPI Support for Gwenview.

He also mentioned that those are minor issues that coulbe be fixed later.
This change is rather big and complicated, so it would be better to leave it with fixing one main issue on HiDPI displays.
@hetzenecker wrote: "Extracted QRect scaling to helper methods (there seems to be rounding errors now, those still have to be fixed)",
so I guess this is the only thing that needs to be checked for this patch.

Mon, Apr 1, 7:45 PM · Gwenview
volkov added a comment to D7581: HiDPI Support for Gwenview.

Yes, I can do it. But what issues exactly?

Mon, Apr 1, 4:27 PM · Gwenview
volkov added a comment to D7581: HiDPI Support for Gwenview.

I rebased and tested the patch on higdpi screen, it works.

Mon, Apr 1, 2:38 PM · Gwenview
volkov added inline comments to D7581: HiDPI Support for Gwenview.
Mon, Apr 1, 1:34 PM · Gwenview

Mar 26 2019

volkov added a comment to D19920: Add High DPI support.

Fix for tiny cards: D20061

Mar 26 2019, 12:11 PM
volkov requested review of D20061: Avoid tiny cards on high screen resolutions.
Mar 26 2019, 12:09 PM

Mar 21 2019

volkov updated the diff for D19920: Add High DPI support.

done

Mar 21 2019, 10:32 AM

Mar 20 2019

volkov added a comment to D19920: Add High DPI support.

This is strange. I can't reproduce it.
Could you provide more information?

  • Wayland or X11
  • version of Qt
  • env | grep QT
Mar 20 2019, 11:00 PM
volkov requested review of D19920: Add High DPI support.
Mar 20 2019, 4:38 PM

Mar 4 2019

volkov committed R119:14d6402abc34: [kcm/componentchooser] Remove unused ktimerdialog.{h,cpp} (authored by volkov).
[kcm/componentchooser] Remove unused ktimerdialog.{h,cpp}
Mar 4 2019, 7:23 PM
volkov closed D19496: [kcm/componentchooser] Remove unused ktimerdialog.{h,cpp}.
Mar 4 2019, 7:23 PM · Plasma

Mar 3 2019

volkov added a comment to D13901: Touch support for Gwenview.

+1 to adding gesture recognizers to KWidgetsAddons

Mar 3 2019, 8:56 PM · Gwenview
volkov added a reviewer for D19496: [kcm/componentchooser] Remove unused ktimerdialog.{h,cpp}: Plasma.
Mar 3 2019, 7:38 PM · Plasma
volkov requested review of D19496: [kcm/componentchooser] Remove unused ktimerdialog.{h,cpp}.
Mar 3 2019, 7:36 PM · Plasma

Feb 18 2019

volkov committed R260:b99e6a5d6a46: Set the same image mime types in all desktop files (authored by volkov).
Set the same image mime types in all desktop files
Feb 18 2019, 8:22 PM
volkov closed D19122: Set the same image mime types in all desktop files.
Feb 18 2019, 8:22 PM · Gwenview
volkov added a comment to D18852: Add mime types for raw image formats to desktop file.

D19122

Feb 18 2019, 5:23 PM · Gwenview
volkov added a reviewer for D19122: Set the same image mime types in all desktop files: Gwenview.
Feb 18 2019, 5:23 PM · Gwenview
volkov requested review of D19122: Set the same image mime types in all desktop files.
Feb 18 2019, 5:23 PM · Gwenview
volkov committed R260:7afa340f9bf9: Add mime types for raw image formats to desktop file (authored by volkov).
Add mime types for raw image formats to desktop file
Feb 18 2019, 4:22 PM
volkov closed D18852: Add mime types for raw image formats to desktop file.
Feb 18 2019, 2:58 PM · Gwenview
volkov added a comment to D18852: Add mime types for raw image formats to desktop file.

ping

Feb 18 2019, 9:39 AM · Gwenview

Feb 13 2019

volkov updated the summary of D18852: Add mime types for raw image formats to desktop file.
Feb 13 2019, 2:46 PM · Gwenview

Feb 12 2019

volkov updated the diff for D18852: Add mime types for raw image formats to desktop file.

modify existing desktop file instead of installing a new one

Feb 12 2019, 5:30 PM · Gwenview
volkov added a comment to D14661: Force reevaluation of Predicates if interfaces are removed.

I guess that there is a short period of time when UDisks daemon is in inconsistent state, i.e. org.freedesktop.UDisks2.Filesystem interface is removed for CD-ROM device, but the device's properties still have Optical=true.
Adding "updateBackend(udi);" before "emit deviceAdded(udi);" gives Udisks time to become consistent.

Feb 12 2019, 5:01 PM · Frameworks

Feb 11 2019

volkov added a comment to D18852: Add mime types for raw image formats to desktop file.

Wouldn't it be better to add mime types to org.kde.gwenview.desktop during the build?
https://lxr.kde.org/ doesn't respond, so I can't find an example for now.

Feb 11 2019, 3:09 PM · Gwenview
volkov added a comment to D18852: Add mime types for raw image formats to desktop file.

Gwenview supports these formats only when it is built with KDcraw.
I used the approach from okular: when okular is built with support for a set of formats, then a separate desktop file is installed for them.
And the added gwenviewApplication_raw.desktop contains translations because it is just a modified copy of org.kde.gwenview.desktop.

Feb 11 2019, 10:52 AM · Gwenview
volkov committed R36:233de9e97cb1: Preset file name of archive in CreateDialog (authored by volkov).
Preset file name of archive in CreateDialog
Feb 11 2019, 10:44 AM
volkov closed D18152: Preset file name of archive in CreateDialog.
Feb 11 2019, 10:44 AM · Ark

Feb 9 2019

volkov added a reviewer for D18852: Add mime types for raw image formats to desktop file: Gwenview.
Feb 9 2019, 1:55 PM · Gwenview

Feb 8 2019

volkov requested review of D18852: Add mime types for raw image formats to desktop file.
Feb 8 2019, 2:55 PM · Gwenview
volkov added a comment to D18152: Preset file name of archive in CreateDialog.

ping

Feb 8 2019, 12:47 PM · Ark

Jan 22 2019

volkov committed R108:5d63b9c05bbe: Fix flickering with Qt 5.12 (authored by volkov).
Fix flickering with Qt 5.12
Jan 22 2019, 7:38 PM
volkov closed D18366: Fix flickering with Qt 5.12.
Jan 22 2019, 7:37 PM · KWin
volkov committed R119:768fa11c277b: Fonts KCM: Port from kde_file.h to QFileInfo (authored by volkov).
Fonts KCM: Port from kde_file.h to QFileInfo
Jan 22 2019, 11:53 AM
volkov closed D18454: Fonts KCM: Port from kde_file.h to QFileInfo.
Jan 22 2019, 11:53 AM · Plasma
volkov added a reviewer for D18454: Fonts KCM: Port from kde_file.h to QFileInfo: Plasma.
Jan 22 2019, 11:30 AM · Plasma
volkov requested review of D18454: Fonts KCM: Port from kde_file.h to QFileInfo.
Jan 22 2019, 11:30 AM · Plasma
volkov committed R119:ed840a5379c6: Remove dependency on KDELibs4Support for some KCM modules (authored by volkov).
Remove dependency on KDELibs4Support for some KCM modules
Jan 22 2019, 10:36 AM
volkov closed D18449: Remove dependency on KDELibs4Support for some KCM modules.
Jan 22 2019, 10:36 AM · Plasma
volkov requested review of D18449: Remove dependency on KDELibs4Support for some KCM modules.
Jan 22 2019, 9:25 AM · Plasma

Jan 21 2019

volkov updated the diff for D18366: Fix flickering with Qt 5.12.

extend the comment

Jan 21 2019, 4:58 PM · KWin
volkov updated the summary of D18366: Fix flickering with Qt 5.12.
Jan 21 2019, 11:43 AM · KWin
volkov updated the summary of D18366: Fix flickering with Qt 5.12.
Jan 21 2019, 11:40 AM · KWin
volkov updated the diff for D18366: Fix flickering with Qt 5.12.

fix commit description

Jan 21 2019, 11:38 AM · KWin

Jan 19 2019

volkov updated the diff for D18366: Fix flickering with Qt 5.12.

re-target to Plasma/5.12

Jan 19 2019, 10:33 AM · KWin

Jan 18 2019

volkov added a comment to D18366: Fix flickering with Qt 5.12.

See also https://bugreports.qt.io/browse/QTBUG-73122

Jan 18 2019, 3:18 PM · KWin
volkov added a reviewer for D18366: Fix flickering with Qt 5.12: KWin.
Jan 18 2019, 3:17 PM · KWin
volkov requested review of D18366: Fix flickering with Qt 5.12.
Jan 18 2019, 3:16 PM · KWin

Jan 17 2019

volkov committed R119:deebad73af22: [Mouse KCM] Port away from KDELibs4Support (authored by volkov).
[Mouse KCM] Port away from KDELibs4Support
Jan 17 2019, 11:35 AM
volkov closed D18300: [Mouse KCM] Port away from KDELibs4Support.
Jan 17 2019, 11:35 AM · Plasma

Jan 16 2019

volkov requested review of D18300: [Mouse KCM] Port away from KDELibs4Support.
Jan 16 2019, 5:11 PM · Plasma
volkov committed R223:0d958be2900b: Fix MimeType in org.kde.mobile.okular_comicbook.desktop (authored by volkov).
Fix MimeType in org.kde.mobile.okular_comicbook.desktop
Jan 16 2019, 2:51 PM
volkov committed R478:8fbc33b58070: qtests: Connect slots explicitly instead of using auto-connections (authored by volkov).
qtests: Connect slots explicitly instead of using auto-connections
Jan 16 2019, 11:16 AM
volkov closed D16543: qtests: Connect slots explicitly instead of using auto-connections.
Jan 16 2019, 11:16 AM
volkov updated the diff for D16543: qtests: Connect slots explicitly instead of using auto-connections.

rebased

Jan 16 2019, 11:14 AM
volkov abandoned D18251: Bump required Qt version to 5.9.

It makes sense to sync with Calligra.

Jan 16 2019, 11:01 AM

Jan 15 2019

volkov added a comment to D14661: Force reevaluation of Predicates if interfaces are removed.

Looks like the bug is caused by removing the line "updateBackend(udi);"

Jan 15 2019, 2:49 PM · Frameworks
volkov added a comment to D14661: Force reevaluation of Predicates if interfaces are removed.

This change causes a bug: when you eject a mounted CD from the applet, then CD-ROM tray closes immediately after ejecting.

Jan 15 2019, 2:14 PM · Frameworks

Jan 14 2019

volkov added a reviewer for D18251: Bump required Qt version to 5.9: KDiagram.
Jan 14 2019, 8:33 PM
volkov requested review of D18251: Bump required Qt version to 5.9.
Jan 14 2019, 8:33 PM
volkov added inline comments to D18152: Preset file name of archive in CreateDialog.
Jan 14 2019, 11:06 AM · Ark