volkov (Alexander Volkov)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
May 20 2016, 1:05 PM (226 w, 4 d)
Availability
Available

Recent Activity

Jul 22 2020

volkov added a comment to D28774: [KFontRequester] Port from QFontDialog to KFontChooserDialog.

Why not add support for QPlatformTheme::FontDialog in KdePlatformTheme::createPlatformDialogHelper()?

Jul 22 2020, 3:54 PM · Frameworks

Jul 16 2020

volkov abandoned D22737: xcb: Fix setStrut() for High-DPI scaling.

Moved to https://invent.kde.org/frameworks/kwindowsystem/-/merge_requests/7

Jul 16 2020, 2:42 PM · Frameworks

Jul 13 2020

volkov abandoned D21887: Fix -Wimplicit-fallthrough warnings.

Moved to https://invent.kde.org/multimedia/k3b/-/merge_requests/1

Jul 13 2020, 5:31 PM
volkov added a comment to D23106: Allow the user to select the JPEG save/compression quality.

kf5 version is still not bumped.

Jul 13 2020, 5:22 PM · Gwenview
volkov abandoned D16612: Connect slots explicitly instead of using auto-connections.

Moved to https://invent.kde.org/frameworks/kio/-/merge_requests/76

Jul 13 2020, 2:57 PM · Frameworks
volkov abandoned D16226: Reformat library code using kde-dev-scripts/astyle-kdelibs.

Outdated and no chance it will be reviewed.

Jul 13 2020, 2:37 PM
volkov abandoned D16251: qca-gcrypt: Add support for HKDF.

Moved to https://invent.kde.org/libraries/qca/-/merge_requests/35

Jul 13 2020, 2:34 PM
volkov abandoned D16109: Get rid of QMetaObject::invokeMethod() with 'const char *member' arg.

Moved to https://invent.kde.org/graphics/gwenview/-/merge_requests/10

Jul 13 2020, 2:10 PM · Gwenview
volkov abandoned D28683: Get rid of workaround that prevents file dialog from being blocked.

Moved to https://invent.kde.org/plasma/plasma-integration/-/merge_requests/1

Jul 13 2020, 12:03 PM · Plasma
volkov closed D20790: Add highdpi support for RDP and VNC.
Jul 13 2020, 11:23 AM

Jul 10 2020

volkov added inline comments to D20790: Add highdpi support for RDP and VNC.
Jul 10 2020, 3:06 PM
volkov updated the diff for D20790: Add highdpi support for RDP and VNC.

fixed current screen resolution

Jul 10 2020, 2:52 PM

Jul 6 2020

volkov added a reviewer for D20790: Add highdpi support for RDP and VNC: ngraham.
Jul 6 2020, 3:06 PM

May 28 2020

volkov abandoned D11573: Use QPlatformWindow::startSystemMove() with Qt 5.11.

Moved to https://invent.kde.org/plasma/breeze/-/merge_requests/7

May 28 2020, 1:28 PM · Plasma

May 20 2020

volkov added a comment to D20790: Add highdpi support for RDP and VNC.

@yuyichao, your patch changes requested resolution,
If I choose screen size to be 800x600, it can be surprising to see the remote session starting with 1600x1200.

May 20 2020, 9:39 AM

May 1 2020

volkov committed R983:3533fe4d8645: Add HiDPI support (authored by volkov).
Add HiDPI support
May 1 2020, 3:45 PM
volkov committed R551:0e1c02b00ba5: Add missing override (authored by volkov).
Add missing override
May 1 2020, 11:23 AM

Apr 27 2020

volkov added a comment to T12140: Killing KInit With Fire.

alberts really old machine seems to gain a lot, why?

Apr 27 2020, 5:28 PM · Frameworks, KF6

Apr 8 2020

volkov added a comment to D28683: Get rid of workaround that prevents file dialog from being blocked.

DialogIsQtWindow was introduced in https://codereview.qt-project.org/c/qt/qtbase/+/144710

Apr 8 2020, 5:14 PM · Plasma
volkov added a reviewer for D28683: Get rid of workaround that prevents file dialog from being blocked: Plasma.
Apr 8 2020, 5:12 PM · Plasma
volkov requested review of D28683: Get rid of workaround that prevents file dialog from being blocked.
Apr 8 2020, 5:11 PM · Plasma

Feb 27 2020

volkov updated the diff for D14562: Introduce Theme.smallestFont.

registered for 2.2

Feb 27 2020, 3:35 PM · Kirigami

Jan 14 2020

volkov added a comment to D26648: Improved quality of JPEG thumbnails.

imageReader.setQuality(0); was added in https://phabricator.kde.org/R320:c249f8547f2d1913e0570d78a0240c5f8865c336 when I ported JpegCreator to QImageReader.
But as I mentioned there, it doesn't really influence on the decoding speed, and it was only needed to preserve the old behavior as much as possible.
This change looks good to me, +1.

Jan 14 2020, 10:37 AM · Frameworks, Dolphin

Dec 30 2019

volkov added a dependency for D26244: Install all kcm plugins into kcms subdir: D26294: Allow to load widget based KCMs from kcms subdir.
Dec 30 2019, 4:25 PM · Plasma
volkov added a dependent revision for D26294: Allow to load widget based KCMs from kcms subdir: D26244: Install all kcm plugins into kcms subdir.
Dec 30 2019, 4:25 PM · Frameworks
volkov updated the diff for D26294: Allow to load widget based KCMs from kcms subdir.

change branch

Dec 30 2019, 4:24 PM · Frameworks
volkov added a reviewer for D26294: Allow to load widget based KCMs from kcms subdir: Frameworks.
Dec 30 2019, 4:23 PM · Frameworks
volkov requested review of D26294: Allow to load widget based KCMs from kcms subdir.
Dec 30 2019, 4:22 PM · Frameworks
volkov updated the diff for D26244: Install all kcm plugins into kcms subdir.

build metadata from desktop files into the plugins

Dec 30 2019, 4:13 PM · Plasma

Dec 27 2019

volkov added a reviewer for D26244: Install all kcm plugins into kcms subdir: Plasma.
Dec 27 2019, 2:14 PM · Plasma
volkov requested review of D26244: Install all kcm plugins into kcms subdir.
Dec 27 2019, 2:14 PM · Plasma

Dec 24 2019

volkov committed R467:99be7550302a: Always adjust IntMapComboBox to contents (authored by volkov).
Always adjust IntMapComboBox to contents
Dec 24 2019, 12:12 PM
volkov closed D26209: Always adjust IntMapComboBox to contents.
Dec 24 2019, 11:42 AM
volkov added a comment to D26209: Always adjust IntMapComboBox to contents.

before:

Dec 24 2019, 11:41 AM
volkov added a reviewer for D26209: Always adjust IntMapComboBox to contents: aacid.
Dec 24 2019, 11:32 AM
volkov requested review of D26209: Always adjust IntMapComboBox to contents.
Dec 24 2019, 11:31 AM

Dec 2 2019

volkov added inline comments to D25640: RDP: Warn if trying to share a non existing folder.
Dec 2 2019, 11:40 AM
volkov added inline comments to D25640: RDP: Warn if trying to share a non existing folder.
Dec 2 2019, 11:21 AM

Nov 19 2019

volkov added a comment to D25397: Install .pri file for KAuthCore.

Qt Core

> cat qt_lib_widgets.pri | grep depends
QT.widgets.depends = core gui
Nov 19 2019, 2:05 PM · Frameworks
volkov added a reviewer for D25397: Install .pri file for KAuthCore: aacid.
Nov 19 2019, 11:33 AM · Frameworks
volkov added a comment to D18610: Introduce KF5AuthCore.

Fix for .pri: D25397

Nov 19 2019, 11:33 AM · Frameworks
volkov requested review of D25397: Install .pri file for KAuthCore.
Nov 19 2019, 11:32 AM · Frameworks
volkov added a comment to D18610: Introduce KF5AuthCore.

What about qmake?
I came across the following error:

g++ -Wl,-z,relro -o ... /usr/lib/x86_64-linux-gnu/libQt5Gui.so /usr/lib/x86_64-linux-gnu/libKF5Auth.so /usr/lib/x86_64-linux-gnu/libKF5CoreAddons.so /usr/lib/x86_64-linux-gnu/libQt5Core.so /usr/lib/x86_64-linux-gnu/libGL.so -lpthread   
/usr/bin/ld: ...: undefined reference to symbol '_ZN5KAuth11ActionReplyD1Ev'
/usr/bin/ld: //usr/lib/x86_64-linux-gnu/libKF5AuthCore.so.5: error adding symbols: DSO missing from command line
Nov 19 2019, 10:16 AM · Frameworks

Nov 11 2019

volkov added a comment to D19920: Add High DPI support.

Hmmm, unfortunately arc created a needless merge commit :(

Nov 11 2019, 1:56 PM
volkov committed R410:d8633b796d9c: Add High DPI support (authored by volkov).
Add High DPI support
Nov 11 2019, 1:43 PM
volkov committed R410:82972f8082be: Add High DPI support (authored by volkov).
Add High DPI support
Nov 11 2019, 1:43 PM
volkov closed D19920: Add High DPI support.
Nov 11 2019, 1:42 PM

Oct 28 2019

volkov added a comment to D19920: Add High DPI support.

Do you mean that it doesn't work on X11?

Oct 28 2019, 10:35 AM
volkov added a comment to D19920: Add High DPI support.

Why rebase? I can cherry-pick this change to master without conflicts.

Oct 28 2019, 10:33 AM

Oct 1 2019

volkov added a comment to D24245: Add support for passing Unix file descriptors.

It will require adding the following methods:

Action::setFileDescriptors()
Action::addFileDescriptor()
Action::fileDescriptors()
ActionReply::setFileDescriptors()
ActionReply::addFileDescriptor()
ActionReply::fileDescriptors()

and

ExecuteJob::fileDescriptors()
ExecuteJob::newFileDescriptors()

with the condition that for progress data they can be used only with direct signal-slot connections,
because without UnixFileDescriptor we cannot guarantee the open state of file descriptors.
It doesn't seem better than exposing this class.

Oct 1 2019, 7:35 AM · Frameworks

Sep 29 2019

volkov added a comment to D24245: Add support for passing Unix file descriptors.

Without UnixFileDescriptor you could try to write

int fd = ...
Action action(...);
action.addArgument(QStringLiteral("fd"), fd);

but then KAuth won't be able to detect that it'a file descriptor and will pass it to a helper as int.

Sep 29 2019, 12:22 PM · Frameworks
volkov added a comment to D24245: Add support for passing Unix file descriptors.

Yes, UnixFileDescriptor allows to use existing methods Action::setArguments() and ActionReply::setData().

Sep 29 2019, 11:49 AM · Frameworks

Sep 28 2019

volkov added inline comments to D24245: Add support for passing Unix file descriptors.
Sep 28 2019, 8:49 AM · Frameworks

Sep 27 2019

volkov updated the summary of D24245: Add support for passing Unix file descriptors.
Sep 27 2019, 8:17 PM · Frameworks
volkov updated the diff for D24245: Add support for passing Unix file descriptors.

moved dbus stuff to DBusHelperProxy

Sep 27 2019, 8:15 PM · Frameworks
volkov added inline comments to D24245: Add support for passing Unix file descriptors.
Sep 27 2019, 8:14 PM · Frameworks
volkov added a comment to D24245: Add support for passing Unix file descriptors.
Sep 27 2019, 8:13 PM · Frameworks
volkov added a dependency for D24259: WIP: Save file directly if possible when root privileges are required: D24245: Add support for passing Unix file descriptors.
Sep 27 2019, 1:19 PM · Frameworks, Kate
volkov added a dependent revision for D24245: Add support for passing Unix file descriptors: D24259: WIP: Save file directly if possible when root privileges are required.
Sep 27 2019, 1:19 PM · Frameworks
volkov requested review of D24259: WIP: Save file directly if possible when root privileges are required.
Sep 27 2019, 1:16 PM · Frameworks, Kate
volkov updated the diff for D24245: Add support for passing Unix file descriptors.

fix breaking API and ABI of KAuth::ActionReply

Sep 27 2019, 1:13 PM · Frameworks

Sep 26 2019

volkov added a comment to D24245: Add support for passing Unix file descriptors.

DBus is an internal dependency for KAuth. With the wrapper users don't have to link with QtDBus.

Sep 26 2019, 6:37 PM · Frameworks
volkov added a comment to D6709: Add support for sharing file descriptor between KIO slave and KAuth helper.

Passing file descriptors with KAuth: D24245

Sep 26 2019, 4:32 PM · Frameworks
volkov added a comment to D5394: KAuth integration in document saving - vol. 2.

D24245 - support for passing Unix file descriptors in KAuth.

Sep 26 2019, 4:26 PM · Kate, Frameworks, KTextEditor
volkov requested review of D24245: Add support for passing Unix file descriptors.
Sep 26 2019, 4:22 PM · Frameworks

Sep 24 2019

Restricted Application added a project to D5394: KAuth integration in document saving - vol. 2: Kate.

Wouldn't it be better to avoid creation of a temporary file by opening an original file for writing in the helper and passing the file descriptor back to the main process?

Sep 24 2019, 12:27 PM · Kate, Frameworks, KTextEditor

Sep 16 2019

volkov committed R120:e8e97f8c5fb9: Remove QT_VERSION checks (authored by volkov).
Remove QT_VERSION checks
Sep 16 2019, 12:17 PM

Sep 10 2019

volkov committed R345:6b59a9a86568: Get rid of dependency on KIconThemes (authored by volkov).
Get rid of dependency on KIconThemes
Sep 10 2019, 10:18 AM
volkov committed R345:6fdf3c6f52ba: Fix shrinking of group boxes' titles (authored by volkov).
Fix shrinking of group boxes' titles
Sep 10 2019, 10:17 AM
volkov closed D22816: Get rid of dependency on KIconThemes.
Sep 10 2019, 10:17 AM
volkov closed D22825: Fix shrinking of group boxes' titles.
Sep 10 2019, 10:13 AM

Jul 30 2019

volkov added a reviewer for D22825: Fix shrinking of group boxes' titles: marten.
Jul 30 2019, 11:20 AM
volkov requested review of D22825: Fix shrinking of group boxes' titles.
Jul 30 2019, 11:20 AM
volkov committed R302:71a16579073f: Restore "Check if group < LastGroup, as KIconEffect doesn't handle UserGroup… (authored by volkov).
Restore "Check if group < LastGroup, as KIconEffect doesn't handle UserGroup…
Jul 30 2019, 10:44 AM
volkov closed D22809: Restore "Check if group < LastGroup, as KIconEffect doesn't handle UserGroup anyway".
Jul 30 2019, 10:44 AM · Frameworks
volkov added a comment to D22815: Fix finding (KF5)Plasma.

Oh, thanks.

Jul 30 2019, 10:33 AM

Jul 29 2019

volkov added a reviewer for D22816: Get rid of dependency on KIconThemes: marten.
Jul 29 2019, 9:23 PM
volkov requested review of D22816: Get rid of dependency on KIconThemes.
Jul 29 2019, 9:21 PM
volkov committed R345:b23f46652022: Add support for High DPI (authored by volkov).
Add support for High DPI
Jul 29 2019, 3:57 PM
volkov closed D22808: Add support for High DPI.
Jul 29 2019, 3:56 PM
volkov added a reviewer for D22809: Restore "Check if group < LastGroup, as KIconEffect doesn't handle UserGroup anyway": broulik.
Jul 29 2019, 3:50 PM · Frameworks
volkov requested review of D22809: Restore "Check if group < LastGroup, as KIconEffect doesn't handle UserGroup anyway".
Jul 29 2019, 3:50 PM · Frameworks
volkov added a reviewer for D22808: Add support for High DPI: marten.
Jul 29 2019, 3:25 PM
volkov requested review of D22808: Add support for High DPI.
Jul 29 2019, 3:25 PM
volkov added inline comments to D6313: Support Icon Scale from Icon naming specification 0.13.
Jul 29 2019, 3:12 PM · Frameworks, Plasma
volkov added inline comments to D6313: Support Icon Scale from Icon naming specification 0.13.
Jul 29 2019, 2:47 PM · Frameworks, Plasma
volkov committed R345:0613aa47e415: Make dependency on Plasma optional (authored by volkov).
Make dependency on Plasma optional
Jul 29 2019, 2:08 PM
volkov closed D22806: Make dependency on Plasma optional.
Jul 29 2019, 2:08 PM
volkov added a reviewer for D22806: Make dependency on Plasma optional: marten.
Jul 29 2019, 12:24 PM
volkov requested review of D22806: Make dependency on Plasma optional.
Jul 29 2019, 12:24 PM

Jul 26 2019

volkov added a reviewer for D22766: Fix positioning of output identifiers on screens with different dprs: Plasma.
Jul 26 2019, 4:18 PM · Plasma
volkov requested review of D22766: Fix positioning of output identifiers on screens with different dprs.
Jul 26 2019, 4:16 PM · Plasma

Jul 25 2019

volkov updated the diff for D22737: xcb: Fix setStrut() for High-DPI scaling.

fixed

Jul 25 2019, 1:05 PM · Frameworks
volkov added inline comments to D22737: xcb: Fix setStrut() for High-DPI scaling.
Jul 25 2019, 1:02 PM · Frameworks
volkov added a reviewer for D22737: xcb: Fix setStrut() for High-DPI scaling: Frameworks.
Jul 25 2019, 11:36 AM · Frameworks
volkov requested review of D22737: xcb: Fix setStrut() for High-DPI scaling.
Jul 25 2019, 11:35 AM · Frameworks

Jul 16 2019

volkov added a comment to D22482: WIP: Show file dialog in directory mode when only directory is requested.

This is for non-sandboxed applications that want to use KDE file dialog.

Jul 16 2019, 7:14 AM · Plasma

Jul 15 2019

volkov requested review of D22482: WIP: Show file dialog in directory mode when only directory is requested.
Jul 15 2019, 8:23 PM · Plasma

Jun 28 2019

volkov committed R467:9d0f1447f976: Merge remote-tracking branch 'origin/Applications/19.04' (authored by volkov).
Merge remote-tracking branch 'origin/Applications/19.04'
Jun 28 2019, 9:50 AM
volkov committed R467:7548d001a58a: Avoid leaking of file descriptors to child processes (authored by volkov).
Avoid leaking of file descriptors to child processes
Jun 28 2019, 9:50 AM