volkov (Alexander Volkov)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
May 20 2016, 1:05 PM (126 w, 2 d)
Availability
Available

Recent Activity

Wed, Oct 17

volkov added a reviewer for D16276: libzipplugin: Simplify registration of progress callbacks: Ark.
Wed, Oct 17, 3:34 PM · Ark
volkov requested review of D16276: libzipplugin: Simplify registration of progress callbacks.
Wed, Oct 17, 3:33 PM · Ark
volkov committed R486:32343842d359: Fix build with botan < 2 and openssl < 1.1 (authored by volkov).
Fix build with botan < 2 and openssl < 1.1
Wed, Oct 17, 11:55 AM
volkov closed D16248: Fix build with botan < 2 and openssl < 1.1.
Wed, Oct 17, 11:55 AM
volkov added inline comments to D16248: Fix build with botan < 2 and openssl < 1.1.
Wed, Oct 17, 10:36 AM

Tue, Oct 16

volkov added a reviewer for D16251: qca-gcrypt: Add support for HKDF: dfaure.
Tue, Oct 16, 3:31 PM
volkov requested review of D16251: qca-gcrypt: Add support for HKDF.
Tue, Oct 16, 3:29 PM
volkov added a comment to D16250: Use lambdas instead of std::bind().

Lambdas are more readable.

Tue, Oct 16, 3:03 PM · Frameworks
volkov added a reviewer for D16250: Use lambdas instead of std::bind(): KWin.
Tue, Oct 16, 2:13 PM · Frameworks
volkov requested review of D16250: Use lambdas instead of std::bind().
Tue, Oct 16, 2:11 PM · Frameworks
volkov added reviewers for D16248: Fix build with botan < 2 and openssl < 1.1: dfaure, bcooksley.
Tue, Oct 16, 11:03 AM
volkov added a comment to D15510: Introduce HKDF.

D16248

Tue, Oct 16, 11:02 AM
volkov requested review of D16248: Fix build with botan < 2 and openssl < 1.1.
Tue, Oct 16, 11:01 AM

Mon, Oct 15

volkov added a reviewer for D16226: Reformat library code using kde-dev-scripts/astyle-kdelibs: Frameworks.
Mon, Oct 15, 2:05 PM
volkov requested review of D16226: Reformat library code using kde-dev-scripts/astyle-kdelibs.
Mon, Oct 15, 2:04 PM
volkov committed R486:7ba030cdbf13: Reformat code using kde-dev-scripts/astyle-kdelibs (authored by volkov).
Reformat code using kde-dev-scripts/astyle-kdelibs
Mon, Oct 15, 12:08 PM
volkov committed R486:f57d661416ec: Introduce HKDF (authored by volkov).
Introduce HKDF
Mon, Oct 15, 11:31 AM
volkov closed D15510: Introduce HKDF.
Mon, Oct 15, 11:31 AM

Sat, Oct 13

volkov committed R345:ff7f9e254694: Get rid of dependency on KInit (authored by volkov).
Get rid of dependency on KInit
Sat, Oct 13, 9:09 AM
volkov closed D16161: Get rid of dependency on KInit.
Sat, Oct 13, 9:09 AM

Fri, Oct 12

volkov added a reviewer for D16161: Get rid of dependency on KInit: marten.
Fri, Oct 12, 4:47 PM
volkov requested review of D16161: Get rid of dependency on KInit.
Fri, Oct 12, 4:45 PM
volkov committed R260:2ad1dd48dc26: Use PMFs instead of C-strings to store and emit signals (authored by volkov).
Use PMFs instead of C-strings to store and emit signals
Fri, Oct 12, 3:00 PM
volkov committed R260:219b343e4663: Emit signals from internal implementaions directly (authored by volkov).
Emit signals from internal implementaions directly
Fri, Oct 12, 3:00 PM
volkov updated the summary of D16109: Get rid of QMetaObject::invokeMethod() with 'const char *member' arg.
Fri, Oct 12, 2:56 PM · Gwenview
volkov updated the diff for D16109: Get rid of QMetaObject::invokeMethod() with 'const char *member' arg.

simplify, leave only invokeMethod() -> QTimer::singleShot() change

Fri, Oct 12, 2:55 PM · Gwenview

Thu, Oct 11

volkov added a comment to D16109: Get rid of QMetaObject::invokeMethod() with 'const char *member' arg.

Yes, but gwenview requires at least 5.9.
And code is longer with QMetaObject::invokeMethod, compare:
QTimer::singleShot(0, this, &FileOpsContextManagerItem::updateActions);
and
QMetaObject::invokeMethod(this, &FileOpsContextManagerItem::updateActions, Qt::QueuedConnection);

Thu, Oct 11, 10:44 AM · Gwenview

Wed, Oct 10

volkov added a reviewer for D16109: Get rid of QMetaObject::invokeMethod() with 'const char *member' arg: Gwenview.
Wed, Oct 10, 3:59 PM · Gwenview
volkov requested review of D16109: Get rid of QMetaObject::invokeMethod() with 'const char *member' arg.
Wed, Oct 10, 3:58 PM · Gwenview

Mon, Oct 8

volkov added a comment to D15510: Introduce HKDF.

BTW, should I create a review request to reformat code with astyle-kdelibs?

Mon, Oct 8, 11:41 AM
volkov updated the diff for D15510: Introduce HKDF.

more reinterpret_casts

Mon, Oct 8, 11:27 AM
volkov updated the diff for D15510: Introduce HKDF.

fixed

Mon, Oct 8, 11:18 AM
volkov added inline comments to D15510: Introduce HKDF.
Mon, Oct 8, 11:15 AM

Sat, Oct 6

volkov abandoned D15969: Add support for systemd's suspend-then-hibernate.
Sat, Oct 6, 7:31 AM · Plasma

Fri, Oct 5

volkov requested review of D15969: Add support for systemd's suspend-then-hibernate.
Fri, Oct 5, 4:55 PM · Plasma
volkov committed R122:531dfa5e9b11: Avoid creation of needless temporary containers (authored by volkov).
Avoid creation of needless temporary containers
Fri, Oct 5, 12:01 PM
volkov committed R122:168178b25f25: Add missing emit keyword (authored by volkov).
Add missing emit keyword
Fri, Oct 5, 12:01 PM
volkov committed R110:66a0c467dd51: Avoid creation of needless temporary containers (authored by volkov).
Avoid creation of needless temporary containers
Fri, Oct 5, 11:05 AM
volkov closed D15946: Avoid creation of needless temporary containers.
Fri, Oct 5, 11:04 AM · Plasma
volkov added inline comments to D15946: Avoid creation of needless temporary containers.
Fri, Oct 5, 11:03 AM · Plasma

Thu, Oct 4

volkov committed R110:f5d9943ea65a: Remove unused QPointer includes (authored by volkov).
Remove unused QPointer includes
Thu, Oct 4, 3:43 PM
volkov committed R110:dcb4a6cf8cc1: Don't leak Edid (authored by volkov).
Don't leak Edid
Thu, Oct 4, 3:42 PM
volkov updated the diff for D15946: Avoid creation of needless temporary containers.

fixed

Thu, Oct 4, 3:06 PM · Plasma
volkov added inline comments to D15946: Avoid creation of needless temporary containers.
Thu, Oct 4, 2:55 PM · Plasma
volkov added a reviewer for D15946: Avoid creation of needless temporary containers: Plasma.
Thu, Oct 4, 2:32 PM · Plasma
volkov requested review of D15946: Avoid creation of needless temporary containers.
Thu, Oct 4, 2:30 PM · Plasma
volkov committed R110:56932fc204a4: Fix qstring-insensitive-allocation clazy warning (authored by volkov).
Fix qstring-insensitive-allocation clazy warning
Thu, Oct 4, 2:29 PM
volkov committed R110:13c9d74d686f: Remove unused member variable (authored by volkov).
Remove unused member variable
Thu, Oct 4, 1:52 PM

Mon, Oct 1

volkov committed R40:e261f1ff0488: Use lambdas instead of QSignalMapper (authored by volkov).
Use lambdas instead of QSignalMapper
Mon, Oct 1, 7:47 PM
volkov closed D15292: Use lambdas instead of QSignalMapper.
Mon, Oct 1, 7:47 PM · Kate

Fri, Sep 28

volkov committed R260:bf9ed0fe0760: Use refs with non-trivial types in range-for (authored by volkov).
Use refs with non-trivial types in range-for
Fri, Sep 28, 11:49 AM
volkov committed R260:7f06194a25cd: Use constFirst() instead if first() for temporaries (authored by volkov).
Use constFirst() instead if first() for temporaries
Fri, Sep 28, 11:49 AM
volkov committed R260:5af1f4cf7930: Use QColor ctor that takes ints as it's more performant (authored by volkov).
Use QColor ctor that takes ints as it's more performant
Fri, Sep 28, 11:49 AM
volkov committed R260:61068da1bdca: Use QVariant::toUrl() instead of QVariant::value<QUrl>() (authored by volkov).
Use QVariant::toUrl() instead of QVariant::value<QUrl>()
Fri, Sep 28, 11:49 AM
volkov committed R260:b136f5ec5e8f: Use qEnvironmentVariableIsEmpty() to save memory allocations (authored by volkov).
Use qEnvironmentVariableIsEmpty() to save memory allocations
Fri, Sep 28, 11:49 AM
volkov committed R260:3c4db4461993: Use the multi-arg overload of QString::arg() to save memory allocations (authored by volkov).
Use the multi-arg overload of QString::arg() to save memory allocations
Fri, Sep 28, 11:49 AM
volkov committed R260:5de94511ec81: Add missing emit keyword (authored by volkov).
Add missing emit keyword
Fri, Sep 28, 10:34 AM
volkov closed D15802: Add missing emit keyword.
Fri, Sep 28, 10:34 AM · Gwenview

Thu, Sep 27

volkov added a reviewer for D15802: Add missing emit keyword: Gwenview.
Thu, Sep 27, 4:59 PM · Gwenview
volkov requested review of D15802: Add missing emit keyword.
Thu, Sep 27, 4:58 PM · Gwenview

Wed, Sep 26

volkov added a reviewer for D15510: Introduce HKDF: Frameworks.
Wed, Sep 26, 12:44 PM

Sep 18 2018

volkov committed R166:466de5213027: Don't show rectangular region editor if failed to take a screenshot (authored by volkov).
Don't show rectangular region editor if failed to take a screenshot
Sep 18 2018, 9:32 AM
volkov closed D15425: Don't show rectangular region editor if failed to take a screenshot.
Sep 18 2018, 9:32 AM · Spectacle
volkov added a comment to D15425: Don't show rectangular region editor if failed to take a screenshot.

Thanks :)

Sep 18 2018, 9:30 AM · Spectacle

Sep 14 2018

volkov added reviewers for D15510: Introduce HKDF: iromanov, sitter.
Sep 14 2018, 4:27 PM
volkov requested review of D15510: Introduce HKDF.
Sep 14 2018, 4:23 PM
volkov committed R486:98eead005828: Add .arcconfig (authored by volkov).
Add .arcconfig
Sep 14 2018, 4:21 PM

Sep 12 2018

volkov added a comment to D15425: Don't show rectangular region editor if failed to take a screenshot.

I'm afraid that there is no such way :( I found the bug with proprietary security extension.
It should be possible to reproduce the situation with XSelinux, but I don't know how.

Sep 12 2018, 11:07 AM · Spectacle

Sep 11 2018

volkov requested review of D15425: Don't show rectangular region editor if failed to take a screenshot.
Sep 11 2018, 1:15 PM · Spectacle
volkov accepted D15420: Intialize m_lastPosition.
Sep 11 2018, 11:36 AM · Frameworks, Kate
volkov added a comment to D12016: [ktexteditor] much faster positionFromCursor.

I get the following warning from valgrind because of this change:

Sep 11 2018, 10:52 AM · Frameworks, Kate

Sep 10 2018

volkov committed R260:154b765b5b03: Don't show Plugins menu if built without KIPI support (authored by volkov).
Don't show Plugins menu if built without KIPI support
Sep 10 2018, 11:44 AM
volkov closed D15270: Don't show Plugins menu if built without KIPI support.
Sep 10 2018, 11:44 AM · Gwenview
volkov committed R260:cd6c2a20e726: Don't show empty Rating menu when built without semantic info backend (authored by volkov).
Don't show empty Rating menu when built without semantic info backend
Sep 10 2018, 11:44 AM
volkov closed D15271: Don't show empty Rating menu when built without semantic info backend.
Sep 10 2018, 11:44 AM · Gwenview
volkov updated the diff for D15271: Don't show empty Rating menu when built without semantic info backend.

style fix

Sep 10 2018, 10:17 AM · Gwenview
volkov updated the diff for D15270: Don't show Plugins menu if built without KIPI support.

style fix

Sep 10 2018, 10:17 AM · Gwenview
volkov committed R260:f15cc6f3fabf: Use QOverload to select overloaded functions (authored by volkov).
Use QOverload to select overloaded functions
Sep 10 2018, 10:13 AM
volkov closed D15296: Use QOverload to select overloaded functions.
Sep 10 2018, 10:13 AM · Gwenview

Sep 7 2018

volkov added a comment to D15270: Don't show Plugins menu if built without KIPI support.

Right.

Sep 7 2018, 3:58 PM · Gwenview

Sep 6 2018

volkov added a comment to D15317: trash: Fix directorysizes cache parsing.

It should fix the bugs:
https://bugs.kde.org/show_bug.cgi?id=331707
https://bugs.kde.org/show_bug.cgi?id=386460

Sep 6 2018, 10:11 PM · Frameworks
volkov committed R241:9d682612de46: trash: Fix directorysizes cache parsing (authored by volkov).
trash: Fix directorysizes cache parsing
Sep 6 2018, 9:44 PM
volkov closed D15317: trash: Fix directorysizes cache parsing.
Sep 6 2018, 9:43 PM · Frameworks
volkov added a reviewer for D15317: trash: Fix directorysizes cache parsing: Frameworks.
Sep 6 2018, 4:01 PM · Frameworks
volkov requested review of D15317: trash: Fix directorysizes cache parsing.
Sep 6 2018, 4:01 PM · Frameworks

Sep 5 2018

volkov committed R36:67f073732555: Use lambdas instead of QSignalMapper (authored by volkov).
Use lambdas instead of QSignalMapper
Sep 5 2018, 9:20 PM
volkov closed D15249: Use lambdas instead of QSignalMapper.
Sep 5 2018, 8:49 PM · Ark
volkov committed R116:7e578ddc6873: Use QOverload to select overloaded functions (authored by volkov).
Use QOverload to select overloaded functions
Sep 5 2018, 3:46 PM
volkov closed D15297: Use QOverload to select overloaded functions.
Sep 5 2018, 3:43 PM · Plasma
volkov added a reviewer for D15297: Use QOverload to select overloaded functions: jgrulich.
Sep 5 2018, 3:19 PM · Plasma
volkov requested review of D15297: Use QOverload to select overloaded functions.
Sep 5 2018, 3:18 PM · Plasma
volkov added a reviewer for D15296: Use QOverload to select overloaded functions: Gwenview.
Sep 5 2018, 2:53 PM · Gwenview
volkov requested review of D15296: Use QOverload to select overloaded functions.
Sep 5 2018, 2:53 PM · Gwenview
volkov added inline comments to D15292: Use lambdas instead of QSignalMapper.
Sep 5 2018, 1:59 PM · Kate
volkov added inline comments to D15292: Use lambdas instead of QSignalMapper.
Sep 5 2018, 12:54 PM · Kate
volkov added inline comments to D15292: Use lambdas instead of QSignalMapper.
Sep 5 2018, 12:52 PM · Kate
volkov committed R111:fe44c73bd32e: Use lambda instead of QSignalMapper (authored by volkov).
Use lambda instead of QSignalMapper
Sep 5 2018, 12:25 PM
volkov closed D15289: Use lambda instead of QSignalMapper.
Sep 5 2018, 12:22 PM · Plasma
volkov committed R382:e79047d37a3f: Use QOverload (authored by volkov).
Use QOverload
Sep 5 2018, 12:20 PM
volkov committed R382:f9c254816c24: Reduce differences between KSaneScanThread and KSanePreviewThread (authored by volkov).
Reduce differences between KSaneScanThread and KSanePreviewThread
Sep 5 2018, 12:19 PM