volkov (Alexander Volkov)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
May 20 2016, 1:05 PM (161 w, 4 d)
Availability
Available

Recent Activity

Yesterday

volkov abandoned D21363: Fix build with poppler < 0.51.

It's specific only for AstraLinux.

Mon, Jun 24, 10:21 AM · Okular
volkov committed R467:9821f9aa4c3b: Merge remote-tracking branch 'origin/Applications/19.04' (authored by volkov).
Merge remote-tracking branch 'origin/Applications/19.04'
Mon, Jun 24, 10:12 AM
volkov committed R467:1137f7641998: Fix detection of recommendation about DAO mode from growisofs (authored by volkov).
Fix detection of recommendation about DAO mode from growisofs
Mon, Jun 24, 10:11 AM
volkov closed D21880: Fix detection of recommendation about DAO mode from growisofs.
Mon, Jun 24, 10:11 AM

Fri, Jun 21

volkov added a comment to D21880: Fix detection of recommendation about DAO mode from growisofs.

The last release of dvd+rw-tools was made in 2008, and dvd+rw-format printed :-( even then.

Fri, Jun 21, 10:11 AM

Thu, Jun 20

volkov added a comment to D20790: Add highdpi support for RDP and VNC.

This change allows to show remote contents as is.
For example, remote desktop may be started with QT_SCREEN_SCALE_FACTORS=2 and it will look good on highdpi monitor.

Thu, Jun 20, 10:38 AM

Tue, Jun 18

volkov requested review of D21887: Fix -Wimplicit-fallthrough warnings.
Tue, Jun 18, 8:24 PM
volkov added a reviewer for D21880: Fix detection of recommendation about DAO mode from growisofs: KDE Applications.
Tue, Jun 18, 12:10 PM
volkov requested review of D21880: Fix detection of recommendation about DAO mode from growisofs.
Tue, Jun 18, 12:09 PM

Mon, Jun 17

volkov added a comment to D20790: Add highdpi support for RDP and VNC.

Yes, remote contents should not be scaled.

Mon, Jun 17, 4:08 PM
volkov added a comment to D20790: Add highdpi support for RDP and VNC.

Have you installed libkrdc_vncplugin.so into the system?
KRDC doesn't search for plugins in the build tree.

Mon, Jun 17, 3:35 PM
volkov updated the diff for D20790: Add highdpi support for RDP and VNC.

fix initialization order

Mon, Jun 17, 3:31 PM
volkov updated the diff for D20790: Add highdpi support for RDP and VNC.

rebased

Mon, Jun 17, 10:42 AM

Fri, Jun 14

volkov committed R467:1c673165a680: Merge remote-tracking branch 'origin/Applications/19.04' (authored by volkov).
Merge remote-tracking branch 'origin/Applications/19.04'
Fri, Jun 14, 10:38 AM
volkov committed R467:8b8b4674cada: Fix available writing modes when formatting DVD-RW (authored by volkov).
Fix available writing modes when formatting DVD-RW
Fri, Jun 14, 10:32 AM
volkov closed D21751: Fix available writing modes when formatting DVD-RW.
Fri, Jun 14, 10:32 AM

Thu, Jun 13

volkov added a comment to D21751: Fix available writing modes when formatting DVD-RW.

No, this change is only for DVD-RW, not DVD+RW.

Thu, Jun 13, 6:22 AM

Tue, Jun 11

volkov added a reviewer for D21751: Fix available writing modes when formatting DVD-RW: KDE Applications.
Tue, Jun 11, 5:46 PM
volkov requested review of D21751: Fix available writing modes when formatting DVD-RW.
Tue, Jun 11, 5:45 PM

Mon, Jun 10

volkov added a comment to D20790: Add highdpi support for RDP and VNC.

This change prevents highdpi scaling of the remote desktop.
It's double-scaled on your gif and looks pixelated.

Mon, Jun 10, 11:14 AM
volkov committed R223:3311ba3a67da: Use lambdas instead of QSignalMapper (authored by volkov).
Use lambdas instead of QSignalMapper
Mon, Jun 10, 11:10 AM
volkov closed D17481: Use lambdas instead of QSignalMapper.
Mon, Jun 10, 11:10 AM · Okular
volkov committed R467:9957433a5fb1: Use lambda instead of QSignalMapper (authored by volkov).
Use lambda instead of QSignalMapper
Mon, Jun 10, 10:59 AM
volkov closed D15288: Use lambda instead of QSignalMapper.
Mon, Jun 10, 10:58 AM
volkov added a comment to D15290: Use lambdas instead of QSignalMapper.

Well, I don't have time to contribute to this project, so I don't know what to do with it.

Mon, Jun 10, 10:56 AM
volkov committed R254:bf6b348eb4f5: Use lambdas instead of QSignalMapper (authored by volkov).
Use lambdas instead of QSignalMapper
Mon, Jun 10, 10:54 AM
volkov closed D15290: Use lambdas instead of QSignalMapper.
Mon, Jun 10, 10:54 AM
volkov committed R436:87f3b0754638: vnc: Optimize and simplify repainting (authored by volkov).
vnc: Optimize and simplify repainting
Mon, Jun 10, 10:44 AM
volkov closed D21096: vnc: Optimize and simplify repainting.
Mon, Jun 10, 10:44 AM

May 25 2019

volkov added a comment to D21363: Fix build with poppler < 0.51.

My OS (AstraLinux) is based on Debian stretch and has poppler 0.48, Qt 5.11, KF5 5.46.
And probably it will be a headache to update poppler on it, cause it's rather low-level library (cups-filters depends on it).

May 25 2019, 11:35 AM · Okular

May 23 2019

volkov added reviewers for D21363: Fix build with poppler < 0.51: Okular, sander.
May 23 2019, 10:31 AM · Okular
volkov added a comment to D21320: Fix build with poppler < 0.51.

Sorry. I didn't add #include <config-okular-poppler.h> to formfields.h.
Correct fix: D21363.

May 23 2019, 10:31 AM · Okular
volkov requested review of D21363: Fix build with poppler < 0.51.
May 23 2019, 10:28 AM · Okular

May 22 2019

volkov committed R223:f29f6727a2a8: Merge remote-tracking branch 'origin/Applications/19.04' (authored by volkov).
Merge remote-tracking branch 'origin/Applications/19.04'
May 22 2019, 12:40 PM
volkov committed R223:32786e6b3d8d: Fix build with poppler < 0.51 (authored by volkov).
Fix build with poppler < 0.51
May 22 2019, 12:33 PM
volkov closed D21320: Fix build with poppler < 0.51.
May 22 2019, 12:33 PM · Okular

May 21 2019

volkov added a reviewer for D21320: Fix build with poppler < 0.51: Okular.
May 21 2019, 3:49 PM · Okular
volkov requested review of D21320: Fix build with poppler < 0.51.
May 21 2019, 3:49 PM · Okular
volkov added inline comments to D14655: Reimplement signature form field and related utility classes in poppler generator.
May 21 2019, 3:26 PM · Okular

May 16 2019

volkov committed R420:358221c1e4b9: Replace Q_DECL_OVERRIDE by override (authored by volkov).
Replace Q_DECL_OVERRIDE by override
May 16 2019, 2:28 PM
volkov closed D21240: Replace Q_DECL_OVERRIDE by override.
May 16 2019, 2:28 PM
volkov added a reviewer for D21240: Replace Q_DECL_OVERRIDE by override: mlaurent.
May 16 2019, 1:54 PM
volkov requested review of D21240: Replace Q_DECL_OVERRIDE by override.
May 16 2019, 1:53 PM
volkov committed R420:dcdbc8a70317: Add .arcconfig (authored by volkov).
Add .arcconfig
May 16 2019, 1:24 PM

May 15 2019

volkov added a comment to D21231: Add initial HiDPI support.

Complete HiDPI support requires D21230.

May 15 2019, 5:01 PM
volkov requested review of D21231: Add initial HiDPI support.
May 15 2019, 5:00 PM
volkov requested review of D21230: Add support for creating high-dpi pixmaps by KGameRenderer{Client}.
May 15 2019, 4:52 PM

May 9 2019

volkov updated the summary of D20790: Add highdpi support for RDP and VNC.
May 9 2019, 7:23 PM
volkov updated the summary of D21096: vnc: Optimize and simplify repainting.
May 9 2019, 4:06 PM
volkov updated the diff for D20790: Add highdpi support for RDP and VNC.

rebased

May 9 2019, 3:17 PM
volkov added a comment to D20790: Add highdpi support for RDP and VNC.

I'm going to rebase it on D21096. Please, review that change first.

May 9 2019, 12:21 PM
volkov added a reviewer for D21096: vnc: Optimize and simplify repainting: KDE Applications.
May 9 2019, 12:16 PM
volkov requested review of D21096: vnc: Optimize and simplify repainting.
May 9 2019, 12:14 PM

Apr 29 2019

volkov committed R483:cb382f87d63b: Add HiDPI support (authored by volkov).
Add HiDPI support
Apr 29 2019, 1:21 PM
volkov closed D20821: Add HiDPI support.
Apr 29 2019, 1:21 PM
volkov committed R382:23c3a433d339: Add HiDPI support (authored by volkov).
Add HiDPI support
Apr 29 2019, 1:13 PM
volkov closed D20806: Add HiDPI support.
Apr 29 2019, 1:13 PM
volkov committed R382:9690fd2162dd: Extract HideRectItem class (authored by volkov).
Extract HideRectItem class
Apr 29 2019, 1:09 PM
volkov closed D20841: Extract HideRectItem class.
Apr 29 2019, 1:09 PM
volkov updated the diff for D20841: Extract HideRectItem class.

ok, leave only my own copyright

Apr 29 2019, 12:26 PM
volkov updated the diff for D20806: Add HiDPI support.

emulate missing QGraphicsView::mapToScene(const QPointF &) by using QPainterPath wrapper

Apr 29 2019, 12:23 PM
volkov added a comment to D20841: Extract HideRectItem class.

But the code is yours, isn't it?

Apr 29 2019, 12:12 PM
volkov added a reviewer for D20790: Add highdpi support for RDP and VNC: davidedmundson.
Apr 29 2019, 12:08 PM
volkov updated the diff for D20806: Add HiDPI support.

use precise coordinates for selections + use cosmetic pens

Apr 29 2019, 12:06 PM
volkov added inline comments to D20806: Add HiDPI support.
Apr 29 2019, 10:31 AM
volkov added a comment to D20821: Add HiDPI support.

AA_UseHighDpiPixmaps is not related to previews, it's for icons on buttons.
devicePixelRatioF is needed to paint an image as is without highdpi scaling by Qt.

Apr 29 2019, 10:26 AM
volkov updated the diff for D20841: Extract HideRectItem class.

fix copyrights

Apr 29 2019, 10:20 AM

Apr 26 2019

volkov added a reviewer for D20841: Extract HideRectItem class: sars.
Apr 26 2019, 9:36 PM
volkov added a reviewer for D20790: Add highdpi support for RDP and VNC: KDE Applications.
Apr 26 2019, 4:35 PM
volkov updated the diff for D20790: Add highdpi support for RDP and VNC.

polished

Apr 26 2019, 4:33 PM
volkov added a dependency for D20806: Add HiDPI support: D20841: Extract HideRectItem class.
Apr 26 2019, 1:01 PM
volkov added a dependent revision for D20841: Extract HideRectItem class: D20806: Add HiDPI support.
Apr 26 2019, 1:01 PM
volkov updated the diff for D20806: Add HiDPI support.

leave a single commit

Apr 26 2019, 1:00 PM
volkov updated the diff for D20806: Add HiDPI support.

rebase on D20841

Apr 26 2019, 12:50 PM
volkov requested review of D20841: Extract HideRectItem class.
Apr 26 2019, 12:47 PM
volkov updated the diff for D20806: Add HiDPI support.

revert

Apr 26 2019, 12:45 PM
volkov updated the diff for D20806: Add HiDPI support.

rebase on extracted HideRectItem

Apr 26 2019, 12:35 PM
volkov added a comment to D20821: Add HiDPI support.

To paint non-pixelated icons on buttons.
This attribute "makes QIcon::pixmap() generate high-dpi pixmaps that can be larger than the requested size. Such pixmaps will have devicePixelRatio() set to a value higher than 1."

Apr 26 2019, 11:40 AM
volkov added a comment to D20806: Add HiDPI support.

Qt supports a high DPI mode where the main coordinate system is virtualized and made independent of the display pixel density.
...
Geometry is now specified in device independent pixels. This includes widget and item geometry, event geometry, desktop, window and screen
geometry, and animation velocities. Rendered output is in device pixels, which corresponds to the display resolution. The ratio between the
device independent and device pixel coordinate systems is the devicePixelRatio.

Apr 26 2019, 11:28 AM

Apr 25 2019

volkov added a comment to D13901: Touch support for Gwenview.

Ideally, QWidget::mouseDoubleClickEvent() could be used instead of double tap gesture...
https://codereview.qt-project.org/#/c/259787/

Apr 25 2019, 5:05 PM · Gwenview
volkov added reviewers for D20821: Add HiDPI support: sars, davidedmundson, ngraham.
Apr 25 2019, 3:13 PM
volkov requested review of D20821: Add HiDPI support.
Apr 25 2019, 3:12 PM
volkov updated the diff for D20806: Add HiDPI support.

removed needless image scaling

Apr 25 2019, 2:51 PM
volkov added inline comments to D20806: Add HiDPI support.
Apr 25 2019, 2:50 PM
volkov added a reviewer for D20806: Add HiDPI support: sars.
Apr 25 2019, 12:46 PM
volkov requested review of D20806: Add HiDPI support.
Apr 25 2019, 12:44 PM

Apr 24 2019

volkov committed R410:e41c3cce214e: Avoid tiny cards on high screen resolutions (authored by volkov).
Avoid tiny cards on high screen resolutions
Apr 24 2019, 3:57 PM
volkov closed D20061: Avoid tiny cards on high screen resolutions.
Apr 24 2019, 3:57 PM
volkov requested review of D20790: Add highdpi support for RDP and VNC.
Apr 24 2019, 3:19 PM

Apr 16 2019

volkov added a comment to D20445: signalplotter: Add highdpi support.

Beams look ugly when their width is >= 4 pixels.
The idea is to draw them with the same width regardless of DPI.
Another option is to not set Qt::FlatCap for thick pens, but I prefer this one.

Apr 16 2019, 9:59 AM · Plasma

Apr 15 2019

volkov added inline comments to D20445: signalplotter: Add highdpi support.
Apr 15 2019, 3:43 PM · Plasma

Apr 12 2019

volkov updated the diff for D20445: signalplotter: Add highdpi support.

use QPen::setWidthF() instead of QPen::setWidth()

Apr 12 2019, 9:44 PM · Plasma
volkov updated the diff for D20445: signalplotter: Add highdpi support.

reduced beam width

Apr 12 2019, 4:38 PM · Plasma

Apr 11 2019

volkov added a comment to D20445: signalplotter: Add highdpi support.

Hi, thanks for the review.
I know about the issues, I've uploaded the patch to avoid losing it :)

Apr 11 2019, 9:51 AM · Plasma

Apr 10 2019

volkov requested review of D20445: signalplotter: Add highdpi support.
Apr 10 2019, 4:31 PM · Plasma

Apr 8 2019

volkov committed R260:b6e6ec6e92d0: Drop unnecessary PaintUtils::containingRect() (authored by volkov).
Drop unnecessary PaintUtils::containingRect()
Apr 8 2019, 5:13 PM
volkov closed D20251: Drop unnecessary PaintUtils::containingRect().
Apr 8 2019, 5:12 PM · Gwenview
volkov updated subscribers of D20251: Drop unnecessary PaintUtils::containingRect().

Well, actually, it was caught by @hetzenecker: https://phabricator.kde.org/D7581?id=22415#change-vIXPDUvyb3sZ

Apr 8 2019, 5:12 PM · Gwenview
volkov added a comment to D7581: HiDPI Support for Gwenview.

You are welcome!
I started to implement highdpi support from scratch, but then I found this change and it was a huge help!

Apr 8 2019, 12:54 PM · Gwenview
volkov added a comment to D19920: Add High DPI support.

ping

Apr 8 2019, 11:24 AM