volkov (Alexander Volkov)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
May 20 2016, 1:05 PM (143 w, 5 d)
Availability
Available

Recent Activity

Mon, Feb 18

volkov committed R260:b99e6a5d6a46: Set the same image mime types in all desktop files (authored by volkov).
Set the same image mime types in all desktop files
Mon, Feb 18, 8:22 PM
volkov closed D19122: Set the same image mime types in all desktop files.
Mon, Feb 18, 8:22 PM · Gwenview
volkov added a comment to D18852: Add mime types for raw image formats to desktop file.

D19122

Mon, Feb 18, 5:23 PM · Gwenview
volkov added a reviewer for D19122: Set the same image mime types in all desktop files: Gwenview.
Mon, Feb 18, 5:23 PM · Gwenview
volkov requested review of D19122: Set the same image mime types in all desktop files.
Mon, Feb 18, 5:23 PM · Gwenview
volkov committed R260:7afa340f9bf9: Add mime types for raw image formats to desktop file (authored by volkov).
Add mime types for raw image formats to desktop file
Mon, Feb 18, 4:22 PM
volkov closed D18852: Add mime types for raw image formats to desktop file.
Mon, Feb 18, 2:58 PM · Gwenview
volkov added a comment to D18852: Add mime types for raw image formats to desktop file.

ping

Mon, Feb 18, 9:39 AM · Gwenview

Wed, Feb 13

volkov updated the summary of D18852: Add mime types for raw image formats to desktop file.
Wed, Feb 13, 2:46 PM · Gwenview

Tue, Feb 12

volkov updated the diff for D18852: Add mime types for raw image formats to desktop file.

modify existing desktop file instead of installing a new one

Tue, Feb 12, 5:30 PM · Gwenview
volkov added a comment to D14661: Force reevaluation of Predicates if interfaces are removed.

I guess that there is a short period of time when UDisks daemon is in inconsistent state, i.e. org.freedesktop.UDisks2.Filesystem interface is removed for CD-ROM device, but the device's properties still have Optical=true.
Adding "updateBackend(udi);" before "emit deviceAdded(udi);" gives Udisks time to become consistent.

Tue, Feb 12, 5:01 PM · Frameworks

Mon, Feb 11

volkov added a comment to D18852: Add mime types for raw image formats to desktop file.

Wouldn't it be better to add mime types to org.kde.gwenview.desktop during the build?
https://lxr.kde.org/ doesn't respond, so I can't find an example for now.

Mon, Feb 11, 3:09 PM · Gwenview
volkov added a comment to D18852: Add mime types for raw image formats to desktop file.

Gwenview supports these formats only when it is built with KDcraw.
I used the approach from okular: when okular is built with support for a set of formats, then a separate desktop file is installed for them.
And the added gwenviewApplication_raw.desktop contains translations because it is just a modified copy of org.kde.gwenview.desktop.

Mon, Feb 11, 10:52 AM · Gwenview
volkov committed R36:233de9e97cb1: Preset file name of archive in CreateDialog (authored by volkov).
Preset file name of archive in CreateDialog
Mon, Feb 11, 10:44 AM
volkov closed D18152: Preset file name of archive in CreateDialog.
Mon, Feb 11, 10:44 AM · Ark

Sat, Feb 9

volkov added a reviewer for D18852: Add mime types for raw image formats to desktop file: Gwenview.
Sat, Feb 9, 1:55 PM · Gwenview

Fri, Feb 8

volkov requested review of D18852: Add mime types for raw image formats to desktop file.
Fri, Feb 8, 2:55 PM · Gwenview
volkov added a comment to D18152: Preset file name of archive in CreateDialog.

ping

Fri, Feb 8, 12:47 PM · Ark

Tue, Jan 22

volkov committed R108:5d63b9c05bbe: Fix flickering with Qt 5.12 (authored by volkov).
Fix flickering with Qt 5.12
Tue, Jan 22, 7:38 PM
volkov closed D18366: Fix flickering with Qt 5.12.
Tue, Jan 22, 7:37 PM · KWin
volkov committed R119:768fa11c277b: Fonts KCM: Port from kde_file.h to QFileInfo (authored by volkov).
Fonts KCM: Port from kde_file.h to QFileInfo
Tue, Jan 22, 11:53 AM
volkov closed D18454: Fonts KCM: Port from kde_file.h to QFileInfo.
Tue, Jan 22, 11:53 AM · Plasma
volkov added a reviewer for D18454: Fonts KCM: Port from kde_file.h to QFileInfo: Plasma.
Tue, Jan 22, 11:30 AM · Plasma
volkov requested review of D18454: Fonts KCM: Port from kde_file.h to QFileInfo.
Tue, Jan 22, 11:30 AM · Plasma
volkov committed R119:ed840a5379c6: Remove dependency on KDELibs4Support for some KCM modules (authored by volkov).
Remove dependency on KDELibs4Support for some KCM modules
Tue, Jan 22, 10:36 AM
volkov closed D18449: Remove dependency on KDELibs4Support for some KCM modules.
Tue, Jan 22, 10:36 AM · Plasma
volkov requested review of D18449: Remove dependency on KDELibs4Support for some KCM modules.
Tue, Jan 22, 9:25 AM · Plasma

Jan 21 2019

volkov updated the diff for D18366: Fix flickering with Qt 5.12.

extend the comment

Jan 21 2019, 4:58 PM · KWin
volkov updated the summary of D18366: Fix flickering with Qt 5.12.
Jan 21 2019, 11:43 AM · KWin
volkov updated the summary of D18366: Fix flickering with Qt 5.12.
Jan 21 2019, 11:40 AM · KWin
volkov updated the diff for D18366: Fix flickering with Qt 5.12.

fix commit description

Jan 21 2019, 11:38 AM · KWin

Jan 19 2019

volkov updated the diff for D18366: Fix flickering with Qt 5.12.

re-target to Plasma/5.12

Jan 19 2019, 10:33 AM · KWin

Jan 18 2019

volkov added a comment to D18366: Fix flickering with Qt 5.12.

See also https://bugreports.qt.io/browse/QTBUG-73122

Jan 18 2019, 3:18 PM · KWin
volkov added a reviewer for D18366: Fix flickering with Qt 5.12: KWin.
Jan 18 2019, 3:17 PM · KWin
volkov requested review of D18366: Fix flickering with Qt 5.12.
Jan 18 2019, 3:16 PM · KWin

Jan 17 2019

volkov committed R119:deebad73af22: [Mouse KCM] Port away from KDELibs4Support (authored by volkov).
[Mouse KCM] Port away from KDELibs4Support
Jan 17 2019, 11:35 AM
volkov closed D18300: [Mouse KCM] Port away from KDELibs4Support.
Jan 17 2019, 11:35 AM · Plasma

Jan 16 2019

volkov requested review of D18300: [Mouse KCM] Port away from KDELibs4Support.
Jan 16 2019, 5:11 PM · Plasma
volkov committed R223:0d958be2900b: Fix MimeType in org.kde.mobile.okular_comicbook.desktop (authored by volkov).
Fix MimeType in org.kde.mobile.okular_comicbook.desktop
Jan 16 2019, 2:51 PM
volkov committed R478:8fbc33b58070: qtests: Connect slots explicitly instead of using auto-connections (authored by volkov).
qtests: Connect slots explicitly instead of using auto-connections
Jan 16 2019, 11:16 AM
volkov closed D16543: qtests: Connect slots explicitly instead of using auto-connections.
Jan 16 2019, 11:16 AM
volkov updated the diff for D16543: qtests: Connect slots explicitly instead of using auto-connections.

rebased

Jan 16 2019, 11:14 AM
volkov abandoned D18251: Bump required Qt version to 5.9.

It makes sense to sync with Calligra.

Jan 16 2019, 11:01 AM

Jan 15 2019

volkov added a comment to D14661: Force reevaluation of Predicates if interfaces are removed.

Looks like the bug is caused by removing the line "updateBackend(udi);"

Jan 15 2019, 2:49 PM · Frameworks
volkov added a comment to D14661: Force reevaluation of Predicates if interfaces are removed.

This change causes a bug: when you eject a mounted CD from the applet, then CD-ROM tray closes immediately after ejecting.

Jan 15 2019, 2:14 PM · Frameworks

Jan 14 2019

volkov added a reviewer for D18251: Bump required Qt version to 5.9: KDiagram.
Jan 14 2019, 8:33 PM
volkov requested review of D18251: Bump required Qt version to 5.9.
Jan 14 2019, 8:33 PM
volkov added inline comments to D18152: Preset file name of archive in CreateDialog.
Jan 14 2019, 11:06 AM · Ark
volkov committed R467:75692f78b54b: Correctly extend context menu of file view (authored by volkov).
Correctly extend context menu of file view
Jan 14 2019, 10:58 AM
volkov closed D18184: Correctly extend context menu of file view.
Jan 14 2019, 10:58 AM

Jan 11 2019

volkov added a reviewer for D18184: Correctly extend context menu of file view: KDE Applications.
Jan 11 2019, 2:12 PM
volkov requested review of D18184: Correctly extend context menu of file view.
Jan 11 2019, 2:10 PM

Jan 10 2019

volkov added a reviewer for D18152: Preset file name of archive in CreateDialog: Ark.
Jan 10 2019, 12:10 PM · Ark
volkov requested review of D18152: Preset file name of archive in CreateDialog.
Jan 10 2019, 12:09 PM · Ark
volkov added a comment to D17659: Set parent window for dialogs.

Oh, I see.

Jan 10 2019, 10:34 AM · Plasma

Jan 9 2019

volkov added a comment to D17659: Set parent window for dialogs.

I mean this plugin: https://cgit.kde.org/kwin.git/tree/plugins/qpa

Jan 9 2019, 10:22 AM · Plasma

Dec 25 2018

volkov committed R838:6f7b16e5bd59: Set parent window for dialogs (authored by volkov).
Set parent window for dialogs
Dec 25 2018, 3:10 PM
volkov closed D17659: Set parent window for dialogs.
Dec 25 2018, 3:10 PM · Plasma

Dec 20 2018

volkov added a comment to D17659: Set parent window for dialogs.

Is it possible to implement support for foreign windows in KWin QPA plugin?

Dec 20 2018, 11:29 AM · Plasma

Dec 18 2018

volkov added a reviewer for D17659: Set parent window for dialogs: jgrulich.
Dec 18 2018, 4:23 PM · Plasma
volkov requested review of D17659: Set parent window for dialogs.
Dec 18 2018, 4:22 PM · Plasma

Dec 10 2018

volkov added a reviewer for D17481: Use lambdas instead of QSignalMapper: Okular.
Dec 10 2018, 3:28 PM · Okular
volkov requested review of D17481: Use lambdas instead of QSignalMapper.
Dec 10 2018, 3:26 PM · Okular

Dec 4 2018

volkov added a comment to D16269: Show correct current download and upload speed.

The problem with this change is that speed is shown in bytes, not in bytes/s.

Dec 4 2018, 10:06 AM · Plasma

Dec 3 2018

volkov added a comment to D16269: Show correct current download and upload speed.

I mentioned in D14835 that the total number of received/transmitted bytes is more useful than the current speed.
One can see the current speed on the graph.

Dec 3 2018, 4:24 PM · Plasma

Dec 2 2018

volkov committed R119:c419eaa8d805: Use QFlags::QFlags() ctor instead of nullptr. (authored by volkov).
Use QFlags::QFlags() ctor instead of nullptr.
Dec 2 2018, 11:40 AM

Nov 20 2018

volkov added a comment to D16109: Get rid of QMetaObject::invokeMethod() with 'const char *member' arg.

ping

Nov 20 2018, 10:02 AM · Gwenview

Nov 19 2018

volkov committed R127:dfe65276b274: Use lambdas instead of std::bind() (authored by volkov).
Use lambdas instead of std::bind()
Nov 19 2018, 11:52 AM
volkov added a reviewer for D15288: Use lambda instead of QSignalMapper: aacid.
Nov 19 2018, 11:51 AM
volkov closed D16250: Use lambdas instead of std::bind().
Nov 19 2018, 11:47 AM · Frameworks
volkov committed R104:962ca65570f9: Prefer to set current mode in resolution combobox (authored by volkov).
Prefer to set current mode in resolution combobox
Nov 19 2018, 11:02 AM
volkov added a comment to D16250: Use lambdas instead of std::bind().

https://clang.llvm.org/extra/clang-tidy/checks/modernize-avoid-bind.html

std::bind can be hard to read and can result in larger object files and binaries due to type information that will not be produced by equivalent lambdas.

Nov 19 2018, 10:53 AM · Frameworks
volkov closed D16400: Prefer to set current mode in resolution combobox.
Nov 19 2018, 10:40 AM · Plasma

Nov 2 2018

volkov added a reviewer for D16612: Connect slots explicitly instead of using auto-connections: Frameworks.
Nov 2 2018, 4:07 PM · Frameworks
volkov requested review of D16612: Connect slots explicitly instead of using auto-connections.
Nov 2 2018, 4:06 PM · Frameworks

Nov 1 2018

volkov added a comment to D16543: qtests: Connect slots explicitly instead of using auto-connections.

Maybe bump up required Qt version?
Qt 5.9 is the current LTS release and the next LTS release Qt 5.12 is coming soon.

Nov 1 2018, 2:03 PM
volkov added inline comments to D16543: qtests: Connect slots explicitly instead of using auto-connections.
Nov 1 2018, 11:42 AM
volkov committed R478:f4013f88af6c: Fix warnings about nullptr for flags (authored by volkov).
Fix warnings about nullptr for flags
Nov 1 2018, 10:57 AM
volkov closed D16545: Fix warnings about nullptr for flags.
Nov 1 2018, 10:57 AM

Oct 31 2018

volkov committed R121:4f2c8ba512f3: Connect slots explicitly instead of using auto-connections (authored by volkov).
Connect slots explicitly instead of using auto-connections
Oct 31 2018, 3:36 PM
volkov closed D16547: Connect slots explicitly instead of using auto-connections.
Oct 31 2018, 3:35 PM · Plasma
volkov added a reviewer for D16547: Connect slots explicitly instead of using auto-connections: Plasma.
Oct 31 2018, 2:54 PM · Plasma
volkov updated the diff for D16547: Connect slots explicitly instead of using auto-connections.

rename slot

Oct 31 2018, 2:54 PM · Plasma
volkov requested review of D16547: Connect slots explicitly instead of using auto-connections.
Oct 31 2018, 2:51 PM · Plasma
volkov added a reviewer for D16545: Fix warnings about nullptr for flags: KDiagram.
Oct 31 2018, 2:40 PM
volkov requested review of D16545: Fix warnings about nullptr for flags.
Oct 31 2018, 2:39 PM
volkov added a reviewer for D16543: qtests: Connect slots explicitly instead of using auto-connections: KDiagram.
Oct 31 2018, 1:20 PM
volkov requested review of D16543: qtests: Connect slots explicitly instead of using auto-connections.
Oct 31 2018, 1:20 PM
volkov committed R478:20f99670f739: KChart: Connect slots explicitly instead of using auto-connections (authored by volkov).
KChart: Connect slots explicitly instead of using auto-connections
Oct 31 2018, 1:09 PM
volkov closed D16540: KChart: Connect slots explicitly instead of using auto-connections.
Oct 31 2018, 1:09 PM
volkov added a reviewer for D16540: KChart: Connect slots explicitly instead of using auto-connections: KDiagram.
Oct 31 2018, 11:56 AM
volkov requested review of D16540: KChart: Connect slots explicitly instead of using auto-connections.
Oct 31 2018, 11:55 AM
volkov committed R36:43ae86b022d8: libzipplugin: Simplify registration of progress callbacks (authored by volkov).
libzipplugin: Simplify registration of progress callbacks
Oct 31 2018, 10:36 AM
volkov closed D16276: libzipplugin: Simplify registration of progress callbacks.
Oct 31 2018, 10:36 AM · Ark

Oct 30 2018

volkov added a comment to D10895: Add sanitizer support in CMake.

Why not use include(ECMEnableSanitizers)?

Oct 30 2018, 12:22 PM · Kube

Oct 29 2018

volkov added a comment to D16276: libzipplugin: Simplify registration of progress callbacks.

The constant 0.001 is taken from libzip. It means that the callback will be called each time when compressing more than 1/1000 part of a file.
At least it doesn't change the old behavior.

Oct 29 2018, 5:10 PM · Ark

Oct 24 2018

volkov added a reviewer for D16400: Prefer to set current mode in resolution combobox: Plasma.
Oct 24 2018, 2:11 PM · Plasma
volkov requested review of D16400: Prefer to set current mode in resolution combobox.
Oct 24 2018, 2:11 PM · Plasma

Oct 22 2018

volkov committed R345:6fc243172bae: Remove unused local variable (authored by volkov).
Remove unused local variable
Oct 22 2018, 7:10 PM
volkov committed R345:a3f28b64216d: Use the multi-arg overload of QString::arg() (authored by volkov).
Use the multi-arg overload of QString::arg()
Oct 22 2018, 7:10 PM