smartins (Sergio Martins)
User

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Aug 25 2015, 12:40 PM (203 w, 2 d)
Availability
Available

Recent Activity

Jun 12 2019

smartins committed R74:6640d4ef77ec: mini-ast-dumper: Encode spellingLocation too (authored by smartins).
mini-ast-dumper: Encode spellingLocation too
Jun 12 2019, 10:24 AM

Jun 11 2019

smartins committed R74:deb8780e7af8: Remove duplicated classes (authored by smartins).
Remove duplicated classes
Jun 11 2019, 9:56 PM
smartins committed R74:5515bf158752: WIP (authored by smartins).
WIP
Jun 11 2019, 9:42 PM
smartins committed R74:5e226f6cf876: Add FunctionUtils::getFunctionDeclaration() (authored by smartins).
Add FunctionUtils::getFunctionDeclaration()
Jun 11 2019, 9:42 PM

Jun 10 2019

smartins committed R74:019f936ee737: Handle templates and built-in functions too (authored by smartins).
Handle templates and built-in functions too
Jun 10 2019, 6:21 PM
smartins committed R74:c7bcc9dbce2b: Add some sanity checks (authored by smartins).
Add some sanity checks
Jun 10 2019, 2:36 PM
smartins committed R74:3901d72b120a: WIP: Start processing the AST (authored by smartins).
WIP: Start processing the AST
Jun 10 2019, 1:44 PM
smartins committed R74:e50222c243b9: WIP (authored by smartins).
WIP
Jun 10 2019, 1:44 PM

Jun 9 2019

smartins committed R74:e89a0230dcc4: Fix cbor errors (authored by smartins).
Fix cbor errors
Jun 9 2019, 12:50 PM
smartins committed R74:027a93871500: WIP (authored by smartins).
WIP
Jun 9 2019, 11:42 AM

Jun 7 2019

smartins committed R74:8586dd8c2a3c: WIP (authored by smartins).
WIP
Jun 7 2019, 1:55 PM
smartins committed R74:22b8c12a447d: WIP (authored by smartins).
WIP
Jun 7 2019, 11:45 AM

Jun 6 2019

smartins committed R74:849343a794b2: WIP (authored by smartins).
WIP
Jun 6 2019, 8:44 PM
smartins committed R74:c9abcd5ee9e9: Add 3rdparty/tinycbor (authored by Sérgio Martins <sergio.martins@kdab.com>).
Add 3rdparty/tinycbor
Jun 6 2019, 6:53 PM

Jun 4 2019

smartins committed R74:bd40d70a1855: Add a mini AST dumper (authored by Sérgio Martins <sergio.martins@kdab.com>).
Add a mini AST dumper
Jun 4 2019, 9:00 PM
smartins committed R74:a8172f1df34f: Add missing override (authored by smartins).
Add missing override
Jun 4 2019, 9:00 PM

Jun 3 2019

smartins committed R74:04d096386a14: signal-with-return-value: warn for by-ref signal arguments (authored by smartins).
signal-with-return-value: warn for by-ref signal arguments
Jun 3 2019, 5:02 PM
smartins committed R74:7763c1d33ea6: Introduce signal-with-return-value (authored by Sérgio Martins <sergio.martins@kdab.com>).
Introduce signal-with-return-value
Jun 3 2019, 4:15 PM

May 30 2019

smartins closed D21485: Fix window activation on Windows.

pushed

May 30 2019, 7:19 PM · Kate
smartins committed R40:18b05cb14bdd: Fix window activation on Windows (authored by smartins).
Fix window activation on Windows
May 30 2019, 7:19 PM

May 29 2019

smartins requested review of D21485: Fix window activation on Windows.
May 29 2019, 6:23 PM · Kate

May 27 2019

smartins committed R74:4918d8efba9b: unneeded-cast: Improve warning message for unneeded qobject_cast (authored by smartins).
unneeded-cast: Improve warning message for unneeded qobject_cast
May 27 2019, 1:12 PM

May 26 2019

smartins committed R45:34175cdd3976: Fix build with MSVC (authored by smartins).
Fix build with MSVC
May 26 2019, 1:00 AM
smartins committed R45:f540b95cc744: Use 'unsigned int' instead of 'uint' (authored by smartins).
Use 'unsigned int' instead of 'uint'
May 26 2019, 1:00 AM

May 19 2019

smartins committed R74:3e684e046eef: Fix build with llvm trunk (authored by smartins).
Fix build with llvm trunk
May 19 2019, 12:44 PM

May 15 2019

smartins added a comment to D21151: WIP: clang-tidy compatibility.

needs a rebase, then it probably can be merged (if it's functionally equivalent, i.e. doesn't remove the env vars just yet)
then in another commit it can read from .clazy

May 15 2019, 6:10 PM

May 13 2019

smartins committed R74:ea204e3e5e5a: copyable-polymorphic: Explain better what's the problem in the README (authored by smartins).
copyable-polymorphic: Explain better what's the problem in the README
May 13 2019, 9:52 PM
smartins committed R74:57888024f031: Remove mention of CLAZY_FIXIT from the READMEs (authored by smartins).
Remove mention of CLAZY_FIXIT from the READMEs
May 13 2019, 9:18 AM
smartins committed R74:73f8700b4b2a: Remove unused ClazyFixItOptions (authored by smartins).
Remove unused ClazyFixItOptions
May 13 2019, 9:18 AM
smartins added a comment to D21151: WIP: clang-tidy compatibility.

I'll fix the docs, thanks

May 13 2019, 9:02 AM

May 12 2019

smartins added a comment to D21125: Add check for obsolete QVariant functions.

Actually these functions have been deprecated for 5.14.

May 12 2019, 7:49 PM
smartins committed R74:8863e191a934: tests: Remove last mention of CLAZY_FIXIT (authored by smartins).
tests: Remove last mention of CLAZY_FIXIT
May 12 2019, 7:35 PM
smartins committed R74:6c8892d7a31f: tests: Remove mention of CLAZY_FIXITS (authored by smartins).
tests: Remove mention of CLAZY_FIXITS
May 12 2019, 7:30 PM
smartins requested changes to D21151: WIP: clang-tidy compatibility.

some things are unrelated and so simple that should be committed directly already

May 12 2019, 7:18 PM
smartins added a comment to D21125: Add check for obsolete QVariant functions.

Also, please edit checks.json, add your check there, with level "0", since it doesn't have false positives.

May 12 2019, 7:04 PM
smartins requested changes to D21125: Add check for obsolete QVariant functions.

The preferred way is always to use one of the built-in clang warnings and make clazy spend less CPU cycles. I wonder why these are just not marked as deprecated.

May 12 2019, 6:53 PM
smartins committed R74:7400b5f6b62f: Use clazy namespace instead of TypeUtils (authored by smartins).
Use clazy namespace instead of TypeUtils
May 12 2019, 4:08 PM
smartins committed R74:d1cb8a0e5d8d: Introduce heap-allocated-small-trivial-type (authored by smartins).
Introduce heap-allocated-small-trivial-type
May 12 2019, 3:52 PM
smartins committed R74:2ea365b34208: TypeUtils: Make it optional to pass the VarDecl (authored by smartins).
TypeUtils: Make it optional to pass the VarDecl
May 12 2019, 2:51 PM
smartins committed R74:e1c8faffca38: Add TypeUtils::isSmallTrivial() (authored by smartins).
Add TypeUtils::isSmallTrivial()
May 12 2019, 2:51 PM
smartins committed R74:df640cb267a4: generate.py: Fix editing of Changelog (authored by smartins).
generate.py: Fix editing of Changelog
May 12 2019, 2:51 PM

May 11 2019

smartins committed R74:b25cd28c3b8b: Polish the howto a bit (authored by smartins).
Polish the howto a bit
May 11 2019, 10:21 PM
smartins committed R74:0380e066d442: tests: Allow to run run_tests.py from any directory (authored by smartins).
tests: Allow to run run_tests.py from any directory
May 11 2019, 10:21 PM

May 9 2019

smartins committed R74:e4ddb677f33a: qt-macros: Fix unit-tests (authored by smartins).
qt-macros: Fix unit-tests
May 9 2019, 7:46 PM
smartins committed R74:52c35819162b: qvariant-template-instantiation: Move out of level 0, since it has false… (authored by smartins).
qvariant-template-instantiation: Move out of level 0, since it has false…
May 9 2019, 7:13 PM
smartins committed R74:948a23ae1b15: inefficient-qlist: Dont warn for QVariantList (authored by smartins).
inefficient-qlist: Dont warn for QVariantList
May 9 2019, 2:39 PM

May 8 2019

smartins committed R74:008cdc9d1452: qt-keywords: Don't warn about Q_OS_WINDOWS if Qt < 5.12.4 (authored by smartins).
qt-keywords: Don't warn about Q_OS_WINDOWS if Qt < 5.12.4
May 8 2019, 8:56 PM
smartins committed R74:23c0a5122a6e: range-loop: unit-tests++ (authored by smartins).
range-loop: unit-tests++
May 8 2019, 8:56 PM
smartins committed R74:68daa24912ef: range-loop: Add unit-test (authored by smartins).
range-loop: Add unit-test
May 8 2019, 1:17 PM
smartins committed R74:9c8ade0c72a9: range-loop: Specify in the README that we have a fixit for adding qAsConst (authored by smartins).
range-loop: Specify in the README that we have a fixit for adding qAsConst
May 8 2019, 9:47 AM
smartins committed R74:c5914fc2a2a3: Minor readability improvement (authored by smartins).
Minor readability improvement
May 8 2019, 9:46 AM

May 7 2019

smartins committed R74:77b82be63b92: minor: Fix numeration of the ClazyOptions flags (authored by smartins).
minor: Fix numeration of the ClazyOptions flags
May 7 2019, 9:42 PM

May 5 2019

smartins committed R74:364d4763c498: README++ (authored by smartins).
README++
May 5 2019, 5:38 PM
smartins committed R74:f958d903b653: tests: fix yaml files not being removed (authored by smartins).
tests: fix yaml files not being removed
May 5 2019, 5:27 PM
smartins committed R74:ede2633b83b0: Add a CLAZY_EXPORT_FIXES env variable (authored by smartins).
Add a CLAZY_EXPORT_FIXES env variable
May 5 2019, 5:27 PM
smartins committed R74:a95d6e93bdf7: tests: Also test fixits there were introduced in headers (authored by smartins).
tests: Also test fixits there were introduced in headers
May 5 2019, 5:27 PM
smartins committed R74:2555ccc9f942: Update README and Changelog (authored by smartins).
Update README and Changelog
May 5 2019, 5:27 PM
smartins committed R74:c971a035dcdc: tests: Fix XFAIL tests not passing (authored by smartins).
tests: Fix XFAIL tests not passing
May 5 2019, 5:27 PM
smartins committed R74:05c9ccade074: Make the clazy plugin also export fixes, not only clazy-standalone (authored by smartins).
Make the clazy plugin also export fixes, not only clazy-standalone
May 5 2019, 5:27 PM
smartins committed R74:797d548546a1: tests: Always run the fixit tests on the tests that passed (authored by smartins).
tests: Always run the fixit tests on the tests that passed
May 5 2019, 5:27 PM
smartins committed R74:a45b9fc6cc31: tests: Fix old-style-connect/q_private_slot.cpp (authored by smartins).
tests: Fix old-style-connect/q_private_slot.cpp
May 5 2019, 5:27 PM
smartins committed R74:379aff5d1f15: tests: Cleanup the fixit files before running tests (authored by smartins).
tests: Cleanup the fixit files before running tests
May 5 2019, 5:27 PM
smartins committed R74:91fbc9723b99: tests: Run clang-reply-replacements exactly once, at the end of the tests (authored by smartins).
tests: Run clang-reply-replacements exactly once, at the end of the tests
May 5 2019, 5:27 PM
smartins committed R74:c5d0a2d0169c: WIP: Remove the FixitRewriter (authored by smartins).
WIP: Remove the FixitRewriter
May 5 2019, 5:27 PM
smartins committed R74:6b236c78c013: Port the unit-tests to the new fixit framework (authored by smartins).
Port the unit-tests to the new fixit framework
May 5 2019, 5:27 PM
smartins committed R74:c76e8d9d73ed: WIP: Remove -no-inplace-fixits option (authored by smartins).
WIP: Remove -no-inplace-fixits option
May 5 2019, 5:27 PM
smartins committed R74:ba00feae3117: Add '-export-fixes' command line option (authored by christiangagneraud).
Add '-export-fixes' command line option
May 5 2019, 5:27 PM
smartins committed R74:64efc0e8ffe5: Add a YAML diagnostic exporter (like clang-tidy) (authored by christiangagneraud).
Add a YAML diagnostic exporter (like clang-tidy)
May 5 2019, 5:27 PM
smartins committed R74:393c435726ee: qstring-allocations: Added missing auto (authored by smartins).
qstring-allocations: Added missing auto
May 5 2019, 5:06 PM
smartins committed R74:4b4e66d919eb: qstring-allocations: Workaround broken fixit in qstring.cpp (authored by smartins).
qstring-allocations: Workaround broken fixit in qstring.cpp
May 5 2019, 5:03 PM
smartins committed R74:253a1c789d6a: Comment DEBUG_FIX_IT_EXPORTER (authored by Sérgio Martins <sergio.martins@kdab.com>).
Comment DEBUG_FIX_IT_EXPORTER
May 5 2019, 4:31 PM
smartins committed R74:c4d6ae25111c: Use llvm::errs() instead of std::cerr (authored by smartins).
Use llvm::errs() instead of std::cerr
May 5 2019, 4:31 PM
smartins committed R74:0485eae9f27b: tests: fix yaml files not being removed (authored by smartins).
tests: fix yaml files not being removed
May 5 2019, 4:30 PM
smartins committed R74:5fb0c18a96ca: qstring-allocations: Fix fixits not working with ternary operators (authored by Sérgio Martins <sergio.martins@kdab.com>).
qstring-allocations: Fix fixits not working with ternary operators
May 5 2019, 4:30 PM
smartins committed R74:eee75b6d7098: Merge branch '1.5' (authored by smartins).
Merge branch '1.5'
May 5 2019, 3:36 PM
smartins committed R74:ad084532c2a2: qstring-allocations: Fix unit-tests (authored by smartins).
qstring-allocations: Fix unit-tests
May 5 2019, 3:32 PM
smartins committed R74:80e775303bf8: qstring-allocations: Fix fixits not working with ternary operators (authored by Sérgio Martins <sergio.martins@kdab.com>).
qstring-allocations: Fix fixits not working with ternary operators
May 5 2019, 3:32 PM
smartins committed R74:7cae26a019eb: Add a CLAZY_EXPORT_FIXES env variable (authored by smartins).
Add a CLAZY_EXPORT_FIXES env variable
May 5 2019, 1:17 PM
smartins committed R74:896fc66f475f: Update README and Changelog (authored by smartins).
Update README and Changelog
May 5 2019, 1:04 PM
smartins committed R74:ab8712ee8e8a: Make the clazy plugin also export fixes, not only clazy-standalone (authored by smartins).
Make the clazy plugin also export fixes, not only clazy-standalone
May 5 2019, 12:49 PM

May 4 2019

smartins committed R74:dad8728a08c6: Remove stray debug statement (authored by smartins).
Remove stray debug statement
May 4 2019, 9:28 PM
smartins committed R74:02e2fd099281: tests: Also test fixits there were introduced in headers (authored by smartins).
tests: Also test fixits there were introduced in headers
May 4 2019, 3:31 PM
smartins committed R74:a0d5074dfce5: tests: Fix XFAIL tests not passing (authored by smartins).
tests: Fix XFAIL tests not passing
May 4 2019, 3:11 PM
smartins committed R74:1b33162c0c02: same as previous commit (authored by smartins).
same as previous commit
May 4 2019, 2:56 PM
smartins committed R74:08475a4102a1: tests: Fix old-style-connect/q_private_slot.cpp (authored by smartins).
tests: Fix old-style-connect/q_private_slot.cpp
May 4 2019, 2:50 PM
smartins committed R74:4cacd2513fc7: qstring-allocations: Fix unit-tests (authored by smartins).
qstring-allocations: Fix unit-tests
May 4 2019, 2:13 PM
smartins committed R74:dca54f3be546: tests: Always run the fixit tests on the tests that passed (authored by smartins).
tests: Always run the fixit tests on the tests that passed
May 4 2019, 1:36 PM
smartins committed R74:4c71d6f8695b: tests: Run clang-reply-replacements exactly once, at the end of the tests (authored by smartins).
tests: Run clang-reply-replacements exactly once, at the end of the tests
May 4 2019, 12:50 PM
smartins committed R74:61002ce3c042: tests: Cleanup the fixit files before running tests (authored by smartins).
tests: Cleanup the fixit files before running tests
May 4 2019, 12:50 PM

May 3 2019

smartins committed R74:929320a7272e: Some styling fixes (authored by smartins).
Some styling fixes
May 3 2019, 6:48 PM
smartins committed R74:0149d89e8744: Port the unit-tests to the new fixit framework (authored by smartins).
Port the unit-tests to the new fixit framework
May 3 2019, 3:51 PM

May 2 2019

smartins committed R74:fd3977e31cf0: WIP: Remove the FixitRewriter (authored by smartins).
WIP: Remove the FixitRewriter
May 2 2019, 8:58 PM
smartins committed R74:fd5680571602: WIP: Remove -no-inplace-fixits option (authored by smartins).
WIP: Remove -no-inplace-fixits option
May 2 2019, 8:58 PM

Apr 29 2019

smartins added a comment to D20799: Add '-export-fixes' command line option.

Am i by-passing code review now?

Apr 29 2019, 12:12 PM

Apr 28 2019

smartins added a comment to D20799: Add '-export-fixes' command line option.

Can you push to your github ? I'll merge into clazy repo

Apr 28 2019, 4:01 PM
smartins added a comment to D20799: Add '-export-fixes' command line option.

you need a developer account then: https://identity.kde.org/index.php?r=developerApplication

Apr 28 2019, 3:56 PM
smartins added a comment to D20799: Add '-export-fixes' command line option.

anongit is readonly, use git@git.kde.org:clazy instead

Apr 28 2019, 9:21 AM

Apr 27 2019

smartins added a comment to D20799: Add '-export-fixes' command line option.

can you just git push to the branch without arc ?

Apr 27 2019, 7:26 PM
smartins committed R74:cff6b2307ef4: Merge branch '1.5' (authored by smartins).
Merge branch '1.5'
Apr 27 2019, 7:08 PM
smartins added inline comments to D20714: akonadi: fix some clazy warnings.
Apr 27 2019, 4:52 PM · KDE PIM