smartins (Sergio Martins)
User

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Aug 25 2015, 12:40 PM (194 w, 6 d)
Availability
Available

Recent Activity

Sun, May 19

smartins committed R74:3e684e046eef: Fix build with llvm trunk (authored by smartins).
Fix build with llvm trunk
Sun, May 19, 12:44 PM

Wed, May 15

smartins added a comment to D21151: WIP: clang-tidy compatibility.

needs a rebase, then it probably can be merged (if it's functionally equivalent, i.e. doesn't remove the env vars just yet)
then in another commit it can read from .clazy

Wed, May 15, 6:10 PM

Mon, May 13

smartins committed R74:ea204e3e5e5a: copyable-polymorphic: Explain better what's the problem in the README (authored by smartins).
copyable-polymorphic: Explain better what's the problem in the README
Mon, May 13, 9:52 PM
smartins committed R74:57888024f031: Remove mention of CLAZY_FIXIT from the READMEs (authored by smartins).
Remove mention of CLAZY_FIXIT from the READMEs
Mon, May 13, 9:18 AM
smartins committed R74:73f8700b4b2a: Remove unused ClazyFixItOptions (authored by smartins).
Remove unused ClazyFixItOptions
Mon, May 13, 9:18 AM
smartins added a comment to D21151: WIP: clang-tidy compatibility.

I'll fix the docs, thanks

Mon, May 13, 9:02 AM

Sun, May 12

smartins added a comment to D21125: Add check for obsolete QVariant functions.

Actually these functions have been deprecated for 5.14.

Sun, May 12, 7:49 PM
smartins committed R74:8863e191a934: tests: Remove last mention of CLAZY_FIXIT (authored by smartins).
tests: Remove last mention of CLAZY_FIXIT
Sun, May 12, 7:35 PM
smartins committed R74:6c8892d7a31f: tests: Remove mention of CLAZY_FIXITS (authored by smartins).
tests: Remove mention of CLAZY_FIXITS
Sun, May 12, 7:30 PM
smartins requested changes to D21151: WIP: clang-tidy compatibility.

some things are unrelated and so simple that should be committed directly already

Sun, May 12, 7:18 PM
smartins added a comment to D21125: Add check for obsolete QVariant functions.

Also, please edit checks.json, add your check there, with level "0", since it doesn't have false positives.

Sun, May 12, 7:04 PM
smartins requested changes to D21125: Add check for obsolete QVariant functions.

The preferred way is always to use one of the built-in clang warnings and make clazy spend less CPU cycles. I wonder why these are just not marked as deprecated.

Sun, May 12, 6:53 PM
smartins committed R74:7400b5f6b62f: Use clazy namespace instead of TypeUtils (authored by smartins).
Use clazy namespace instead of TypeUtils
Sun, May 12, 4:08 PM
smartins committed R74:d1cb8a0e5d8d: Introduce heap-allocated-small-trivial-type (authored by smartins).
Introduce heap-allocated-small-trivial-type
Sun, May 12, 3:52 PM
smartins committed R74:2ea365b34208: TypeUtils: Make it optional to pass the VarDecl (authored by smartins).
TypeUtils: Make it optional to pass the VarDecl
Sun, May 12, 2:51 PM
smartins committed R74:e1c8faffca38: Add TypeUtils::isSmallTrivial() (authored by smartins).
Add TypeUtils::isSmallTrivial()
Sun, May 12, 2:51 PM
smartins committed R74:df640cb267a4: generate.py: Fix editing of Changelog (authored by smartins).
generate.py: Fix editing of Changelog
Sun, May 12, 2:51 PM

Sat, May 11

smartins committed R74:b25cd28c3b8b: Polish the howto a bit (authored by smartins).
Polish the howto a bit
Sat, May 11, 10:21 PM
smartins committed R74:0380e066d442: tests: Allow to run run_tests.py from any directory (authored by smartins).
tests: Allow to run run_tests.py from any directory
Sat, May 11, 10:21 PM

Thu, May 9

smartins committed R74:e4ddb677f33a: qt-macros: Fix unit-tests (authored by smartins).
qt-macros: Fix unit-tests
Thu, May 9, 7:46 PM
smartins committed R74:52c35819162b: qvariant-template-instantiation: Move out of level 0, since it has false… (authored by smartins).
qvariant-template-instantiation: Move out of level 0, since it has false…
Thu, May 9, 7:13 PM
smartins committed R74:948a23ae1b15: inefficient-qlist: Dont warn for QVariantList (authored by smartins).
inefficient-qlist: Dont warn for QVariantList
Thu, May 9, 2:39 PM

Wed, May 8

smartins committed R74:008cdc9d1452: qt-keywords: Don't warn about Q_OS_WINDOWS if Qt < 5.12.4 (authored by smartins).
qt-keywords: Don't warn about Q_OS_WINDOWS if Qt < 5.12.4
Wed, May 8, 8:56 PM
smartins committed R74:23c0a5122a6e: range-loop: unit-tests++ (authored by smartins).
range-loop: unit-tests++
Wed, May 8, 8:56 PM
smartins committed R74:68daa24912ef: range-loop: Add unit-test (authored by smartins).
range-loop: Add unit-test
Wed, May 8, 1:17 PM
smartins committed R74:9c8ade0c72a9: range-loop: Specify in the README that we have a fixit for adding qAsConst (authored by smartins).
range-loop: Specify in the README that we have a fixit for adding qAsConst
Wed, May 8, 9:47 AM
smartins committed R74:c5914fc2a2a3: Minor readability improvement (authored by smartins).
Minor readability improvement
Wed, May 8, 9:46 AM

Tue, May 7

smartins committed R74:77b82be63b92: minor: Fix numeration of the ClazyOptions flags (authored by smartins).
minor: Fix numeration of the ClazyOptions flags
Tue, May 7, 9:42 PM

Sun, May 5

smartins committed R74:364d4763c498: README++ (authored by smartins).
README++
Sun, May 5, 5:38 PM
smartins committed R74:f958d903b653: tests: fix yaml files not being removed (authored by smartins).
tests: fix yaml files not being removed
Sun, May 5, 5:27 PM
smartins committed R74:ede2633b83b0: Add a CLAZY_EXPORT_FIXES env variable (authored by smartins).
Add a CLAZY_EXPORT_FIXES env variable
Sun, May 5, 5:27 PM
smartins committed R74:a95d6e93bdf7: tests: Also test fixits there were introduced in headers (authored by smartins).
tests: Also test fixits there were introduced in headers
Sun, May 5, 5:27 PM
smartins committed R74:2555ccc9f942: Update README and Changelog (authored by smartins).
Update README and Changelog
Sun, May 5, 5:27 PM
smartins committed R74:c971a035dcdc: tests: Fix XFAIL tests not passing (authored by smartins).
tests: Fix XFAIL tests not passing
Sun, May 5, 5:27 PM
smartins committed R74:05c9ccade074: Make the clazy plugin also export fixes, not only clazy-standalone (authored by smartins).
Make the clazy plugin also export fixes, not only clazy-standalone
Sun, May 5, 5:27 PM
smartins committed R74:797d548546a1: tests: Always run the fixit tests on the tests that passed (authored by smartins).
tests: Always run the fixit tests on the tests that passed
Sun, May 5, 5:27 PM
smartins committed R74:a45b9fc6cc31: tests: Fix old-style-connect/q_private_slot.cpp (authored by smartins).
tests: Fix old-style-connect/q_private_slot.cpp
Sun, May 5, 5:27 PM
smartins committed R74:379aff5d1f15: tests: Cleanup the fixit files before running tests (authored by smartins).
tests: Cleanup the fixit files before running tests
Sun, May 5, 5:27 PM
smartins committed R74:91fbc9723b99: tests: Run clang-reply-replacements exactly once, at the end of the tests (authored by smartins).
tests: Run clang-reply-replacements exactly once, at the end of the tests
Sun, May 5, 5:27 PM
smartins committed R74:c5d0a2d0169c: WIP: Remove the FixitRewriter (authored by smartins).
WIP: Remove the FixitRewriter
Sun, May 5, 5:27 PM
smartins committed R74:6b236c78c013: Port the unit-tests to the new fixit framework (authored by smartins).
Port the unit-tests to the new fixit framework
Sun, May 5, 5:27 PM
smartins committed R74:c76e8d9d73ed: WIP: Remove -no-inplace-fixits option (authored by smartins).
WIP: Remove -no-inplace-fixits option
Sun, May 5, 5:27 PM
smartins committed R74:ba00feae3117: Add '-export-fixes' command line option (authored by christiangagneraud).
Add '-export-fixes' command line option
Sun, May 5, 5:27 PM
smartins committed R74:64efc0e8ffe5: Add a YAML diagnostic exporter (like clang-tidy) (authored by christiangagneraud).
Add a YAML diagnostic exporter (like clang-tidy)
Sun, May 5, 5:27 PM
smartins committed R74:393c435726ee: qstring-allocations: Added missing auto (authored by smartins).
qstring-allocations: Added missing auto
Sun, May 5, 5:06 PM
smartins committed R74:4b4e66d919eb: qstring-allocations: Workaround broken fixit in qstring.cpp (authored by smartins).
qstring-allocations: Workaround broken fixit in qstring.cpp
Sun, May 5, 5:03 PM
smartins committed R74:253a1c789d6a: Comment DEBUG_FIX_IT_EXPORTER (authored by Sérgio Martins <sergio.martins@kdab.com>).
Comment DEBUG_FIX_IT_EXPORTER
Sun, May 5, 4:31 PM
smartins committed R74:c4d6ae25111c: Use llvm::errs() instead of std::cerr (authored by smartins).
Use llvm::errs() instead of std::cerr
Sun, May 5, 4:31 PM
smartins committed R74:0485eae9f27b: tests: fix yaml files not being removed (authored by smartins).
tests: fix yaml files not being removed
Sun, May 5, 4:30 PM
smartins committed R74:5fb0c18a96ca: qstring-allocations: Fix fixits not working with ternary operators (authored by Sérgio Martins <sergio.martins@kdab.com>).
qstring-allocations: Fix fixits not working with ternary operators
Sun, May 5, 4:30 PM
smartins committed R74:eee75b6d7098: Merge branch '1.5' (authored by smartins).
Merge branch '1.5'
Sun, May 5, 3:36 PM
smartins committed R74:ad084532c2a2: qstring-allocations: Fix unit-tests (authored by smartins).
qstring-allocations: Fix unit-tests
Sun, May 5, 3:32 PM
smartins committed R74:80e775303bf8: qstring-allocations: Fix fixits not working with ternary operators (authored by Sérgio Martins <sergio.martins@kdab.com>).
qstring-allocations: Fix fixits not working with ternary operators
Sun, May 5, 3:32 PM
smartins committed R74:7cae26a019eb: Add a CLAZY_EXPORT_FIXES env variable (authored by smartins).
Add a CLAZY_EXPORT_FIXES env variable
Sun, May 5, 1:17 PM
smartins committed R74:896fc66f475f: Update README and Changelog (authored by smartins).
Update README and Changelog
Sun, May 5, 1:04 PM
smartins committed R74:ab8712ee8e8a: Make the clazy plugin also export fixes, not only clazy-standalone (authored by smartins).
Make the clazy plugin also export fixes, not only clazy-standalone
Sun, May 5, 12:49 PM

Sat, May 4

smartins committed R74:dad8728a08c6: Remove stray debug statement (authored by smartins).
Remove stray debug statement
Sat, May 4, 9:28 PM
smartins committed R74:02e2fd099281: tests: Also test fixits there were introduced in headers (authored by smartins).
tests: Also test fixits there were introduced in headers
Sat, May 4, 3:31 PM
smartins committed R74:a0d5074dfce5: tests: Fix XFAIL tests not passing (authored by smartins).
tests: Fix XFAIL tests not passing
Sat, May 4, 3:11 PM
smartins committed R74:1b33162c0c02: same as previous commit (authored by smartins).
same as previous commit
Sat, May 4, 2:56 PM
smartins committed R74:08475a4102a1: tests: Fix old-style-connect/q_private_slot.cpp (authored by smartins).
tests: Fix old-style-connect/q_private_slot.cpp
Sat, May 4, 2:50 PM
smartins committed R74:4cacd2513fc7: qstring-allocations: Fix unit-tests (authored by smartins).
qstring-allocations: Fix unit-tests
Sat, May 4, 2:13 PM
smartins committed R74:dca54f3be546: tests: Always run the fixit tests on the tests that passed (authored by smartins).
tests: Always run the fixit tests on the tests that passed
Sat, May 4, 1:36 PM
smartins committed R74:4c71d6f8695b: tests: Run clang-reply-replacements exactly once, at the end of the tests (authored by smartins).
tests: Run clang-reply-replacements exactly once, at the end of the tests
Sat, May 4, 12:50 PM
smartins committed R74:61002ce3c042: tests: Cleanup the fixit files before running tests (authored by smartins).
tests: Cleanup the fixit files before running tests
Sat, May 4, 12:50 PM

Fri, May 3

smartins committed R74:929320a7272e: Some styling fixes (authored by smartins).
Some styling fixes
Fri, May 3, 6:48 PM
smartins committed R74:0149d89e8744: Port the unit-tests to the new fixit framework (authored by smartins).
Port the unit-tests to the new fixit framework
Fri, May 3, 3:51 PM

Thu, May 2

smartins committed R74:fd3977e31cf0: WIP: Remove the FixitRewriter (authored by smartins).
WIP: Remove the FixitRewriter
Thu, May 2, 8:58 PM
smartins committed R74:fd5680571602: WIP: Remove -no-inplace-fixits option (authored by smartins).
WIP: Remove -no-inplace-fixits option
Thu, May 2, 8:58 PM

Mon, Apr 29

smartins added a comment to D20799: Add '-export-fixes' command line option.

Am i by-passing code review now?

Mon, Apr 29, 12:12 PM

Sun, Apr 28

smartins added a comment to D20799: Add '-export-fixes' command line option.

Can you push to your github ? I'll merge into clazy repo

Sun, Apr 28, 4:01 PM
smartins added a comment to D20799: Add '-export-fixes' command line option.

you need a developer account then: https://identity.kde.org/index.php?r=developerApplication

Sun, Apr 28, 3:56 PM
smartins added a comment to D20799: Add '-export-fixes' command line option.

anongit is readonly, use git@git.kde.org:clazy instead

Sun, Apr 28, 9:21 AM

Sat, Apr 27

smartins added a comment to D20799: Add '-export-fixes' command line option.

can you just git push to the branch without arc ?

Sat, Apr 27, 7:26 PM
smartins committed R74:cff6b2307ef4: Merge branch '1.5' (authored by smartins).
Merge branch '1.5'
Sat, Apr 27, 7:08 PM
smartins added inline comments to D20714: akonadi: fix some clazy warnings.
Sat, Apr 27, 4:52 PM · KDE PIM
smartins committed R74:ab7f69ea4e0e: empty-qstringliteral: Suggest QLatin1String("") (authored by smartins).
empty-qstringliteral: Suggest QLatin1String("")
Sat, Apr 27, 4:51 PM
smartins committed R74:581dd09aa770: empty-qstringliteral: Fix typo in the docs (authored by smartins).
empty-qstringliteral: Fix typo in the docs
Sat, Apr 27, 4:22 PM
smartins added inline comments to D20714: akonadi: fix some clazy warnings.
Sat, Apr 27, 4:07 PM · KDE PIM
smartins committed R74:8c98fcdcee3f: Merge branch '1.5' (authored by smartins).
Merge branch '1.5'
Sat, Apr 27, 3:58 PM

Fri, Apr 26

smartins committed R74:e4c77237db90: qstring-allocations: Add unit-test for not warning in ui files (authored by smartins).
qstring-allocations: Add unit-test for not warning in ui files
Fri, Apr 26, 9:05 PM

Thu, Apr 25

smartins committed R74:5c3c679cc2a8: [SQUASH_WITH_PREVIOUS_COMMIT] Remove unrelated commited code (authored by smartins).
[SQUASH_WITH_PREVIOUS_COMMIT] Remove unrelated commited code
Thu, Apr 25, 11:22 AM
smartins added a comment to R74:5460a41140a1: [SQUASH_WITH_PREVIOUS_COMMIT] Fixed styling and attributed copyright to….

I'm about to push changes that add the -export-fixes command line option

Thu, Apr 25, 11:20 AM
smartins added a comment to R74:5460a41140a1: [SQUASH_WITH_PREVIOUS_COMMIT] Fixed styling and attributed copyright to….

Sorry for the styling, which tool do you use for that? do you have a .clang-format file?

Thu, Apr 25, 11:20 AM

Tue, Apr 23

smartins committed R74:8df0e52bcbd6: Add unit-test that we can use emit keywoard on scriptable signals (authored by smartins).
Add unit-test that we can use emit keywoard on scriptable signals
Tue, Apr 23, 8:55 PM
smartins committed R74:f36dd1971422: Process Q_SCRIPTABLE separately (authored by smartins).
Process Q_SCRIPTABLE separately
Tue, Apr 23, 8:55 PM
smartins committed R74:1cdae9af5557: Merge branch '1.5' (authored by smartins).
Merge branch '1.5'
Tue, Apr 23, 5:53 PM
smartins committed R74:d6e7f4c8ed63: qstring-allocations: Don't warn for ui_*h files (authored by smartins).
qstring-allocations: Don't warn for ui_*h files
Tue, Apr 23, 5:36 PM
smartins committed R74:a96b19e25566: qstring-allocations: Refactor in preparation for a fix (authored by smartins).
qstring-allocations: Refactor in preparation for a fix
Tue, Apr 23, 5:36 PM
smartins committed R74:5460a41140a1: [SQUASH_WITH_PREVIOUS_COMMIT] Fixed styling and attributed copyright to… (authored by smartins).
[SQUASH_WITH_PREVIOUS_COMMIT] Fixed styling and attributed copyright to…
Tue, Apr 23, 8:32 AM

Mon, Apr 22

smartins committed R74:2dd781dd8481: Add a YAML diagnostic exporter (like clang-tidy) (authored by christiangagneraud).
Add a YAML diagnostic exporter (like clang-tidy)
Mon, Apr 22, 10:11 PM
smartins committed R74:753375c9358e: Merge branch '1.5' (authored by smartins).
Merge branch '1.5'
Mon, Apr 22, 10:08 PM
smartins committed R74:616ca1aa9de2: Readme: Mention AppImage based on clang 8.0 (authored by smartins).
Readme: Mention AppImage based on clang 8.0
Mon, Apr 22, 10:08 PM
smartins committed R74:c2f9a7765da4: function-args-by-value: Fix unit-test (authored by smartins).
function-args-by-value: Fix unit-test
Mon, Apr 22, 9:51 PM
smartins committed R74:9477d3453661: AppImage: Set the PATH to the gcc compiler (authored by smartins).
AppImage: Set the PATH to the gcc compiler
Mon, Apr 22, 9:43 PM
smartins committed R74:a531242f8976: AppImage: Set the path to llvm 8.0.0 (authored by smartins).
AppImage: Set the path to llvm 8.0.0
Mon, Apr 22, 9:29 PM
smartins committed R74:089a4d38f062: AppImage: set the compiler explicity (authored by smartins).
AppImage: set the compiler explicity
Mon, Apr 22, 9:29 PM

Apr 4 2019

smartins committed R74:6eba9241b2c1: old-style-connect: Added fixit for QSignalSpy too (authored by smartins).
old-style-connect: Added fixit for QSignalSpy too
Apr 4 2019, 8:27 AM
smartins committed R74:1253cc3b5964: old-style-connect: Warn for QSignalSpy (authored by smartins).
old-style-connect: Warn for QSignalSpy
Apr 4 2019, 8:26 AM

Mar 25 2019

smartins committed R74:c7137441c6a2: Add a way to know in which function we're in (authored by smartins).
Add a way to know in which function we're in
Mar 25 2019, 10:54 PM